Skip to contentSkip to conversation

rtlwifi: btcoex: fix argument typo of if-statement found by Coccinelle

PATCH In review [email protected] 2 participants 2 messages Feb 27, 2018 Realtek wireless driver (rtlwifi family)

lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH 1/1 rtlwifi: btcoex: fix argument typo of if-statement found by Coccinelle

From: Ping-Ke Shih <[email protected]>

This was detected with static analysis using Coccinelle:

./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c:1107:5-18:
duplicated argument to && or ||

---
 drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c +1 -1
index fd3b1fb35dff..05beb16f0a0a 100644
@@ -1104,7 +1104,7 @@ static void halbtc8723b1ant_ps_tdma(struct btc_coexist *btcoexist,
 	}
 
 	if ((type == 1) || (type == 2) || (type == 9) || (type == 11) ||
-	    (type == 101) || (type == 102) || (type == 109) || (type == 101)) {
+	    (type == 101) || (type == 102) || (type == 109) || (type == 111)) {
 		if (!coex_sta->force_lps_on) {
 			/* Native power save TDMA, only for A2DP-only case
 			 * 1/2/9/11 while wifi noisy threshold > 30
Signature · 1 line
2.15.1
#1 lore raw
Quoted 9 lines · Ping-Ke Shih

From: Ping-Ke Shih <[email protected]>

This was detected with static analysis using Coccinelle:

./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c:1107:5-18:
duplicated argument to && or ||

Patch applied to wireless-drivers-next.git, thanks.

e28adf9ae63c rtlwifi: btcoex: fix argument typo of if-statement found by Coccinelle

Signature · 3 lines
https://patchwork.kernel.org/patch/10244103/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches