apache sbindir
PATCH 1/1 apache sbindir
The apache configure script help indicates that the sbindir is PREFIX/sbin , but it actually uses PREFIX/bin. I suspect most people would expect httpd to be /usr/sbin/httpd , not /usr/bin/httpd.
--- package/apache/apache.mk | 1 + 1 file changed, 1 insertion(+)
package/apache/apache.mk +1 -0
@@ -29,6 +29,7 @@ APACHE_MPM = worker endif APACHE_CONF_OPTS = \ + --sbindir=/usr/sbin \ --sysconfdir=/etc/apache2 \ --with-apr=$(STAGING_DIR)/usr \ --with-apr-util=$(STAGING_DIR)/usr \
Signature · 1 line
2.14.3
PATCH 1/1 apache sbindir
Hello,
The commit title should be:
apache: pass explicit sbindir
Quoted 1 line · Christopher McCrory
The apache configure script help indicates that the sbindir is PREFIX/sbin , but it actually uses PREFIX/bin. I suspect most people would expect httpd to be
/usr/sbin/httpd, not/usr/bin/httpd.
This needs to be wrapped at 72 characters. Also, it's good avoid first person sentences. So instead of "I suspect" you could say: "Most people probably expect httpd to be located in /usr/sbin/httpd".
package/apache/apache.mk APACHE_MPM = worker · line 32
Quoted 9 lines
package/apache/apache.mk +1
-0@@ -29,6 +29,7 @@ APACHE_MPM = worker endif APACHE_CONF_OPTS = \ + --sbindir=/usr/sbin \
Perhaps a quick comment would be appropriate above APACHE_CONF_OPTS, like:
# Explicitly pass sbindir, because apache configure script defines it
# to PREFIX/bin, which doesn't make much sense
Or something like that.
Could you respin an updated version ?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com