Skip to contentSkip to conversation

tests/kms_frontbuffer_tracking: Fix build warning

PATCH In review Tvrtko Ursulin 4 participants 6 messages Feb 28, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 tests/kms_frontbuffer_tracking: Fix build warning

From: Tvrtko Ursulin <[email protected]>

Mark drrs_set as static to avoid a build warning.

---
 tests/kms_frontbuffer_tracking.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/kms_frontbuffer_tracking.c +1 -1
index 1483c228044e..43384801e2b5 100644
@@ -830,7 +830,7 @@ static void psr_print_status(void)
 	igt_info("PSR status:\n%s\n", buf);
 }
 
-void drrs_set(unsigned int val)
+static void drrs_set(unsigned int val)
 {
 	char buf[2];
 	int ret;
Signature · 6 lines
2.14.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

PATCH 2/2 tests/perf: Fix build warning

From: Tvrtko Ursulin <[email protected]>

Move variable declaration to top of scope to avoid C90 build warning.

---
 tests/perf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/perf.c +1 -1
index c302a355b850..78bf6cdd3504 100644
@@ -1726,6 +1726,7 @@ test_oa_exponents(void)
 		int buf_size = sample_size * max_reports * 1.5;
 		uint8_t *buf = calloc(1, buf_size);
 		int ret, n_timer_reports = 0;
+		uint32_t matches = 0;
 		struct {
 			uint32_t report[64];
 		} timer_reports[30];
@@ -1785,7 +1786,6 @@ test_oa_exponents(void)
 		igt_debug("report%04i ts=%08x hw_id=0x%08x\n", 0,
 			  timer_reports[0].report[1],
 			  oa_report_get_ctx_id(timer_reports[0].report));
-		uint32_t matches = 0;
 		for (int i = 1; i < n_timer_reports; i++) {
 			uint32_t delta =
 				timer_reports[i].report[1] - timer_reports[i - 1].report[1];
Signature · 6 lines
2.14.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Reviewed-by on v1 2/2
#2 lore raw

Re: [igt-dev] [PATCH i-g-t 2/2] tests/perf: Fix build warning

Quoted 22 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Move variable declaration to top of scope to avoid C90 build warning.

---
  tests/perf.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
tests/perf.c +1 -0
index c302a355b850..78bf6cdd3504 100644
@@ -1726,6 +1726,7 @@ test_oa_exponents(void)
  		int buf_size = sample_size * max_reports * 1.5;
  		uint8_t *buf = calloc(1, buf_size);
  		int ret, n_timer_reports = 0;
+		uint32_t matches = 0;
  		struct {
  			uint32_t report[64];
  		} timer_reports[30];

tests/perf.c test_oa_exponents(void) · line 1791

Quoted 7 lines
tests/perf.c +0 -1
@@ -1785,7 +1786,6 @@ test_oa_exponents(void)
  		igt_debug("report%04i ts=%08x hw_id=0x%08x\n", 0,
  			  timer_reports[0].report[1],
  			  oa_report_get_ctx_id(timer_reports[0].report));
-		uint32_t matches = 0;
  		for (int i = 1; i < n_timer_reports; i++) {
  			uint32_t delta =
  				timer_reports[i].report[1] - timer_reports[i - 1].report[1];

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#4 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/kms_frontbuffer_tracking: Fix build warning

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: series starting with [i-g-t,1/2] tests/kms_frontbuffer_tracking: Fix build warning
URL : https://patchwork.freedesktop.org/series/39101/
State : success

== Summary ==

IGT patchset tested on top of latest successful build d3dc9c619791c8cb88d176fc7b3d8aa5e802055d lib/igt_draw: Fix bo leak in gpu draw routines

with latest DRM-Tip kernel build CI_DRM_3846
9a02ae14ae02 drm-tip: 2018y-02m-28d-10h-13m-18s UTC integration manifest

No testlist changes.

---- Known issues:

Test debugfs_test:

        Subgroup read_all_entries:
                pass       -> INCOMPLETE (fi-snb-2520m) fdo#103713
Test gem_mmap_gtt:
        Subgroup basic-small-bo-tiledx:
                fail       -> PASS       (fi-gdg-551) fdo#102575

fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:419s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:430s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:374s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:490s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:286s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:482s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:487s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:470s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:460s
fi-cfl-8700k     total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:393s
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:566s
fi-cnl-y3        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:578s
fi-elk-e7500     total:288  pass:229  dwarn:0   dfail:0   fail:0   skip:59  time:414s
fi-gdg-551       total:288  pass:180  dwarn:0   dfail:0   fail:0   skip:108 time:286s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:507s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:387s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:410s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:453s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:418s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:452s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:488s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:451s
fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:491s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:587s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:427s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:499s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:520s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:487s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:478s
fi-skl-guc       total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:407s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:432s
fi-snb-2520m     total:3    pass:2    dwarn:0   dfail:0   fail:0   skip:0  
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:393s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1020/issues.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#5 lore raw

[igt-dev] ✗ Fi.CI.IGT: warning for series starting with [i-g-t,1/2] tests/kms_frontbuffer_tracking: Fix build warning

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: series starting with [i-g-t,1/2] tests/kms_frontbuffer_tracking: Fix build warning
URL : https://patchwork.freedesktop.org/series/39101/
State : warning

== Summary ==

---- Possible new issues:

Test gem_tiled_blits:

        Subgroup normal:
                pass       -> SKIP       (shard-apl)
Test kms_rotation_crc:
        Subgroup primary-rotation-270:
                fail       -> PASS       (shard-apl)

---- Known issues:

Test gem_softpin:

        Subgroup noreloc-s3:
                incomplete -> PASS       (shard-hsw) fdo#103540
                pass       -> SKIP       (shard-snb) fdo#103375
Test kms_chv_cursor_fail:
        Subgroup pipe-b-64x64-bottom-edge:
                pass       -> DMESG-WARN (shard-snb) fdo#105185 +1
Test kms_flip:
        Subgroup flip-vs-panning-vs-hang-interruptible:
                pass       -> DMESG-WARN (shard-snb) fdo#103821
        Subgroup plain-flip-ts-check-interruptible:
                fail       -> PASS       (shard-hsw) fdo#100368
Test kms_rotation_crc:
        Subgroup sprite-rotation-180:
                fail       -> PASS       (shard-snb) fdo#103925
Test kms_sysfs_edid_timing:
                warn       -> PASS       (shard-apl) fdo#100047
Test perf:
        Subgroup oa-exponents:
                incomplete -> PASS       (shard-apl) fdo#102254
        Subgroup polling:
                fail       -> PASS       (shard-hsw) fdo#102252

fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#105185 https://bugs.freedesktop.org/show_bug.cgi?id=105185
fdo#103821 https://bugs.freedesktop.org/show_bug.cgi?id=103821
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
fdo#102254 https://bugs.freedesktop.org/show_bug.cgi?id=102254
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252

shard-apl        total:3460 pass:1819 dwarn:1   dfail:0   fail:7   skip:1633 time:12199s
shard-hsw        total:3460 pass:1767 dwarn:1   dfail:0   fail:1   skip:1690 time:11880s
shard-snb        total:3460 pass:1356 dwarn:3   dfail:0   fail:1   skip:2100 time:6643s

Blacklisted hosts:
shard-kbl total:3368 pass:1856 dwarn:29 dfail:1 fail:8 skip:1473 time:9407s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1020/shards.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev