Skip to contentSkip to conversation

Bluetooth: btusb: Remove Yoga 920 from the btusb_needs_reset_resume_table

PATCH New Hans de Goede 4 participants 5 messages Feb 28, 2018 – Mar 1, 2018

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

cover Bluetooth: btusb: Remove Yoga 920 from the btusb_needs_reset_resume_table

Hi All,

So Brian Norris was right and the problems on the Yoga 920 have been caused all along by the initial QCA Rome suspend/resume fix issues.

So we can remove the Yoga 920 from the btusb_needs_reset_resume_table, note after this the table is empty.

I've decided to keep the empty table around to make adding new entries easier. Kai-Heng AFAIK you said that you have at least one model laptop which does really need the reset-resume quirk for QCA? Can you submit a patch adding this model to the btusb_needs_reset_resume_table please?

Regards,

Hans

#1 lore raw

PATCH 1/1 Bluetooth: btusb: Remove Yoga 920 from the btusb_needs_reset_resume_table

Commit 55a9c95d70ab ("Bluetooth: btusb: Use DMI matching for QCA reset_resume quirking"), added the Lenovo Yoga 920 to the btusb_needs_reset_resume_table.

Testing has shown that this is a false positive and the problems where caused by issues with the initial fix: commit fd865802c66b ("Bluetooth:
btusb: fix QCA Rome suspend/resume"), which has already been reverted.

So the QCA Rome BT in the Yoga 920 does not need a reset-resume quirk at all and this commit removes it from the btusb_needs_reset_resume_table.

Note that after this commit the btusb_needs_reset_resume_table is now empty. It is kept around on purpose, since this whole series of commits started for a reason and there are actually broken platforms around, which need to be added to it.

Fixes 55a9c95d70ab ("Bluetooth: btusb: Use DMI matching for QCA ...")
Cc Brian Norris <[email protected]>
Cc Kai-Heng Feng <[email protected]>
---
 drivers/bluetooth/btusb.c | 7 -------
 1 file changed, 7 deletions(-)
drivers/bluetooth/btusb.c +0 -7
index a4b62f0a93cc..418550eb1522 100644
@@ -386,13 +386,6 @@ static const struct usb_device_id blacklist_table[] = {
  * the module itself. So we use a DMI list to match known broken platforms.
  */
 static const struct dmi_system_id btusb_needs_reset_resume_table[] = {
-	{
-		/* Lenovo Yoga 920 (QCA Rome device 0cf3:e300) */
-		.matches = {
-			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
-			DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo YOGA 920"),
-		},
-	},
 	{}
 };
 
Signature · 1 line
2.14.3
Reviewed-by on v1 1/1
#2 lore raw

+ Leif

Quoted 8 lines · Hans de Goede

Commit 55a9c95d70ab ("Bluetooth: btusb: Use DMI matching for QCA reset_resume quirking"), added the Lenovo Yoga 920 to the btusb_needs_reset_resume_table.

Testing has shown that this is a false positive and the problems where caused by issues with the initial fix: commit fd865802c66b ("Bluetooth:
btusb: fix QCA Rome suspend/resume"), which has already been reverted.

Quoted 7 lines

So the QCA Rome BT in the Yoga 920 does not need a reset-resume quirk at all and this commit removes it from the btusb_needs_reset_resume_table.

Note that after this commit the btusb_needs_reset_resume_table is now empty. It is kept around on purpose, since this whole series of commits started for a reason and there are actually broken platforms around, which need to be added to it.

This is hilarious.

I think we need to go back to the author(s) of commit fd865802c66b and find proper details about said "numerous reported instances" of problems... Anyway:

Quoted 33 lines
Fixes 55a9c95d70ab ("Bluetooth: btusb: Use DMI matching for QCA ...")
Cc Brian Norris <[email protected]>
Cc Kai-Heng Feng <[email protected]>
---
 drivers/bluetooth/btusb.c | 7 -------
 1 file changed, 7 deletions(-)
drivers/bluetooth/btusb.c +0 -8
index a4b62f0a93cc..418550eb1522 100644
@@ -386,13 +386,6 @@ static const struct usb_device_id blacklist_table[] = {
  * the module itself. So we use a DMI list to match known broken platforms.
  */
 static const struct dmi_system_id btusb_needs_reset_resume_table[] = {
-       {
-               /* Lenovo Yoga 920 (QCA Rome device 0cf3:e300) */
-               .matches = {
-                       DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
-                       DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo YOGA 920"),
-               },
-       },
        {}
 };
 
--

2.14.3

#3 lore raw
Quoted 14 lines · Brian Norris

+ Leif

Quoted 11 lines · Hans de Goede

Commit 55a9c95d70ab ("Bluetooth: btusb: Use DMI matching for QCA reset_resume quirking"), added the Lenovo Yoga 920 to the btusb_needs_reset_resume_table.

Testing has shown that this is a false positive and the problems where caused by issues with the initial fix: commit fd865802c66b ("Bluetooth:
btusb: fix QCA Rome suspend/resume"), which has already been reverted.

So the QCA Rome BT in the Yoga 920 does not need a reset-resume quirk at all and this commit removes it from the btusb_needs_reset_resume_table.

Quoted 7 lines
Quoted 4 lines

Note that after this commit the btusb_needs_reset_resume_table is now empty. It is kept around on purpose, since this whole series of commits started for a reason and there are actually broken platforms around, which need to be added to it.

This is hilarious.

The platform at my hand still needs the quirk though, so the table is quite useful. I’ll send a patch soon.

Quoted 40 lines

I think we need to go back to the author(s) of commit fd865802c66b and find proper details about said "numerous reported instances" of problems... Anyway:

Quoted 34 lines
Fixes 55a9c95d70ab ("Bluetooth: btusb: Use DMI matching for QCA ...")
Cc Brian Norris <[email protected]>
Cc Kai-Heng Feng <[email protected]>
---
 drivers/bluetooth/btusb.c | 7 -------
 1 file changed, 7 deletions(-)
drivers/bluetooth/btusb.c +0 -7
index a4b62f0a93cc..418550eb1522 100644
@@ -386,13 +386,6 @@ static const struct usb_device_id blacklist_table[]  
 = {
  * the module itself. So we use a DMI list to match known broken platforms.
  */
 static const struct dmi_system_id btusb_needs_reset_resume_table[] = {
-       {
-               /* Lenovo Yoga 920 (QCA Rome device 0cf3:e300) */
-               .matches = {
-                       DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
-                       DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo YOGA 920"),
-               },
-       },
        {}
 };

—

2.14.3

maintainer
#4 lore raw
In reply to Hans de Goede

Hi Hans,

Quoted 24 lines

Commit 55a9c95d70ab ("Bluetooth: btusb: Use DMI matching for QCA reset_resume quirking"), added the Lenovo Yoga 920 to the btusb_needs_reset_resume_table.

Testing has shown that this is a false positive and the problems where caused by issues with the initial fix: commit fd865802c66b ("Bluetooth:
btusb: fix QCA Rome suspend/resume"), which has already been reverted.

So the QCA Rome BT in the Yoga 920 does not need a reset-resume quirk at all and this commit removes it from the btusb_needs_reset_resume_table.

Note that after this commit the btusb_needs_reset_resume_table is now empty. It is kept around on purpose, since this whole series of commits started for a reason and there are actually broken platforms around, which need to be added to it.

Fixes 55a9c95d70ab ("Bluetooth: btusb: Use DMI matching for QCA ...")
Cc Brian Norris <[email protected]>
Cc Kai-Heng Feng <[email protected]>
Quoted 3 lines

---
drivers/bluetooth/btusb.c | 7 -------

1 file changed, 7 deletions(-)

patch has been applied to bluetooth-stable tree.

Regards

Marcel