Skip to contentSkip to conversation

gpio: raspberrypi-ext: fix firmware dependency

PATCH In review Arnd Bergmann 3 participants 8 messages Feb 28, 2018 – Mar 2, 2018 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpio: raspberrypi-ext: fix firmware dependency

When the firmware driver is a loadable module, the gpio driver cannot be built-in:

drivers/gpio/gpio-raspberrypi-exp.o: In function `rpi_exp_gpio_set':
gpio-raspberrypi-exp.c:(.text+0xb4): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_get':
gpio-raspberrypi-exp.c:(.text+0x1ec): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_get_direction':
gpio-raspberrypi-exp.c:(.text+0x360): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_get_polarity':
gpio-raspberrypi-exp.c:(.text+0x4d4): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_dir_out':
gpio-raspberrypi-exp.c:(.text+0x670): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o:gpio-raspberrypi-exp.c:(.text+0x7fc): more undefined references to rpi_firmware_property' follow drivers/gpio/gpio-raspberrypi-exp.o: In function `rpi_exp_gpio_dir_in':
drivers/gpio/gpio-raspberrypi-exp.o: In function `rpi_exp_gpio_probe':
gpio-raspberrypi-exp.c:(.text+0x93c): undefined reference to `rpi_firmware_get'

We already have a Kconfig dependency for it, but when compile-testing, it is disregarded.

This changes the dependency so that compile-testing is only done when the firmware driver is completely disabled.

Fixes a98d90e7d588 ("gpio: raspberrypi-exp: Driver for RPi3 GPIO expander via mailbox service")
---
 drivers/gpio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/Kconfig +1 -1
index 2ecd2adbaec6..52a8b0a6f4e1 100644
@@ -126,7 +126,7 @@ config GPIO_RASPBERRYPI_EXP
 	tristate "Raspberry Pi 3 GPIO Expander"
 	default RASPBERRYPI_FIRMWARE
 	depends on OF_GPIO
-	depends on (ARCH_BCM2835 && RASPBERRYPI_FIRMWARE) || COMPILE_TEST
+	depends on (ARCH_BCM2835 && RASPBERRYPI_FIRMWARE) || (COMPILE_TEST && !RASPBERRYPI_FIRMWARE)
 	help
 	  Turn on GPIO support for the expander on Raspberry Pi 3 boards, using
 	  the firmware mailbox to communicate with VideoCore on BCM283x chips.
Signature · 1 line
2.9.0
#1 lore raw

Hi Arnd,

Thanks for the fix.

Quoted 18 lines · Arnd Bergmann

When the firmware driver is a loadable module, the gpio driver cannot be built-in:

drivers/gpio/gpio-raspberrypi-exp.o: In function `rpi_exp_gpio_set':
gpio-raspberrypi-exp.c:(.text+0xb4): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_get':
gpio-raspberrypi-exp.c:(.text+0x1ec): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_get_direction':
gpio-raspberrypi-exp.c:(.text+0x360): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_get_polarity':
gpio-raspberrypi-exp.c:(.text+0x4d4): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_dir_out':
gpio-raspberrypi-exp.c:(.text+0x670): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o:gpio-raspberrypi-exp.c:(.text+0x7fc): more undefined references to rpi_firmware_property' follow drivers/gpio/gpio-raspberrypi-exp.o: In function `rpi_exp_gpio_dir_in':
drivers/gpio/gpio-raspberrypi-exp.o: In function `rpi_exp_gpio_probe':
gpio-raspberrypi-exp.c:(.text+0x93c): undefined reference to `rpi_firmware_get'

Quoted 5 lines

We already have a Kconfig dependency for it, but when compile-testing, it is disregarded.

This changes the dependency so that compile-testing is only done when the firmware driver is completely disabled.

What about the CONFIG_ARCH_BCM2835=y case? The combination of CONFIG_GPIO_RASPBERRYPI_EXP=y and CONFIG_RASPBERRYPI_FIRMWARE=m is still valid. Wouldn't that break the build?

Isn't there a way in Kconfig to force CONFIG_GPIO_RASPBERRYPI_EXP=m when CONFIG_RASPBERRYPI_FIRMWARE=m?

What about 'depends on m || RASPBERRYPI_FIRMWARE=y'?

Grepping around I also found this:

drivers/power/supply/Kconfig: depends on USB_GADGET || !USB_GADGET # if USB_GADGET=m, this can't be 'y'

And this:

drivers/infiniband/Kconfig: depends on m || IPV6 != m

Quoted 11 lines
Fixes a98d90e7d588 ("gpio: raspberrypi-exp: Driver for RPi3 GPIO expander via mailbox service")
---
 drivers/gpio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/Kconfig +0 -0
index 2ecd2adbaec6..52a8b0a6f4e1 100644

drivers/gpio/Kconfig config GPIO_RASPBERRYPI_EXP · line 129

Quoted 5 lines
drivers/gpio/Kconfig +1 -1
@@ -126,7 +126,7 @@ config GPIO_RASPBERRYPI_EXP
 	tristate "Raspberry Pi 3 GPIO Expander"
 	default RASPBERRYPI_FIRMWARE
 	depends on OF_GPIO
-	depends on (ARCH_BCM2835 && RASPBERRYPI_FIRMWARE) || COMPILE_TEST
+	depends on (ARCH_BCM2835 && RASPBERRYPI_FIRMWARE) || (COMPILE_TEST && !RASPBERRYPI_FIRMWARE)

This is really non-obvious. An inline comment here might help, IMO.

drivers/gpio/Kconfig config GPIO_RASPBERRYPI_EXP · line 132

Quoted 3 lines
drivers/gpio/Kconfig +0 -0
 	help
 	  Turn on GPIO support for the expander on Raspberry Pi 3 boards, using
 	  the firmware mailbox to communicate with VideoCore on BCM283x chips.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - [email protected] - tel: +972.52.368.4656, http://www.tkos.co.il -
#2 lore raw
Quoted 29 lines · Baruch Siach

Hi Arnd,

Thanks for the fix.

Quoted 18 lines · Arnd Bergmann

When the firmware driver is a loadable module, the gpio driver cannot be built-in:

drivers/gpio/gpio-raspberrypi-exp.o: In function `rpi_exp_gpio_set':
gpio-raspberrypi-exp.c:(.text+0xb4): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_get':
gpio-raspberrypi-exp.c:(.text+0x1ec): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_get_direction':
gpio-raspberrypi-exp.c:(.text+0x360): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_get_polarity':
gpio-raspberrypi-exp.c:(.text+0x4d4): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_dir_out':
gpio-raspberrypi-exp.c:(.text+0x670): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o:gpio-raspberrypi-exp.c:(.text+0x7fc): more undefined references to rpi_firmware_property' follow drivers/gpio/gpio-raspberrypi-exp.o: In function `rpi_exp_gpio_dir_in':
drivers/gpio/gpio-raspberrypi-exp.o: In function `rpi_exp_gpio_probe':
gpio-raspberrypi-exp.c:(.text+0x93c): undefined reference to `rpi_firmware_get'

Quoted 5 lines

We already have a Kconfig dependency for it, but when compile-testing, it is disregarded.

This changes the dependency so that compile-testing is only done when the firmware driver is completely disabled.

Quoted 6 lines

What about the CONFIG_ARCH_BCM2835=y case? The combination of CONFIG_GPIO_RASPBERRYPI_EXP=y and CONFIG_RASPBERRYPI_FIRMWARE=m is still valid. Wouldn't that break the build?

Isn't there a way in Kconfig to force CONFIG_GPIO_RASPBERRYPI_EXP=m when CONFIG_RASPBERRYPI_FIRMWARE=m?

The problem I ran into only happens with CONFIG_ARCH_BCM2835=y to start with. My fix handles that case correctly, it forces CONFIG_GPIO_RASPBERRYPI_EXP to be either 'n' or 'm' when CONFIG_RASPBERRYPI_FIRMWARE=m.

Quoted 1 line

What about 'depends on m || RASPBERRYPI_FIRMWARE=y'?

That would be (slightly) wrong, it would force CONFIG_GPIO_RASPBERRYPI_EXP to be 'm' even if RASPBERRYPI_FIRMWARE=n.

Quoted 3 lines

Grepping around I also found this:

drivers/power/supply/Kconfig: depends on USB_GADGET || !USB_GADGET # if USB_GADGET=m, this can't be 'y'

That is what I did here as well, except the !RASPBERRYPI_FIRMWARE only applies for COMPILE_TEST.

Quoted 3 lines

And this:

drivers/infiniband/Kconfig: depends on m || IPV6 != m

This is a less common way to express it. The idiomatic Kconfig expression here would be 'depends on IPV6 || !IPV6'.

Quoted 6 lines
Quoted 6 lines
Fixes a98d90e7d588 ("gpio: raspberrypi-exp: Driver for RPi3 GPIO expander via mailbox service")
---
 drivers/gpio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 12 lines

drivers/gpio/Kconfig config GPIO_RASPBERRYPI_EXP · line 129

Quoted 10 lines
drivers/gpio/Kconfig +1 -1
index 2ecd2adbaec6..52a8b0a6f4e1 100644
@@ -126,7 +126,7 @@ config GPIO_RASPBERRYPI_EXP
      tristate "Raspberry Pi 3 GPIO Expander"
      default RASPBERRYPI_FIRMWARE
      depends on OF_GPIO
-     depends on (ARCH_BCM2835 && RASPBERRYPI_FIRMWARE) || COMPILE_TEST
+     depends on (ARCH_BCM2835 && RASPBERRYPI_FIRMWARE) || (COMPILE_TEST && !RASPBERRYPI_FIRMWARE)

This is really non-obvious. An inline comment here might help, IMO.

How about

# RASPBERRYPI_FIRMWARE is only available for ARCH_BCM2835, but we want to # allow compile-testing when it is disabled

?

Arnd

#3 lore raw

Hi Arnd,

Quoted 32 lines · Arnd Bergmann
Quoted 31 lines · Baruch Siach

Thanks for the fix.

Quoted 18 lines · Arnd Bergmann

When the firmware driver is a loadable module, the gpio driver cannot be built-in:

drivers/gpio/gpio-raspberrypi-exp.o: In function `rpi_exp_gpio_set':
gpio-raspberrypi-exp.c:(.text+0xb4): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_get':
gpio-raspberrypi-exp.c:(.text+0x1ec): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_get_direction':
gpio-raspberrypi-exp.c:(.text+0x360): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_get_polarity':
gpio-raspberrypi-exp.c:(.text+0x4d4): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_dir_out':
gpio-raspberrypi-exp.c:(.text+0x670): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o:gpio-raspberrypi-exp.c:(.text+0x7fc): more undefined references to rpi_firmware_property' follow drivers/gpio/gpio-raspberrypi-exp.o: In function `rpi_exp_gpio_dir_in':
drivers/gpio/gpio-raspberrypi-exp.o: In function `rpi_exp_gpio_probe':
gpio-raspberrypi-exp.c:(.text+0x93c): undefined reference to `rpi_firmware_get'

Quoted 5 lines

We already have a Kconfig dependency for it, but when compile-testing, it is disregarded.

This changes the dependency so that compile-testing is only done when the firmware driver is completely disabled.

What about the CONFIG_ARCH_BCM2835=y case? The combination of CONFIG_GPIO_RASPBERRYPI_EXP=y and CONFIG_RASPBERRYPI_FIRMWARE=m is still valid. Wouldn't that break the build?

Quoted 7 lines
Quoted 2 lines

Isn't there a way in Kconfig to force CONFIG_GPIO_RASPBERRYPI_EXP=m when CONFIG_RASPBERRYPI_FIRMWARE=m?

The problem I ran into only happens with CONFIG_ARCH_BCM2835=y to start with. My fix handles that case correctly, it forces CONFIG_GPIO_RASPBERRYPI_EXP to be either 'n' or 'm' when CONFIG_RASPBERRYPI_FIRMWARE=m.

Thanks for the explanation.

Quoted 12 lines
Quoted 1 line

What about 'depends on m || RASPBERRYPI_FIRMWARE=y'?

That would be (slightly) wrong, it would force CONFIG_GPIO_RASPBERRYPI_EXP to be 'm' even if RASPBERRYPI_FIRMWARE=n.

Quoted 3 lines

Grepping around I also found this:

drivers/power/supply/Kconfig: depends on USB_GADGET || !USB_GADGET # if USB_GADGET=m, this can't be 'y'

That is what I did here as well, except the !RASPBERRYPI_FIRMWARE only applies for COMPILE_TEST.

Quoted 6 lines
Quoted 3 lines

And this:

drivers/infiniband/Kconfig: depends on m || IPV6 != m

This is a less common way to express it. The idiomatic Kconfig expression here would be 'depends on IPV6 || !IPV6'.

I find this way much easier to understand. Without the comment I would never have guessed what 'USB_GADGET || !USB_GADGET' actually means. And indeed no comment is needed in the infiniband case.

Quoted 19 lines
Quoted 6 lines
Quoted 6 lines
Fixes a98d90e7d588 ("gpio: raspberrypi-exp: Driver for RPi3 GPIO expander via mailbox service")
---
 drivers/gpio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 12 lines

drivers/gpio/Kconfig config GPIO_RASPBERRYPI_EXP · line 129

Quoted 10 lines
drivers/gpio/Kconfig +1 -1
index 2ecd2adbaec6..52a8b0a6f4e1 100644
@@ -126,7 +126,7 @@ config GPIO_RASPBERRYPI_EXP
      tristate "Raspberry Pi 3 GPIO Expander"
      default RASPBERRYPI_FIRMWARE
      depends on OF_GPIO
-     depends on (ARCH_BCM2835 && RASPBERRYPI_FIRMWARE) || COMPILE_TEST
+     depends on (ARCH_BCM2835 && RASPBERRYPI_FIRMWARE) || (COMPILE_TEST && !RASPBERRYPI_FIRMWARE)

This is really non-obvious. An inline comment here might help, IMO.

Quoted 6 lines

How about

# RASPBERRYPI_FIRMWARE is only available for ARCH_BCM2835, but we want to # allow compile-testing when it is disabled

?

The module vs built-in aspect is missing. That is the non-obvious part.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - [email protected] - tel: +972.52.368.4656, http://www.tkos.co.il -
#4 lore raw
In reply to Arnd Bergmann
Quoted 18 lines · Arnd Bergmann

When the firmware driver is a loadable module, the gpio driver cannot be built-in:

drivers/gpio/gpio-raspberrypi-exp.o: In function `rpi_exp_gpio_set':
gpio-raspberrypi-exp.c:(.text+0xb4): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_get':
gpio-raspberrypi-exp.c:(.text+0x1ec): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_get_direction':
gpio-raspberrypi-exp.c:(.text+0x360): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_get_polarity':
gpio-raspberrypi-exp.c:(.text+0x4d4): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_dir_out':
gpio-raspberrypi-exp.c:(.text+0x670): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o:gpio-raspberrypi-exp.c:(.text+0x7fc): more undefined references to rpi_firmware_property' follow drivers/gpio/gpio-raspberrypi-exp.o: In function `rpi_exp_gpio_dir_in':
drivers/gpio/gpio-raspberrypi-exp.o: In function `rpi_exp_gpio_probe':
gpio-raspberrypi-exp.c:(.text+0x93c): undefined reference to `rpi_firmware_get'

Quoted 8 lines

We already have a Kconfig dependency for it, but when compile-testing, it is disregarded.

This changes the dependency so that compile-testing is only done when the firmware driver is completely disabled.

Fixes a98d90e7d588 ("gpio: raspberrypi-exp: Driver for RPi3 GPIO expander via mailbox service")

Baruch, are you waiting for a fixed fix or should I apply this?

It's a bit unclear from the mail chain what action I should take...

Yours,
Linus Walleij

#5 lore raw

Hi Linus,

Quoted 25 lines · Linus Walleij
Quoted 24 lines · Arnd Bergmann

When the firmware driver is a loadable module, the gpio driver cannot be built-in:

drivers/gpio/gpio-raspberrypi-exp.o: In function `rpi_exp_gpio_set':
gpio-raspberrypi-exp.c:(.text+0xb4): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_get':
gpio-raspberrypi-exp.c:(.text+0x1ec): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_get_direction':
gpio-raspberrypi-exp.c:(.text+0x360): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_get_polarity':
gpio-raspberrypi-exp.c:(.text+0x4d4): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_dir_out':
gpio-raspberrypi-exp.c:(.text+0x670): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o:gpio-raspberrypi-exp.c:(.text+0x7fc): more undefined references to rpi_firmware_property' follow drivers/gpio/gpio-raspberrypi-exp.o: In function `rpi_exp_gpio_dir_in':
drivers/gpio/gpio-raspberrypi-exp.o: In function `rpi_exp_gpio_probe':
gpio-raspberrypi-exp.c:(.text+0x93c): undefined reference to `rpi_firmware_get'

We already have a Kconfig dependency for it, but when compile-testing, it is disregarded.

This changes the dependency so that compile-testing is only done when the firmware driver is completely disabled.

Quoted 6 lines
Quoted 2 lines
Fixes a98d90e7d588 ("gpio: raspberrypi-exp: Driver for RPi3 GPIO expander via mailbox service")

Baruch, are you waiting for a fixed fix or should I apply this?

It's a bit unclear from the mail chain what action I should take...

This patch fixes the issue. I think that an inline comment should be added at least, because otherwise the dependency in incomprehensible. I also prefer the

depends on m || DEPENDENCY != m

style to express this kind of dependencies.

What do you think?

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - [email protected] - tel: +972.52.368.4656, http://www.tkos.co.il -
#6 lore raw
Quoted 33 lines · Baruch Siach
Quoted 25 lines · Linus Walleij
Quoted 24 lines · Arnd Bergmann

When the firmware driver is a loadable module, the gpio driver cannot be built-in:

drivers/gpio/gpio-raspberrypi-exp.o: In function `rpi_exp_gpio_set':
gpio-raspberrypi-exp.c:(.text+0xb4): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_get':
gpio-raspberrypi-exp.c:(.text+0x1ec): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_get_direction':
gpio-raspberrypi-exp.c:(.text+0x360): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_get_polarity':
gpio-raspberrypi-exp.c:(.text+0x4d4): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_dir_out':
gpio-raspberrypi-exp.c:(.text+0x670): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o:gpio-raspberrypi-exp.c:(.text+0x7fc): more undefined references to rpi_firmware_property' follow drivers/gpio/gpio-raspberrypi-exp.o: In function `rpi_exp_gpio_dir_in':
drivers/gpio/gpio-raspberrypi-exp.o: In function `rpi_exp_gpio_probe':
gpio-raspberrypi-exp.c:(.text+0x93c): undefined reference to `rpi_firmware_get'

We already have a Kconfig dependency for it, but when compile-testing, it is disregarded.

This changes the dependency so that compile-testing is only done when the firmware driver is completely disabled.

Quoted 6 lines
Quoted 2 lines
Fixes a98d90e7d588 ("gpio: raspberrypi-exp: Driver for RPi3 GPIO expander via mailbox service")

Baruch, are you waiting for a fixed fix or should I apply this?

It's a bit unclear from the mail chain what action I should take...

Quoted 8 lines

This patch fixes the issue. I think that an inline comment should be added at least, because otherwise the dependency in incomprehensible. I also prefer the

depends on m || DEPENDENCY != m

style to express this kind of dependencies.

What do you think?

I am hopelessly ignorant about Kconfig and the whole thing just bites me and scares me all the time, like it's an angry dog.

Just patch on top of Arnds fix if you prefer some other solution, I bet you know this better than me.

Yours,
Linus Walleij

#7 lore raw
In reply to Arnd Bergmann
Quoted 18 lines · Arnd Bergmann

When the firmware driver is a loadable module, the gpio driver cannot be built-in:

drivers/gpio/gpio-raspberrypi-exp.o: In function `rpi_exp_gpio_set':
gpio-raspberrypi-exp.c:(.text+0xb4): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_get':
gpio-raspberrypi-exp.c:(.text+0x1ec): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_get_direction':
gpio-raspberrypi-exp.c:(.text+0x360): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_get_polarity':
gpio-raspberrypi-exp.c:(.text+0x4d4): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o: In function rpi_exp_gpio_dir_out':
gpio-raspberrypi-exp.c:(.text+0x670): undefined reference to rpi_firmware_property' drivers/gpio/gpio-raspberrypi-exp.o:gpio-raspberrypi-exp.c:(.text+0x7fc): more undefined references to rpi_firmware_property' follow drivers/gpio/gpio-raspberrypi-exp.o: In function `rpi_exp_gpio_dir_in':
drivers/gpio/gpio-raspberrypi-exp.o: In function `rpi_exp_gpio_probe':
gpio-raspberrypi-exp.c:(.text+0x93c): undefined reference to `rpi_firmware_get'

Quoted 8 lines

We already have a Kconfig dependency for it, but when compile-testing, it is disregarded.

This changes the dependency so that compile-testing is only done when the firmware driver is completely disabled.

Fixes a98d90e7d588 ("gpio: raspberrypi-exp: Driver for RPi3 GPIO expander via mailbox service")

Patch applied.

Yours,
Linus Walleij