drm/i915: Add an option to disable SAGV
Subsystems (2)
PATCH v2 1/1 drm/i915: Add an option to disable SAGV
On Gen9 systems, with SAGV enabled, we have seen display corruption(screenshots attached in the bug) which eventually lead to a system hang. This happens when we have overlay plane and on enabling and disabling the overlay plane. When the system hangs, we do not have enough logs or information to debug the issue.
Having a module parameter will help in debugging the system hang.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104975
---
Changes from v1:
- Update the title and commit message.
- Rename the module param to enable_sagv and set it to default true.
drivers/gpu/drm/i915/i915_params.c | 3 +++ drivers/gpu/drm/i915/i915_params.h | 3 ++- drivers/gpu/drm/i915/intel_pm.c | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_params.c +3 -0
@@ -167,6 +167,9 @@ struct i915_params i915_modparams __read_mostly = {i915_param_named_unsafe (enable_dp_mst, bool,0600 ,"Enable multi-stream transport (MST) for new DisplayPort sinks. (default: true)" ); +i915_param_named_unsafe (enable_sagv, bool,0600 , +"Enable SAGV (default: true)" ); +#if IS_ENABLED (CONFIG_DRM_I915_DEBUG )i915_param_named_unsafe (inject_load_failure, uint,0400 ,"Force an error after a number of failure check points (0:disabled (default), N:force failure at the Nth failure check point)" );
drivers/gpu/drm/i915/i915_params.h +2 -1
@@ -69,7 +69,8 @@ param(bool, nuclear_pageflip, false) \ param(bool, enable_dp_mst, true) \ param(bool, enable_dpcd_backlight, false) \ - param(bool, enable_gvt, false) + param(bool, enable_gvt, false) \ + param(bool, enable_sagv, true)#define MEMBER (T , member, ...) T member;struct i915_params {
drivers/gpu/drm/i915/intel_pm.c +1 -1
@@ -3693,7 +3693,7 @@ bool intel_can_enable_sagv(struct drm_atomic_state *state)int level, latency;int sagv_block_time_us; -if (!intel_has_sagv (dev_priv)) +if (!intel_has_sagv (dev_priv) || !i915_modparams.enable_sagv)return false;if (IS_GEN9 (dev_priv))
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Add an option to disable SAGV
== Series Details ==
== Series Details ==
Series: drm/i915: Add an option to disable SAGV
URL : https://patchwork.freedesktop.org/series/39161/
State : success
== Summary ==
Series 39161v1 drm/i915: Add an option to disable SAGV
https://patchwork.freedesktop.org/api/1.0/series/39161/revisions/1/mbox/
---- Possible new issues:
Test gem_sync:
Subgroup basic-each:
dmesg-fail -> PASS (fi-bsw-n3050)
Subgroup basic-many-each:
skip -> PASS (fi-bsw-n3050)
Subgroup basic-store-all:
skip -> PASS (fi-bsw-n3050)
Subgroup basic-store-each:
skip -> PASS (fi-bsw-n3050)
Test gem_tiled_blits:
Subgroup basic:
skip -> PASS (fi-bsw-n3050)
Test gem_tiled_fence_blits:
Subgroup basic:
skip -> PASS (fi-bsw-n3050)
Test gem_wait:
Subgroup basic-await-all:
skip -> PASS (fi-bsw-n3050)
Subgroup basic-busy-all:
skip -> PASS (fi-bsw-n3050)
Subgroup basic-wait-all:
skip -> PASS (fi-bsw-n3050)
Test gem_workarounds:
Subgroup basic-read:
skip -> PASS (fi-bsw-n3050)
Test kms_busy:
Subgroup basic-flip-c:
skip -> PASS (fi-bsw-n3050)
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-atomic:
skip -> PASS (fi-bsw-n3050)
Subgroup basic-busy-flip-before-cursor-legacy:
skip -> PASS (fi-bsw-n3050)
Test kms_frontbuffer_tracking:
Subgroup basic:
skip -> PASS (fi-bsw-n3050)
Test kms_pipe_crc_basic:
Subgroup hang-read-crc-pipe-c:
dmesg-fail -> PASS (fi-bsw-n3050)
Subgroup suspend-read-crc-pipe-c:
dmesg-warn -> PASS (fi-bsw-n3050)---- Known issues:
Test gem_mmap_gtt:
Subgroup basic-small-bo-tiledx:
fail -> PASS (fi-gdg-551) fdo#102575
Test prime_vgem:
Subgroup basic-fence-flip:
pass -> FAIL (fi-ilk-650) fdo#104008fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:415s fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:372s fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:485s fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:283s fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:478s fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:484s fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:465s fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:455s fi-cfl-8700k total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:396s fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:562s fi-cnl-y3 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:592s fi-elk-e7500 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:414s fi-gdg-551 total:288 pass:180 dwarn:0 dfail:0 fail:0 skip:108 time:285s fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:508s fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:386s fi-ilk-650 total:288 pass:227 dwarn:0 dfail:0 fail:1 skip:60 time:405s fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:452s fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:410s fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:446s fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:489s fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:454s fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:493s fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:586s fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:423s fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:501s fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:516s fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:485s fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:472s fi-skl-guc total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:406s fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:430s fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:524s fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:390s
a6fa130671cfb3ace92ff6f6b045ccc851c3f95e drm-tip: 2018y-02m-28d-20h-19m-06s UTC integration manifest 646472ccd7db drm/i915: Add an option to disable SAGV
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8190/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: warning for drm/i915: Add an option to disable SAGV
In reply to Azhar Shaikh== Series Details ==
== Series Details ==
Series: drm/i915: Add an option to disable SAGV
URL : https://patchwork.freedesktop.org/series/39161/
State : warning
== Summary ==
---- Possible new issues:
Test kms_chv_cursor_fail:
Subgroup pipe-b-256x256-bottom-edge:
pass -> DMESG-WARN (shard-snb)
Test kms_vblank:
Subgroup pipe-c-ts-continuation-dpms-suspend:
fail -> PASS (shard-hsw)
Test pm_rc6_residency:
Subgroup rc6-accuracy:
pass -> SKIP (shard-snb)---- Known issues:
Test drv_suspend:
Subgroup debugfs-reader:
fail -> PASS (shard-hsw) k.org#196691
Test kms_chv_cursor_fail:
Subgroup pipe-b-64x64-top-edge:
pass -> DMESG-WARN (shard-snb) fdo#105185
Test kms_cursor_crc:
Subgroup cursor-256x256-suspend:
pass -> INCOMPLETE (shard-hsw) fdo#103375
Test kms_fbcon_fbt:
Subgroup fbc-suspend:
fail -> PASS (shard-hsw) fdo#105087
Test kms_flip:
Subgroup 2x-flip-vs-expired-vblank-interruptible:
pass -> FAIL (shard-hsw) fdo#102887 +1
Subgroup basic-flip-vs-wf_vblank:
pass -> FAIL (shard-hsw) fdo#103928
Test kms_setmode:
Subgroup basic:
pass -> FAIL (shard-apl) fdo#99912
Test kms_vblank:
Subgroup pipe-c-ts-continuation-suspend:
fail -> PASS (shard-hsw) fdo#103540 +1k.org#196691 https://bugzilla.kernel.org/show_bug.cgi?id=196691
fdo#105185 https://bugs.freedesktop.org/show_bug.cgi?id=105185
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#105087 https://bugs.freedesktop.org/show_bug.cgi?id=105087
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
shard-apl total:3460 pass:1819 dwarn:1 dfail:0 fail:7 skip:1632 time:12149s shard-hsw total:3446 pass:1754 dwarn:1 dfail:0 fail:3 skip:1686 time:11290s shard-snb total:3460 pass:1357 dwarn:3 dfail:0 fail:1 skip:2099 time:6620s
Blacklisted hosts:
shard-kbl total:3410 pass:1906 dwarn:16 dfail:0 fail:7 skip:1480 time:9393s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8190/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx