Skip to contentSkip to conversation

net/bnxt: fix an erorr with vnic_tpa_cfg command

PATCH Applied Ajit Khaparde 2 participants 4 messages Feb 28, 2018 – Mar 26, 2018 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/bnxt: fix an erorr with vnic_tpa_cfg command

When the vnic_tpa_cfg HWRM command is sent to the FW, we are not passing the VNIC ID in case of disable. This can cause the FW to return an error.
Correct VNIC ID needs to be passed for both enable and disable.

Fixes 0958d8b6435d ("net/bnxt: support LRO")
---
 drivers/net/bnxt/bnxt_hwrm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bnxt/bnxt_hwrm.c +1 -1
index b7843afe6..05663fedd 100644
@@ -1517,12 +1517,12 @@ int bnxt_hwrm_vnic_tpa_cfg(struct bnxt *bp,
 				HWRM_VNIC_TPA_CFG_INPUT_FLAGS_GRO |
 				HWRM_VNIC_TPA_CFG_INPUT_FLAGS_AGG_WITH_ECN |
 			HWRM_VNIC_TPA_CFG_INPUT_FLAGS_AGG_WITH_SAME_GRE_SEQ);
-		req.vnic_id = rte_cpu_to_le_32(vnic->fw_vnic_id);
 		req.max_agg_segs = rte_cpu_to_le_16(5);
 		req.max_aggs =
 			rte_cpu_to_le_16(HWRM_VNIC_TPA_CFG_INPUT_MAX_AGGS_MAX);
 		req.min_agg_len = rte_cpu_to_le_32(512);
 	}
+	req.vnic_id = rte_cpu_to_le_32(vnic->fw_vnic_id);
 
 	rc = bnxt_hwrm_send_message(bp, &req, sizeof(req));
 
Signature · 1 line
2.14.3 (Apple Git-98)
#1 lore raw
Quoted 4 lines · Ajit Khaparde

When the vnic_tpa_cfg HWRM command is sent to the FW, we are not passing the VNIC ID in case of disable. This can cause the FW to return an error.
Correct VNIC ID needs to be passed for both enable and disable.

Hi Ajit,

Patch title doesn't tell what is actually fixed, after reading commit log, will you be agree on following:

"net/bnxt: fix LRO disable"

Quoted 28 lines
Fixes 0958d8b6435d ("net/bnxt: support LRO")
---
 drivers/net/bnxt/bnxt_hwrm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bnxt/bnxt_hwrm.c +1 -1
index b7843afe6..05663fedd 100644
@@ -1517,12 +1517,12 @@ int bnxt_hwrm_vnic_tpa_cfg(struct bnxt *bp,
 				HWRM_VNIC_TPA_CFG_INPUT_FLAGS_GRO |
 				HWRM_VNIC_TPA_CFG_INPUT_FLAGS_AGG_WITH_ECN |
 			HWRM_VNIC_TPA_CFG_INPUT_FLAGS_AGG_WITH_SAME_GRE_SEQ);
-		req.vnic_id = rte_cpu_to_le_32(vnic->fw_vnic_id);
 		req.max_agg_segs = rte_cpu_to_le_16(5);
 		req.max_aggs =
 			rte_cpu_to_le_16(HWRM_VNIC_TPA_CFG_INPUT_MAX_AGGS_MAX);
 		req.min_agg_len = rte_cpu_to_le_32(512);
 	}
+	req.vnic_id = rte_cpu_to_le_32(vnic->fw_vnic_id);
 
 	rc = bnxt_hwrm_send_message(bp, &req, sizeof(req));
 
#2 lore raw
Quoted 6 lines · Ferruh Yigit
Quoted 4 lines · Ajit Khaparde

When the vnic_tpa_cfg HWRM command is sent to the FW, we are not passing the VNIC ID in case of disable. This can cause the FW to return an error.
Correct VNIC ID needs to be passed for both enable and disable.

Quoted 8 lines

Hi Ajit,

Patch title doesn't tell what is actually fixed, after reading commit log, will
you be agree on following:

"net/bnxt: fix LRO disable"

​Yes, Ferruh. This is fine.​ Thanks

Quoted 34 lines
Quoted 15 lines
Fixes 0958d8b6435d ("net/bnxt: support LRO")
---
 drivers/net/bnxt/bnxt_hwrm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bnxt/bnxt_hwrm.c +0 -0
index b7843afe6..05663fedd 100644

drivers/net/bnxt/bnxt_hwrm.c int bnxt_hwrm_vnic_tpa_cfg(struct bnxt *bp, · line 1518

Quoted 2 lines
drivers/net/bnxt/bnxt_hwrm.c +0 -0
@@ -1517,12 +1517,12 @@ int bnxt_hwrm_vnic_tpa_cfg(struct bnxt *bp,
                              HWRM_VNIC_TPA_CFG_INPUT_FLAGS_GRO |
                              HWRM_VNIC_TPA_CFG_INPUT_FLAGS_AGG_WITH_ECN

|

drivers/net/bnxt/bnxt_hwrm.c int bnxt_hwrm_vnic_tpa_cfg(struct bnxt *bp, · line 1519

Quoted 1 line
drivers/net/bnxt/bnxt_hwrm.c +0 -0
                      HWRM_VNIC_TPA_CFG_INPUT_FLAGS_

AGG_WITH_SAME_GRE_SEQ);

drivers/net/bnxt/bnxt_hwrm.c int bnxt_hwrm_vnic_tpa_cfg(struct bnxt *bp,

Quoted 4 lines
drivers/net/bnxt/bnxt_hwrm.c +0 -1
-             req.vnic_id = rte_cpu_to_le_32(vnic->fw_vnic_id);
              req.max_agg_segs = rte_cpu_to_le_16(5);
              req.max_aggs =
                      rte_cpu_to_le_16(HWRM_VNIC_

TPA_CFG_INPUT_MAX_AGGS_MAX);

Quoted 7 lines
drivers/net/bnxt/bnxt_hwrm.c +1 -0
              req.min_agg_len = rte_cpu_to_le_32(512);
      }
+     req.vnic_id = rte_cpu_to_le_32(vnic->fw_vnic_id);
 
      rc = bnxt_hwrm_send_message(bp, &req, sizeof(req));