media: ov5695: Off by one in ov5695_enum_frame_sizes()

PATCH New Dan Carpenter 1 participant 1 message Mar 1, 2018

Subsystems (4)

Media (V4L/DVB) Kernel janitors V4L2 camera sensor drivers Omnivision OV5695 sensor driver

lore

Share & tools

lore

Dan Carpenter

author

2018-03-01 10:07 UTC #0 lore raw

PATCH 1/1 media: ov5695: Off by one in ov5695_enum_frame_sizes()

The ">" should be ">=" so that we don't read one element beyond the end of the array.

Fixes 8a77009be4be ("media: ov5695: add support for OV5695 sensor")

Signed-off-by Dan Carpenter <[email protected]>

drivers/media/i2c/ov5695.c +1 -1

index a4985a4715f5..9be38a0a2046 100644
@@ -884,7 +884,7 @@ static int ov5695_enum_frame_sizes(struct v4l2_subdev *sd,
 				   struct v4l2_subdev_pad_config *cfg,
 				   struct v4l2_subdev_frame_size_enum *fse)
 {
-	if (fse->index > ARRAY_SIZE(supported_modes))
+	if (fse->index >= ARRAY_SIZE(supported_modes))
 		return -EINVAL;
 
 	if (fse->code != MEDIA_BUS_FMT_SBGGR10_1X10)