Skip to contentSkip to conversation

xrdp, xorgxrdp: require pam in DISTRO_FEATURES

PATCH In review Martin Jansa 2 participants 3 messages Mar 1, 2018 – Mar 4, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xrdp, xorgxrdp: require pam in DISTRO_FEATURES

* libpam dependency was added to xrdp in
http://git.openembedded.org/meta-openembedded/commit/?id=cc32ca8030c02a2b1b22f6b43e1894dc5f00e14e

---
 meta-oe/recipes-support/xorg-xrdp/xorgxrdp_0.2.5.bb | 2 +-
 meta-oe/recipes-support/xrdp/xrdp_0.9.4.bb          | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
meta-oe/recipes-support/xorg-xrdp/xorgxrdp_0.2.5.bb +1 -1
index 9355379840..558a1982f5 100644
@@ -8,7 +8,7 @@ inherit autotools pkgconfig
 DEPENDS = "virtual/libx11 xserver-xorg xrdp nasm-native"
 
 inherit distro_features_check
-REQUIRED_DISTRO_FEATURES = "x11"
+REQUIRED_DISTRO_FEATURES = "x11 pam"
 
 SRC_URI = "git://github.com/neutrinolabs/xorgxrdp.git"
 
meta-oe/recipes-support/xrdp/xrdp_0.9.4.bb +1 -1
index 88e309a59f..671a251962 100644
@@ -8,7 +8,7 @@ inherit distro_features_check autotools pkgconfig useradd systemd
 
 DEPENDS = "openssl virtual/libx11 libxfixes libxrandr libpam nasm-native fuse"
 
-REQUIRED_DISTRO_FEATURES = "x11"
+REQUIRED_DISTRO_FEATURES = "x11 pam"
 
 SRC_URI = "git://github.com/neutrinolabs/xrdp.git \
            file://xrdp.sysconfig \
Signature · 1 line
2.15.1
#1 lore raw
Quoted 2 lines · Martin Jansa

* libpam dependency was added to xrdp in
http://git.openembedded.org/meta-openembedded/commit/?id=cc32ca8030c02a2b1b22f6b43e1894dc5f00e14e

Please rebase

- armin

Quoted 33 lines
---
 meta-oe/recipes-support/xorg-xrdp/xorgxrdp_0.2.5.bb | 2 +-
 meta-oe/recipes-support/xrdp/xrdp_0.9.4.bb          | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
meta-oe/recipes-support/xorg-xrdp/xorgxrdp_0.2.5.bb +1 -1
index 9355379840..558a1982f5 100644
@@ -8,7 +8,7 @@ inherit autotools pkgconfig
 DEPENDS = "virtual/libx11 xserver-xorg xrdp nasm-native"
 
 inherit distro_features_check
-REQUIRED_DISTRO_FEATURES = "x11"
+REQUIRED_DISTRO_FEATURES = "x11 pam"
 
 SRC_URI = "git://github.com/neutrinolabs/xorgxrdp.git"
 
meta-oe/recipes-support/xrdp/xrdp_0.9.4.bb +1 -1
index 88e309a59f..671a251962 100644
@@ -8,7 +8,7 @@ inherit distro_features_check autotools pkgconfig useradd systemd
 
 DEPENDS = "openssl virtual/libx11 libxfixes libxrandr libpam nasm-native fuse"
 
-REQUIRED_DISTRO_FEATURES = "x11"
+REQUIRED_DISTRO_FEATURES = "x11 pam"
 
 SRC_URI = "git://github.com/neutrinolabs/xrdp.git \
            file://xrdp.sysconfig \
#2 lore raw

It does apply cleanly in master, but it depends on:
http://lists.openembedded.org/pipermail/openembedded-devel/2018-February/116994.html
which is still missing in master-next.

Quoted 49 lines · On Sun, Mar 4, 2018 at 4:02 PM, akuster808 <[email protected]> wrote:
Quoted 2 lines · Martin Jansa

* libpam dependency was added to xrdp in
http://git.openembedded.org/meta-openembedded/commit/?id=

cc32ca8030c02a2b1b22f6b43e1894dc5f00e14e

Please rebase

- armin

Review

Quoted 8 lines
---
 meta-oe/recipes-support/xorg-xrdp/xorgxrdp_0.2.5.bb | 2 +-
 meta-oe/recipes-support/xrdp/xrdp_0.9.4.bb          | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/meta-oe/recipes-support/xorg-xrdp/xorgxrdp_0.2.5.bb

Review

Quoted 13 lines

index 9355379840..558a1982f5 100644

meta-oe/recipes-support/xorg-xrdp/xorgxrdp_0.2.5.bb +1 -1
@@ -8,7 +8,7 @@ inherit autotools pkgconfig
 DEPENDS = "virtual/libx11 xserver-xorg xrdp nasm-native"
 
 inherit distro_features_check
-REQUIRED_DISTRO_FEATURES = "x11"
+REQUIRED_DISTRO_FEATURES = "x11 pam"
 
 SRC_URI = "git://github.com/neutrinolabs/xorgxrdp.git"
 
(quoted diff) +0 -0

b/meta-oe/recipes-support/xrdp/xrdp_0.9.4.bb

meta-oe/recipes-support/xrdp/xrdp_0.9.4.bb inherit distro_features_check autotools pkgconfig

Quoted 4 lines

index 88e309a59f..671a251962 100644

meta-oe/recipes-support/xrdp/xrdp_0.9.4.bb +0 -0
@@ -8,7 +8,7 @@ inherit distro_features_check autotools pkgconfig

useradd systemd

meta-oe/recipes-support/xrdp/xrdp_0.9.4.bb inherit distro_features_check autotools pkgconfig · line 8

Quoted 2 lines
meta-oe/recipes-support/xrdp/xrdp_0.9.4.bb +0 -0
 DEPENDS = "openssl virtual/libx11 libxfixes libxrandr libpam

nasm-native fuse"

Quoted 6 lines
meta-oe/recipes-support/xrdp/xrdp_0.9.4.bb +1 -1
-REQUIRED_DISTRO_FEATURES = "x11"
+REQUIRED_DISTRO_FEATURES = "x11 pam"
 
 SRC_URI = "git://github.com/neutrinolabs/xrdp.git \
            file://xrdp.sysconfig \