Skip to contentSkip to conversation

package/qt5/qt5scxml: install missing QML module

PATCH New Bartosz Bilas 3 participants 7 messages Mar 1, 2018 – Mar 7, 2018

lore
Share & tools
lore

Bartosz Bilas

author
#0 lore raw

PATCH 1/1 package/qt5/qt5scxml: install missing QML module

This patch add support for scxml module in QML projects. When would you like to use state machines in qml files, you get an error like this:

qrc:/MainUI.qml:2 module "QtScxml" is not installed

Signed-off-by Bartosz Bilas <[email protected]>
---
 package/qt5/qt5scxml/qt5scxml.mk | 7 +++++++
 1 file changed, 7 insertions(+)
package/qt5/qt5scxml/qt5scxml.mk +7 -0
index 2d197a2bca..3f0f1a9054 100644
@@ -35,6 +35,12 @@ define QT5SCXML_INSTALL_TARGET_LIBS
 endef
 endif
 
+ifeq ($(BR2_PACKAGE_QT5DECLARATIVE_QUICK),y)
+define QT5SCXML_INSTALL_TARGET_QMLS
+	cp -dpfr $(STAGING_DIR)/usr/qml/QtScxml/ $(TARGET_DIR)/usr/qml/
+endef
+endif
+
 ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y)
 define QT5SCXML_INSTALL_TARGET_EXAMPLES
 	cp -dpfr $(STAGING_DIR)/usr/lib/qt/examples/scxml $(TARGET_DIR)/usr/lib/qt/examples/

@@ -43,6 +49,7 @@ endif
 
 define QT5SCXML_INSTALL_TARGET_CMDS
 	$(QT5SCXML_INSTALL_TARGET_LIBS)
+	$(QT5SCXML_INSTALL_TARGET_QMLS)
 	$(QT5SCXML_INSTALL_TARGET_EXAMPLES)
 endef
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 package/qt5/qt5scxml: install missing QML module

Hello Bartosz,

first thanks for the suggested patch.

Quoted 6 lines · Bartosz Bilas

This patch add support for scxml module in QML projects. When would you like to use state machines in qml files, you get an error like this:

qrc:/MainUI.qml:2 module "QtScxml" is not installed

Patch subject: 'qt5scxml: install missing QML module' and

Fixes:

qrc:/MainUI.qml:2 module "QtScxml" is not installed

would be enough (I think the patched lines are self-explanatory)...

Quoted 11 lines
Signed-off-by Bartosz Bilas <[email protected]>
---
 package/qt5/qt5scxml/qt5scxml.mk | 7 +++++++
 1 file changed, 7 insertions(+)
package/qt5/qt5scxml/qt5scxml.mk +0 -0
index 2d197a2bca..3f0f1a9054 100644

package/qt5/qt5scxml/qt5scxml.mk define QT5SCXML_INSTALL_TARGET_LIBS · line 43

Quoted 9 lines
package/qt5/qt5scxml/qt5scxml.mk +6 -0
@@ -35,6 +35,12 @@ define QT5SCXML_INSTALL_TARGET_LIBS
 endef
 endif
 
+ifeq ($(BR2_PACKAGE_QT5DECLARATIVE_QUICK),y)
+define QT5SCXML_INSTALL_TARGET_QMLS
+	cp -dpfr $(STAGING_DIR)/usr/qml/QtScxml/ $(TARGET_DIR)/usr/qml/
+endef
+endif
+

The dependency on BR2_PACKAGE_QT5DECLARATIVE_QUICK is not needed, the QtScxml module is build/installed even without enabled BR2_PACKAGE_QT5DECLARATIVE_QUICK...

With this changes you can add my

Reviewed-by Peter Seiderer <[email protected]>

Regards,
Peter

Quoted 11 lines
package/qt5/qt5scxml/qt5scxml.mk +1 -0
 ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y)
 define QT5SCXML_INSTALL_TARGET_EXAMPLES
 	cp -dpfr $(STAGING_DIR)/usr/lib/qt/examples/scxml $(TARGET_DIR)/usr/lib/qt/examples/

@@ -43,6 +49,7 @@ endif
 
 define QT5SCXML_INSTALL_TARGET_CMDS
 	$(QT5SCXML_INSTALL_TARGET_LIBS)
+	$(QT5SCXML_INSTALL_TARGET_QMLS)
 	$(QT5SCXML_INSTALL_TARGET_EXAMPLES)
 endef
author
#2 lore raw

PATCH 1/1 package/qt5/qt5scxml: install missing QML module

Hi Peter,

Quoted 33 lines · Peter Seiderer

Hello Bartosz,

first thanks for the suggested patch.

Quoted 6 lines · Bartosz Bilas

This patch add support for scxml module in QML projects. When would you like to use state machines in qml files, you get an error like this:

qrc:/MainUI.qml:2 module "QtScxml" is not installed

Patch subject: 'qt5scxml: install missing QML module' and

Fixes:

qrc:/MainUI.qml:2 module "QtScxml" is not installed

would be enough (I think the patched lines are self-explanatory)...

Quoted 13 lines
Signed-off-by Bartosz Bilas <[email protected]>
---
  package/qt5/qt5scxml/qt5scxml.mk | 7 +++++++
  1 file changed, 7 insertions(+)
package/qt5/qt5scxml/qt5scxml.mk +0 -0
index 2d197a2bca..3f0f1a9054 100644
@@ -35,6 +35,12 @@ define QT5SCXML_INSTALL_TARGET_LIBS
  endef
  endif
Quoted 8 lines

package/qt5/qt5scxml/qt5scxml.mk define QT5SCXML_INSTALL_TARGET_LIBS · line 43

Quoted 6 lines
package/qt5/qt5scxml/qt5scxml.mk +6 -0
+ifeq ($(BR2_PACKAGE_QT5DECLARATIVE_QUICK),y)
+define QT5SCXML_INSTALL_TARGET_QMLS
+	cp -dpfr $(STAGING_DIR)/usr/qml/QtScxml/ $(TARGET_DIR)/usr/qml/
+endef
+endif
+

The dependency on BR2_PACKAGE_QT5DECLARATIVE_QUICK is not needed, the QtScxml module is build/installed even without enabled BR2_PACKAGE_QT5DECLARATIVE_QUICK...

I was thinking about it but without qt quick this module is unnecessary so I'm not sure that we should copy this to the image.

Best regards,
Bartosz Bi?as

Quoted 20 lines

With this changes you can add my

Reviewed-by Peter Seiderer <[email protected]>

Regards,
Peter

Quoted 11 lines
package/qt5/qt5scxml/qt5scxml.mk +1 -0
  ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y)
  define QT5SCXML_INSTALL_TARGET_EXAMPLES
  	cp -dpfr $(STAGING_DIR)/usr/lib/qt/examples/scxml $(TARGET_DIR)/usr/lib/qt/examples/

@@ -43,6 +49,7 @@ endif
 
  define QT5SCXML_INSTALL_TARGET_CMDS
  	$(QT5SCXML_INSTALL_TARGET_LIBS)
+	$(QT5SCXML_INSTALL_TARGET_QMLS)
  	$(QT5SCXML_INSTALL_TARGET_EXAMPLES)
  endef
Signature · 3 lines
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180301/34a91dad/attachment.html>
#3 lore raw

PATCH 1/1 package/qt5/qt5scxml: install missing QML module

Hello Bartosz,

Quoted 44 lines · Bartosz Bi?as

Hi Peter,

Quoted 33 lines · Peter Seiderer

Hello Bartosz,

first thanks for the suggested patch.

Quoted 6 lines · Bartosz Bilas

This patch add support for scxml module in QML projects. When would you like to use state machines in qml files, you get an error like this:

qrc:/MainUI.qml:2 module "QtScxml" is not installed

Patch subject: 'qt5scxml: install missing QML module' and

Fixes:

qrc:/MainUI.qml:2 module "QtScxml" is not installed

would be enough (I think the patched lines are self-explanatory)...

Quoted 13 lines
Signed-off-by Bartosz Bilas <[email protected]>
---
  package/qt5/qt5scxml/qt5scxml.mk | 7 +++++++
  1 file changed, 7 insertions(+)
package/qt5/qt5scxml/qt5scxml.mk +0 -0
index 2d197a2bca..3f0f1a9054 100644
@@ -35,6 +35,12 @@ define QT5SCXML_INSTALL_TARGET_LIBS
  endef
  endif
Quoted 8 lines

package/qt5/qt5scxml/qt5scxml.mk define QT5SCXML_INSTALL_TARGET_LIBS · line 43

Quoted 6 lines
package/qt5/qt5scxml/qt5scxml.mk +6 -0
+ifeq ($(BR2_PACKAGE_QT5DECLARATIVE_QUICK),y)
+define QT5SCXML_INSTALL_TARGET_QMLS
+	cp -dpfr $(STAGING_DIR)/usr/qml/QtScxml/ $(TARGET_DIR)/usr/qml/
+endef
+endif
+

The dependency on BR2_PACKAGE_QT5DECLARATIVE_QUICK is not needed, the QtScxml module is build/installed even without enabled BR2_PACKAGE_QT5DECLARATIVE_QUICK...

Quoted 2 lines

I was thinking about it but without qt quick this module is unnecessary so I'm not sure that we should copy this to the image.

Mhhh, point for you ;-), I would still prefer the version without dependency on quick (as the qt compile/configure logic does) even if a usage without quick is more or less theoretically? But I am o.k. with both solutions in case you add a little comment...

Regards,
Peter

Quoted 24 lines

Best regards,
Bartosz Bi?as

Quoted 20 lines

With this changes you can add my

Reviewed-by Peter Seiderer <[email protected]>

Regards,
Peter

Quoted 11 lines
package/qt5/qt5scxml/qt5scxml.mk +1 -0
  ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y)
  define QT5SCXML_INSTALL_TARGET_EXAMPLES
  	cp -dpfr $(STAGING_DIR)/usr/lib/qt/examples/scxml $(TARGET_DIR)/usr/lib/qt/examples/

@@ -43,6 +49,7 @@ endif
 
  define QT5SCXML_INSTALL_TARGET_CMDS
  	$(QT5SCXML_INSTALL_TARGET_LIBS)
+	$(QT5SCXML_INSTALL_TARGET_QMLS)
  	$(QT5SCXML_INSTALL_TARGET_EXAMPLES)
  endef
#4 lore raw

PATCH 1/1 package/qt5/qt5scxml: install missing QML module

In reply to Peter Seiderer

Hello,

Quoted 2 lines · Peter Seiderer

The dependency on BR2_PACKAGE_QT5DECLARATIVE_QUICK is not needed, the QtScxml module is build/installed even without enabled BR2_PACKAGE_QT5DECLARATIVE_QUICK...

But does it make sense to install QML files if the Qt that has been built has no way to use them ? Or am I missing something about what BR2_PACKAGE_QT5DECLARATIVE_QUICK is ?

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
#5 lore raw

PATCH 1/1 package/qt5/qt5scxml: install missing QML module

Hello Thomas,

Quoted 10 lines · Thomas Petazzoni

Hello,

Quoted 2 lines · Peter Seiderer

The dependency on BR2_PACKAGE_QT5DECLARATIVE_QUICK is not needed, the QtScxml module is build/installed even without enabled BR2_PACKAGE_QT5DECLARATIVE_QUICK...

But does it make sense to install QML files if the Qt that has been built has no way to use them ? Or am I missing something about what BR2_PACKAGE_QT5DECLARATIVE_QUICK is ?

No expert for Qml/QtQuick either, but as explained in [1] 'QML is the Language (just like C++)' and 'QtQuick is a toolkit for QML, allowing to develop graphical interface in QML language (there are other toolkits for QML, some are graphical like Sailfish Silica or BlackBerry Cascade, and some are non-graphical like QBS...'

Qscxml is usable from QtQuick, but QtQuick is no prerequisite to use Qscxml (from a theoretical point of view (and practical the QML module is buildable without QtQuick))....

Regards,
Peter

[1] https://stackoverflow.com/questions/19696153/difference-between-qt-qml-and-qt-quick

Quoted 4 lines

Best regards,

Thomas

author
#6 lore raw

PATCH 1/1 package/qt5/qt5scxml: install missing QML module

In reply to Thomas Petazzoni

Hi Thomas,
In my opinion no, according to the other packages they also have dependence on qt quick
and if it is not selected then they do not install files related to QML.

Best regards,
Bartosz Bi?as

Quoted 13 lines · Thomas Petazzoni

Hello,

Quoted 2 lines · Peter Seiderer

The dependency on BR2_PACKAGE_QT5DECLARATIVE_QUICK is not needed, the QtScxml module is build/installed even without enabled BR2_PACKAGE_QT5DECLARATIVE_QUICK...

But does it make sense to install QML files if the Qt that has been built has no way to use them ? Or am I missing something about what BR2_PACKAGE_QT5DECLARATIVE_QUICK is ?

Best regards,

Thomas

Signature · 51 lines
Bartosz Bi?as
	Grinn sp. z o.o. <http://grinn-global.com>
Junior Software Developer

	
LinkedIn <https://www.linkedin.com/company/grinn> 	Twitter 
<https://twitter.com/GrinnInt> 	YouTube 
<https://www.youtube.com/channel/UCiiEEK1yzyeMSeku06RFXPQ>

GRINN sp. z o.o
Wagonowa 2
53-609 Wroc?aw 	tel. +48 71 716 40 99
fax +48 71 716 41 53
www.grinn-global.com <http://grinn-global.com/> 	KRS: 0000230049
NIP: 8992730302
REGON: 020047322 	S?d Rejonowy we Wroc?awiu
VI Wydzia? Gospodarczy
Kapita? zak?adowy: 125.000,00 z?


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180307/a43b828d/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Grinn.png
Type: image/png
Size: 5695 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180307/a43b828d/attachment.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: LinkedIn.png
Type: image/png
Size: 521 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180307/a43b828d/attachment-0001.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Twitter.png
Type: image/png
Size: 338 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180307/a43b828d/attachment-0002.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: YouTube.png
Type: image/png
Size: 593 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180307/a43b828d/attachment-0003.png>