Skip to contentSkip to conversation

arm: dts: imx: Add missing #sound-dai-cells for sgtl5000 codec

PATCH New Rob Herring 2 participants 2 messages Mar 1, 2018 – Mar 8, 2018

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 arm: dts: imx: Add missing #sound-dai-cells for sgtl5000 codec

dtc now warns about missing #sound-dai-cells:

arch/arm/boot/dts/imx6ul-geam.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /soc/aips-bus at 2100000/i2c at 21a0000/codec at a or bad phandle (referred from sound-dai[0]) arch/arm/boot/dts/imx6ul-isiot-emmc.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /soc/aips-bus at 2100000/i2c at 21a0000/codec at a or bad phandle (referred from sound-dai[0]) arch/arm/boot/dts/imx6ul-isiot-nand.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /soc/aips-bus at 2100000/i2c at 21a0000/codec at a or bad phandle (referred from sound-dai[0])

Lots of i.MX boards use the SGTL5000 codec, but not all get the warning because only some reference the codec with "sound-dai" property. However, the codec should always provide #sound-dai-cells regardless, so fix all the occurrences.

Cc Shawn Guo <[email protected]>
Cc Sascha Hauer <[email protected]>
Cc Fabio Estevam <[email protected]>
Signed-off-by Rob Herring <[email protected]>
---
 arch/arm/boot/dts/imx28-apx4devkit.dts       | 1 +
 arch/arm/boot/dts/imx28-eukrea-mbmx28lc.dtsi | 1 +
 arch/arm/boot/dts/imx28-evk.dts              | 1 +
 arch/arm/boot/dts/imx28-m28evk.dts           | 1 +
 arch/arm/boot/dts/imx51-babbage.dts          | 1 +
 arch/arm/boot/dts/imx53-m53evk.dts           | 1 +
 arch/arm/boot/dts/imx53-ppd.dts              | 1 +
 arch/arm/boot/dts/imx53-qsb-common.dtsi      | 1 +
 arch/arm/boot/dts/imx53-tx53-x03x.dts        | 1 +
 arch/arm/boot/dts/imx53-tx53-x13x.dts        | 1 +
 arch/arm/boot/dts/imx53-voipac-bsb.dts       | 1 +
 arch/arm/boot/dts/imx6qdl-gw560x.dtsi        | 1 +
 arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi | 1 +
 arch/arm/boot/dts/imx6ul-geam.dts            | 1 +
 14 files changed, 14 insertions(+)
arch/arm/boot/dts/imx28-apx4devkit.dts +1 -0
index ae078341fb60..552ab577f1b0 100644
@@ -146,6 +146,7 @@
 				sgtl5000: codec at a {
 					compatible = "fsl,sgtl5000";
 					reg = <0x0a>;
+					#sound-dai-cells = <0>;
 					VDDA-supply = <&reg_3p3v>;
 					VDDIO-supply = <&reg_3p3v>;
 					clocks = <&saif0>;
arch/arm/boot/dts/imx28-eukrea-mbmx28lc.dtsi +1 -0
index 49ab40838e69..ff1328ce7d37 100644
@@ -151,6 +151,7 @@
 	sgtl5000: codec at a {
 		compatible = "fsl,sgtl5000";
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		VDDA-supply = <&reg_3p3v>;
 		VDDIO-supply = <&reg_3p3v>;
 		clocks = <&saif0>;
arch/arm/boot/dts/imx28-evk.dts +1 -0
index 7f5b80402c54..bc099610cd76 100644
@@ -197,6 +197,7 @@
 				sgtl5000: codec at a {
 					compatible = "fsl,sgtl5000";
 					reg = <0x0a>;
+					#sound-dai-cells = <0>;
 					VDDA-supply = <&reg_3p3v>;
 					VDDIO-supply = <&reg_3p3v>;
 					clocks = <&saif0>;
arch/arm/boot/dts/imx28-m28evk.dts +1 -0
index 22aa025cab1e..7d97a0ce74a3 100644
@@ -140,6 +140,7 @@
 				sgtl5000: codec at a {
 					compatible = "fsl,sgtl5000";
 					reg = <0x0a>;
+					#sound-dai-cells = <0>;
 					VDDA-supply = <&reg_3p3v>;
 					VDDIO-supply = <&reg_3p3v>;
 					clocks = <&saif0>;
arch/arm/boot/dts/imx51-babbage.dts +1 -0
index 4ac5ab614a7f..0b46e9726650 100644
@@ -369,6 +369,7 @@
 	sgtl5000: codec at a {
 		compatible = "fsl,sgtl5000";
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		clocks = <&clk_audio>;
 		VDDA-supply = <&vdig_reg>;
 		VDDIO-supply = <&vvideo_reg>;
arch/arm/boot/dts/imx53-m53evk.dts +1 -0
index e48525763b1b..3935fe6490ed 100644
@@ -153,6 +153,7 @@
 	sgtl5000: codec at a {
 		compatible = "fsl,sgtl5000";
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		VDDA-supply = <&reg_3p2v>;
 		VDDIO-supply = <&reg_3p2v>;
 		clocks = <&clks IMX5_CLK_SSI_EXT1_GATE>;
arch/arm/boot/dts/imx53-ppd.dts +1 -0
index cce959438a79..c37418108e88 100644
@@ -436,6 +436,7 @@
 			sgtl5000: codec at a {
 				compatible = "fsl,sgtl5000";
 				reg = <0xa>;
+				#sound-dai-cells = <0>;
 				VDDA-supply = <&reg_sgtl5k>;
 				VDDIO-supply = <&reg_sgtl5k>;
 				clocks = <&cko2_11M>;
arch/arm/boot/dts/imx53-qsb-common.dtsi +1 -0
index 41a2e2a2b079..2cf41fec282b 100644
@@ -317,6 +317,7 @@
 	sgtl5000: codec at a {
 		compatible = "fsl,sgtl5000";
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		VDDA-supply = <&reg_3p2v>;
 		VDDIO-supply = <&reg_3p2v>;
 		clocks = <&clks IMX5_CLK_SSI_EXT1_GATE>;
arch/arm/boot/dts/imx53-tx53-x03x.dts +1 -0
index fe15c9555d6e..af8ec5e4417b 100644
@@ -230,6 +230,7 @@
 	sgtl5000: codec at a {
 		compatible = "fsl,sgtl5000";
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		VDDA-supply = <&reg_2v5>;
 		VDDIO-supply = <&reg_3v3>;
 		clocks = <&mclk>;
arch/arm/boot/dts/imx53-tx53-x13x.dts +1 -0
index f2b2ad3ce9e5..6cdf2082c742 100644
@@ -131,6 +131,7 @@
 	sgtl5000: codec at a {
 		compatible = "fsl,sgtl5000";
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		VDDA-supply = <&reg_2v5>;
 		VDDIO-supply = <&reg_3v3>;
 		clocks = <&mclk>;
arch/arm/boot/dts/imx53-voipac-bsb.dts +1 -0
index 25c78f19826c..957053755c3c 100644
@@ -133,6 +133,7 @@
 	sgtl5000: codec at a {
 		compatible = "fsl,sgtl5000";
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		VDDA-supply = <&reg_3p3v>;
 		VDDIO-supply = <&reg_3p3v>;
 		clocks = <&clks 150>;
arch/arm/boot/dts/imx6qdl-gw560x.dtsi +1 -0
index d894dde6e85d..b5986efe1090 100644
@@ -288,6 +288,7 @@
 	sgtl5000: codec at a {
 		compatible = "fsl,sgtl5000";
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		clocks = <&clks IMX6QDL_CLK_CKO>;
 		VDDA-supply = <&reg_1p8v>;
 		VDDIO-supply = <&reg_3p3v>;
arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi +1 -0
index dffbc92e0023..8dcf3bb96e79 100644
@@ -191,6 +191,7 @@
 	sgtl5000: codec at a {
 		clocks = <&clks IMX6QDL_CLK_CKO>;
 		compatible = "fsl,sgtl5000";
+		#sound-dai-cells = <0>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_hummingboard2_sgtl5000>;
 		reg = <0x0a>;
arch/arm/boot/dts/imx6ul-geam.dts +1 -0
index 571eea7f1c6b..aee6cf39cb76 100644
@@ -181,6 +181,7 @@
 	sgtl5000: codec at a {
 		compatible = "fsl,sgtl5000";
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		clocks = <&clks IMX6UL_CLK_OSC>;
 		clock-names = "mclk";
 		VDDA-supply = <&reg_3p3v>;
Signature · 1 line
2.14.1
Applied
#1 lore raw

PATCH 1/1 arm: dts: imx: Add missing #sound-dai-cells for sgtl5000 codec

Quoted 11 lines · Rob Herring

dtc now warns about missing #sound-dai-cells:

arch/arm/boot/dts/imx6ul-geam.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /soc/aips-bus at 2100000/i2c at 21a0000/codec at a or bad phandle (referred from sound-dai[0]) arch/arm/boot/dts/imx6ul-isiot-emmc.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /soc/aips-bus at 2100000/i2c at 21a0000/codec at a or bad phandle (referred from sound-dai[0]) arch/arm/boot/dts/imx6ul-isiot-nand.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /soc/aips-bus at 2100000/i2c at 21a0000/codec at a or bad phandle (referred from sound-dai[0])

Lots of i.MX boards use the SGTL5000 codec, but not all get the warning because only some reference the codec with "sound-dai" property. However, the codec should always provide #sound-dai-cells regardless, so fix all the occurrences.

Quoted 4 lines
Cc Shawn Guo <[email protected]>
Cc Sascha Hauer <[email protected]>
Cc Fabio Estevam <[email protected]>
Signed-off-by Rob Herring <[email protected]>

Applied, thanks.