git-gui: CTRL/CMD + numpad ENTER does not invoke same command as "regular" ENTER
In git-gui, we can hit CTRL/CMD+ENTER to create a commit. However, using the numpad ENTER does not invoke the same command.
I propose that both numpad ENTER and "regular" ENTER should invoke the same command.
PATCH 1/1 git-gui: bind CTRL/CMD+numpad ENTER to do_commit
--- git-gui/git-gui.sh | 1 + 1 file changed, 1 insertion(+)
git-gui/git-gui.sh +1 -0
@@ -3867,6 +3867,7 @@ bind . <$M1B-Key-equal> {show_more_context;break} bind . <$M1B-Key-plus> {show_more_context;break} bind . <$M1B-Key-KP_Add> {show_more_context;break} bind . <$M1B-Key-Return> do_commit +bind . <$M1B-Key-KP_Enter> do_commit foreach i [list $ui_index $ui_workdir] { bind $i <Button-1> { toggle_or_diff click %W %x %y; break } bind $i <$M1B-Button-1> { add_one_to_selection %W %x %y; break }
Signature · 1 line
2.16.2.268.g7f9c27f2f.dirty
Re: [PATCH] git-gui: bind CTRL/CMD+numpad ENTER to do_commit
Quoted 1 line · Birger Skogeng Pedersen
---
Please sign-off on your patch. See Documentation/SubmittingPatches.
Also, it would be helpful to write at least a short commit message justifying the change. The reason you gave in your lead-in email[1] might be sufficient:
In git-gui, we can hit CTRL/CMD+ENTER to create a commit. However, using the numpad ENTER does not invoke the same command.
(assuming people don't argue that numpad ENTER should be saved for some other function).
Thanks.
[1]: https://public-inbox.org/git/CAGr--=LxMtz5RRP4742u3VsrADRsWARE2SitCSOWATySOn2LcQ@mail.gmail.com/
Quoted 12 lines
git-gui/git-gui.sh +1
-0@@ -3867,6 +3867,7 @@ bind . <$M1B-Key-equal> {show_more_context;break} bind . <$M1B-Key-plus> {show_more_context;break} bind . <$M1B-Key-KP_Add> {show_more_context;break} bind . <$M1B-Key-Return> do_commit +bind . <$M1B-Key-KP_Enter> do_commit foreach i [list $ui_index $ui_workdir] { bind $i <Button-1> { toggle_or_diff click %W %x %y; break } bind $i <$M1B-Button-1> { add_one_to_selection %W %x %y; break }
Re: [PATCH] git-gui: bind CTRL/CMD+numpad ENTER to do_commit
Sorry about that. Version 2 coming right up.
Quoted 32 lines · Eric Sunshine
Quoted 1 line · Birger Skogeng Pedersen
---
Please sign-off on your patch. See
Documentation/SubmittingPatches.Also, it would be helpful to write at least a short commit message justifying the change. The reason you gave in your lead-in email[1] might be sufficient:
In git-gui, we can hit CTRL/CMD+ENTER to create a commit. However, using the numpad ENTER does not invoke the same command.
(assuming people don't argue that numpad ENTER should be saved for some other function).
Thanks.
[1]: https://public-inbox.org/git/CAGr--=LxMtz5RRP4742u3VsrADRsWARE2SitCSOWATySOn2LcQ@mail.gmail.com/
Quoted 12 lines
git-gui/git-gui.sh +1
-0@@ -3867,6 +3867,7 @@ bind . <$M1B-Key-equal> {show_more_context;break} bind . <$M1B-Key-plus> {show_more_context;break} bind . <$M1B-Key-KP_Add> {show_more_context;break} bind . <$M1B-Key-Return> do_commit +bind . <$M1B-Key-KP_Enter> do_commit foreach i [list $ui_index $ui_workdir] { bind $i <Button-1> { toggle_or_diff click %W %x %y; break } bind $i <$M1B-Button-1> { add_one_to_selection %W %x %y; break }
PATCH v2 1/1 git-gui: bind CTRL/CMD+numpad ENTER to do_commit
CTRL/CMD+ENTER is bound to do_commit, but this did not apply for the (numpad ENTER) key. To enable CTRL/CMD+ENTER and CTRL/CMD+(numpad ENTER) to yield the same behaviour, CTRL/CMD+(numpad enter) has also been bound to do_commit.
--- git-gui/git-gui.sh | 1 + 1 file changed, 1 insertion(+)
git-gui/git-gui.sh +1 -0
@@ -3867,6 +3867,7 @@ bind . <$M1B-Key-equal> {show_more_context;break} bind . <$M1B-Key-plus> {show_more_context;break} bind . <$M1B-Key-KP_Add> {show_more_context;break} bind . <$M1B-Key-Return> do_commit +bind . <$M1B-Key-KP_Enter> do_commit foreach i [list $ui_index $ui_workdir] { bind $i <Button-1> { toggle_or_diff click %W %x %y; break } bind $i <$M1B-Button-1> { add_one_to_selection %W %x %y; break }
Signature · 1 line
2.16.2.270.gdc6133cf5