mm: add the preempt check into alloc_vmap_area()
Subsystems (2)
Uladzislau Rezki (Sony)
maintainerRFC 1/1 mm: add the preempt check into alloc_vmap_area()
During finding a suitable hole in the vmap_area_list there is an explicit rescheduling check for latency reduction. We do it, since there are workloads which are sensitive for long (more than 1 millisecond) preemption off scenario.
--- mm/vmalloc.c | 57 +++++++++++++++++++++++++++++++++++++++++++++------------ 1 file changed, 45 insertions(+), 12 deletions(-)
mm/vmalloc.c +45 -12
@@ -325,6 +325,7 @@ EXPORT_SYMBOL(vmalloc_to_pfn);#define VM_LAZY_FREE 0x02#define VM_VM_AREA 0x04 +#define VM_LAZY_FREE_DEFER 0x08static DEFINE_SPINLOCK (vmap_area_lock);/* Export for kexec only */
@@ -491,6 +492,20 @@ static struct vmap_area *alloc_vmap_area(unsigned long size,if (addr + size < addr) goto overflow; +/* +* Put on hold this VA preventing it from being +* removed from the list because of dropping the +* vmap_area_lock. It means we are save to proceed +* the search after the lock is taken again if we +* were scheduled out or the spin needed a break. +*/ +if (gfpflags_allow_blocking (gfp_mask) && + !(first->flags &VM_LAZY_FREE_DEFER )) { + first->flags |=VM_LAZY_FREE_DEFER ; +cond_resched_lock (&vmap_area_lock); + first->flags &= ~VM_LAZY_FREE_DEFER ; + } +if (list_is_last (&first->list, &vmap_area_list)) goto found;
@@ -586,16 +601,6 @@ static void __free_vmap_area(struct vmap_area *va) }/* -* Free a region of KVA allocated by alloc_vmap_area -*/ -static void free_vmap_area (struct vmap_area *va) -{ -spin_lock (&vmap_area_lock); -__free_vmap_area (va); -spin_unlock (&vmap_area_lock); -} - -/* * Clear the pagetable entries of a given vmap_area */ static void unmap_vmap_area (struct vmap_area *va)
@@ -678,6 +683,7 @@ static bool __purge_vmap_area_lazy(unsigned long start, unsigned long end)struct vmap_area *va;struct vmap_area *n_va;bool do_free = false; +int va_nr_pages;lockdep_assert_held (&vmap_purge_lock);
@@ -697,10 +703,19 @@ static bool __purge_vmap_area_lazy(unsigned long start, unsigned long end)spin_lock (&vmap_area_lock);llist_for_each_entry_safe (va, n_va, valist, purge_list) { -int nr = (va->va_end - va->va_start) >>PAGE_SHIFT ; +if (unlikely (va->flags &VM_LAZY_FREE_DEFER )) { +/* +* Put deferred VA back to the vmap_purge_list. +* We do not need to modify vmap_lazy_nr since +* the va will not be removed now. +*/ +llist_add (&va->purge_list, &vmap_purge_list); +continue ; + } + va_nr_pages = (va->va_end - va->va_start) >>PAGE_SHIFT ;__free_vmap_area (va); -atomic_sub (nr, &vmap_lazy_nr); +atomic_sub (va_nr_pages, &vmap_lazy_nr);cond_resched_lock (&vmap_area_lock); }spin_unlock (&vmap_area_lock);
@@ -750,6 +765,24 @@ static void free_vmap_area_noflush(struct vmap_area *va) }/* +* Free a region of KVA allocated by alloc_vmap_area +*/ +static void free_vmap_area (struct vmap_area *va) +{ +bool do_lazy_free = false; + +spin_lock (&vmap_area_lock); +if (unlikely (va->flags &VM_LAZY_FREE_DEFER )) + do_lazy_free = true; +else +__free_vmap_area (va); +spin_unlock (&vmap_area_lock); + +if (unlikely (do_lazy_free)) +free_vmap_area_noflush (va); +} + +/* * Free and unmap a vmap area */ static void free_unmap_vmap_area (struct vmap_area *va)
Signature · 7 lines
2.11.0 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 4 lines · Uladzislau Rezki (Sony)
During finding a suitable hole in the
vmap_area_listthere is an explicit rescheduling check for latency reduction. We do it, since there are workloads which are sensitive for long (more than 1 millisecond) preemption off scenario.
I understand your problem, but this is a horrid solution. If it takes us a millisecond to find a suitable chunk of free address space, something is terribly wrong. On a 3GHz CPU, that's 3 million clock ticks!
I think our real problem is that we have no data structure that stores free VA space. We have the vmap_area which stores allocated space, but no data structure to store free space.
My initial proposal would be to reuse the vmap_area structure and store the freed ones in a second rb_tree sorted by the size (ie va_end - va_start). When freeing, we might need to merge forwards and backwards. Allocating would be a matter of finding an area preferably of the exact right size; otherwise split a larger free area into a free area and an allocated area (there's a lot of literature on how exactly to choose which larger area to split; memory allocators are pretty well-studied).
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Uladzislau Rezki
maintainerQuoted 10 lines · Matthew Wilcox
Quoted 4 lines · Uladzislau Rezki (Sony)
During finding a suitable hole in the
vmap_area_listthere is an explicit rescheduling check for latency reduction. We do it, since there are workloads which are sensitive for long (more than 1 millisecond) preemption off scenario.I understand your problem, but this is a horrid solution. If it takes us a millisecond to find a suitable chunk of free address space, something is terribly wrong. On a 3GHz CPU, that's 3 million clock ticks!
Some background. I spent some time analyzing an issue regarding audio drops/glitches during playing hires audio on our mobile device. It is ARM A53 with 4 CPUs on one socket. When it comes to frequency and test case, the system is most likely idle and operation is done on ~576 MHz.
I found out that the reason was in vmalloc due to it can take time to find a suitable chunk of memory and it is done in non-preemptible context. As a result the other audio thread is not run on CPU in time despite need_resched is set.
Quoted 5 lines
I think our real problem is that we have no data structure that stores free VA space. We have the
vmap_areawhich stores allocated space, but no data structure to store free space.
Quoted 8 lines
My initial proposal would be to reuse the
vmap_areastructure and store the freed ones in a secondrb_treesorted by the size (ieva_end-va_start). When freeing, we might need to merge forwards and backwards. Allocating would be a matter of finding an area preferably of the exact right size; otherwise split a larger free area into a free area and an allocated area (there's a lot of literature on how exactly to choose which larger area to split; memory allocators are pretty well-studied).
Thank you for your comments and proposal.
--
Vlad Rezki
Andrew Morton
maintainerQuoted 9 lines · On Tue, 27 Feb 2018 05:06:43 -0800 Matthew Wilcox <[email protected]> wrote:
Quoted 4 lines · Uladzislau Rezki (Sony)
During finding a suitable hole in the
vmap_area_listthere is an explicit rescheduling check for latency reduction. We do it, since there are workloads which are sensitive for long (more than 1 millisecond) preemption off scenario.I understand your problem, but this is a horrid solution. If it takes us a millisecond to find a suitable chunk of free address space, something is terribly wrong. On a 3GHz CPU, that's 3 million clock ticks!
Yup.
Quoted 3 lines
I think our real problem is that we have no data structure that stores free VA space. We have the
vmap_areawhich stores allocated space, but no data structure to store free space.
I wonder if we can reuse free_vmap_cache as a quick fix: if need_resched(), point free_vmap_cache at the current rb_node, drop the lock, cond_resched, goto retry?
Uladzislau Rezki
maintainerQuoted 14 lines · Andrew Morton
Quoted 9 lines · On Tue, 27 Feb 2018 05:06:43 -0800 Matthew Wilcox <[email protected]> wrote:
Quoted 4 lines · Uladzislau Rezki (Sony)
During finding a suitable hole in the
vmap_area_listthere is an explicit rescheduling check for latency reduction. We do it, since there are workloads which are sensitive for long (more than 1 millisecond) preemption off scenario.I understand your problem, but this is a horrid solution. If it takes us a millisecond to find a suitable chunk of free address space, something is terribly wrong. On a 3GHz CPU, that's 3 million clock ticks!
Yup.
Quoted 8 lines
Quoted 3 lines
I think our real problem is that we have no data structure that stores free VA space. We have the
vmap_areawhich stores allocated space, but no data structure to store free space.I wonder if we can reuse
free_vmap_cacheas a quick fix: ifneed_resched(), pointfree_vmap_cacheat the currentrb_node, drop the lock,cond_resched, goto retry?
It sounds like we can. But there is a concern if that potentially can introduce a degrade of search time due to changing a starting point for our search.
--
Vlad Rezki
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>