sunxi: video: mark framebuffer as EFI reserved memory
Subsystems (2)
PATCH 1/1 sunxi: video: mark framebuffer as EFI reserved memory
Inform the EFI subsystem that the framebuffer memory is reserved.
Without the patch the AllocatePool boot service allocates memory from the framebuffer which will will be overwritten by screen output.
--- drivers/video/sunxi/sunxi_display.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/video/sunxi/sunxi_display.c +8 -0
@@ -8,6 +8,7 @@*/ #include <common.h> +#include <efi_loader.h> #include <asm/arch/clock.h> #include <asm/arch/display.h>
@@ -1207,6 +1208,13 @@ void *video_hw_init(void) gd->bd->bi_dram[0 ].size - sunxi_display.fb_size;sunxi_engines_init (); +#ifdef CONFIG_EFI_LOADER +efi_add_memory_map (gd->fb_base, +ALIGN (sunxi_display.fb_size,EFI_PAGE_SIZE ) >> +EFI_PAGE_SHIFT , +EFI_RESERVED_MEMORY_TYPE , false); +#endif + fb_dma_addr = gd->fb_base -CONFIG_SYS_SDRAM_BASE ; sunxi_display.fb_addr = gd->fb_base;if (overscan_offset) {
Signature · 1 line
2.16.1
PATCH 1/1 sunxi: video: mark framebuffer as EFI reserved memory
Hi Heinrich,
Quoted 6 lines · On Sat, 3 Mar 2018 10:30:17 +0100 Heinrich Schuchardt xypron.glpk at gmx.de…
Inform the EFI subsystem that the framebuffer memory is reserved.
Without the patch the AllocatePool boot service allocates memory from the framebuffer which will will be overwritten by screen output.
Signed-off-by Heinrich Schuchardt <[email protected]>
Should this patch be merged into v2018.03 release or can it wait?
Thanks,
Anatolij
PATCH 1/1 sunxi: video: mark framebuffer as EFI reserved memory
Quoted 5 lines · Anatolij Gustschin
Hi Heinrich,
On Sat, 3 Mar 2018 10:30:17 +0100
Heinrich Schuchardt xypron.glpk at gmx.de wrote:
Quoted 8 lines
Quoted 6 lines
Inform the EFI subsystem that the framebuffer memory is reserved.
Without the patch the AllocatePool boot service allocates memory from the framebuffer which will will be overwritten by screen output.
Signed-off-by Heinrich Schuchardt <[email protected]>Should this patch be merged into v2018.03 release or can it wait?
Hello Anatolij,
v2018.05 is fine. The problem will become visible in more cases with
[PATCH 1/1] efi_loader: efi_allocate_pages is too restrictive
https://patchwork.ozlabs.org/patch/881055/
https://lists.denx.de/pipermail/u-boot/2018-March/321840.html
which is also pending.
Regards
Heinrich
PATCH 1/1 sunxi: video: mark framebuffer as EFI reserved memory
Hello Heinrich,
On Mon, 5 Mar 2018 17:55:52 +0100
Heinrich Schuchardt xypron.glpk at gmx.de wrote:
...
Quoted 7 lines
v2018.05 is fine. The problem will become visible in more cases with
[PATCH 1/1]
efi_loader:efi_allocate_pagesis too restrictive
https://patchwork.ozlabs.org/patch/881055/
https://lists.denx.de/pipermail/u-boot/2018-March/321840.htmlwhich is also pending.
Okay, I'll apply your patch when efi_loader patch is merged.
Thanks,
Anatolij
PATCH 1/1 sunxi: video: mark framebuffer as EFI reserved memory
Quoted 7 lines · Anatolij Gustschin
Hello Heinrich,
On Mon, 5 Mar 2018 17:55:52 +0100
Heinrich Schuchardt xypron.glpk at gmx.de wrote:
...Quoted 2 lines
v2018.05 is fine. The problem will become visible in more cases with
Quoted 7 lines
Quoted 5 lines
[PATCH 1/1]
efi_loader:efi_allocate_pagesis too restrictive
https://patchwork.ozlabs.org/patch/881055/
https://lists.denx.de/pipermail/u-boot/2018-March/321840.htmlwhich is also pending.
Okay, I'll apply your patch when
efi_loaderpatch is merged.
If efi_allocate_memory is called with type = EFI_ALLOCATE_MAX_ADDRESS we can already have an error. So, please, put the patch into your v2018.05 queue. There is no need to wait for Alex.
Regards
Heinrich
PATCH 1/1 sunxi: video: mark framebuffer as EFI reserved memory
On Fri, 9 Mar 2018 16:49:49 +0100
Heinrich Schuchardt xypron.glpk at gmx.de wrote:
...
Quoted 3 lines
If
efi_allocate_memoryis called with type =EFI_ALLOCATE_MAX_ADDRESSwe can already have an error. So, please, put the patch into your v2018.05 queue. There is no need to wait for Alex.
okay, done.
--
Anatolij
PATCH 1/1 sunxi: video: mark framebuffer as EFI reserved memory
In reply to Heinrich SchuchardtQuoted 9 lines · On Sat, 3 Mar 2018 10:30:17 +0100 Heinrich Schuchardt xypron.glpk at gmx.de…
Inform the EFI subsystem that the framebuffer memory is reserved.
Without the patch the AllocatePool boot service allocates memory from the framebuffer which will will be overwritten by screen output.
Signed-off-by Heinrich Schuchardt <[email protected]>--- drivers/video/sunxi/sunxi_display.c | 8 ++++++++ 1 file changed, 8 insertions(+)
Applied to u-boot-video/next, thanks!
--
Anatolij