Skip to contentSkip to conversation

dm: mmc: socfpga: call dwmci_probe()

PATCH In review linux-kernel-dev at beckhoff.com 4 participants 15 messages Mar 6, 2018 – Apr 30, 2018 MMC, SD and SDIO

lore
Share & tools
lore

linux-kernel-dev at beckhoff.com

author
#0 lore raw

PATCH 1/1 dm: mmc: socfpga: call dwmci_probe()

From: Patrick Bruenn <[email protected]>

On a socfpga_cyclone5 based board the SD card, was never powered up. For other dw_mmc based SoCs dwmci_probe() is called in the platform specific probe(). It seems this call is missing for socfpga_dw_mmc.

With this change DWMCI_PWREN is set by dmwci_init().

Signed-off-by Patrick Bruenn <[email protected]>

---

 drivers/mmc/socfpga_dw_mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/socfpga_dw_mmc.c +1 -1
index 759686ccd6..c5fce8f09d 100644
@@ -124,7 +124,7 @@ static int socfpga_dwmmc_probe(struct udevice *dev)
 	upriv->mmc = host->mmc;
 	host->mmc->dev = dev;
 
-	return 0;
+	return dwmci_probe(dev);
 }
 
 static int socfpga_dwmmc_bind(struct udevice *dev)
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 dm: mmc: socfpga: call dwmci_probe()

Quoted 9 lines · linux-kernel-dev at beckhoff.com

From: Patrick Bruenn <[email protected]>

On a socfpga_cyclone5 based board the SD card, was never powered up. For other dw_mmc based SoCs dwmci_probe() is called in the platform specific probe(). It seems this call is missing for socfpga_dw_mmc.

With this change DWMCI_PWREN is set by dmwci_init().

Signed-off-by Patrick Bruenn <[email protected]>
Reviewed-by Jaehoon Chung <[email protected]>

Will apply this patch before releasing v2018.03.
(I have a problem about accessing git.denx.de. After fixing my problem, will resend email about applying.)

Thanks.

Best Regards,
Jaehoon Chung

Quoted 19 lines

---

 drivers/mmc/socfpga_dw_mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/socfpga_dw_mmc.c +1 -1
index 759686ccd6..c5fce8f09d 100644
@@ -124,7 +124,7 @@ static int socfpga_dwmmc_probe(struct udevice *dev)
 	upriv->mmc = host->mmc;
 	host->mmc->dev = dev;
 
-	return 0;
+	return dwmci_probe(dev);
 }
 
 static int socfpga_dwmmc_bind(struct udevice *dev)
#2 lore raw

PATCH 1/1 dm: mmc: socfpga: call dwmci_probe()

Quoted 7 lines · Jaehoon Chung
Quoted 6 lines · linux-kernel-dev at beckhoff.com

From: Patrick Bruenn <[email protected]>

On a socfpga_cyclone5 based board the SD card, was never powered up. For other dw_mmc based SoCs dwmci_probe() is called in the platform specific probe(). It seems this call is missing for socfpga_dw_mmc.

Quoted 8 lines
Quoted 3 lines

With this change DWMCI_PWREN is set by dmwci_init().

Signed-off-by Patrick Bruenn <[email protected]>
Reviewed-by Jaehoon Chung <[email protected]>

Will apply this patch before releasing v2018.03.
(I have a problem about accessing git.denx.de. After fixing my problem, will resend email about applying.)

DWMMC works on SoCFPGA for me (tested on rc4), so I don't understand what this patch is trying to fix. I'd prefer if you did not hastily apply this.

#3 lore raw

PATCH 1/1 dm: mmc: socfpga: call dwmci_probe()

Quoted 10 lines · Marek Vasut
Quoted 9 lines · Jaehoon Chung
Quoted 8 lines · linux-kernel-dev at beckhoff.com

From: Patrick Bruenn <[email protected]>

On a socfpga_cyclone5 based board the SD card, was never powered up. For other dw_mmc based SoCs dwmci_probe() is called in the platform specific probe(). It seems this call is missing for socfpga_dw_mmc.

With this change DWMCI_PWREN is set by dmwci_init().

Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Signed-off-by Patrick Bruenn <[email protected]>
Reviewed-by Jaehoon Chung <[email protected]>

Will apply this patch before releasing v2018.03.
(I have a problem about accessing git.denx.de. After fixing my problem, will resend email about applying.)

DWMMC works on SoCFPGA for me (tested on rc4), so I don't understand what this patch is trying to fix. I'd prefer if you did not hastily apply this.

It's my misunderstanding. When i checked more. I think that Marek is right. Thanks Marek for pointing out.

Best Regards,
Jaehoon Chung

Quoted 3 lines
#4 lore raw

PATCH 1/1 dm: mmc: socfpga: call dwmci_probe()

Quoted 21 lines

From: Jaehoon Chung [mailto:jh80.chung at samsung.com]
Sent: Donnerstag, 8. März 2018 04:57

Quoted 5 lines · Marek Vasut
Quoted 4 lines · Jaehoon Chung
Quoted 3 lines · linux-kernel-dev at beckhoff.com

From: Patrick Bruenn <[email protected]>

On a socfpga_cyclone5 based board the SD card, was never powered up.

For

Quoted 1 line
Quoted 1 line
Quoted 1 line

other dw_mmc based SoCs dwmci_probe() is called in the platform

specific

Quoted 10 lines
Quoted 10 lines
Quoted 5 lines

probe(). It seems this call is missing for socfpga_dw_mmc.

With this change DWMCI_PWREN is set by dmwci_init().

Signed-off-by Patrick Bruenn <[email protected]>
Reviewed-by Jaehoon Chung <[email protected]>

Will apply this patch before releasing v2018.03.
(I have a problem about accessing git.denx.de. After fixing my problem,

Quoted 8 lines

will resend email about applying.)

Quoted 2 lines

DWMMC works on SoCFPGA for me (tested on rc4), so I don't understand

what this patch is trying to fix. I'd prefer if you did not hastily apply this.

It's my misunderstanding. When i checked more. I think that Marek is right. Thanks Marek for pointing out.

Okay, but do you have any hint what I am doing wrong? My board (cx8100 not mainline, yet) is based on socfpga_cyclone5. And on my board " dwmci_writel(host, DWMCI_PWREN, 1);" is never called, because dwmci_init() is never called. As far as I can see with CONFIG_DM_MMC enabled dwmci_init() should be called by dwmci_probe().

exynos and rockchip do call dwmci_probe() within exynos/rockchip_dwmmc_probe().
but socfpga_dwmmc_probe() is missing this call. So I looked deeper but found no place for socfpga platform to call dwmci_probe() or dwmci_init(). What am I missing?

Maybe this diff helps:
u-boot$ diff configs/socfpga_cx8100_defconfig configs/socfpga_cyclone5_defconfig 2d1
< CONFIG_API=y
6c5
< CONFIG_TARGET_SOCFPGA_CX8100=y
---

Quoted 1 line

CONFIG_TARGET_SOCFPGA_CYCLONE5_SOCDK=y

8c7,8
< CONFIG_DEFAULT_DEVICE_TREE="socfpga_cyclone5_cx8100"
---

Quoted 2 lines

CONFIG_DEFAULT_DEVICE_TREE="socfpga_cyclone5_socdk" CONFIG_DISTRO_DEFAULTS=y

9a10

Quoted 1 line

# CONFIG_USE_BOOTCOMMAND is not set

13c14
< CONFIG_DEFAULT_FDT_FILE="socfpga_cyclone5_cx8100.dtb"
---

Quoted 1 line

CONFIG_DEFAULT_FDT_FILE="socfpga_cyclone5_socdk.dtb"

16d16
< CONFIG_BOARD_EARLY_INIT_F=y
20,21d19
< CONFIG_HUSH_PARSER=y
< CONFIG_CMD_BOOTZ=y
29d26
< CONFIG_CMD_PART=y
34,37d30
< CONFIG_CMD_DHCP=y
< CONFIG_CMD_PXE=y
< CONFIG_CMD_MII=y
< CONFIG_CMD_PING=y
39d31
< CONFIG_CMD_EXT4=y
41,42d32
< CONFIG_CMD_FAT=y
< CONFIG_CMD_FS_GENERIC=y
54,56d43
< CONFIG_CMD_LED=y
< CONFIG_LED=y
< CONFIG_LED_GPIO=y
60a48

Quoted 1 line

CONFIG_SPI_FLASH_MACRONIX=y

Thanks for your time and patience,
Patrick

Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff Registered office: Verl, Germany | Register court: Guetersloh HRA 7075

#5 lore raw

PATCH 1/1 dm: mmc: socfpga: call dwmci_probe()

In reply to Jaehoon Chung
Quoted 39 lines

From: Patrick Brünn
Sent: Donnerstag, 8. März 2018 06:39

Quoted 8 lines

From: Jaehoon Chung [mailto:jh80.chung at samsung.com]
Sent: Donnerstag, 8. März 2018 04:57

Quoted 5 lines · Marek Vasut
Quoted 4 lines · Jaehoon Chung
Quoted 3 lines · linux-kernel-dev at beckhoff.com

From: Patrick Bruenn <[email protected]>

On a socfpga_cyclone5 based board the SD card, was never powered

up.

Quoted 13 lines

For

Quoted 1 line
Quoted 1 line
Quoted 1 line

other dw_mmc based SoCs dwmci_probe() is called in the platform

specific

Quoted 10 lines
Quoted 10 lines
Quoted 5 lines

probe(). It seems this call is missing for socfpga_dw_mmc.

With this change DWMCI_PWREN is set by dmwci_init().

Signed-off-by Patrick Bruenn <[email protected]>
Reviewed-by Jaehoon Chung <[email protected]>

Will apply this patch before releasing v2018.03.
(I have a problem about accessing git.denx.de. After fixing my problem,

Quoted 8 lines

will resend email about applying.)

Quoted 2 lines

DWMMC works on SoCFPGA for me (tested on rc4), so I don't understand

what this patch is trying to fix. I'd prefer if you did not hastily apply this.

It's my misunderstanding. When i checked more. I think that Marek is right. Thanks Marek for pointing out.

Okay, but do you have any hint what I am doing wrong? My board (cx8100 not mainline, yet) is based on socfpga_cyclone5. And on my board " dwmci_writel(host, DWMCI_PWREN, 1);" is never called, because dwmci_init() is never called.
As far as I can see with CONFIG_DM_MMC enabled dwmci_init() should be called by dwmci_probe().

Quoted 6 lines

exynos and rockchip do call dwmci_probe() within exynos/rockchip_dwmmc_probe().
but socfpga_dwmmc_probe() is missing this call. So I looked deeper but found no place for socfpga platform to call dwmci_probe() or dwmci_init(). What am I missing?

I got an idea, what might be the difference between my board and your boards. I suspect you use U-BOOT SPL without CONFIG_DM_MMC set, so dwmci_init() is called indirectly by mmc_start_init().
Now, when your main U-Boot (with CONFIG_DM_MMC) is launched, everything is already configured and it isn't necessary to call dwmci_init() again. On my board the Altera MPL is used (and I can't replace it). Which seems to disable DWMCI_PWREN before launching U-Boot.
If my assumption is correct, I still think it is a U-Boot bug to assume code like in dwmci_init() was already run before U-Boot gets in control.
Besides exynos/rockchip_dw_mmc don't have this precondition requirement.

Please take your time to look deeper into this issue, before deciding anything. I don't think we need to rush this into the next release, as normal mainline boards are "accidently" not affected.

Thanks and regards,
Patrick

Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff Registered office: Verl, Germany | Register court: Guetersloh HRA 7075

#6 lore raw

PATCH 1/1 dm: mmc: socfpga: call dwmci_probe()

Dear Patrick,

Quoted 45 lines · Patrick Br체nn
Quoted 39 lines

From: Patrick Br체nn
Sent: Donnerstag, 8. M채rz 2018 06:39

Quoted 8 lines

From: Jaehoon Chung [mailto:jh80.chung at samsung.com]
Sent: Donnerstag, 8. M채rz 2018 04:57

Quoted 5 lines · Marek Vasut
Quoted 4 lines · Jaehoon Chung
Quoted 3 lines · linux-kernel-dev at beckhoff.com

From: Patrick Bruenn <[email protected]>

On a socfpga_cyclone5 based board the SD card, was never powered

up.

Quoted 13 lines

For

Quoted 1 line
Quoted 1 line
Quoted 1 line

other dw_mmc based SoCs dwmci_probe() is called in the platform

specific

Quoted 10 lines
Quoted 10 lines
Quoted 5 lines

probe(). It seems this call is missing for socfpga_dw_mmc.

With this change DWMCI_PWREN is set by dmwci_init().

Signed-off-by Patrick Bruenn <[email protected]>
Reviewed-by Jaehoon Chung <[email protected]>

Will apply this patch before releasing v2018.03.
(I have a problem about accessing git.denx.de. After fixing my problem,

Quoted 8 lines

will resend email about applying.)

Quoted 2 lines

DWMMC works on SoCFPGA for me (tested on rc4), so I don't understand

what this patch is trying to fix. I'd prefer if you did not hastily apply this.

It's my misunderstanding. When i checked more. I think that Marek is right. Thanks Marek for pointing out.

Okay, but do you have any hint what I am doing wrong? My board (cx8100 not mainline, yet) is based on socfpga_cyclone5. And on my board " dwmci_writel(host, DWMCI_PWREN, 1);" is never called, because dwmci_init() is never called.
As far as I can see with CONFIG_DM_MMC enabled dwmci_init() should be called by dwmci_probe().

Quoted 6 lines

exynos and rockchip do call dwmci_probe() within exynos/rockchip_dwmmc_probe().
but socfpga_dwmmc_probe() is missing this call. So I looked deeper but found no place for socfpga platform to call dwmci_probe() or dwmci_init(). What am I missing?

Quoted 3 lines

I got an idea, what might be the difference between my board and your boards. I suspect you use U-BOOT SPL without CONFIG_DM_MMC set, so dwmci_init() is called indirectly by mmc_start_init().

Right, it's difference with CONFIG_DM_MMC. I had checked this.

Quoted 11 lines

Now, when your main U-Boot (with CONFIG_DM_MMC) is launched, everything is already configured and it isn't necessary to call dwmci_init() again. On my board the Altera MPL is used (and I can't replace it). Which seems to disable DWMCI_PWREN before launching U-Boot.
If my assumption is correct, I still think it is a U-Boot bug to assume code like in dwmci_init() was already run before U-Boot gets in control.
Besides exynos/rockchip_dw_mmc don't have this precondition requirement.

Please take your time to look deeper into this issue, before deciding anything. I don't think we need to rush this into the next release, as normal mainline boards are "accidently" not affected.

Sure. I will check this patch. Before applying this, will check more carefully. I agreed about Marek's opinion "did not hastily apply this."
And i think that your approach also is right.

Best Regards,
Jaehoon Chung

Quoted 8 lines

Thanks and regards,
Patrick

Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff Registered office: Verl, Germany | Register court: Guetersloh HRA 7075

#7 lore raw

PATCH 1/1 dm: mmc: socfpga: call dwmci_probe()

Quoted 62 lines · Jaehoon Chung

Dear Patrick,

Quoted 45 lines · Patrick Br체nn
Quoted 39 lines

From: Patrick Br체nn
Sent: Donnerstag, 8. M채rz 2018 06:39

Quoted 8 lines

From: Jaehoon Chung [mailto:jh80.chung at samsung.com]
Sent: Donnerstag, 8. M채rz 2018 04:57

Quoted 5 lines · Marek Vasut
Quoted 4 lines · Jaehoon Chung
Quoted 3 lines · linux-kernel-dev at beckhoff.com

From: Patrick Bruenn <[email protected]>

On a socfpga_cyclone5 based board the SD card, was never powered

up.

Quoted 13 lines

For

Quoted 1 line
Quoted 1 line
Quoted 1 line

other dw_mmc based SoCs dwmci_probe() is called in the platform

specific

Quoted 10 lines
Quoted 10 lines
Quoted 5 lines

probe(). It seems this call is missing for socfpga_dw_mmc.

With this change DWMCI_PWREN is set by dmwci_init().

Signed-off-by Patrick Bruenn <[email protected]>
Reviewed-by Jaehoon Chung <[email protected]>

Will apply this patch before releasing v2018.03.
(I have a problem about accessing git.denx.de. After fixing my problem,

Quoted 8 lines

will resend email about applying.)

Quoted 2 lines

DWMMC works on SoCFPGA for me (tested on rc4), so I don't understand

what this patch is trying to fix. I'd prefer if you did not hastily apply this.

It's my misunderstanding. When i checked more. I think that Marek is right. Thanks Marek for pointing out.

Okay, but do you have any hint what I am doing wrong? My board (cx8100 not mainline, yet) is based on socfpga_cyclone5. And on my board " dwmci_writel(host, DWMCI_PWREN, 1);" is never called, because dwmci_init() is never called.
As far as I can see with CONFIG_DM_MMC enabled dwmci_init() should be called by dwmci_probe().

Quoted 6 lines

exynos and rockchip do call dwmci_probe() within exynos/rockchip_dwmmc_probe().
but socfpga_dwmmc_probe() is missing this call. So I looked deeper but found no place for socfpga platform to call dwmci_probe() or dwmci_init(). What am I missing?

Quoted 3 lines

I got an idea, what might be the difference between my board and your boards. I suspect you use U-BOOT SPL without CONFIG_DM_MMC set, so dwmci_init() is called indirectly by mmc_start_init().

Right, it's difference with CONFIG_DM_MMC. I had checked this.

Quoted 8 lines

Now, when your main U-Boot (with CONFIG_DM_MMC) is launched, everything is already configured and it isn't necessary to call dwmci_init() again. On my board the Altera MPL is used (and I can't replace it). Which seems to disable DWMCI_PWREN before launching U-Boot.
If my assumption is correct, I still think it is a U-Boot bug to assume code like in dwmci_init() was already run before U-Boot gets in control.
Besides exynos/rockchip_dw_mmc don't have this precondition requirement.

Quoted 7 lines
Quoted 3 lines

Please take your time to look deeper into this issue, before deciding anything. I don't think we need to rush this into the next release, as normal mainline boards are "accidently" not affected.

Sure. I will check this patch. Before applying this, will check more carefully. I agreed about Marek's opinion "did not hastily apply this."
And i think that your approach also is right.

Please queue for -next , NOT this release.

#8 lore raw

PATCH 1/1 dm: mmc: socfpga: call dwmci_probe()

Quoted 67 lines · Marek Vasut
Quoted 66 lines · Jaehoon Chung

Dear Patrick,

Quoted 45 lines · Patrick Brünn
Quoted 39 lines

From: Patrick Brünn
Sent: Donnerstag, 8. März 2018 06:39

Quoted 8 lines

From: Jaehoon Chung [mailto:jh80.chung at samsung.com]
Sent: Donnerstag, 8. März 2018 04:57

Quoted 5 lines · Marek Vasut
Quoted 4 lines · Jaehoon Chung
Quoted 3 lines · linux-kernel-dev at beckhoff.com

From: Patrick Bruenn <[email protected]>

On a socfpga_cyclone5 based board the SD card, was never powered

up.

Quoted 13 lines

For

Quoted 1 line
Quoted 1 line
Quoted 1 line

other dw_mmc based SoCs dwmci_probe() is called in the platform

specific

Quoted 10 lines
Quoted 10 lines
Quoted 5 lines

probe(). It seems this call is missing for socfpga_dw_mmc.

With this change DWMCI_PWREN is set by dmwci_init().

Signed-off-by Patrick Bruenn <[email protected]>
Reviewed-by Jaehoon Chung <[email protected]>

Will apply this patch before releasing v2018.03.
(I have a problem about accessing git.denx.de. After fixing my problem,

Quoted 8 lines

will resend email about applying.)

Quoted 2 lines

DWMMC works on SoCFPGA for me (tested on rc4), so I don't understand

what this patch is trying to fix. I'd prefer if you did not hastily apply this.

It's my misunderstanding. When i checked more. I think that Marek is right. Thanks Marek for pointing out.

Okay, but do you have any hint what I am doing wrong? My board (cx8100 not mainline, yet) is based on socfpga_cyclone5. And on my board " dwmci_writel(host, DWMCI_PWREN, 1);" is never called, because dwmci_init() is never called.
As far as I can see with CONFIG_DM_MMC enabled dwmci_init() should be called by dwmci_probe().

Quoted 6 lines

exynos  and rockchip do call dwmci_probe() within exynos/rockchip_dwmmc_probe().
but socfpga_dwmmc_probe() is missing this call. So I looked deeper but found no place for socfpga platform to call dwmci_probe() or dwmci_init(). What am I missing?

Quoted 3 lines

I got an idea, what might be the difference between my board and your boards. I suspect you use U-BOOT SPL without CONFIG_DM_MMC set, so dwmci_init() is called indirectly by mmc_start_init().

Right, it's difference with CONFIG_DM_MMC. I had checked this.

Quoted 11 lines

Now, when your main U-Boot (with CONFIG_DM_MMC) is launched, everything is already configured and it isn't necessary to call dwmci_init() again. On my board the Altera MPL is used (and I can't replace it).  Which seems to disable DWMCI_PWREN before launching U-Boot.
If my assumption is correct, I still think it is a U-Boot bug to assume code like in dwmci_init() was already run before U-Boot gets in control.
Besides exynos/rockchip_dw_mmc don't have this precondition requirement.

Please take your time to look deeper into this issue, before deciding anything. I don't think we need to rush this into the next release, as normal mainline boards are "accidently" not affected.

Quoted 5 lines
Quoted 3 lines

Sure. I will check this patch. Before applying this, will check more carefully. I agreed about Marek's opinion "did not hastily apply this."
And i think that your approach also is right.

Please queue for -next , NOT this release.

Yes. I understood what you want. Thanks!

Quoted 3 lines
#9 lore raw

PATCH 1/1 dm: mmc: socfpga: call dwmci_probe()

In reply to Patrick Brünn
Quoted 45 lines · Patrick Br체nn
Quoted 39 lines

From: Patrick Br체nn
Sent: Donnerstag, 8. M채rz 2018 06:39

Quoted 8 lines

From: Jaehoon Chung [mailto:jh80.chung at samsung.com]
Sent: Donnerstag, 8. M채rz 2018 04:57

Quoted 5 lines · Marek Vasut
Quoted 4 lines · Jaehoon Chung
Quoted 3 lines · linux-kernel-dev at beckhoff.com

From: Patrick Bruenn <[email protected]>

On a socfpga_cyclone5 based board the SD card, was never powered

up.

Quoted 13 lines

For

Quoted 1 line
Quoted 1 line
Quoted 1 line

other dw_mmc based SoCs dwmci_probe() is called in the platform

specific

Quoted 10 lines
Quoted 10 lines
Quoted 5 lines

probe(). It seems this call is missing for socfpga_dw_mmc.

With this change DWMCI_PWREN is set by dmwci_init().

Signed-off-by Patrick Bruenn <[email protected]>
Reviewed-by Jaehoon Chung <[email protected]>

Will apply this patch before releasing v2018.03.
(I have a problem about accessing git.denx.de. After fixing my problem,

Quoted 8 lines

will resend email about applying.)

Quoted 2 lines

DWMMC works on SoCFPGA for me (tested on rc4), so I don't understand

what this patch is trying to fix. I'd prefer if you did not hastily apply this.

It's my misunderstanding. When i checked more. I think that Marek is right. Thanks Marek for pointing out.

Okay, but do you have any hint what I am doing wrong? My board (cx8100 not mainline, yet) is based on socfpga_cyclone5. And on my board " dwmci_writel(host, DWMCI_PWREN, 1);" is never called, because dwmci_init() is never called.
As far as I can see with CONFIG_DM_MMC enabled dwmci_init() should be called by dwmci_probe().

Quoted 6 lines

exynos and rockchip do call dwmci_probe() within exynos/rockchip_dwmmc_probe().
but socfpga_dwmmc_probe() is missing this call. So I looked deeper but found no place for socfpga platform to call dwmci_probe() or dwmci_init(). What am I missing?

Quoted 5 lines

I got an idea, what might be the difference between my board and your boards. I suspect you use U-BOOT SPL without CONFIG_DM_MMC set, so dwmci_init() is called indirectly by mmc_start_init().
Now, when your main U-Boot (with CONFIG_DM_MMC) is launched, everything is already configured and it isn't necessary to call dwmci_init() again.

Yes, that's the only supported configuration -- U-Boot SPL and U-Boot. Any such mix-and-match setups are NOT supported.

Quoted 5 lines

On my board the Altera MPL is used (and I can't replace it). Which seems to disable DWMCI_PWREN before launching U-Boot.
If my assumption is correct, I still think it is a U-Boot bug to assume code like in dwmci_init() was already run before U-Boot gets in control.
Besides exynos/rockchip_dw_mmc don't have this precondition requirement.

We're too close to the release and it's not broken in mainline, it's only broken if you use this horrible shitty MPL configuration, which is not supported.

So we should revisit this patch after release, after it can be tested properly and checked if it doesn't break standard setups.

Quoted 3 lines

Please take your time to look deeper into this issue, before deciding anything. I don't think we need to rush this into the next release, as normal mainline boards are "accidently" not affected.

Sounds good

#10 lore raw
In reply to linux-kernel-dev at beckhoff.com

Hi,

Quoted 7 lines · linux-kernel-dev at beckhoff.com

From: Patrick Bruenn <[email protected]>

On a socfpga_cyclone5 based board the SD card, was never powered up. For other dw_mmc based SoCs dwmci_probe() is called in the platform specific probe(). It seems this call is missing for socfpga_dw_mmc.

With this change DWMCI_PWREN is set by dmwci_init().

Sorry for late. Applied to u-boot-mmc. Thanks!

Best Regards,
Jaehoon Chung

Quoted 22 lines
Signed-off-by Patrick Bruenn <[email protected]>
Reviewed-by Jaehoon Chung <[email protected]>

---

 drivers/mmc/socfpga_dw_mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/socfpga_dw_mmc.c +1 -1
index 759686ccd6..c5fce8f09d 100644
@@ -124,7 +124,7 @@ static int socfpga_dwmmc_probe(struct udevice *dev)
 	upriv->mmc = host->mmc;
 	host->mmc->dev = dev;
 
-	return 0;
+	return dwmci_probe(dev);
 }
 
 static int socfpga_dwmmc_bind(struct udevice *dev)
#11 lore raw
Quoted 5 lines · Jaehoon Chung

Hi,

Quoted 2 lines · linux-kernel-dev at beckhoff.com

From: Patrick Bruenn <[email protected]>

Quoted 7 lines
Quoted 5 lines

On a socfpga_cyclone5 based board the SD card, was never powered up. For other dw_mmc based SoCs dwmci_probe() is called in the platform specific probe(). It seems this call is missing for socfpga_dw_mmc.

With this change DWMCI_PWREN is set by dmwci_init().

Sorry for late. Applied to u-boot-mmc. Thanks!

This is for next, right ?

Signature · 2 lines
Best regards,
Marek Vasut
#12 lore raw

Dear Marek,

Quoted 10 lines · Marek Vasut
Quoted 9 lines · Jaehoon Chung

Hi,

Quoted 6 lines · linux-kernel-dev at beckhoff.com

From: Patrick Bruenn <[email protected]>

On a socfpga_cyclone5 based board the SD card, was never powered up. For other dw_mmc based SoCs dwmci_probe() is called in the platform specific probe(). It seems this call is missing for socfpga_dw_mmc.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

With this change DWMCI_PWREN is set by dmwci_init().

Sorry for late. Applied to u-boot-mmc. Thanks!

This is for next, right ?

If possible, i want to apply this for v2018.05.
I know it's too late. It's my fault.
If not possible, i will rebase mmc repository with fixing patches. And other patches will move to next branch.

Will make a decision until today. And Will send the PR for v2081.05.

Best Regards,
Jaehoon Chung

Quoted 1 line
#13 lore raw
Quoted 13 lines · Jaehoon Chung

Dear Marek,

Quoted 10 lines · Marek Vasut
Quoted 9 lines · Jaehoon Chung

Hi,

Quoted 6 lines · linux-kernel-dev at beckhoff.com

From: Patrick Bruenn <[email protected]>

On a socfpga_cyclone5 based board the SD card, was never powered up. For other dw_mmc based SoCs dwmci_probe() is called in the platform specific probe(). It seems this call is missing for socfpga_dw_mmc.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

With this change DWMCI_PWREN is set by dmwci_init().

Sorry for late. Applied to u-boot-mmc. Thanks!

This is for next, right ?

If possible, i want to apply this for v2018.05.
I know it's too late. It's my fault.

Yes it is, and if it breaks something, there's very little time to find out or test it.

Quoted 2 lines

If not possible, i will rebase mmc repository with fixing patches. And other patches will move to next branch.

Yes

Quoted 1 line

Will make a decision until today. And Will send the PR for v2081.05.

I am happy to take this via socfpga-next if you cannot submit a PR right after the release for some reason.

Signature · 2 lines
Best regards,
Marek Vasut
#14 lore raw
Quoted 23 lines · Marek Vasut
Quoted 13 lines · Jaehoon Chung

Dear Marek,

Quoted 10 lines · Marek Vasut
Quoted 9 lines · Jaehoon Chung

Hi,

Quoted 6 lines · linux-kernel-dev at beckhoff.com

From: Patrick Bruenn <[email protected]>

On a socfpga_cyclone5 based board the SD card, was never powered up. For other dw_mmc based SoCs dwmci_probe() is called in the platform specific probe(). It seems this call is missing for socfpga_dw_mmc.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

With this change DWMCI_PWREN is set by dmwci_init().

Sorry for late. Applied to u-boot-mmc. Thanks!

This is for next, right ?

If possible, i want to apply this for v2018.05.
I know it's too late. It's my fault.

Quoted 7 lines

Yes it is, and if it breaks something, there's very little time to find out or test it.

Quoted 2 lines

If not possible, i will rebase mmc repository with fixing patches. And other patches will move to next branch.

Yes

Will do. This patch will move to next branch.

Quoted 5 lines
Quoted 2 lines

Will make a decision until today. And Will send the PR for v2081.05.

I am happy to take this via socfpga-next if you cannot submit a PR right after the release for some reason.

I will do.

Best Regards,
Jaehoon Chung

Quoted 1 line