pwm-backlight: make power-supply as option

PATCH In review Kever Yang 3 participants 3 messages Feb 9, 2018 – Mar 6, 2018 Framebuffer layer

lore

Share & tools

lore

Kever Yang

author

2018-02-09 02:45 UTC #0 lore raw

PATCH 1/1 pwm-backlight: make power-supply as option

Some pwm backlight may not need 'power-supply', let's make it as option in pwm-backlight driver.

Signed-off-by Kever Yang <[email protected]>

---

 drivers/video/pwm_backlight.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

drivers/video/pwm_backlight.c +12 ~~-12~~

index fbd7bf7..f40e57b 100644
@@ -32,16 +32,18 @@ static int pwm_backlight_enable(struct udevice *dev)
 	uint duty_cycle;
 	int ret;
 
-	plat = dev_get_uclass_platdata(priv->reg);
-	debug("%s: Enable '%s', regulator '%s'/'%s'\n", __func__, dev->name,
-	      priv->reg->name, plat->name);
-	ret = regulator_set_enable(priv->reg, true);
-	if (ret) {
-		debug("%s: Cannot enable regulator for PWM '%s'\n", __func__,
-		      dev->name);
-		return ret;
+	if (priv->reg) {
+		plat = dev_get_uclass_platdata(priv->reg);
+		debug("%s: Enable '%s', regulator '%s'/'%s'\n", __func__,
+		      dev->name, priv->reg->name, plat->name);
+		ret = regulator_set_enable(priv->reg, true);
+		if (ret) {
+			debug("%s: Cannot enable regulator for PWM '%s'\n",
+			      __func__, dev->name);
+			return ret;
+		}
+		mdelay(120);
 	}
-	mdelay(120);
 
 	duty_cycle = priv->period_ns * (priv->default_level - priv->min_level) /
 		(priv->max_level - priv->min_level + 1);

@@ -68,10 +70,8 @@ static int pwm_backlight_ofdata_to_platdata(struct udevice *dev)
 	debug("%s: start\n", __func__);
 	ret = uclass_get_device_by_phandle(UCLASS_REGULATOR, dev,
 					   "power-supply", &priv->reg);
-	if (ret) {
+	if (ret)
 		debug("%s: Cannot get power supply: ret=%d\n", __func__, ret);
-		return ret;
-	}
 	ret = gpio_request_by_name(dev, "enable-gpios", 0, &priv->enable,
 				   GPIOD_IS_OUT);
 	if (ret) {

Signature · 1 line

1.9.1

Philipp Tomsich

Reviewed-by on v1 1/1

2018-02-09 10:15 UTC #1 lore raw

Quoted 9 lines

Some pwm backlight may not need 'power-supply', let's make it as option in pwm-backlight driver.
Signed-off-by Kever Yang <[email protected]>
---
 drivers/video/pwm_backlight.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

Reviewed-by Philipp Tomsich <[email protected]>

Anatolij Gustschin

2018-03-06 09:21 UTC #2 lore raw

PATCH 1/1 pwm-backlight: make power-supply as option

In reply to Kever Yang

Quoted 8 lines · On Fri, 9 Feb 2018 10:45:12 +0800 Kever Yang kever.yang at rock-chips.com…

Some pwm backlight may not need 'power-supply', let's make it as option in pwm-backlight driver.
Signed-off-by Kever Yang <[email protected]>
---
 drivers/video/pwm_backlight.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

Applied to u-boot-video/next, thanks!

--
Anatolij