Skip to contentSkip to conversation

staging: iio: meter: Remove reduntant __func__ from debug print

PATCH In review [email protected] 2 participants 2 messages Mar 7, 2018

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: iio: meter: Remove reduntant __func__ from debug print

From: HariPrasath Elango <[email protected]>

dev_dbg includes the function name & line number by default when dynamic debugging is enabled. Hence__func__ is reduntant here and removed.

---
 drivers/staging/iio/meter/ade7758_trigger.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/meter/ade7758_trigger.c +1 -1
index 1f0d1a0..da489ae 100644
@@ -34,7 +34,7 @@ static int ade7758_data_rdy_trigger_set_state(struct iio_trigger *trig,
 {
 	struct iio_dev *indio_dev = iio_trigger_get_drvdata(trig);
 
-	dev_dbg(&indio_dev->dev, "%s (%d)\n", __func__, state);
+	dev_dbg(&indio_dev->dev, "(%d)\n", state);
 	return ade7758_set_irq(&indio_dev->dev, state);
 }
 
Signature · 6 lines
2.10.0.GIT

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
maintainer
#1 lore raw
Quoted 6 lines · On Wed, 7 Mar 2018 11:08:04 +0530 [email protected] wrote:

From: HariPrasath Elango <[email protected]>

dev_dbg includes the function name & line number by default when dynamic debugging is enabled. Hence__func__ is reduntant here and removed.

Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it.

Please note that, after discussions with Michael, I'm planning to send out an email stating these meter drivers will be dropped next cycle unless we have someone come forward who can test them.

We can't realistically do the work needed to move them out of testing without a high risk of breaking them and they are 'not suitable for new designs'.

Ah well, we'll see - someone might care and be able to help

Thanks

Jonathan

Quoted 17 lines
---
 drivers/staging/iio/meter/ade7758_trigger.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/meter/ade7758_trigger.c +1 -1
index 1f0d1a0..da489ae 100644
@@ -34,7 +34,7 @@ static int ade7758_data_rdy_trigger_set_state(struct iio_trigger *trig,
 {
 	struct iio_dev *indio_dev = iio_trigger_get_drvdata(trig);
 
-	dev_dbg(&indio_dev->dev, "%s (%d)\n", __func__, state);
+	dev_dbg(&indio_dev->dev, "(%d)\n", state);
 	return ade7758_set_irq(&indio_dev->dev, state);
 }