of: unittest: fix an error test in of_unittest_overlay_8()
Subsystems (2)
PATCH 1/1 of: unittest: fix an error test in of_unittest_overlay_8()
We changed this from of_overlay_apply() to overlay_data_apply(). The overlay_data_apply() function returns 1 on success and 0 on error so the check for less than zero needs to be updated.
drivers/of/unittest.c +1 -2
@@ -1666,8 +1666,7 @@ static void __init of_unittest_overlay_8(void) overlay_name =overlay_name_from_nr (overlay_nr + i); - ret =overlay_data_apply (overlay_name, &ovcs_id); -if (ret <0 ) { +if (!overlay_data_apply (overlay_name, &ovcs_id)) {unittest (0 ,"could not apply overlay \"%s\"\n" , overlay_name);return ;
Quoted 13 lines · Dan Carpenter
We changed this from
of_overlay_apply()tooverlay_data_apply(). Theoverlay_data_apply()function returns 1 on success and 0 on error so the check for less than zero needs to be updated.Fixes 39a751a4cb7e ("of: change overlay apply input data from unflattened to FDT")Signed-off-by Dan Carpenter <[email protected]>drivers/of/unittest.c +0
-0
drivers/of/unittest.c static void __init of_unittest_overlay_8(void) · line 1672
Quoted 9 lines
drivers/of/unittest.c +1
-2@@ -1666,8 +1666,7 @@ static void __init of_unittest_overlay_8(void) overlay_name =overlay_name_from_nr (overlay_nr + i); - ret =overlay_data_apply (overlay_name, &ovcs_id); -if (ret <0 ) { +if (!overlay_data_apply (overlay_name, &ovcs_id)) {unittest (0 ,"could not apply overlay \"%s\"\n" , overlay_name);return ;
Thank you.
Frank Rowand
Reviewed-byQuoted 26 lines · Frank Rowand
Quoted 13 lines · Dan Carpenter
We changed this from
of_overlay_apply()tooverlay_data_apply(). Theoverlay_data_apply()function returns 1 on success and 0 on error so the check for less than zero needs to be updated.Fixes 39a751a4cb7e ("of: change overlay apply input data from unflattened to FDT")Signed-off-by Dan Carpenter <[email protected]>drivers/of/unittest.c +0
-0drivers/of/unittest.c static void __init of_unittest_overlay_8(void) · line 1672
Quoted 9 lines
drivers/of/unittest.c +1
-2@@ -1666,8 +1666,7 @@ static void __init of_unittest_overlay_8(void) overlay_name =overlay_name_from_nr (overlay_nr + i); - ret =overlay_data_apply (overlay_name, &ovcs_id); -if (ret <0 ) { +if (!overlay_data_apply (overlay_name, &ovcs_id)) {unittest (0 ,"could not apply overlay \"%s\"\n" , overlay_name);return ;Thank you.
Quoted 1 line
Reviewed-by Frank Rowand <[email protected]>
sony.com is valid, but that should have been:
Quoted 6 lines · Dan Carpenter
We changed this from
of_overlay_apply()tooverlay_data_apply(). Theoverlay_data_apply()function returns 1 on success and 0 on error so the check for less than zero needs to be updated.Fixes 39a751a4cb7e ("of: change overlay apply input data from unflattened to FDT")Signed-off-by Dan Carpenter <[email protected]>
Applied, thanks.
Rob