Skip to contentSkip to conversation

ARM: dts: imx7d-sdb: Fix regulator-usb-otg2-vbus node name

PATCH New Leonard Crestez 3 participants 3 messages Mar 1, 2018 – Mar 8, 2018

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Leonard Crestez

author
#0 lore raw

PATCH 1/1 ARM: dts: imx7d-sdb: Fix regulator-usb-otg2-vbus node name

The two usb-otg regulators for imx7d-sdb are both called "regulator-usb-otg1-vbus" and they effectively override each other.

This is most likely a copy-paste error.

Fixes b877039aa1fe ("ARM: dts: imx7d-sdb: Adjust the regulator nodes")
Signed-off-by Leonard Crestez <[email protected]>
---
 arch/arm/boot/dts/imx7d-sdb.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx7d-sdb.dts +1 -1
index a7a5dc7..e7d2db8 100644
@@ -75,21 +75,21 @@
 
 	reg_usb_otg1_vbus: regulator-usb-otg1-vbus {
 		compatible = "regulator-fixed";
 		regulator-name = "usb_otg1_vbus";
 		regulator-min-microvolt = <5000000>;
 		regulator-max-microvolt = <5000000>;
 		gpio = <&gpio1 5 GPIO_ACTIVE_HIGH>;
 		enable-active-high;
 	};
 
-	reg_usb_otg2_vbus: regulator-usb-otg1-vbus {
+	reg_usb_otg2_vbus: regulator-usb-otg2-vbus {
 		compatible = "regulator-fixed";
 		regulator-name = "usb_otg2_vbus";
 		regulator-min-microvolt = <5000000>;
 		regulator-max-microvolt = <5000000>;
 		gpio = <&gpio4 7 GPIO_ACTIVE_HIGH>;
 		enable-active-high;
 	};
 
 	reg_can2_3v3: regulator-can2-3v3 {
 		compatible = "regulator-fixed";
Signature · 1 line
2.7.4
reviewer
#1 lore raw

PATCH 1/1 ARM: dts: imx7d-sdb: Fix regulator-usb-otg2-vbus node name

Quoted 8 lines · Leonard Crestez

The two usb-otg regulators for imx7d-sdb are both called "regulator-usb-otg1-vbus" and they effectively override each other.

This is most likely a copy-paste error.

Fixes b877039aa1fe ("ARM: dts: imx7d-sdb: Adjust the regulator nodes")
Signed-off-by Leonard Crestez <[email protected]>

Good catch, thanks:

Reviewed-by Fabio Estevam <[email protected]>
Applied
#2 lore raw

PATCH 1/1 ARM: dts: imx7d-sdb: Fix regulator-usb-otg2-vbus node name

In reply to Leonard Crestez
Quoted 8 lines · Leonard Crestez

The two usb-otg regulators for imx7d-sdb are both called "regulator-usb-otg1-vbus" and they effectively override each other.

This is most likely a copy-paste error.

Fixes b877039aa1fe ("ARM: dts: imx7d-sdb: Adjust the regulator nodes")
Signed-off-by Leonard Crestez <[email protected]>

Applied, thanks.