Skip to contentSkip to conversation

net/ncsi: unlock on error in ncsi_set_interface_nl()

PATCH Applied Dan Carpenter 2 participants 2 messages Mar 8, 2018 – Mar 9, 2018

Subsystems (4)
Networking Network drivers Kernel janitors Ncsi library
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 2/2 net/ncsi: unlock on error in ncsi_set_interface_nl()

There are two error paths which are missing unlocks in this function.

Fixes 955dc68cb9b2 ("net/ncsi: Add generic netlink family")
Signed-off-by Dan Carpenter <[email protected]>
net/ncsi/ncsi-netlink.c +2 -0
index b73239b76349..05fcfb4fbe1d 100644
@@ -299,6 +299,7 @@ static int ncsi_set_interface_nl(struct sk_buff *msg, struct genl_info *info)
 			package = np;
 	if (!package) {
 		/* The user has set a package that does not exist */
+		spin_unlock_irqrestore(&ndp->lock, flags);
 		return -ERANGE;
 	}
 

@@ -317,6 +318,7 @@ static int ncsi_set_interface_nl(struct sk_buff *msg, struct genl_info *info)
 		/* The user has set a channel that does not exist on this
 		 * package
 		 */
+		spin_unlock_irqrestore(&ndp->lock, flags);
 		netdev_info(ndp->ndev.dev, "NCSI: Channel %u does not exist!\n",
 			    channel_id);
 		return -ERANGE;