Skip to contentSkip to conversation

.gitignore: ignore outgoing directory

PATCH New Christopher McCrory 4 participants 6 messages Mar 8, 2018 – May 12, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 .gitignore: ignore outgoing directory

The buildroot documentation for submitting patches creates a new directory "outgoing". This prevents git from nagging about untracked files.

---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)
.gitignore +1 -0
index bb02d9f572..f1a065d95e 100644
@@ -1,5 +1,6 @@
 /output
 /dl
+/outgoing
 /.auto.deps
 /.config.cmd
 /.config.old
Signature · 1 line
2.14.3
#1 lore raw

PATCH 1/1 .gitignore: ignore outgoing directory

Christopher, All,

On 2018-03-08 06:29 -0800, Christopher McCrory spake thusly:

Quoted 5 lines

The buildroot documentation for submitting patches creates a new directory "outgoing". This prevents git from nagging about untracked files.

Peter, this is a candidate for 2018.02.x as well, I guess. ;-)

Regards,
Yann E. MORIN.

Quoted 22 lines
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)
.gitignore +1 -0
index bb02d9f572..f1a065d95e 100644
@@ -1,5 +1,6 @@
 /output
 /dl
+/outgoing
 /.auto.deps
 /.config.cmd
 /.config.old
Signature · 6 lines
2.14.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 .gitignore: ignore outgoing directory

Hello,

Quoted 7 lines · Yann E. MORIN

Christopher, All,

On 2018-03-08 06:29 -0800, Christopher McCrory spake thusly:

Quoted 4 lines

The buildroot documentation for submitting patches creates a new directory "outgoing". This prevents git from nagging about untracked files.

Quoted 5 lines
Quoted 1 line

Peter, this is a candidate for 2018.02.x as well, I guess. ;-)

I'd like to challenge this patch: I am not super convinced. Creating a outgoing/ directory is not "git format-patch" default behavior. By default, the patches go in the current folder.

It's only the Buildroot manual that suggests to put them in an outgoing/ folder (I'm not sure why). My feeling is that the Buildroot manual just gives an example, and really users could put their patches in any other folder, and we're not going to add all random folders in .gitignore.

So I would say no to this patch, and therefore disagree with Yann's Acked-by. Peter, Arnout, could you chime in and give your opinion about this ?

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 .gitignore: ignore outgoing directory

Thomas, All,

On 2018-04-28 18:44 +0200, Thomas Petazzoni spake thusly:

Quoted 12 lines · Yann E. MORIN
Quoted 11 lines

Christopher, All,

On 2018-03-08 06:29 -0800, Christopher McCrory spake thusly:

Quoted 5 lines

The buildroot documentation for submitting patches creates a new directory "outgoing". This prevents git from nagging about untracked files.

Quoted 8 lines
Quoted 1 line

Peter, this is a candidate for 2018.02.x as well, I guess. ;-)

I'd like to challenge this patch: I am not super convinced. Creating a outgoing/ directory is not "git format-patch" default behavior. By default, the patches go in the current folder.

It's only the Buildroot manual that suggests to put them in an outgoing/ folder (I'm not sure why).

And I'm not even sure why we even creat the patches locally, when it is perfectly possible to send them directly, e.g. to send the last three patches:

git send-email --to buidlroot at buildroot.org HEAD^^^..

Regards,
Yann E. MORIN.

Quoted 16 lines

My feeling is that the Buildroot
manual just gives an example, and really users could put their patches in any other folder, and we're not going to add all random folders in .gitignore.

So I would say no to this patch, and therefore disagree with Yann's Acked-by. Peter, Arnout, could you chime in and give your opinion about this ?

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#4 lore raw

PATCH 1/1 .gitignore: ignore outgoing directory

Hello,

Quoted 8 lines · Yann E. MORIN
Quoted 2 lines

It's only the Buildroot manual that suggests to put them in an outgoing/ folder (I'm not sure why).

And I'm not even sure why we even creat the patches locally, when it is perfectly possible to send them directly, e.g. to send the last three patches:

git send-email --to buidlroot at buildroot.org HEAD^^^..

I think for people beginning with git and patches, it is good to use format-patch, so that you can check what the patches look like before sending them.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
#5 lore raw

PATCH 1/1 .gitignore: ignore outgoing directory

In reply to Thomas Petazzoni
Quoted 32 lines

From: "Thomas Petazzoni" <[email protected]>
To: "Yann Morin" <[email protected]>, "Christopher McCrory" <[email protected]>
Cc: "buildroot" <[email protected]>
Sent: Saturday, April 28, 2018 1:44:58 PM
Subject: Re: [Buildroot] [PATCH 1/1] .gitignore: ignore outgoing directory

Hello,

Quoted 7 lines · Yann E. MORIN

Christopher, All,

On 2018-03-08 06:29 -0800, Christopher McCrory spake thusly:

Quoted 4 lines

The buildroot documentation for submitting patches creates a new directory "outgoing". This prevents git from nagging about untracked files.

Quoted 5 lines
Quoted 1 line

Peter, this is a candidate for 2018.02.x as well, I guess. ;-)

I'd like to challenge this patch: I am not super convinced. Creating a outgoing/ directory is not "git format-patch" default behavior. By default, the patches go in the current folder.

It's only the Buildroot manual that suggests to put them in an outgoing/ folder (I'm not sure why). My feeling is that the Buildroot manual just gives an example, and really users could put their patches in any other folder, and we're not going to add all random folders in .gitignore.

Quoted 5 lines

So I would say no to this patch, and therefore disagree with Yann's Acked-by. Peter, Arnout, could you chime in and give your opinion about this ?

Best regards,

If you want to ignore patches under outgoing/ then put something like this in ~/.gitconfig:

[core]
excludesFile = ~/.gitignore-global

And this in ~/.gitignore-global:

outgoing/*.patch
outgoing/*/*.patch

Signature · 3 lines
Carlos Santos (Casantos) - DATACOM, P&D
?Marched towards the enemy, spear upright, armed with the certainty
that only the ignorant can have.? ? Epitaph of a volunteer