Set name of regmap_config
Subsystems (9)
v4 cover Set name of regmap_config
After 9b947a13e7f6 ("regmap: use debugfs even when no device"), we are allowing regmap to create debugfs without a valid device. Some of them would end up using "dummy*" as debugfs name.
This series try to set names in some regmap_config to avoid that.
Changes in v4:
Not to use rtc dev to init regmap, the gpbr is not directly related to the rtc.
Changes in v3:
Modify commit message.
Jeffy Chen (4):
mfd: syscon: Set name of regmap_config
rtc: at91sam9: Set name of regmap_config
clk: lpc32xx: Set name of regmap_config
ARM: rockchip: Set name of regmap_config
arch/arm/mach-rockchip/platsmp.c | 1 + drivers/clk/nxp/clk-lpc32xx.c | 1 + drivers/mfd/syscon.c | 1 + drivers/rtc/rtc-at91sam9.c | 1 + 4 files changed, 4 insertions(+)
Signature · 1 line
2.11.0
PATCH v4 1/4 mfd: syscon: Set name of regmap_config
We are now allowing to register debugfs without a valid device, and not having a valid name will end up using "dummy*" to create debugfs dir.
---
Changes in v4: None
Changes in v3:
Modify commit message.
drivers/mfd/syscon.c | 1 + 1 file changed, 1 insertion(+)
drivers/mfd/syscon.c +1 -0
@@ -110,6 +110,7 @@ static struct syscon *of_syscon_register(struct device_node *np) syscon_config.reg_stride = reg_io_width; syscon_config.val_bits = reg_io_width *8 ; syscon_config.max_register =resource_size (&res) - reg_io_width; + syscon_config.name =of_node_full_name (np); regmap =regmap_init_mmio (NULL , base, &syscon_config);if (IS_ERR (regmap)) {
Signature · 1 line
2.11.0
Re: [PATCH v4 1/4] mfd: syscon: Set name of regmap_config
Quoted 18 lines · Jeffy Chen
We are now allowing to register debugfs without a valid device, and not having a valid name will end up using "dummy*" to create debugfs dir.
Signed-off-by Jeffy Chen <[email protected]>---
Changes in v4: None
Changes in v3:
Modify commit message.drivers/mfd/syscon.c | 1 + 1 file changed, 1 insertion(+)drivers/mfd/syscon.c +0
-0
drivers/mfd/syscon.c static struct syscon *of_syscon_register(struct device_node *np) · line 113
Quoted 4 lines
drivers/mfd/syscon.c +1
-0@@ -110,6 +110,7 @@ static struct syscon *of_syscon_register(struct device_node *np) syscon_config.reg_stride = reg_io_width; syscon_config.val_bits = reg_io_width *8 ; syscon_config.max_register =resource_size (&res) - reg_io_width; + syscon_config.name =of_node_full_name (np);
It's difficult to review, since we cannot see what's happening with the rest of the patch set. Would you mind re-sending the whole set to all parties please?
Signature · 4 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
PATCH v4 2/4 rtc: at91sam9: Set name of regmap_config
In reply to Jeffy ChenWe are now allowing to register debugfs without a valid device, and not having a valid name will end up using "dummy*" to create debugfs dir.
---
Changes in v4:
Not to use rtc dev to init regmap, the gpbr is not directly related to the rtc.
Changes in v3: None
drivers/rtc/rtc-at91sam9.c | 1 + 1 file changed, 1 insertion(+)
drivers/rtc/rtc-at91sam9.c +1 -0
@@ -349,6 +349,7 @@ static const struct rtc_class_ops at91_rtc_ops = { };static const struct regmap_config gpbr_regmap_config = { + .name ="gpbr" , .reg_bits =32 , .val_bits =32 , .reg_stride =4 ,
Signature · 1 line
2.11.0
PATCH v4 3/4 clk: lpc32xx: Set name of regmap_config
In reply to Jeffy ChenWe are now allowing to register debugfs without a valid device, and not having a valid name will end up using "dummy*" to create debugfs dir.
---
Changes in v4: None
Changes in v3: None
drivers/clk/nxp/clk-lpc32xx.c | 1 + 1 file changed, 1 insertion(+)
drivers/clk/nxp/clk-lpc32xx.c +1 -0
@@ -67,6 +67,7 @@#define LPC32XX_USB_CLK_STS 0xF8static struct regmap_config lpc32xx_scb_regmap_config = { + .name ="lpc32xx-scb" , .reg_bits =32 , .val_bits =32 , .reg_stride =4 ,
Signature · 1 line
2.11.0
PATCH v4 4/4 ARM: rockchip: Set name of regmap_config
In reply to Jeffy ChenWe are now allowing to register debugfs without a valid device, and not having a valid name will end up using "dummy*" to create debugfs dir.
---
Changes in v4: None
Changes in v3: None
arch/arm/mach-rockchip/platsmp.c | 1 + 1 file changed, 1 insertion(+)
arch/arm/mach-rockchip/platsmp.c +1 -0
@@ -208,6 +208,7 @@ static int __init rockchip_smp_prepare_sram(struct device_node *node) }static const struct regmap_config rockchip_pmu_regmap_config = { + .name ="rockchip-pmu" , .reg_bits =32 , .val_bits =32 , .reg_stride =4 ,
Signature · 1 line
2.11.0
Quoted 21 lines · Jeffy Chen
After
9b947a13e7f6("regmap: use debugfs even when no device"), we are allowing regmap to create debugfs without a valid device. Some of them would end up using "dummy*" as debugfs name.This series try to set names in some
regmap_configto avoid that.Changes in v4:
Not to use rtc dev to init regmap, the gpbr is not directly related to the rtc.Changes in v3:
Modify commit message.Jeffy Chen (4):
mfd: syscon: Set name ofregmap_config
rtc: at91sam9: Set name ofregmap_config
clk: lpc32xx: Set name ofregmap_config
ARM: rockchip: Set name ofregmap_config
Quoted 3 lines
arch/arm/mach-rockchip/platsmp.c | 1 + drivers/clk/nxp/clk-lpc32xx.c | 1 + drivers/mfd/syscon.c | 1 +
It's difficult to review, since we cannot see what's happening with the rest of the patch set. Would you mind re-sending the whole set to all parties please?
Quoted 3 lines
drivers/rtc/rtc-at91sam9.c | 1 + 4 files changed, 4 insertions(+)
Signature · 4 lines
Lee Jones [???] Linaro Services Technical Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Hi Lee,
Thanks for your reply.
Quoted 7 lines · Lee Jones
Quoted 7 lines
Quoted 7 lines
Jeffy Chen (4):
mfd: syscon: Set name ofregmap_config
rtc: at91sam9: Set name ofregmap_config
clk: lpc32xx: Set name ofregmap_config
ARM: rockchip: Set name ofregmap_config
Quoted 6 lines
Quoted 3 lines
Quoted 3 lines
arch/arm/mach-rockchip/platsmp.c | 1 + drivers/clk/nxp/clk-lpc32xx.c | 1 + drivers/mfd/syscon.c | 1 +It's difficult to review, since we cannot see what's happening with the rest of the patch set. Would you mind re-sending the whole set to all parties please?
sure, i can do that :)