Skip to contentSkip to conversation

qemu-iotests fixes

PATCH In review Amador Pahim 2 participants 5 messages Mar 9, 2018

lore
Share & tools
lore

Amador Pahim

author
#0 lore raw

cover qemu-iotests fixes

- Skipping test 205 for unsupported formats.
- Setting execution permission on test files.

Amador Pahim (2):
qemu-iotests: skip test 205 for unsupported formats
qemu-iotests: set exec permission for tests lacking it

 tests/qemu-iotests/096 | 0
 tests/qemu-iotests/124 | 0
 tests/qemu-iotests/129 | 0
 tests/qemu-iotests/132 | 0
 tests/qemu-iotests/136 | 0
 tests/qemu-iotests/139 | 0
 tests/qemu-iotests/148 | 0
 tests/qemu-iotests/152 | 0
 tests/qemu-iotests/163 | 0
 tests/qemu-iotests/205 | 3 +++
 10 files changed, 3 insertions(+)
 mode change 100644 => 100755 tests/qemu-iotests/096
 mode change 100644 => 100755 tests/qemu-iotests/124
 mode change 100644 => 100755 tests/qemu-iotests/129
 mode change 100644 => 100755 tests/qemu-iotests/132
 mode change 100644 => 100755 tests/qemu-iotests/136
 mode change 100644 => 100755 tests/qemu-iotests/139
 mode change 100644 => 100755 tests/qemu-iotests/148
 mode change 100644 => 100755 tests/qemu-iotests/152
 mode change 100644 => 100755 tests/qemu-iotests/163
 mode change 100644 => 100755 tests/qemu-iotests/205
Signature · 1 line
2.14.3
author
#1 lore raw

PATCH 1/2 qemu-iotests: skip test 205 for unsupported formats

Using bochs or cloop, qemu-img will fail with:

Format driver 'bochs' does not support image creation

Signed-off-by Amador Pahim <[email protected]>
---
 tests/qemu-iotests/205 | 3 +++
 1 file changed, 3 insertions(+)
tests/qemu-iotests/205 +3 -0
index e7b2eae51d..fff9be97d2 100644
@@ -24,6 +24,9 @@ import iotests
 import time
 from iotests import qemu_img_create, qemu_io, filter_qemu_io, QemuIoInteractive
 
+
+iotests.verify_image_format(unsupported_fmts=['bochs', 'cloop'])
+
 nbd_sock = 'nbd_sock'
 nbd_uri = 'nbd+unix:///exp?socket=' + nbd_sock
 disk = os.path.join(iotests.test_dir, 'disk')
Signature · 1 line
2.14.3
Reviewed-by on v1 1/2
#2 lore raw

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] qemu-iotests: skip test 205 for unsupported formats

Quoted 8 lines · Amador Pahim

Using bochs or cloop, qemu-img will fail with:

Format driver 'bochs' does not support image creation

Signed-off-by Amador Pahim <[email protected]>
---
  tests/qemu-iotests/205 | 3 +++
  1 file changed, 3 insertions(+)
Reviewed-by Eric Blake <[email protected]>
Quoted 16 lines
tests/qemu-iotests/205 +3 -0
index e7b2eae51d..fff9be97d2 100644
@@ -24,6 +24,9 @@ import iotests
  import time
  from iotests import qemu_img_create, qemu_io, filter_qemu_io, QemuIoInteractive
 
+
+iotests.verify_image_format(unsupported_fmts=['bochs', 'cloop'])
+
  nbd_sock = 'nbd_sock'
  nbd_uri = 'nbd+unix:///exp?socket=' + nbd_sock
  disk = os.path.join(iotests.test_dir, 'disk')
Signature · 3 lines
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org
author
#3 lore raw

PATCH 2/2 qemu-iotests: set exec permission for tests lacking it

In reply to Amador Pahim

Some tests are not executables. This patch sets the executable permission for those tests lacking that.

Signed-off-by Amador Pahim <[email protected]>
---
 tests/qemu-iotests/096 | 0
 tests/qemu-iotests/124 | 0
 tests/qemu-iotests/129 | 0
 tests/qemu-iotests/132 | 0
 tests/qemu-iotests/136 | 0
 tests/qemu-iotests/139 | 0
 tests/qemu-iotests/148 | 0
 tests/qemu-iotests/152 | 0
 tests/qemu-iotests/163 | 0
 tests/qemu-iotests/205 | 0
 10 files changed, 0 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 tests/qemu-iotests/096
 mode change 100644 => 100755 tests/qemu-iotests/124
 mode change 100644 => 100755 tests/qemu-iotests/129
 mode change 100644 => 100755 tests/qemu-iotests/132
 mode change 100644 => 100755 tests/qemu-iotests/136
 mode change 100644 => 100755 tests/qemu-iotests/139
 mode change 100644 => 100755 tests/qemu-iotests/148
 mode change 100644 => 100755 tests/qemu-iotests/152
 mode change 100644 => 100755 tests/qemu-iotests/163
 mode change 100644 => 100755 tests/qemu-iotests/205
tests/qemu-iotests/096 +0 -0
old mode 100644
new mode 100755
tests/qemu-iotests/124 +0 -0
old mode 100644
new mode 100755
tests/qemu-iotests/129 +0 -0
old mode 100644
new mode 100755
tests/qemu-iotests/132 +0 -0
old mode 100644
new mode 100755
tests/qemu-iotests/136 +0 -0
old mode 100644
new mode 100755
tests/qemu-iotests/139 +0 -0
old mode 100644
new mode 100755
tests/qemu-iotests/148 +0 -0
old mode 100644
new mode 100755
tests/qemu-iotests/152 +0 -0
old mode 100644
new mode 100755
tests/qemu-iotests/163 +0 -0
old mode 100644
new mode 100755
tests/qemu-iotests/205 +0 -0
old mode 100644
new mode 100755
Signature · 1 line
2.14.3
#4 lore raw

Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: set exec permission for tests lacking it

Quoted 5 lines · Amador Pahim

Some tests are not executables. This patch sets the executable permission for those tests lacking that.

Signed-off-by Amador Pahim <[email protected]>

---

Duplicate of a patch already on Max's tree:
https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg01167.html

Signature · 3 lines
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org