thermal: Remove "cooling-{min|max}-level" properties
Subsystems (8)
Viresh Kumar
maintainercover thermal: Remove "cooling-{min|max}-level" properties
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of a cooling devices is found by cooling-device's driver itself.
Also note that a very small number of platforms that support cooling devices currently contain these properties in their dts files. Most of them don't specify them (as no one is going to use them anyway).
Only two type of cooling devices are using these properties currently:
cpu-cooling and gpio-fan. This series first updates all the dts files to not specify the min/max cooling states and then removes the bindings.
The maintainers are requested to apply the relevant patches to their trees directly as there is no dependency between the patches.
--
viresh
Viresh Kumar (10):
ARM: dts: exynos: Remove "cooling-{min|max}-level" for CPU nodes
ARM: dts: omap: Remove "cooling-{min|max}-level" for CPU nodes
ARM: dts: mt7623: Remove "cooling-{min|max}-level" for CPU nodes
ARM: dts: sun[4-7]i: Remove "cooling-{min|max}-level" for CPU nodes
ARM64: dts: hi6220: Remove "cooling-{min|max}-level" for CPU nodes
ARM64: dts: meson: Remove "cooling-{min|max}-level" for CPU nodes
ARM: dts: gemini: Remove "cooling-{min|max}-level" for gpio-fan node
ARM64: dts: meson: Remove "cooling-{min|max}-level" for gpio-fan node
dt-bindings: cpufreq-dt: Remove "cooling-{min|max}-level" properties
dt-bindings: thermal: Remove "cooling-{min|max}-level" properties
Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt | 4 ---- .../devicetree/bindings/cpufreq/cpufreq-mediatek.txt | 4 ---- Documentation/devicetree/bindings/thermal/thermal.txt | 16 +--------------- arch/arm/boot/dts/dra7.dtsi | 2 -- arch/arm/boot/dts/exynos4210.dtsi | 2 -- arch/arm/boot/dts/exynos4412.dtsi | 2 -- arch/arm/boot/dts/exynos5250.dtsi | 2 -- arch/arm/boot/dts/exynos5420-cpus.dtsi | 16 ---------------- arch/arm/boot/dts/exynos5422-cpus.dtsi | 16 ---------------- arch/arm/boot/dts/gemini-dlink-dns-313.dts | 2 -- arch/arm/boot/dts/mt7623.dtsi | 2 -- arch/arm/boot/dts/omap443x.dtsi | 2 -- arch/arm/boot/dts/omap4460.dtsi | 2 -- arch/arm/boot/dts/omap5.dtsi | 2 -- arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts | 1 - arch/arm/boot/dts/sun4i-a10.dtsi | 2 -- arch/arm/boot/dts/sun5i-a13.dtsi | 2 -- arch/arm/boot/dts/sun6i-a31.dtsi | 2 -- arch/arm/boot/dts/sun7i-a20.dtsi | 2 -- arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 6 ------ arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 2 -- 21 files changed, 1 insertion(+), 90 deletions(-)
Signature · 1 line
2.15.0.194.g9af6a3dea062
Viresh Kumar
maintainerPATCH 1/10 ARM: dts: exynos: Remove "cooling-{min|max}-level" for CPU nodes
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of a CPU cooling device is found by referring to the cpufreq table instead.
Remove the unused properties from the CPU nodes.
--- arch/arm/boot/dts/exynos4210.dtsi | 2 -- arch/arm/boot/dts/exynos4412.dtsi | 2 -- arch/arm/boot/dts/exynos5250.dtsi | 2 -- arch/arm/boot/dts/exynos5420-cpus.dtsi | 16 ---------------- arch/arm/boot/dts/exynos5422-cpus.dtsi | 16 ---------------- 5 files changed, 38 deletions(-)
arch/arm/boot/dts/exynos4210.dtsi +0 -2
@@ -49,8 +49,6 @@ 400000 975000 200000 950000 >; - cooling-min-level = <4>; - cooling-max-level = <2>; #cooling-cells = <2>; /* min followed by max */ };
arch/arm/boot/dts/exynos4412.dtsi +0 -2
@@ -42,8 +42,6 @@ clocks = <&clock CLK_ARM_CLK>; clock-names = "cpu"; operating-points-v2 = <&cpu0_opp_table>; - cooling-min-level = <13>; - cooling-max-level = <7>; #cooling-cells = <2>; /* min followed by max */ };
arch/arm/boot/dts/exynos5250.dtsi +0 -2
@@ -77,8 +77,6 @@ 300000 937500 200000 925000 >; - cooling-min-level = <15>; - cooling-max-level = <9>; #cooling-cells = <2>; /* min followed by max */ }; cpu at 1 {
arch/arm/boot/dts/exynos5420-cpus.dtsi +0 -16
@@ -30,8 +30,6 @@ clock-frequency = <1800000000>; cci-control-port = <&cci_control1>; operating-points-v2 = <&cluster_a15_opp_table>; - cooling-min-level = <0>; - cooling-max-level = <11>; #cooling-cells = <2>; /* min followed by max */ capacity-dmips-mhz = <1024>; };
@@ -43,8 +41,6 @@ clock-frequency = <1800000000>; cci-control-port = <&cci_control1>; operating-points-v2 = <&cluster_a15_opp_table>; - cooling-min-level = <0>; - cooling-max-level = <11>; #cooling-cells = <2>; /* min followed by max */ capacity-dmips-mhz = <1024>; };
@@ -56,8 +52,6 @@ clock-frequency = <1800000000>; cci-control-port = <&cci_control1>; operating-points-v2 = <&cluster_a15_opp_table>; - cooling-min-level = <0>; - cooling-max-level = <11>; #cooling-cells = <2>; /* min followed by max */ capacity-dmips-mhz = <1024>; };
@@ -69,8 +63,6 @@ clock-frequency = <1800000000>; cci-control-port = <&cci_control1>; operating-points-v2 = <&cluster_a15_opp_table>; - cooling-min-level = <0>; - cooling-max-level = <11>; #cooling-cells = <2>; /* min followed by max */ capacity-dmips-mhz = <1024>; };
@@ -83,8 +75,6 @@ clock-frequency = <1000000000>; cci-control-port = <&cci_control0>; operating-points-v2 = <&cluster_a7_opp_table>; - cooling-min-level = <0>; - cooling-max-level = <7>; #cooling-cells = <2>; /* min followed by max */ capacity-dmips-mhz = <539>; };
@@ -96,8 +86,6 @@ clock-frequency = <1000000000>; cci-control-port = <&cci_control0>; operating-points-v2 = <&cluster_a7_opp_table>; - cooling-min-level = <0>; - cooling-max-level = <7>; #cooling-cells = <2>; /* min followed by max */ capacity-dmips-mhz = <539>; };
@@ -109,8 +97,6 @@ clock-frequency = <1000000000>; cci-control-port = <&cci_control0>; operating-points-v2 = <&cluster_a7_opp_table>; - cooling-min-level = <0>; - cooling-max-level = <7>; #cooling-cells = <2>; /* min followed by max */ capacity-dmips-mhz = <539>; };
@@ -122,8 +108,6 @@ clock-frequency = <1000000000>; cci-control-port = <&cci_control0>; operating-points-v2 = <&cluster_a7_opp_table>; - cooling-min-level = <0>; - cooling-max-level = <7>; #cooling-cells = <2>; /* min followed by max */ capacity-dmips-mhz = <539>; };
arch/arm/boot/dts/exynos5422-cpus.dtsi +0 -16
@@ -29,8 +29,6 @@ clock-frequency = <1000000000>; cci-control-port = <&cci_control0>; operating-points-v2 = <&cluster_a7_opp_table>; - cooling-min-level = <0>; - cooling-max-level = <11>; #cooling-cells = <2>; /* min followed by max */ capacity-dmips-mhz = <539>; };
@@ -42,8 +40,6 @@ clock-frequency = <1000000000>; cci-control-port = <&cci_control0>; operating-points-v2 = <&cluster_a7_opp_table>; - cooling-min-level = <0>; - cooling-max-level = <11>; #cooling-cells = <2>; /* min followed by max */ capacity-dmips-mhz = <539>; };
@@ -55,8 +51,6 @@ clock-frequency = <1000000000>; cci-control-port = <&cci_control0>; operating-points-v2 = <&cluster_a7_opp_table>; - cooling-min-level = <0>; - cooling-max-level = <11>; #cooling-cells = <2>; /* min followed by max */ capacity-dmips-mhz = <539>; };
@@ -68,8 +62,6 @@ clock-frequency = <1000000000>; cci-control-port = <&cci_control0>; operating-points-v2 = <&cluster_a7_opp_table>; - cooling-min-level = <0>; - cooling-max-level = <11>; #cooling-cells = <2>; /* min followed by max */ capacity-dmips-mhz = <539>; };
@@ -82,8 +74,6 @@ clock-frequency = <1800000000>; cci-control-port = <&cci_control1>; operating-points-v2 = <&cluster_a15_opp_table>; - cooling-min-level = <0>; - cooling-max-level = <15>; #cooling-cells = <2>; /* min followed by max */ capacity-dmips-mhz = <1024>; };
@@ -95,8 +85,6 @@ clock-frequency = <1800000000>; cci-control-port = <&cci_control1>; operating-points-v2 = <&cluster_a15_opp_table>; - cooling-min-level = <0>; - cooling-max-level = <15>; #cooling-cells = <2>; /* min followed by max */ capacity-dmips-mhz = <1024>; };
@@ -108,8 +96,6 @@ clock-frequency = <1800000000>; cci-control-port = <&cci_control1>; operating-points-v2 = <&cluster_a15_opp_table>; - cooling-min-level = <0>; - cooling-max-level = <15>; #cooling-cells = <2>; /* min followed by max */ capacity-dmips-mhz = <1024>; };
@@ -121,8 +107,6 @@ clock-frequency = <1800000000>; cci-control-port = <&cci_control1>; operating-points-v2 = <&cluster_a15_opp_table>; - cooling-min-level = <0>; - cooling-max-level = <15>; #cooling-cells = <2>; /* min followed by max */ capacity-dmips-mhz = <1024>; };
Signature · 1 line
2.15.0.194.g9af6a3dea062
Re: [PATCH 01/10] ARM: dts: exynos: Remove "cooling-{min|max}-level" for CPU nodes
Quoted 6 lines · Viresh Kumar
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of a CPU cooling device is found by referring to the cpufreq table instead.
Remove the unused properties from the CPU nodes.
Quoted 9 lines
Signed-off-by Viresh Kumar <[email protected]>--- arch/arm/boot/dts/exynos4210.dtsi | 2 -- arch/arm/boot/dts/exynos4412.dtsi | 2 -- arch/arm/boot/dts/exynos5250.dtsi | 2 -- arch/arm/boot/dts/exynos5420-cpus.dtsi | 16 ---------------- arch/arm/boot/dts/exynos5422-cpus.dtsi | 16 ---------------- 5 files changed, 38 deletions(-)
Thanks, applied.
Best regards,
Krzysztof
Viresh Kumar
maintainerPATCH 2/10 ARM: dts: omap: Remove "cooling-{min|max}-level" for CPU nodes
In reply to Viresh KumarThe "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of a CPU cooling device is found by referring to the cpufreq table instead.
Remove the unused properties from the CPU nodes.
--- arch/arm/boot/dts/dra7.dtsi | 2 -- arch/arm/boot/dts/omap443x.dtsi | 2 -- arch/arm/boot/dts/omap4460.dtsi | 2 -- arch/arm/boot/dts/omap5.dtsi | 2 -- 4 files changed, 8 deletions(-)
arch/arm/boot/dts/dra7.dtsi +0 -2
@@ -92,8 +92,6 @@ clock-latency = <300000>; /* From omap-cpufreq driver */ /* cooling options */ - cooling-min-level = <0>; - cooling-max-level = <2>; #cooling-cells = <2>; /* min followed by max */ vbb-supply = <&abb_mpu>;
arch/arm/boot/dts/omap443x.dtsi +0 -2
@@ -24,8 +24,6 @@ clock-latency = <300000>; /* From legacy driver */ /* cooling options */ - cooling-min-level = <0>; - cooling-max-level = <3>; #cooling-cells = <2>; /* min followed by max */ }; };
arch/arm/boot/dts/omap4460.dtsi +0 -2
@@ -22,8 +22,6 @@ clock-latency = <300000>; /* From legacy driver */ /* cooling options */ - cooling-min-level = <0>; - cooling-max-level = <2>; #cooling-cells = <2>; /* min followed by max */ }; };
arch/arm/boot/dts/omap5.dtsi +0 -2
@@ -55,8 +55,6 @@ clock-latency = <300000>; /* From omap-cpufreq driver */ /* cooling options */ - cooling-min-level = <0>; - cooling-max-level = <2>; #cooling-cells = <2>; /* min followed by max */ }; cpu at 1 {
Signature · 1 line
2.15.0.194.g9af6a3dea062
Re: [PATCH 02/10] ARM: dts: omap: Remove "cooling-{min|max}-level" for CPU nodes
Quoted 5 lines · Viresh Kumar
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of a CPU cooling device is found by referring to the cpufreq table instead.
Remove the unused properties from the CPU nodes.
It seem this patch needs to wait before we can apply, right?
Regards,
Tony
Re: [PATCH 02/10] ARM: dts: omap: Remove "cooling-{min|max}-level" for CPU nodes
Quoted 8 lines · Tony Lindgren
Quoted 5 lines · Viresh Kumar
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of a CPU cooling device is found by referring to the cpufreq table instead.
Remove the unused properties from the CPU nodes.
It seem this patch needs to wait before we can apply, right?
Oh sorry it's already unused :) Will pick this up for v4.17 thanks.
Tony
Viresh Kumar
maintainerPATCH 3/10 ARM: dts: mt7623: Remove "cooling-{min|max}-level" for CPU nodes
In reply to Viresh KumarThe "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of a CPU cooling device is found by referring to the cpufreq table instead.
Remove the unused properties from the CPU nodes.
--- Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt | 4 ---- arch/arm/boot/dts/mt7623.dtsi | 2 -- 2 files changed, 6 deletions(-)
Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt +0 -4
@@ -21,8 +21,6 @@ Binding for MediaTek's CPUFreq driver flow is handled by hardware, hence no software "voltage tracking" is needed. - #cooling-cells: -- cooling-min-level: -- cooling-max-level: Please refer to Documentation/devicetree/bindings/thermal/thermal.txt for detail.
@@ -67,8 +65,6 @@ Binding for MediaTek's CPUFreq driver clock-names = "cpu", "intermediate"; operating-points-v2 = <&cpu_opp_table>; #cooling-cells = <2>; - cooling-min-level = <0>; - cooling-max-level = <7>; }; cpu at 1 { device_type = "cpu";
arch/arm/boot/dts/mt7623.dtsi +0 -2
@@ -87,8 +87,6 @@ clock-names = "cpu", "intermediate"; operating-points-v2 = <&cpu_opp_table>; #cooling-cells = <2>; - cooling-min-level = <0>; - cooling-max-level = <7>; clock-frequency = <1300000000>; };
Signature · 1 line
2.15.0.194.g9af6a3dea062
Re: [PATCH 03/10] ARM: dts: mt7623: Remove "cooling-{min|max}-level" for CPU nodes
Quoted 11 lines · Viresh Kumar
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of a CPU cooling device is found by referring to the cpufreq table instead.
Remove the unused properties from the CPU nodes.
Signed-off-by Viresh Kumar <[email protected]>--- Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt | 4 ---- arch/arm/boot/dts/mt7623.dtsi | 2 -- 2 files changed, 6 deletions(-)
Viresh Kumar
maintainerPATCH 4/10 ARM: dts: sun[4-7]i: Remove "cooling-{min|max}-level" for CPU nodes
In reply to Viresh KumarThe "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of a CPU cooling device is found by referring to the cpufreq table instead.
Remove the unused properties from the CPU nodes.
--- arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts | 1 - arch/arm/boot/dts/sun4i-a10.dtsi | 2 -- arch/arm/boot/dts/sun5i-a13.dtsi | 2 -- arch/arm/boot/dts/sun6i-a31.dtsi | 2 -- arch/arm/boot/dts/sun7i-a20.dtsi | 2 -- 5 files changed, 9 deletions(-)
arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts +0 -1
@@ -97,7 +97,6 @@ 864000 1300000 624000 1250000 >; - cooling-max-level = <2>; }; &de {
arch/arm/boot/dts/sun4i-a10.dtsi +0 -2
@@ -123,8 +123,6 @@ 624000 1250000 >; #cooling-cells = <2>; - cooling-min-level = <0>; - cooling-max-level = <3>; }; };
arch/arm/boot/dts/sun5i-a13.dtsi +0 -2
@@ -116,8 +116,6 @@ 432000 1200000 >; #cooling-cells = <2>; - cooling-min-level = <0>; - cooling-max-level = <5>; }; &pio {
arch/arm/boot/dts/sun6i-a31.dtsi +0 -2
@@ -113,8 +113,6 @@ 480000 1000000 >; #cooling-cells = <2>; - cooling-min-level = <0>; - cooling-max-level = <3>; }; cpu at 1 {
arch/arm/boot/dts/sun7i-a20.dtsi +0 -2
@@ -116,8 +116,6 @@ 144000 1000000 >; #cooling-cells = <2>; - cooling-min-level = <0>; - cooling-max-level = <6>; }; cpu at 1 {
Signature · 1 line
2.15.0.194.g9af6a3dea062
Maxime Ripard
AppliedRe: [PATCH 04/10] ARM: dts: sun[4-7]i: Remove "cooling-{min|max}-level" for CPU nodes
Quoted 7 lines · Viresh Kumar
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of a CPU cooling device is found by referring to the cpufreq table instead.
Remove the unused properties from the CPU nodes.
Signed-off-by Viresh Kumar <[email protected]>
Applied, thanks!
Maxime
Signature · 10 lines
Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180213/815363f7/attachment-0001.sig>
Re: [PATCH 04/10] ARM: dts: sun[4-7]i: Remove "cooling-{min|max}-level" for CPU nodes
Quoted 4 lines · Maxime Ripard
Quoted 3 lines · Viresh Kumar
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of a CPU cooling device is found by referring to the cpufreq table instead.
That doesn't mean that other systems aren't using it. It's still part of the device tree binding. Last I checked, while they are optional, they aren't deprecated.
Any comments from the device tree maintainers?
Quoted 12 lines
Quoted 4 lines
Remove the unused properties from the CPU nodes.
Signed-off-by Viresh Kumar <[email protected]>Applied, thanks!
Maxime--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
Viresh Kumar
maintainerRe: [PATCH 04/10] ARM: dts: sun[4-7]i: Remove "cooling-{min|max}-level" for CPU nodes
Quoted 8 lines · Chen-Yu Tsai
Quoted 4 lines · Maxime Ripard
Quoted 3 lines · Viresh Kumar
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of a CPU cooling device is found by referring to the cpufreq table instead.
That doesn't mean that other systems aren't using it.
Are you aware of any systems which are using them ?
Quoted 3 lines
It's still part of
the device tree binding. Last I checked, while they are optional, they aren't deprecated.
Yeah, it isn't deprecated yet. Though the last patches of this series tries to do something similar.
Quoted 1 line
Any comments from the device tree maintainers?
None yet.
Signature · 1 line
viresh
Viresh Kumar
maintainerPATCH 5/10 ARM64: dts: hi6220: Remove "cooling-{min|max}-level" for CPU nodes
In reply to Viresh KumarThe "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of a CPU cooling device is found by referring to the cpufreq table instead.
Moreover, the entries are incorrect here as min level is 4 and the max level is 0.
Remove the unused properties from the CPU nodes.
--- arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 2 -- 1 file changed, 2 deletions(-)
arch/arm64/boot/dts/hisilicon/hi6220.dtsi +0 -2
@@ -88,8 +88,6 @@ next-level-cache = <&CLUSTER0_L2>; clocks = <&stub_clock 0>; operating-points-v2 = <&cpu_opp_table>; - cooling-min-level = <4>; - cooling-max-level = <0>; #cooling-cells = <2>; /* min followed by max */ cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; dynamic-power-coefficient = <311>;
Signature · 1 line
2.15.0.194.g9af6a3dea062
Re: [PATCH 05/10] ARM64: dts: hi6220: Remove "cooling-{min|max}-level" for CPU nodes
Hi Viresh,
Quoted 11 lines · Viresh Kumar
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of a CPU cooling device is found by referring to the cpufreq table instead.
Moreover, the entries are incorrect here as min level is 4 and the max level is 0.
Remove the unused properties from the CPU nodes.
Signed-off-by Viresh Kumar <[email protected]>---
Applied into hisilicon dt tree.
Thanks!
BR,
Wei
Quoted 17 lines
arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 2 -- 1 file changed, 2 deletions(-)arch/arm64/boot/dts/hisilicon/hi6220.dtsi +0
-2@@ -88,8 +88,6 @@ next-level-cache = <&CLUSTER0_L2>; clocks = <&stub_clock 0>; operating-points-v2 = <&cpu_opp_table>; - cooling-min-level = <4>; - cooling-max-level = <0>; #cooling-cells = <2>; /* min followed by max */ cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; dynamic-power-coefficient = <311>;
Viresh Kumar
maintainerPATCH 6/10 ARM64: dts: meson: Remove "cooling-{min|max}-level" for CPU nodes
In reply to Viresh KumarThe "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of a CPU cooling device is found by referring to the cpufreq table instead.
Remove the unused properties from the CPU nodes.
--- arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 4 ---- 1 file changed, 4 deletions(-)
arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts +0 -4
@@ -209,14 +209,10 @@ }; &cpu0 { - cooling-min-level = <0>; - cooling-max-level = <6>; #cooling-cells = <2>; }; &cpu4 { - cooling-min-level = <0>; - cooling-max-level = <4>; #cooling-cells = <2>; };
Signature · 1 line
2.15.0.194.g9af6a3dea062
Re: [PATCH 06/10] ARM64: dts: meson: Remove "cooling-{min|max}-level" for CPU nodes
Quoted 21 lines · Viresh Kumar
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of a CPU cooling device is found by referring to the cpufreq table instead.
Remove the unused properties from the CPU nodes.
Signed-off-by Viresh Kumar <[email protected]>--- arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 4 ---- 1 file changed, 4 deletions(-)arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts +0
-1@@ -209,14 +209,10 @@ }; &cpu0 { - cooling-min-level = <0>;
arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts line 218
Quoted 10 lines
arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts +0
-3- cooling-max-level = <6>; #cooling-cells = <2>; }; &cpu4 { - cooling-min-level = <0>; - cooling-max-level = <4>; #cooling-cells = <2>; };
Viresh Kumar
maintainerRe: [PATCH 06/10] ARM64: dts: meson: Remove "cooling-{min|max}-level" for CPU nodes
Quoted 25 lines · Neil Armstrong
Quoted 24 lines · Viresh Kumar
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of a CPU cooling device is found by referring to the cpufreq table instead.
Remove the unused properties from the CPU nodes.
Signed-off-by Viresh Kumar <[email protected]>--- arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 4 ---- 1 file changed, 4 deletions(-)arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts +0
-2@@ -209,14 +209,10 @@ }; &cpu0 { - cooling-min-level = <0>; - cooling-max-level = <6>; #cooling-cells = <2>; };
Quoted 9 lines
arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts line 218
Quoted 7 lines
arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts +0
-2&cpu4 { - cooling-min-level = <0>; - cooling-max-level = <4>; #cooling-cells = <2>; };Acked-by Neil Armstrong <[email protected]>
Is Kevin going to apply these for 4.17 ?
Signature · 1 line
viresh
Viresh Kumar
maintainerRe: [PATCH 06/10] ARM64: dts: meson: Remove "cooling-{min|max}-level" for CPU nodes
In reply to Viresh KumarQuoted 10 lines · Viresh Kumar
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of a CPU cooling device is found by referring to the cpufreq table instead.
Remove the unused properties from the CPU nodes.
Signed-off-by Viresh Kumar <[email protected]>--- arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 4 ---- 1 file changed, 4 deletions(-)
@Arnd: Can you please pick this and patch 8/10 from this series for 4.17 ? Both are already Acked by Neil. I have just re-bounced both the messages to arm at kernel.org. Thanks.
--
viresh
Re: [PATCH 06/10] ARM64: dts: meson: Remove "cooling-{min|max}-level" for CPU nodes
Quoted 7 lines · Viresh Kumar
Quoted 6 lines · Viresh Kumar
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of a CPU cooling device is found by referring to the cpufreq table instead.
Remove the unused properties from the CPU nodes.
Quoted 8 lines
Quoted 4 lines
Signed-off-by Viresh Kumar <[email protected]>--- arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 4 ---- 1 file changed, 4 deletions(-)@Arnd: Can you please pick this and patch 8/10 from this series for 4.17 ? Both are already Acked by Neil. I have just re-bounced both the messages to arm at kernel.org. Thanks.
Picked up patches 6, 7 and 8 now. For some reason I didn't see patch 8 in my arm at kernel.org inbox, but I found it on the mailing list.
Arnd
Viresh Kumar
maintainerPATCH 7/10 ARM: dts: gemini: Remove "cooling-{min|max}-level" for gpio-fan node
In reply to Viresh KumarThe "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of gpio-fan cooling device is found by referring to the "gpio-fan,speed-map" instead.
Remove the unused properties from the gpio-fan node.
--- arch/arm/boot/dts/gemini-dlink-dns-313.dts | 2 -- 1 file changed, 2 deletions(-)
arch/arm/boot/dts/gemini-dlink-dns-313.dts +0 -2
@@ -78,8 +78,6 @@ gpios = <&gpio0 11 GPIO_ACTIVE_HIGH>, <&gpio0 12 GPIO_ACTIVE_HIGH>; gpio-fan,speed-map = <0 0>, <3000 1>, <6000 2>; - cooling-min-level = <0>; - cooling-max-level = <2>; #cooling-cells = <2>; };
Signature · 1 line
2.15.0.194.g9af6a3dea062
Viresh Kumar
maintainerRe: [PATCH 07/10] ARM: dts: gemini: Remove "cooling-{min|max}-level" for gpio-fan node
Quoted 17 lines · Viresh Kumar
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of gpio-fan cooling device is found by referring to the "gpio-fan,speed-map" instead.
Remove the unused properties from the gpio-fan node.
Signed-off-by Viresh Kumar <[email protected]>--- arch/arm/boot/dts/gemini-dlink-dns-313.dts | 2 -- 1 file changed, 2 deletions(-)arch/arm/boot/dts/gemini-dlink-dns-313.dts +0
-0
arch/arm/boot/dts/gemini-dlink-dns-313.dts line 83
Quoted 8 lines
arch/arm/boot/dts/gemini-dlink-dns-313.dts +0
-2@@ -78,8 +78,6 @@ gpios = <&gpio0 11 GPIO_ACTIVE_HIGH>, <&gpio0 12 GPIO_ACTIVE_HIGH>; gpio-fan,speed-map = <0 0>, <3000 1>, <6000 2>; - cooling-min-level = <0>; - cooling-max-level = <2>; #cooling-cells = <2>; };
@Linus: Can you please pick this one for 4.17 ?
Signature · 1 line
viresh
Viresh Kumar
maintainerRe: [PATCH 07/10] ARM: dts: gemini: Remove "cooling-{min|max}-level" for gpio-fan node
Quoted 13 lines · Viresh Kumar
Quoted 12 lines · Viresh Kumar
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of gpio-fan cooling device is found by referring to the "gpio-fan,speed-map" instead.
Remove the unused properties from the gpio-fan node.
Signed-off-by Viresh Kumar <[email protected]>--- arch/arm/boot/dts/gemini-dlink-dns-313.dts | 2 -- 1 file changed, 2 deletions(-)
Quoted 15 lines
arch/arm/boot/dts/gemini-dlink-dns-313.dts line 83
Quoted 13 lines
arch/arm/boot/dts/gemini-dlink-dns-313.dts +0
-2@@ -78,8 +78,6 @@ gpios = <&gpio0 11 GPIO_ACTIVE_HIGH>, <&gpio0 12 GPIO_ACTIVE_HIGH>; gpio-fan,speed-map = <0 0>, <3000 1>, <6000 2>; - cooling-min-level = <0>; - cooling-max-level = <2>; #cooling-cells = <2>; };@Linus: Can you please pick this one for 4.17 ?
@Arnd/Olof: Can you please pick this one up as well ?
Signature · 1 line
viresh
Re: [PATCH 07/10] ARM: dts: gemini: Remove "cooling-{min|max}-level" for gpio-fan node
In reply to Viresh KumarQuoted 8 lines · Viresh Kumar
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of gpio-fan cooling device is found by referring to the "gpio-fan,speed-map" instead.
Remove the unused properties from the gpio-fan node.
Signed-off-by Viresh Kumar <[email protected]>
I can queue it next week (different machine hosting the git tree) but it is also OK if the ARM SoC maintainers want to pick it directly for the ARM SoC DTS branch.
Yours,
Linus Walleij
Arnd Bergmann
AppliedRe: [PATCH 07/10] ARM: dts: gemini: Remove "cooling-{min|max}-level" for gpio-fan node
Quoted 9 lines · Linus Walleij
Quoted 7 lines · Viresh Kumar
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of gpio-fan cooling device is found by referring to the "gpio-fan,speed-map" instead.
Remove the unused properties from the gpio-fan node.
Quoted 7 lines
Quoted 1 line
Signed-off-by Viresh Kumar <[email protected]>Acked-by Linus Walleij <[email protected]>I can queue it next week (different machine hosting the git tree) but it is also OK if the ARM SoC maintainers want to pick it directly for the ARM SoC DTS branch.
I've picked it up directly now, as we're about to run out of time before the merge window.
Arnd
Re: [PATCH 07/10] ARM: dts: gemini: Remove "cooling-{min|max}-level" for gpio-fan node
Quoted 12 lines · Arnd Bergmann
Quoted 11 lines · Linus Walleij
Quoted 8 lines · Viresh Kumar
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of gpio-fan cooling device is found by referring to the "gpio-fan,speed-map" instead.
Remove the unused properties from the gpio-fan node.
Signed-off-by Viresh Kumar <[email protected]>
Quoted 8 lines
Quoted 5 lines
Acked-by Linus Walleij <[email protected]>I can queue it next week (different machine hosting the git tree) but it is also OK if the ARM SoC maintainers want to pick it directly for the ARM SoC DTS branch.
I've picked it up directly now, as we're about to run out of time before the merge window.
Thanks, I was just about to queue it and send a pull request but now I don't need to :)
Yours,
Linus Walleij
Viresh Kumar
maintainerPATCH 8/10 ARM64: dts: meson: Remove "cooling-{min|max}-level" for gpio-fan node
In reply to Viresh KumarThe "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of gpio-fan cooling device is found by referring to the "gpio-fan,speed-map" instead.
Remove the unused properties from the gpio-fan node.
--- arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 2 -- 1 file changed, 2 deletions(-)
arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts +0 -2
@@ -59,8 +59,6 @@ 1 1 2 2 3 3>; - cooling-min-level = <0>; - cooling-max-level = <3>; #cooling-cells = <2>; };
Signature · 1 line
2.15.0.194.g9af6a3dea062
Re: [PATCH 08/10] ARM64: dts: meson: Remove "cooling-{min|max}-level" for gpio-fan node
Quoted 18 lines · Viresh Kumar
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of the kernel currently and the max cooling state of gpio-fan cooling device is found by referring to the "gpio-fan,speed-map" instead.
Remove the unused properties from the gpio-fan node.
Signed-off-by Viresh Kumar <[email protected]>--- arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 2 -- 1 file changed, 2 deletions(-)arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts +0
-0
arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts line 64
Quoted 8 lines
arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts +0
-2@@ -59,8 +59,6 @@ 1 1 2 2 3 3>; - cooling-min-level = <0>; - cooling-max-level = <3>; #cooling-cells = <2>; };
Viresh Kumar
maintainerPATCH 9/10 dt-bindings: cpufreq-dt: Remove "cooling-{min|max}-level" properties
In reply to Viresh KumarThe "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of kernel currently and the max cooling state of a CPU cooling device is found by referring to the cpufreq table instead.
Remove the unused bindings.
--- Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt | 4 ---- 1 file changed, 4 deletions(-)
Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt +0 -4
@@ -18,8 +18,6 @@ under node /cpus/cpu at 0. in unit of nanoseconds. - voltage-tolerance: Specify the CPU voltage tolerance in percentage. - #cooling-cells: -- cooling-min-level: -- cooling-max-level: Please refer to Documentation/devicetree/bindings/thermal/thermal.txt. Examples:
@@ -40,8 +38,6 @@ cpus { >; clock-latency = <61036>; /* two CLK32 periods */ #cooling-cells = <2>; - cooling-min-level = <0>; - cooling-max-level = <2>; }; cpu at 1 {
Signature · 1 line
2.15.0.194.g9af6a3dea062
Re: [PATCH 09/10] dt-bindings: cpufreq-dt: Remove "cooling-{min|max}-level" properties
Quoted 10 lines · Viresh Kumar
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of kernel currently and the max cooling state of a CPU cooling device is found by referring to the cpufreq table instead.
Remove the unused bindings.
Signed-off-by Viresh Kumar <[email protected]>--- Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt | 4 ---- 1 file changed, 4 deletions(-)
Viresh Kumar
maintainerPATCH 10/10 dt-bindings: thermal: Remove "cooling-{min|max}-level" properties
In reply to Viresh KumarThe "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of kernel currently and the max cooling state of a CPU cooling device is found by referring to the cpufreq table instead.
Remove the unused bindings.
--- Documentation/devicetree/bindings/thermal/thermal.txt | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-)
Documentation/devicetree/bindings/thermal/thermal.txt +1 -15
@@ -55,8 +55,7 @@ of heat dissipation). For example a fan's cooling states correspond to the different fan speeds possible. Cooling states are referred to by single unsigned integers, where larger numbers mean greater heat dissipation. The precise set of cooling states associated with a device -(as referred to by the cooling-min-level and cooling-max-level -properties) should be defined in a particular device's binding. +should be defined in a particular device's binding. For more examples of cooling devices, refer to the example sections below. Required properties:
@@ -69,15 +68,6 @@ For more examples of cooling devices, refer to the example sections below. See Cooling device maps section below for more details on how consumers refer to cooling devices. -Optional properties: -- cooling-min-level: An integer indicating the smallest - Type: unsigned cooling state accepted. Typically 0. - Size: one cell - -- cooling-max-level: An integer indicating the largest - Type: unsigned cooling state accepted. - Size: one cell - * Trip points The trip node is a node to describe a point in the temperature domain
@@ -226,8 +216,6 @@ cpus { 396000 950000 198000 850000 >; - cooling-min-level = <0>; - cooling-max-level = <3>; #cooling-cells = <2>; /* min followed by max */ }; ...
@@ -241,8 +229,6 @@ cpus { */ fan0: fan at 48 { ... - cooling-min-level = <0>; - cooling-max-level = <9>; #cooling-cells = <2>; /* min followed by max */ }; };
Signature · 1 line
2.15.0.194.g9af6a3dea062
Rob Herring
maintainerRe: [PATCH 10/10] dt-bindings: thermal: Remove "cooling-{min|max}-level" properties
Quoted 3 lines · Viresh Kumar
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of kernel currently and the max cooling state of a CPU cooling device is found by referring to the cpufreq table instead.
What about non-CPU devices? A fan for example.
Quoted 59 lines
Remove the unused bindings.
Signed-off-by Viresh Kumar <[email protected]>--- Documentation/devicetree/bindings/thermal/thermal.txt | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-)Documentation/devicetree/bindings/thermal/thermal.txt +1
-15@@ -55,8 +55,7 @@ of heat dissipation). For example a fan's cooling states correspond to the different fan speeds possible. Cooling states are referred to by single unsigned integers, where larger numbers mean greater heat dissipation. The precise set of cooling states associated with a device -(as referred to by the cooling-min-level and cooling-max-level -properties) should be defined in a particular device's binding. +should be defined in a particular device's binding. For more examples of cooling devices, refer to the example sections below. Required properties:@@ -69,15 +68,6 @@ For more examples of cooling devices, refer to the example sections below. See Cooling device maps section below for more details on how consumers refer to cooling devices. -Optional properties: -- cooling-min-level: An integer indicating the smallest - Type: unsigned cooling state accepted. Typically 0. - Size: one cell - -- cooling-max-level: An integer indicating the largest - Type: unsigned cooling state accepted. - Size: one cell - * Trip points The trip node is a node to describe a point in the temperature domain@@ -226,8 +216,6 @@ cpus { 396000 950000 198000 850000 >; - cooling-min-level = <0>; - cooling-max-level = <3>; #cooling-cells = <2>; /* min followed by max */ };@@ -241,8 +229,6 @@ cpus { */ fan0: fan at 48 { - cooling-min-level = <0>; - cooling-max-level = <9>; #cooling-cells = <2>; /* min followed by max */ }; };Signature · 1 line
2.15.0.194.g9af6a3dea062
Viresh Kumar
maintainerRe: [PATCH 10/10] dt-bindings: thermal: Remove "cooling-{min|max}-level" properties
Quoted 6 lines · Rob Herring
Quoted 3 lines · Viresh Kumar
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of kernel currently and the max cooling state of a CPU cooling device is found by referring to the cpufreq table instead.
What about non-CPU devices? A fan for example.
Even they aren't using these properties. The gpio-fan binding[1] for example uses the "gpio-fan,speed-map" property instead to find the number of states it supports.
Signature · 3 lines
viresh [1] Documentation/devicetree/bindings/gpio/gpio-fan.txt
Re: [PATCH 10/10] dt-bindings: thermal: Remove "cooling-{min|max}-level" properties
Quoted 11 lines · Viresh Kumar
Quoted 6 lines · Rob Herring
Quoted 3 lines · Viresh Kumar
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of kernel currently and the max cooling state of a CPU cooling device is found by referring to the cpufreq table instead.
What about non-CPU devices? A fan for example.
Even they aren't using these properties. The gpio-fan binding[1] for example uses the "gpio-fan,speed-map" property instead to find the number of states it supports.
Okay.
Viresh Kumar
maintainerRe: [PATCH 10/10] dt-bindings: thermal: Remove "cooling-{min|max}-level" properties
In reply to Viresh KumarQuoted 10 lines · Viresh Kumar
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of kernel currently and the max cooling state of a CPU cooling device is found by referring to the cpufreq table instead.
Remove the unused bindings.
Signed-off-by Viresh Kumar <[email protected]>--- Documentation/devicetree/bindings/thermal/thermal.txt | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-)
@Zhang/Eduardo: Can you please pick this patch (10/10) as almost everything else is already lined up for 4.17 ?
Signature · 1 line
viresh
Zhang Rui
reviewerRe: [PATCH 10/10] dt-bindings: thermal: Remove "cooling-{min|max}-level" properties
Quoted 10 lines · Viresh Kumar
Quoted 9 lines · Viresh Kumar
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of kernel currently and the max cooling state of a
CPU cooling device is found by referring to the cpufreq table instead.Remove the unused bindings.
Quoted 8 lines
Quoted 5 lines
Signed-off-by Viresh Kumar <[email protected]>---
?Documentation/devicetree/bindings/thermal/thermal.txt | 16 +----
-----------
?1 file changed, 1 insertion(+), 15 deletions(-)@Zhang/Eduardo: Can you please pick this patch (10/10) as almost everything else
is already lined up for 4.17 ?
I think Eduardo should have reviewed all the DT thermal patches in the list, but I didn't see his response about this one.
Eduardo,
did you miss this one?
thanks,
rui
Quoted 1 line
Re: [PATCH 10/10] dt-bindings: thermal: Remove "cooling-{min|max}-level" properties
Quoted 20 lines · Zhang Rui
Quoted 10 lines · Viresh Kumar
Quoted 9 lines · Viresh Kumar
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of kernel currently and the max cooling state of a
CPU cooling device is found by referring to the cpufreq table instead.Remove the unused bindings.
Quoted 8 lines
Quoted 5 lines
Signed-off-by Viresh Kumar <[email protected]>---
?Documentation/devicetree/bindings/thermal/thermal.txt | 16 +----
-----------
?1 file changed, 1 insertion(+), 15 deletions(-)@Zhang/Eduardo: Can you please pick this patch (10/10) as almost everything else
is already lined up for 4.17 ?
Quoted 5 lines
I think Eduardo should have reviewed all the DT thermal patches in the list, but I didn't see his response about this one.
Eduardo,
did you miss this one?
just applied and sending it in my pull request.
Quoted 4 lines
thanks,
ruiQuoted 1 line