Skip to contentSkip to conversation

auxdisplay for v4.16-rc6

GIT PULL Miguel Ojeda 2 participants 3 messages Mar 13, 2018 – Mar 14, 2018

lore
Share & tools
lore
#0 lore raw

Hi Linus,

Please pull these small changes to silence a few warnings in auxdisplay.

This is my first pull request, so if there is anything wrong, please let me know!

Also, note that for the moment my PGP/GPG key is only signed by 2 other kernel maintainers and that we did it over email/Skype. I used GitHub as well for the same reason.

Cheers,
Miguel Ojeda

The following changes since commit 0c8efd610b58cb23cefdfa12015799079aef94ae:

Linux 4.16-rc5 (2018-03-11 17:25:09 -0700)

are available in the git repository at:

https://github.com/ojeda/linux.git tags/auxdisplay-for-linus-v4.16-rc6

for you to fetch changes up to 26a2c54d03bd514fb3d3520706f911b3ca56b011:

auxdisplay: img-ascii-lcd: Silence 2 uninitialized warnings (2018-03-13 18:16:38 +0100)

----------------------------------------------------------------
Silence a few warnings in auxdisplay.

- A couple of uninitialized warnings reported by the build service.

- A doc comment warning under W=1.

- Three fall through comments not recognized under W=1.

----------------------------------------------------------------
Miguel Ojeda (3):
auxdisplay: panel: Change comments to silence fallthrough warnings
auxdisplay: img-ascii-lcd: Fix doc comment to silence warnings
auxdisplay: img-ascii-lcd: Silence 2 uninitialized warnings

 drivers/auxdisplay/img-ascii-lcd.c | 6 +++---
 drivers/auxdisplay/panel.c         | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)
#1 lore raw
Quoted 3 lines · Miguel Ojeda

This is my first pull request, so if there is anything wrong, please let me know!

The commits in there looks fine, but I have to admit to not being super-happy about it. They are recently rebased, and looking around in the logs you've been gone for the last eight years.

Quoted 3 lines

Also, note that for the moment my PGP/GPG key is only signed by 2 other kernel maintainers and that we did it over email/Skype. I used GitHub as well for the same reason.

Ok, I see Linus Walleij's signature there, and the individual commits look trivially correct, so I'm pulling it, but with a bit of grumbling about the timing.

Linus

#2 lore raw
Quoted 9 lines · Linus Torvalds
Quoted 3 lines · Miguel Ojeda

This is my first pull request, so if there is anything wrong, please let me know!

The commits in there looks fine, but I have to admit to not being super-happy about it. They are recently rebased, and looking around in the logs you've been gone for the last eight years.

Yeah, I came back a couple of months ago. The story is long and boring, but basically drivers/auxdisplay/ came to be due to my submission of a driver more than 10 years ago. Due to that I was made maintainer of that folder with that driver alone (so maintainer of myself! :-).

Later I started university and after all those wild years, it seems the folder grew without me noticing. I attribute this due to my change of gmail account, plus my own stupidity when setting up the email filters in the new account. I don't recall anymore, but the filters were wrong when I checked two months ago anyway, so I have to blame myself.

So when two months ago I searched for "auxdisplay" by chance, and noticed there were dozens of matches, I opened my eyes wide in disbelief, panicked a couple of seconds, then I sighed a lot, and then started going one email by one... :-)

I have a few things from different people that I have to send in the next merge window. But since I had never sent stuff before, and didn't want to screw things in the next merge window, I thought that the best approach was to do my first PR now with some trivial changes and see if everything is alright (also, one of them fixes the warnings from the build service, so we get that cleaned up as well).

The author dates are real, though: I started them when I was reorganizing myself a few weeks ago. I hope that explains it the disparity... And indeed, I rebased them before sending them to have them on top of -rc5.

Quoted 8 lines
Quoted 4 lines

Also, note that for the moment my PGP/GPG key is only signed by 2 other kernel maintainers and that we did it over email/Skype. I used GitHub as well for the same reason.

Ok, I see Linus Walleij's signature there, and the individual commits look trivially correct, so I'm pulling it, but with a bit of grumbling about the timing.

Yep, Willy Tarreau & Linus Walleij should be there. I contacted a few others and they agreed to sign it, but they preferred to do so in person. I could have other contacts to sign the key (e.g. people from CERN), but I think it has to be kernel maintainers according to kernel.org.

Thanks for the permissiveness (this time at least :-)!

Cheers,
Miguel

Quoted 2 lines

Linus