Skip to contentSkip to conversation

docker: remove unnecessary checks

PATCH In review Pascal Bach 2 participants 2 messages Mar 14, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 docker: remove unnecessary checks

The variables only take effect if the corresponding init system is enabled

---
 recipes-containers/docker/docker_git.bb | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
recipes-containers/docker/docker_git.bb +4 -4
index 5ae9211..5c21138 100644
@@ -117,13 +117,13 @@ do_compile() {
     go build -o ${S}/src/import/bundles/latest/dynbinary-client/docker github.com/docker/cli/cmd/docker
 }
 
-SYSTEMD_PACKAGES = "${@bb.utils.contains('DISTRO_FEATURES','systemd','${PN}','',d)}"
-SYSTEMD_SERVICE_${PN} = "${@bb.utils.contains('DISTRO_FEATURES','systemd','docker.service','',d)}"
+SYSTEMD_PACKAGES = "${PN}"
+SYSTEMD_SERVICE_${PN} = "docker.service"
 
 SYSTEMD_AUTO_ENABLE_${PN} = "enable"
 
-INITSCRIPT_PACKAGES += "${@bb.utils.contains('DISTRO_FEATURES','sysvinit','${PN}','',d)}"
-INITSCRIPT_NAME_${PN} = "${@bb.utils.contains('DISTRO_FEATURES','sysvinit','docker.init','',d)}"
+INITSCRIPT_PACKAGES += "${PN}"
+INITSCRIPT_NAME_${PN} = "docker.init"
 INITSCRIPT_PARAMS_${PN} = "defaults"
 
 do_install() {
Signature · 1 line
2.11.0
#1 lore raw
Quoted 1 line · Pascal Bach

The variables only take effect if the corresponding init system is enabled

Not in my experience. Can you point me to the oe-core commit that changed this behaviour ?

Bruce

Quoted 36 lines
---
 recipes-containers/docker/docker_git.bb | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
recipes-containers/docker/docker_git.bb +4 -5
index 5ae9211..5c21138 100644
@@ -117,13 +117,13 @@ do_compile() {
     go build -o ${S}/src/import/bundles/latest/dynbinary-client/docker github.com/docker/cli/cmd/docker
 }
 
-SYSTEMD_PACKAGES = "${@bb.utils.contains('DISTRO_FEATURES','systemd','${PN}','',d)}"
-SYSTEMD_SERVICE_${PN} = "${@bb.utils.contains('DISTRO_FEATURES','systemd','docker.service','',d)}"
+SYSTEMD_PACKAGES = "${PN}"
+SYSTEMD_SERVICE_${PN} = "docker.service"
 
 SYSTEMD_AUTO_ENABLE_${PN} = "enable"
 
-INITSCRIPT_PACKAGES += "${@bb.utils.contains('DISTRO_FEATURES','sysvinit','${PN}','',d)}"
-INITSCRIPT_NAME_${PN} = "${@bb.utils.contains('DISTRO_FEATURES','sysvinit','docker.init','',d)}"
+INITSCRIPT_PACKAGES += "${PN}"
+INITSCRIPT_NAME_${PN} = "docker.init"
 INITSCRIPT_PARAMS_${PN} = "defaults"
 
 do_install() {
--

2.11.0

--
_______________________________________________
meta-virtualization mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-virtualization

Signature · 2 lines
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"