Skip to contentSkip to conversation

of: unittest: fix an error code in of_unittest_apply_overlay()

PATCH Applied Dan Carpenter 2 participants 2 messages Mar 14, 2018 – Mar 18, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 of: unittest: fix an error code in of_unittest_apply_overlay()

We accidentally return zero on failure instead of a negative error code.

Fixes 39a751a4cb7e ("of: change overlay apply input data from unflattened to FDT")
drivers/of/unittest.c +2 -4
index dede77a79820..bc03902693b7 100644
@@ -1417,15 +1417,13 @@ static int __init of_unittest_apply_overlay(int overlay_nr, int unittest_nr,
 		int *overlay_id)
 {
 	const char *overlay_name;
-	int ret;
 
 	overlay_name = overlay_name_from_nr(overlay_nr);
 
-	ret = overlay_data_apply(overlay_name, overlay_id);
-	if (!ret) {
+	if (!overlay_data_apply(overlay_name, overlay_id)) {
 		unittest(0, "could not apply overlay \"%s\"\n",
 				overlay_name);
-		return ret;
+		return -EFAULT;
 	}
 	of_unittest_track_overlay(*overlay_id);
 
maintainer Applied
#1 lore raw
Quoted 4 lines · Dan Carpenter

We accidentally return zero on failure instead of a negative error code.

Fixes 39a751a4cb7e ("of: change overlay apply input data from unflattened to FDT")

Applied.

Rob