CNL port refactoring
Subsystems (2)
v3 cover CNL port refactoring
This series fixes CNL PORT_TX_DW5/7_LNO_D register address. This series also introduces macros to get register address of CNL_PORT_TX registers instead of defining for each DW instance.
changes since V1:
completely kill _MMIO_PORT6 macro
changes since V2:
use underscore prefix in macro
merge patch 1 and 2
changes since V3:
Address review comments
Mahesh Kumar (2):
drm/i915/cnl; Add macro to get PORT_TX register
drm/i915/cnl: Kill _MMIO_PORT6 macro
drivers/gpu/drm/i915/i915_reg.h | 147 ++++++++++++---------------------------- 1 file changed, 44 insertions(+), 103 deletions(-)
Signature · 6 lines
2.14.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 1/2 drm/i915/cnl; Add macro to get PORT_TX register
This patch creates a new macro to get PORT_TX register for any given DW. This removes the need of defining register address for each port & DW.
Changes since V1:
- Use underscope prefix, as macro isn't returning an mmio reg(Lucas)
- Merge patch 1 & 2 of the series
Changes since V2:
- remove _MMIO_PORT6_LN macro (Rodrigo)
--- drivers/gpu/drm/i915/i915_reg.h | 137 ++++++++++++---------------------------- 1 file changed, 39 insertions(+), 98 deletions(-)
drivers/gpu/drm/i915/i915_reg.h +39 -98
@@ -154,8 +154,6 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)#define _PLL (pll, a, b) ((a) + (pll)*((b)-(a)))#define _MMIO_PLL (pll, a, b) _MMIO(_PLL(pll, a, b))#define _MMIO_PORT6 (port, a, b, c, d, e, f) _MMIO(_PICK(port, a, b, c, d, e, f)) -#define _MMIO_PORT6_LN (port, ln, a0, a1, b, c, d, e, f) \ - _MMIO(_PICK(port, a0, b, c, d, e, f) + (ln * (a1 - a0)))#define _PHY3 (phy, ...) _PICK(phy, __VA_ARGS__)#define _MMIO_PHY3 (phy, a, b, c) _MMIO(_PHY3(phy, a, b, c))
@@ -1964,30 +1962,36 @@ enum i915_power_well_id { _CNL_PORT_PCS_DW1_LN0_F)#define COMMON_KEEPER_EN (1 << 26) -#define _CNL_PORT_TX_DW2_GRP_AE 0x162348 -#define _CNL_PORT_TX_DW2_GRP_B 0x1623C8 -#define _CNL_PORT_TX_DW2_GRP_C 0x162B48 -#define _CNL_PORT_TX_DW2_GRP_D 0x162BC8 -#define _CNL_PORT_TX_DW2_GRP_F 0x162A48 -#define _CNL_PORT_TX_DW2_LN0_AE 0x162448 -#define _CNL_PORT_TX_DW2_LN0_B 0x162648 -#define _CNL_PORT_TX_DW2_LN0_C 0x162C48 -#define _CNL_PORT_TX_DW2_LN0_D 0x162E48 -#define _CNL_PORT_TX_DW2_LN0_F 0x162848 -#define CNL_PORT_TX_DW2_GRP (port) _MMIO_PORT6(port, \ - _CNL_PORT_TX_DW2_GRP_AE, \ - _CNL_PORT_TX_DW2_GRP_B, \ - _CNL_PORT_TX_DW2_GRP_C, \ - _CNL_PORT_TX_DW2_GRP_D, \ - _CNL_PORT_TX_DW2_GRP_AE, \ - _CNL_PORT_TX_DW2_GRP_F) -#define CNL_PORT_TX_DW2_LN0 (port) _MMIO_PORT6(port, \ - _CNL_PORT_TX_DW2_LN0_AE, \ - _CNL_PORT_TX_DW2_LN0_B, \ - _CNL_PORT_TX_DW2_LN0_C, \ - _CNL_PORT_TX_DW2_LN0_D, \ - _CNL_PORT_TX_DW2_LN0_AE, \ - _CNL_PORT_TX_DW2_LN0_F) +/* CNL Port TX registers */ +#define _CNL_PORT_TX_AE_GRP_OFFSET 0x162340 +#define _CNL_PORT_TX_B_GRP_OFFSET 0x1623C0 +#define _CNL_PORT_TX_C_GRP_OFFSET 0x162B40 +#define _CNL_PORT_TX_D_GRP_OFFSET 0x162BC0 +#define _CNL_PORT_TX_F_GRP_OFFSET 0x162A40 +#define _CNL_PORT_TX_AE_LN0_OFFSET 0x162440 +#define _CNL_PORT_TX_B_LN0_OFFSET 0x162640 +#define _CNL_PORT_TX_C_LN0_OFFSET 0x162C40 +#define _CNL_PORT_TX_D_LN0_OFFSET 0x162E40 +#define _CNL_PORT_TX_F_LN0_OFFSET 0x162840 +#define _CNL_PORT_TX_DW_GRP (port, dw) (_PICK((port), \ + _CNL_PORT_TX_AE_GRP_OFFSET, \ + _CNL_PORT_TX_B_GRP_OFFSET, \ + _CNL_PORT_TX_B_GRP_OFFSET, \ + _CNL_PORT_TX_D_GRP_OFFSET, \ + _CNL_PORT_TX_AE_GRP_OFFSET, \ + _CNL_PORT_TX_F_GRP_OFFSET) + \ + 4*(dw)) +#define _CNL_PORT_TX_DW_LN0 (port, dw) (_PICK((port), \ + _CNL_PORT_TX_AE_LN0_OFFSET, \ + _CNL_PORT_TX_B_LN0_OFFSET, \ + _CNL_PORT_TX_B_LN0_OFFSET, \ + _CNL_PORT_TX_D_LN0_OFFSET, \ + _CNL_PORT_TX_AE_LN0_OFFSET, \ + _CNL_PORT_TX_F_LN0_OFFSET) + \ + 4*(dw)) + +#define CNL_PORT_TX_DW2_GRP (port) _MMIO(_CNL_PORT_TX_DW_GRP((port), 2)) +#define CNL_PORT_TX_DW2_LN0 (port) _MMIO(_CNL_PORT_TX_DW_LN0((port), 2))#define SWING_SEL_UPPER (x) ((x >> 3) << 15)#define SWING_SEL_UPPER_MASK (1 << 15)#define SWING_SEL_LOWER (x) ((x & 0x7) << 11)
@@ -1995,32 +1999,13 @@ enum i915_power_well_id {#define RCOMP_SCALAR (x) ((x) << 0)#define RCOMP_SCALAR_MASK (0xFF << 0) -#define _CNL_PORT_TX_DW4_GRP_AE 0x162350 -#define _CNL_PORT_TX_DW4_GRP_B 0x1623D0 -#define _CNL_PORT_TX_DW4_GRP_C 0x162B50 -#define _CNL_PORT_TX_DW4_GRP_D 0x162BD0 -#define _CNL_PORT_TX_DW4_GRP_F 0x162A50#define _CNL_PORT_TX_DW4_LN0_AE 0x162450#define _CNL_PORT_TX_DW4_LN1_AE 0x1624D0 -#define _CNL_PORT_TX_DW4_LN0_B 0x162650 -#define _CNL_PORT_TX_DW4_LN0_C 0x162C50 -#define _CNL_PORT_TX_DW4_LN0_D 0x162E50 -#define _CNL_PORT_TX_DW4_LN0_F 0x162850 -#define CNL_PORT_TX_DW4_GRP (port) _MMIO_PORT6(port, \ - _CNL_PORT_TX_DW4_GRP_AE, \ - _CNL_PORT_TX_DW4_GRP_B, \ - _CNL_PORT_TX_DW4_GRP_C, \ - _CNL_PORT_TX_DW4_GRP_D, \ - _CNL_PORT_TX_DW4_GRP_AE, \ - _CNL_PORT_TX_DW4_GRP_F) -#define CNL_PORT_TX_DW4_LN (port, ln) _MMIO_PORT6_LN(port, ln, \ - _CNL_PORT_TX_DW4_LN0_AE, \ - _CNL_PORT_TX_DW4_LN1_AE, \ - _CNL_PORT_TX_DW4_LN0_B, \ - _CNL_PORT_TX_DW4_LN0_C, \ - _CNL_PORT_TX_DW4_LN0_D, \ - _CNL_PORT_TX_DW4_LN0_AE, \ - _CNL_PORT_TX_DW4_LN0_F) +#define CNL_PORT_TX_DW4_GRP (port) _MMIO(_CNL_PORT_TX_DW_GRP((port), 4)) +#define CNL_PORT_TX_DW4_LN0 (port) _MMIO(_CNL_PORT_TX_DW_LN0((port), 4)) +#define CNL_PORT_TX_DW4_LN (port, ln) _MMIO(_CNL_PORT_TX_DW_LN0((port), 4) + \ + (ln * (_CNL_PORT_TX_DW4_LN1_AE - \ + _CNL_PORT_TX_DW4_LN0_AE)))#define LOADGEN_SELECT (1 << 31)#define POST_CURSOR_1 (x) ((x) << 12)#define POST_CURSOR_1_MASK (0x3F << 12)
@@ -2029,30 +2014,8 @@ enum i915_power_well_id {#define CURSOR_COEFF (x) ((x) << 0)#define CURSOR_COEFF_MASK (0x3F << 0) -#define _CNL_PORT_TX_DW5_GRP_AE 0x162354 -#define _CNL_PORT_TX_DW5_GRP_B 0x1623D4 -#define _CNL_PORT_TX_DW5_GRP_C 0x162B54 -#define _CNL_PORT_TX_DW5_GRP_D 0x162BD4 -#define _CNL_PORT_TX_DW5_GRP_F 0x162A54 -#define _CNL_PORT_TX_DW5_LN0_AE 0x162454 -#define _CNL_PORT_TX_DW5_LN0_B 0x162654 -#define _CNL_PORT_TX_DW5_LN0_C 0x162C54 -#define _CNL_PORT_TX_DW5_LN0_D 0x162E54 -#define _CNL_PORT_TX_DW5_LN0_F 0x162854 -#define CNL_PORT_TX_DW5_GRP (port) _MMIO_PORT6(port, \ - _CNL_PORT_TX_DW5_GRP_AE, \ - _CNL_PORT_TX_DW5_GRP_B, \ - _CNL_PORT_TX_DW5_GRP_C, \ - _CNL_PORT_TX_DW5_GRP_D, \ - _CNL_PORT_TX_DW5_GRP_AE, \ - _CNL_PORT_TX_DW5_GRP_F) -#define CNL_PORT_TX_DW5_LN0 (port) _MMIO_PORT6(port, \ - _CNL_PORT_TX_DW5_LN0_AE, \ - _CNL_PORT_TX_DW5_LN0_B, \ - _CNL_PORT_TX_DW5_LN0_C, \ - _CNL_PORT_TX_DW5_LN0_D, \ - _CNL_PORT_TX_DW5_LN0_AE, \ - _CNL_PORT_TX_DW5_LN0_F) +#define CNL_PORT_TX_DW5_GRP (port) _MMIO(_CNL_PORT_TX_DW_GRP((port), 5)) +#define CNL_PORT_TX_DW5_LN0 (port) _MMIO(_CNL_PORT_TX_DW_LN0((port), 5))#define TX_TRAINING_EN (1 << 31)#define TAP3_DISABLE (1 << 29)#define SCALING_MODE_SEL (x) ((x) << 18)
@@ -2060,30 +2023,8 @@ enum i915_power_well_id {#define RTERM_SELECT (x) ((x) << 3)#define RTERM_SELECT_MASK (0x7 << 3) -#define _CNL_PORT_TX_DW7_GRP_AE 0x16235C -#define _CNL_PORT_TX_DW7_GRP_B 0x1623DC -#define _CNL_PORT_TX_DW7_GRP_C 0x162B5C -#define _CNL_PORT_TX_DW7_GRP_D 0x162BDC -#define _CNL_PORT_TX_DW7_GRP_F 0x162A5C -#define _CNL_PORT_TX_DW7_LN0_AE 0x16245C -#define _CNL_PORT_TX_DW7_LN0_B 0x16265C -#define _CNL_PORT_TX_DW7_LN0_C 0x162C5C -#define _CNL_PORT_TX_DW7_LN0_D 0x162E5C -#define _CNL_PORT_TX_DW7_LN0_F 0x16285C -#define CNL_PORT_TX_DW7_GRP (port) _MMIO_PORT6(port, \ - _CNL_PORT_TX_DW7_GRP_AE, \ - _CNL_PORT_TX_DW7_GRP_B, \ - _CNL_PORT_TX_DW7_GRP_C, \ - _CNL_PORT_TX_DW7_GRP_D, \ - _CNL_PORT_TX_DW7_GRP_AE, \ - _CNL_PORT_TX_DW7_GRP_F) -#define CNL_PORT_TX_DW7_LN0 (port) _MMIO_PORT6(port, \ - _CNL_PORT_TX_DW7_LN0_AE, \ - _CNL_PORT_TX_DW7_LN0_B, \ - _CNL_PORT_TX_DW7_LN0_C, \ - _CNL_PORT_TX_DW7_LN0_D, \ - _CNL_PORT_TX_DW7_LN0_AE, \ - _CNL_PORT_TX_DW7_LN0_F) +#define CNL_PORT_TX_DW7_GRP (port) _MMIO(_CNL_PORT_TX_DW_GRP((port), 7)) +#define CNL_PORT_TX_DW7_LN0 (port) _MMIO(_CNL_PORT_TX_DW_LN0((port), 7))#define N_SCALAR (x) ((x) << 24)#define N_SCALAR_MASK (0x7F << 24)
Signature · 6 lines
2.14.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v4 1/2] drm/i915/cnl; Add macro to get PORT_TX register
Quoted 9 lines
-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Mahesh Kumar
Sent: Wednesday, March 14, 2018 1:37 PM
To: [email protected]
Cc: De Marchi, Lucas <[email protected]>; Vivi, Rodrigo <[email protected]>
Subject: [Intel-gfx] [PATCH v4 1/2] drm/i915/cnl; Add macro to getPORT_TXregister
Looks typo. Replace ";" with ":" in commit header.
Quoted 93 lines
This patch creates a new macro to get
PORT_TXregister for any given DW. This removes the need of defining register address for each port & DW.Changes since V1:
- Use underscope prefix, as macro isn't returning an mmio reg(Lucas)
- Merge patch 1 & 2 of the series
Changes since V2:
- remove_MMIO_PORT6_LNmacro (Rodrigo)Signed-off-by Mahesh Kumar <[email protected]>Reviewed-by Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/i915_reg.h | 137 ++++++++++++---------------------------- 1 file changed, 39 insertions(+), 98 deletions(-)(quoted diff) +0
-0
b/drivers/gpu/drm/i915/i915_reg.hindexe8e912f08e22..095833af2f81100644drivers/gpu/drm/i915/i915_reg.h +0
-22@@ -154,8 +154,6 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg) #define _PLL(pll, a, b) ((a) + (pll)*((b)-(a))) #define _MMIO_PLL(pll, a, b) _MMIO(_PLL(pll, a, b)) #define _MMIO_PORT6(port, a, b, c, d, e, f) _MMIO(_PICK(port, a, b, c, d, e, f)) -#define _MMIO_PORT6_LN (port, ln, a0, a1, b, c, d, e, f) \ - _MMIO(_PICK(port, a0, b, c, d, e, f) + (ln * (a1 - a0))) #define _PHY3(phy, ...) _PICK(phy, __VA_ARGS__) #define _MMIO_PHY3(phy, a, b, c) _MMIO(_PHY3(phy, a, b, c))@@ -1964,30 +1962,36 @@ enum i915_power_well_id { _CNL_PORT_PCS_DW1_LN0_F)#define COMMON_KEEPER_EN (1 << 26) -#define _CNL_PORT_TX_DW2_GRP_AE 0x162348 -#define _CNL_PORT_TX_DW2_GRP_B 0x1623C8 -#define _CNL_PORT_TX_DW2_GRP_C 0x162B48 -#define _CNL_PORT_TX_DW2_GRP_D 0x162BC8 -#define _CNL_PORT_TX_DW2_GRP_F 0x162A48 -#define _CNL_PORT_TX_DW2_LN0_AE 0x162448 -#define _CNL_PORT_TX_DW2_LN0_B 0x162648 -#define _CNL_PORT_TX_DW2_LN0_C 0x162C48 -#define _CNL_PORT_TX_DW2_LN0_D 0x162E48 -#define _CNL_PORT_TX_DW2_LN0_F 0x162848 -#define CNL_PORT_TX_DW2_GRP (port) _MMIO_PORT6(port, \ - _CNL_PORT_TX_DW2_GRP_AE, \ - _CNL_PORT_TX_DW2_GRP_B, \ - _CNL_PORT_TX_DW2_GRP_C, \ - _CNL_PORT_TX_DW2_GRP_D, \ - _CNL_PORT_TX_DW2_GRP_AE, \ - _CNL_PORT_TX_DW2_GRP_F) -#define CNL_PORT_TX_DW2_LN0(port) _MMIO_PORT6(port, \ - _CNL_PORT_TX_DW2_LN0_AE, \ -
_CNL_PORT_TX_DW2_LN0_B, \
-_CNL_PORT_TX_DW2_LN0_C, \
-_CNL_PORT_TX_DW2_LN0_D, \
-_CNL_PORT_TX_DW2_LN0_AE, \
-_CNL_PORT_TX_DW2_LN0_F)drivers/gpu/drm/i915/i915_reg.h +13
-0+/* CNL Port TX registers */ +#define _CNL_PORT_TX_AE_GRP_OFFSET 0x162340 +#define _CNL_PORT_TX_B_GRP_OFFSET 0x1623C0 +#define _CNL_PORT_TX_C_GRP_OFFSET 0x162B40 +#define _CNL_PORT_TX_D_GRP_OFFSET 0x162BC0 +#define _CNL_PORT_TX_F_GRP_OFFSET 0x162A40 +#define _CNL_PORT_TX_AE_LN0_OFFSET 0x162440 +#define _CNL_PORT_TX_B_LN0_OFFSET 0x162640 +#define _CNL_PORT_TX_C_LN0_OFFSET 0x162C40 +#define _CNL_PORT_TX_D_LN0_OFFSET 0x162E40 +#define _CNL_PORT_TX_F_LN0_OFFSET 0x162840 +#define _CNL_PORT_TX_DW_GRP (port, dw) (_PICK((port), \ + _CNL_PORT_TX_AE_GRP_OFFSET,\
drivers/gpu/drm/i915/i915_reg.h +4
-0+ _CNL_PORT_TX_B_GRP_OFFSET, \ + _CNL_PORT_TX_B_GRP_OFFSET, \ + _CNL_PORT_TX_D_GRP_OFFSET, \ + _CNL_PORT_TX_AE_GRP_OFFSET,\
drivers/gpu/drm/i915/i915_reg.h +1
-0+ _CNL_PORT_TX_F_GRP_OFFSET) +\
drivers/gpu/drm/i915/i915_reg.h
Quoted 1 line
drivers/gpu/drm/i915/i915_reg.h +1
-0+ 4*(dw))
Add space before and after "*" here and other places in you patch. With these fixes,
Regards,
Madhav
Quoted 170 lines
drivers/gpu/drm/i915/i915_reg.h +2
-0+#define _CNL_PORT_TX_DW_LN0 (port, dw) (_PICK((port), \ + _CNL_PORT_TX_AE_LN0_OFFSET,\
drivers/gpu/drm/i915/i915_reg.h +4
-0+ _CNL_PORT_TX_B_LN0_OFFSET, \ + _CNL_PORT_TX_B_LN0_OFFSET, \ + _CNL_PORT_TX_D_LN0_OFFSET, \ + _CNL_PORT_TX_AE_LN0_OFFSET,\
drivers/gpu/drm/i915/i915_reg.h +1
-0+ _CNL_PORT_TX_F_LN0_OFFSET) +\
drivers/gpu/drm/i915/i915_reg.h +3
-0+ 4*(dw)) + +#define CNL_PORT_TX_DW2_GRP (port)_MMIO(_CNL_PORT_TX_DW_GRP((port), 2)) +#define CNL_PORT_TX_DW2_LN0(port) _MMIO(_CNL_PORT_TX_DW_LN0((port), 2)) #define SWING_SEL_UPPER(x) ((x >> 3) << 15) #define SWING_SEL_UPPER_MASK (1 << 15) #define SWING_SEL_LOWER(x) ((x & 0x7) << 11)drivers/gpu/drm/i915/i915_reg.h +0
-19@@ -1995,32 +1999,13 @@ enum i915_power_well_id {#define RCOMP_SCALAR (x) ((x) << 0)#define RCOMP_SCALAR_MASK (0xFF << 0) -#define _CNL_PORT_TX_DW4_GRP_AE 0x162350 -#define _CNL_PORT_TX_DW4_GRP_B 0x1623D0 -#define _CNL_PORT_TX_DW4_GRP_C 0x162B50 -#define _CNL_PORT_TX_DW4_GRP_D 0x162BD0 -#define _CNL_PORT_TX_DW4_GRP_F 0x162A50#define _CNL_PORT_TX_DW4_LN0_AE 0x162450#define _CNL_PORT_TX_DW4_LN1_AE 0x1624D0 -#define _CNL_PORT_TX_DW4_LN0_B 0x162650 -#define _CNL_PORT_TX_DW4_LN0_C 0x162C50 -#define _CNL_PORT_TX_DW4_LN0_D 0x162E50 -#define _CNL_PORT_TX_DW4_LN0_F 0x162850 -#define CNL_PORT_TX_DW4_GRP (port) _MMIO_PORT6(port, \ - _CNL_PORT_TX_DW4_GRP_AE, \ - _CNL_PORT_TX_DW4_GRP_B, \ - _CNL_PORT_TX_DW4_GRP_C, \ - _CNL_PORT_TX_DW4_GRP_D, \ - _CNL_PORT_TX_DW4_GRP_AE, \ - _CNL_PORT_TX_DW4_GRP_F) -#define CNL_PORT_TX_DW4_LN(port, ln) _MMIO_PORT6_LN(port, ln, \ - _CNL_PORT_TX_DW4_LN0_AE, \ -
_CNL_PORT_TX_DW4_LN1_AE, \
-_CNL_PORT_TX_DW4_LN0_B, \
-_CNL_PORT_TX_DW4_LN0_C, \
-_CNL_PORT_TX_DW4_LN0_D, \
-_CNL_PORT_TX_DW4_LN0_AE, \
-_CNL_PORT_TX_DW4_LN0_F)
+#defineCNL_PORT_TX_DW4_GRP(port)_MMIO(_CNL_PORT_TX_DW_GRP((port), 4)) +#define CNL_PORT_TX_DW4_LN0(port) _MMIO(_CNL_PORT_TX_DW_LN0((port), 4))+#define
CNL_PORT_TX_DW4_LN(port, ln)
_MMIO(_CNL_PORT_TX_DW_LN0((port), 4) + \drivers/gpu/drm/i915/i915_reg.h +1
-0+ (ln *(
_CNL_PORT_TX_DW4_LN1_AE- \
+_CNL_PORT_TX_DW4_LN0_AE)))#define LOADGEN_SELECT (1 << 31) #define POST_CURSOR_1(x) ((x) << 12) #define POST_CURSOR_1_MASK (0x3F << 12)drivers/gpu/drm/i915/i915_reg.h +0
-17@@ -2029,30 +2014,8 @@ enum i915_power_well_id {#define CURSOR_COEFF (x) ((x) << 0)#define CURSOR_COEFF_MASK (0x3F << 0) -#define _CNL_PORT_TX_DW5_GRP_AE 0x162354 -#define _CNL_PORT_TX_DW5_GRP_B 0x1623D4 -#define _CNL_PORT_TX_DW5_GRP_C 0x162B54 -#define _CNL_PORT_TX_DW5_GRP_D 0x162BD4 -#define _CNL_PORT_TX_DW5_GRP_F 0x162A54 -#define _CNL_PORT_TX_DW5_LN0_AE 0x162454 -#define _CNL_PORT_TX_DW5_LN0_B 0x162654 -#define _CNL_PORT_TX_DW5_LN0_C 0x162C54 -#define _CNL_PORT_TX_DW5_LN0_D 0x162E54 -#define _CNL_PORT_TX_DW5_LN0_F 0x162854 -#define CNL_PORT_TX_DW5_GRP (port) _MMIO_PORT6(port, \ - _CNL_PORT_TX_DW5_GRP_AE, \ - _CNL_PORT_TX_DW5_GRP_B, \ - _CNL_PORT_TX_DW5_GRP_C, \ - _CNL_PORT_TX_DW5_GRP_D, \ - _CNL_PORT_TX_DW5_GRP_AE, \ -
_CNL_PORT_TX_DW5_GRP_F)drivers/gpu/drm/i915/i915_reg.h +0
-2-#define CNL_PORT_TX_DW5_LN0 (port) _MMIO_PORT6(port, \ -
_CNL_PORT_TX_DW5_LN0_AE, \
-_CNL_PORT_TX_DW5_LN0_B, \
-_CNL_PORT_TX_DW5_LN0_C, \
-_CNL_PORT_TX_DW5_LN0_D, \
-_CNL_PORT_TX_DW5_LN0_AE, \
-_CNL_PORT_TX_DW5_LN0_F)
+#defineCNL_PORT_TX_DW5_GRP(port)_MMIO(_CNL_PORT_TX_DW_GRP((port), 5)) +#define CNL_PORT_TX_DW5_LN0(port) _MMIO(_CNL_PORT_TX_DW_LN0((port), 5)) #define TX_TRAINING_EN (1 << 31) #define TAP3_DISABLE (1 << 29) #define SCALING_MODE_SEL(x) ((x) << 18)drivers/gpu/drm/i915/i915_reg.h +0
-17@@ -2060,30 +2023,8 @@ enum i915_power_well_id {#define RTERM_SELECT (x) ((x) << 3)#define RTERM_SELECT_MASK (0x7 << 3) -#define _CNL_PORT_TX_DW7_GRP_AE 0x16235C -#define _CNL_PORT_TX_DW7_GRP_B 0x1623DC -#define _CNL_PORT_TX_DW7_GRP_C 0x162B5C -#define _CNL_PORT_TX_DW7_GRP_D 0x162BDC -#define _CNL_PORT_TX_DW7_GRP_F 0x162A5C -#define _CNL_PORT_TX_DW7_LN0_AE 0x16245C -#define _CNL_PORT_TX_DW7_LN0_B 0x16265C -#define _CNL_PORT_TX_DW7_LN0_C 0x162C5C -#define _CNL_PORT_TX_DW7_LN0_D 0x162E5C -#define _CNL_PORT_TX_DW7_LN0_F 0x16285C -#define CNL_PORT_TX_DW7_GRP (port) _MMIO_PORT6(port, \ - _CNL_PORT_TX_DW7_GRP_AE, \ - _CNL_PORT_TX_DW7_GRP_B, \ - _CNL_PORT_TX_DW7_GRP_C, \ - _CNL_PORT_TX_DW7_GRP_D, \ - _CNL_PORT_TX_DW7_GRP_AE, \ -
_CNL_PORT_TX_DW7_GRP_F)drivers/gpu/drm/i915/i915_reg.h +0
-2-#define CNL_PORT_TX_DW7_LN0 (port) _MMIO_PORT6(port, \ -
_CNL_PORT_TX_DW7_LN0_AE, \
-_CNL_PORT_TX_DW7_LN0_B, \
-_CNL_PORT_TX_DW7_LN0_C, \
-_CNL_PORT_TX_DW7_LN0_D, \
-_CNL_PORT_TX_DW7_LN0_AE, \
-_CNL_PORT_TX_DW7_LN0_F)
+#defineCNL_PORT_TX_DW7_GRP(port)_MMIO(_CNL_PORT_TX_DW_GRP((port), 7)) +#define CNL_PORT_TX_DW7_LN0(port) _MMIO(_CNL_PORT_TX_DW_LN0((port), 7))#define
N_SCALAR(x)((x) << 24)
#defineN_SCALAR_MASK(0x7F<< 24)
Quoted 7 lines
--
2.14.1_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v4 1/2] drm/i915/cnl; Add macro to get PORT_TX register
In reply to Mahesh KumarQuoted 20 lines
-----Original Message-----
From: Chauhan, Madhav
Sent: Thursday, March 15, 2018 2:55 PM
To: 'Mahesh Kumar' <[email protected]>; intel- [email protected]
Cc: De Marchi, Lucas <[email protected]>; Vivi, Rodrigo <[email protected]>
Subject: RE: [Intel-gfx] [PATCH v4 1/2] drm/i915/cnl; Add macro to getPORT_TXregisterQuoted 9 lines
-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Mahesh Kumar
Sent: Wednesday, March 14, 2018 1:37 PM
To: [email protected]
Cc: De Marchi, Lucas <[email protected]>; Vivi, Rodrigo <[email protected]>
Subject: [Intel-gfx] [PATCH v4 1/2] drm/i915/cnl; Add macro to getPORT_TXregister
Quoted 1 line
Looks typo. Replace ";" with ":" in commit header.
Just noticed they are pushed to "dinq". May be corrected later When publishing some related patch.
Regards,
Madhav
Quoted 274 lines
Quoted 95 lines
This patch creates a new macro to get
PORT_TXregister for any given DW. This removes the need of defining register address for each port & DW.Changes since V1:
- Use underscope prefix, as macro isn't returning an mmio reg(Lucas)
- Merge patch 1 & 2 of the series
Changes since V2:
- remove_MMIO_PORT6_LNmacro (Rodrigo)Signed-off-by Mahesh Kumar <[email protected]>Reviewed-by Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/i915_reg.h | 137 ++++++++++++---------------------------- 1 file changed, 39 insertions(+), 98 deletions(-)(quoted diff) +0
-0
b/drivers/gpu/drm/i915/i915_reg.hindexe8e912f08e22..095833af2f81100644drivers/gpu/drm/i915/i915_reg.h +0
-0@@ -154,8 +154,6 @@ static inline bool i915_mmio_reg_valid(i915_reg_treg) #define
_PLL(pll, a, b)((a) + (pll)*((b)-(a))) #define_MMIO_PLL(pll, a, b)_MMIO(_PLL(pll, a, b))#define_MMIO_PORT6(port, a, b, c, d, e, f)_MMIO(_PICK(port, a, b, c, d, e, f))-#define_MMIO_PORT6_LN(port, ln, a0, a1, b, c, d, e, f)\drivers/gpu/drm/i915/i915_reg.h +0
-1- _MMIO(_PICK(port, a0, b, c, d, e, f) + (ln * (a1 - a0)))#define _PHY3 (phy, ...) _PICK(phy, __VA_ARGS__) #define
_MMIO_PHY3(phy, a, b, c)_MMIO(_PHY3(phy, a, b, c))drivers/gpu/drm/i915/i915_reg.h +0
-20@@ -1964,30 +1962,36 @@ enum i915_power_well_id { _CNL_PORT_PCS_DW1_LN0_F)#define COMMON_KEEPER_EN (1 << 26) -#define _CNL_PORT_TX_DW2_GRP_AE 0x162348 -#define _CNL_PORT_TX_DW2_GRP_B 0x1623C8 -#define _CNL_PORT_TX_DW2_GRP_C 0x162B48 -#define _CNL_PORT_TX_DW2_GRP_D 0x162BC8 -#define _CNL_PORT_TX_DW2_GRP_F 0x162A48 -#define _CNL_PORT_TX_DW2_LN0_AE 0x162448 -#define _CNL_PORT_TX_DW2_LN0_B 0x162648 -#define _CNL_PORT_TX_DW2_LN0_C 0x162C48 -#define _CNL_PORT_TX_DW2_LN0_D 0x162E48 -#define _CNL_PORT_TX_DW2_LN0_F 0x162848 -#define CNL_PORT_TX_DW2_GRP (port) _MMIO_PORT6(port, \ - _CNL_PORT_TX_DW2_GRP_AE, \ - _CNL_PORT_TX_DW2_GRP_B, \ - _CNL_PORT_TX_DW2_GRP_C, \ - _CNL_PORT_TX_DW2_GRP_D, \ - _CNL_PORT_TX_DW2_GRP_AE, \ - _CNL_PORT_TX_DW2_GRP_F) -#define CNL_PORT_TX_DW2_LN0(port) _MMIO_PORT6(port, \ - _CNL_PORT_TX_DW2_LN0_AE, \ -
_CNL_PORT_TX_DW2_LN0_B, \
-_CNL_PORT_TX_DW2_LN0_C, \
-_CNL_PORT_TX_DW2_LN0_D, \
-_CNL_PORT_TX_DW2_LN0_AE, \
-_CNL_PORT_TX_DW2_LN0_F)drivers/gpu/drm/i915/i915_reg.h +13
-0+/* CNL Port TX registers */ +#define _CNL_PORT_TX_AE_GRP_OFFSET 0x162340 +#define _CNL_PORT_TX_B_GRP_OFFSET 0x1623C0 +#define _CNL_PORT_TX_C_GRP_OFFSET 0x162B40 +#define _CNL_PORT_TX_D_GRP_OFFSET 0x162BC0 +#define _CNL_PORT_TX_F_GRP_OFFSET 0x162A40 +#define _CNL_PORT_TX_AE_LN0_OFFSET 0x162440 +#define _CNL_PORT_TX_B_LN0_OFFSET 0x162640 +#define _CNL_PORT_TX_C_LN0_OFFSET 0x162C40 +#define _CNL_PORT_TX_D_LN0_OFFSET 0x162E40 +#define _CNL_PORT_TX_F_LN0_OFFSET 0x162840 +#define _CNL_PORT_TX_DW_GRP (port, dw) (_PICK((port), \ + _CNL_PORT_TX_AE_GRP_OFFSET,\
drivers/gpu/drm/i915/i915_reg.h +4
-0+ _CNL_PORT_TX_B_GRP_OFFSET, \ + _CNL_PORT_TX_B_GRP_OFFSET, \ + _CNL_PORT_TX_D_GRP_OFFSET, \ + _CNL_PORT_TX_AE_GRP_OFFSET,\
drivers/gpu/drm/i915/i915_reg.h +1
-0+ _CNL_PORT_TX_F_GRP_OFFSET) +\
drivers/gpu/drm/i915/i915_reg.h
Quoted 1 line
drivers/gpu/drm/i915/i915_reg.h +1
-0+ 4*(dw))Add space before and after "*" here and other places in you patch. With these fixes,
Reviewed-by Madhav Chauhan <[email protected]>Regards,
MadhavQuoted 170 lines
drivers/gpu/drm/i915/i915_reg.h +2
-0+#define _CNL_PORT_TX_DW_LN0 (port, dw) (_PICK((port), \ + _CNL_PORT_TX_AE_LN0_OFFSET,\
drivers/gpu/drm/i915/i915_reg.h +4
-0+ _CNL_PORT_TX_B_LN0_OFFSET, \ + _CNL_PORT_TX_B_LN0_OFFSET, \ + _CNL_PORT_TX_D_LN0_OFFSET, \ + _CNL_PORT_TX_AE_LN0_OFFSET,\
drivers/gpu/drm/i915/i915_reg.h +1
-0+ _CNL_PORT_TX_F_LN0_OFFSET) +\
drivers/gpu/drm/i915/i915_reg.h +3
-0+ 4*(dw)) + +#define CNL_PORT_TX_DW2_GRP (port)_MMIO(_CNL_PORT_TX_DW_GRP((port), 2)) +#define CNL_PORT_TX_DW2_LN0(port) _MMIO(_CNL_PORT_TX_DW_LN0((port), 2)) #define SWING_SEL_UPPER(x) ((x >> 3) << 15) #define SWING_SEL_UPPER_MASK (1 << 15) #define SWING_SEL_LOWER(x) ((x & 0x7) << 11)drivers/gpu/drm/i915/i915_reg.h +0
-19@@ -1995,32 +1999,13 @@ enum i915_power_well_id {#define RCOMP_SCALAR (x) ((x) << 0)#define RCOMP_SCALAR_MASK (0xFF << 0) -#define _CNL_PORT_TX_DW4_GRP_AE 0x162350 -#define _CNL_PORT_TX_DW4_GRP_B 0x1623D0 -#define _CNL_PORT_TX_DW4_GRP_C 0x162B50 -#define _CNL_PORT_TX_DW4_GRP_D 0x162BD0 -#define _CNL_PORT_TX_DW4_GRP_F 0x162A50#define _CNL_PORT_TX_DW4_LN0_AE 0x162450#define _CNL_PORT_TX_DW4_LN1_AE 0x1624D0 -#define _CNL_PORT_TX_DW4_LN0_B 0x162650 -#define _CNL_PORT_TX_DW4_LN0_C 0x162C50 -#define _CNL_PORT_TX_DW4_LN0_D 0x162E50 -#define _CNL_PORT_TX_DW4_LN0_F 0x162850 -#define CNL_PORT_TX_DW4_GRP (port) _MMIO_PORT6(port, \ - _CNL_PORT_TX_DW4_GRP_AE, \ - _CNL_PORT_TX_DW4_GRP_B, \ - _CNL_PORT_TX_DW4_GRP_C, \ - _CNL_PORT_TX_DW4_GRP_D, \ - _CNL_PORT_TX_DW4_GRP_AE, \ - _CNL_PORT_TX_DW4_GRP_F) -#define CNL_PORT_TX_DW4_LN(port, ln) _MMIO_PORT6_LN(port, ln, \ - _CNL_PORT_TX_DW4_LN0_AE, \ -
_CNL_PORT_TX_DW4_LN1_AE, \
-_CNL_PORT_TX_DW4_LN0_B, \
-_CNL_PORT_TX_DW4_LN0_C, \
-_CNL_PORT_TX_DW4_LN0_D, \
-_CNL_PORT_TX_DW4_LN0_AE, \
-_CNL_PORT_TX_DW4_LN0_F)
+#defineCNL_PORT_TX_DW4_GRP(port)_MMIO(_CNL_PORT_TX_DW_GRP((port), 4)) +#define CNL_PORT_TX_DW4_LN0(port) _MMIO(_CNL_PORT_TX_DW_LN0((port), 4))+#define
CNL_PORT_TX_DW4_LN(port, ln)
_MMIO(_CNL_PORT_TX_DW_LN0((port), 4) + \drivers/gpu/drm/i915/i915_reg.h +1
-0+ (ln *(
_CNL_PORT_TX_DW4_LN1_AE- \
+_CNL_PORT_TX_DW4_LN0_AE)))#define LOADGEN_SELECT (1 << 31) #define POST_CURSOR_1(x) ((x) << 12) #define POST_CURSOR_1_MASK (0x3F << 12)drivers/gpu/drm/i915/i915_reg.h +0
-17@@ -2029,30 +2014,8 @@ enum i915_power_well_id {#define CURSOR_COEFF (x) ((x) << 0)#define CURSOR_COEFF_MASK (0x3F << 0) -#define _CNL_PORT_TX_DW5_GRP_AE 0x162354 -#define _CNL_PORT_TX_DW5_GRP_B 0x1623D4 -#define _CNL_PORT_TX_DW5_GRP_C 0x162B54 -#define _CNL_PORT_TX_DW5_GRP_D 0x162BD4 -#define _CNL_PORT_TX_DW5_GRP_F 0x162A54 -#define _CNL_PORT_TX_DW5_LN0_AE 0x162454 -#define _CNL_PORT_TX_DW5_LN0_B 0x162654 -#define _CNL_PORT_TX_DW5_LN0_C 0x162C54 -#define _CNL_PORT_TX_DW5_LN0_D 0x162E54 -#define _CNL_PORT_TX_DW5_LN0_F 0x162854 -#define CNL_PORT_TX_DW5_GRP (port) _MMIO_PORT6(port, \ - _CNL_PORT_TX_DW5_GRP_AE, \ - _CNL_PORT_TX_DW5_GRP_B, \ - _CNL_PORT_TX_DW5_GRP_C, \ - _CNL_PORT_TX_DW5_GRP_D, \ - _CNL_PORT_TX_DW5_GRP_AE, \ -
_CNL_PORT_TX_DW5_GRP_F)drivers/gpu/drm/i915/i915_reg.h +0
-2-#define CNL_PORT_TX_DW5_LN0 (port) _MMIO_PORT6(port, \ -
_CNL_PORT_TX_DW5_LN0_AE, \
-_CNL_PORT_TX_DW5_LN0_B, \
-_CNL_PORT_TX_DW5_LN0_C, \
-_CNL_PORT_TX_DW5_LN0_D, \
-_CNL_PORT_TX_DW5_LN0_AE, \
-_CNL_PORT_TX_DW5_LN0_F)
+#defineCNL_PORT_TX_DW5_GRP(port)_MMIO(_CNL_PORT_TX_DW_GRP((port), 5)) +#define CNL_PORT_TX_DW5_LN0(port) _MMIO(_CNL_PORT_TX_DW_LN0((port), 5)) #define TX_TRAINING_EN (1 << 31) #define TAP3_DISABLE (1 << 29) #define SCALING_MODE_SEL(x) ((x) << 18)drivers/gpu/drm/i915/i915_reg.h +0
-17@@ -2060,30 +2023,8 @@ enum i915_power_well_id {#define RTERM_SELECT (x) ((x) << 3)#define RTERM_SELECT_MASK (0x7 << 3) -#define _CNL_PORT_TX_DW7_GRP_AE 0x16235C -#define _CNL_PORT_TX_DW7_GRP_B 0x1623DC -#define _CNL_PORT_TX_DW7_GRP_C 0x162B5C -#define _CNL_PORT_TX_DW7_GRP_D 0x162BDC -#define _CNL_PORT_TX_DW7_GRP_F 0x162A5C -#define _CNL_PORT_TX_DW7_LN0_AE 0x16245C -#define _CNL_PORT_TX_DW7_LN0_B 0x16265C -#define _CNL_PORT_TX_DW7_LN0_C 0x162C5C -#define _CNL_PORT_TX_DW7_LN0_D 0x162E5C -#define _CNL_PORT_TX_DW7_LN0_F 0x16285C -#define CNL_PORT_TX_DW7_GRP (port) _MMIO_PORT6(port, \ - _CNL_PORT_TX_DW7_GRP_AE, \ - _CNL_PORT_TX_DW7_GRP_B, \ - _CNL_PORT_TX_DW7_GRP_C, \ - _CNL_PORT_TX_DW7_GRP_D, \ - _CNL_PORT_TX_DW7_GRP_AE, \ -
_CNL_PORT_TX_DW7_GRP_F)drivers/gpu/drm/i915/i915_reg.h +0
-2-#define CNL_PORT_TX_DW7_LN0 (port) _MMIO_PORT6(port, \ -
_CNL_PORT_TX_DW7_LN0_AE, \
-_CNL_PORT_TX_DW7_LN0_B, \
-_CNL_PORT_TX_DW7_LN0_C, \
-_CNL_PORT_TX_DW7_LN0_D, \
-_CNL_PORT_TX_DW7_LN0_AE, \
-_CNL_PORT_TX_DW7_LN0_F)
+#defineCNL_PORT_TX_DW7_GRP(port)_MMIO(_CNL_PORT_TX_DW_GRP((port), 7)) +#define CNL_PORT_TX_DW7_LN0(port) _MMIO(_CNL_PORT_TX_DW_LN0((port), 7))#define
N_SCALAR(x)((x) << 24)
#defineN_SCALAR_MASK(0x7F<< 24)
Quoted 7 lines
Quoted 7 lines
--
2.14.1_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 2/2 drm/i915/cnl: Kill _MMIO_PORT6 macro
In reply to Mahesh KumarThis patch replaces use of remaining _MMIO_PORT6 macro and removes the macro.
Changes Since V1:
- Rebase
--- drivers/gpu/drm/i915/i915_reg.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/i915_reg.h +5 -5
@@ -153,7 +153,6 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)#define _MMIO_PORT3 (pipe, a, b, c) _MMIO(_PICK(pipe, a, b, c))#define _PLL (pll, a, b) ((a) + (pll)*((b)-(a)))#define _MMIO_PLL (pll, a, b) _MMIO(_PLL(pll, a, b)) -#define _MMIO_PORT6 (port, a, b, c, d, e, f) _MMIO(_PICK(port, a, b, c, d, e, f))#define _PHY3 (phy, ...) _PICK(phy, __VA_ARGS__)#define _MMIO_PHY3 (phy, a, b, c) _MMIO(_PHY3(phy, a, b, c))
@@ -1946,20 +1945,21 @@ enum i915_power_well_id {#define _CNL_PORT_PCS_DW1_LN0_C 0x162C04#define _CNL_PORT_PCS_DW1_LN0_D 0x162E04#define _CNL_PORT_PCS_DW1_LN0_F 0x162804 -#define CNL_PORT_PCS_DW1_GRP (port) _MMIO_PORT6(port, \ +#define CNL_PORT_PCS_DW1_GRP (port) _MMIO(_PICK(port, \ _CNL_PORT_PCS_DW1_GRP_AE, \ _CNL_PORT_PCS_DW1_GRP_B, \ _CNL_PORT_PCS_DW1_GRP_C, \ _CNL_PORT_PCS_DW1_GRP_D, \ _CNL_PORT_PCS_DW1_GRP_AE, \ - _CNL_PORT_PCS_DW1_GRP_F) -#define CNL_PORT_PCS_DW1_LN0 (port) _MMIO_PORT6(port, \ + _CNL_PORT_PCS_DW1_GRP_F)) + +#define CNL_PORT_PCS_DW1_LN0 (port) _MMIO(_PICK(port, \ _CNL_PORT_PCS_DW1_LN0_AE, \ _CNL_PORT_PCS_DW1_LN0_B, \ _CNL_PORT_PCS_DW1_LN0_C, \ _CNL_PORT_PCS_DW1_LN0_D, \ _CNL_PORT_PCS_DW1_LN0_AE, \ - _CNL_PORT_PCS_DW1_LN0_F) + _CNL_PORT_PCS_DW1_LN0_F))#define COMMON_KEEPER_EN (1 << 26)/* CNL Port TX registers */
Signature · 6 lines
2.14.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for CNL port refactoring (rev4)
In reply to Mahesh Kumar== Series Details ==
== Series Details ==
Series: CNL port refactoring (rev4)
URL : https://patchwork.freedesktop.org/series/38334/
State : success
== Summary ==
Series 38334v4 CNL port refactoring
https://patchwork.freedesktop.org/api/1.0/series/38334/revisions/4/mbox/
---- Known issues:
Test debugfs_test:
Subgroup read_all_entries:
pass -> INCOMPLETE (fi-snb-2520m) fdo#103713fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:429s fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:431s fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:382s fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:527s fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:298s fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:506s fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:512s fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:510s fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:494s fi-cfl-8700k total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:409s fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:576s fi-cfl-u total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:509s fi-cnl-y3 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:583s fi-elk-e7500 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:429s fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:533s fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:404s fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:420s fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:479s fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:433s fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:474s fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:469s fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:514s fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:445s fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:528s fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:541s fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:514s fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:499s fi-skl-guc total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:427s fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:437s fi-snb-2520m total:3 pass:2 dwarn:0 dfail:0 fail:0 skip:0
Blacklisted hosts:
fi-cnl-drrs total:288 pass:257 dwarn:3 dfail:0 fail:0 skip:28 time:530s
613eb885b69e808a46f11125870e47b67a326d76 drm-tip: 2018y-03m-14d-05h-56m-23s UTC integration manifest ab97596d274e drm/i915/cnl: Kill _MMIO_PORT6 macro82b4d07e34c4 drm/i915/cnl; Add macro to get PORT_TX register
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8339/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: warning for CNL port refactoring (rev4)
In reply to Mahesh Kumar== Series Details ==
== Series Details ==
Series: CNL port refactoring (rev4)
URL : https://patchwork.freedesktop.org/series/38334/
State : warning
== Summary ==
---- Possible new issues:
Test gem_pwrite:
Subgroup big-cpu-backwards:
skip -> PASS (shard-apl)
Test kms_cursor_legacy:
Subgroup 2x-cursor-vs-flip-atomic:
pass -> SKIP (shard-hsw)
Test kms_frontbuffer_tracking:
Subgroup fbc-2p-primscrn-indfb-msflip-blt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-pri-indfb-draw-blt:
pass -> SKIP (shard-hsw)---- Known issues:
Test gem_eio:
Subgroup in-flight-contexts:
pass -> INCOMPLETE (shard-apl) fdo#105341
Test kms_cursor_crc:
Subgroup cursor-64x64-suspend:
pass -> SKIP (shard-hsw) fdo#103540
Test kms_frontbuffer_tracking:
Subgroup fbc-2p-primscrn-pri-shrfb-draw-mmap-wc:
pass -> SKIP (shard-hsw) fdo#103167
Test kms_setmode:
Subgroup basic:
pass -> FAIL (shard-hsw) fdo#99912
Test kms_sysfs_edid_timing:
pass -> WARN (shard-apl) fdo#100047
Test kms_vblank:
Subgroup pipe-b-ts-continuation-suspend:
pass -> SKIP (shard-snb) fdo#105411
Test prime_vgem:
Subgroup basic-fence-flip:
fail -> PASS (shard-apl) fdo#104008fdo#105341 https://bugs.freedesktop.org/show_bug.cgi?id=105341
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
shard-apl total:3360 pass:1778 dwarn:1 dfail:0 fail:6 skip:1573 time:12768s shard-hsw total:3444 pass:1765 dwarn:1 dfail:0 fail:1 skip:1676 time:11679s shard-snb total:3444 pass:1358 dwarn:1 dfail:0 fail:2 skip:2083 time:7077s
Blacklisted hosts:
shard-kbl total:3360 pass:1868 dwarn:28 dfail:1 fail:9 skip:1453 time:9738s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8339/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 11 lines · Mahesh Kumar
This series fixes CNL PORT_TX_DW5/7_LNO_D register address. This series also introduces macros to get register address of
CNL_PORT_TXregisters instead of defining for each DW instance.changes since V1:
completely kill_MMIO_PORT6macro
changes since V2:
use underscore prefix in macro
merge patch 1 and 2
changes since V3:
Address review comments
pushed to dinq. Thanks for that.
Quoted 15 lines
Mahesh Kumar (2):
drm/i915/cnl; Add macro to getPORT_TXregister
drm/i915/cnl: Kill_MMIO_PORT6macrodrivers/gpu/drm/i915/i915_reg.h | 147 ++++++++++++---------------------------- 1 file changed, 44 insertions(+), 103 deletions(-)Signature · 6 lines
2.14.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx