staging: typec: tcpci: enable vbus detection
PATCH v3 8/12 staging: typec: tcpci: enable vbus detection
Quoted 4 lines · Li Jun
TCPCI implementation may need SW to enable VBUS detection to generate power status events.
Signed-off-by Li Jun <[email protected]>
Makes sense to me. Only question might be if this should be dones before checking the power status at the beginnng of the function. Any thoughts ?
Otherwise
Reviewed-by Guenter Roeck <[email protected]>
Quoted 24 lines
--- drivers/staging/typec/tcpci.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/staging/typec/tcpci.c +6
-0@@ -373,6 +373,12 @@ static int tcpci_init(struct tcpc_dev *tcpc)if (ret <0 )return ret; +/* Enable Vbus detection */ + ret =regmap_write (tcpci->regmap,TCPC_COMMAND , +TCPC_CMD_ENABLE_VBUS_DETECT ); +if (ret <0 ) +return ret; + reg =TCPC_ALERT_TX_SUCCESS |TCPC_ALERT_TX_FAILED |TCPC_ALERT_TX_DISCARDED |TCPC_ALERT_RX_STATUS |TCPC_ALERT_RX_HARD_RST |TCPC_ALERT_CC_STATUS ;Signature · 1 line
2.7.4
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html