Skip to contentSkip to conversation

ARM: dts: msm8974: castor: Correct typo in touchscreen compatible string

PATCH In review Craig Tatlor 3 participants 4 messages Mar 12, 2018 – Mar 15, 2018

Subsystems (2)
Device tree bindings Arm Qualcomm mailing list
lore
Share & tools
lore

Craig Tatlor

author
#0 lore raw

PATCH 1/1 ARM: dts: msm8974: castor: Correct typo in touchscreen compatible string

This was mistakenly pulled from the downstream tree.

Signed-off-by Craig Tatlor <[email protected]>
---
 arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts +1 -1
index e87f2c99060d..d85311a0422c 100644
@@ -491,7 +491,7 @@
 		pinctrl-0 = <&i2c8_pins>;
 
 		synaptics at 2c {
-			compatible = "syna,rmi-i2c";
+			compatible = "syna,rmi4-i2c";
 			reg = <0x2c>;
 
 			interrupt-parent = <&msmgpio>;
Signature · 1 line
2.16.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Craig Tatlor

This was mistakenly pulled from the downstream tree.

Signed-off-by Craig Tatlor <[email protected]>

Thanks Craig,

Reviewed-by Bjorn Andersson <[email protected]>

Regards,
Bjorn

Quoted 20 lines
---
 arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts +1 -1
index e87f2c99060d..d85311a0422c 100644
@@ -491,7 +491,7 @@
 		pinctrl-0 = <&i2c8_pins>;
 
 		synaptics at 2c {
-			compatible = "syna,rmi-i2c";
+			compatible = "syna,rmi4-i2c";
 			reg = <0x2c>;
 
 			interrupt-parent = <&msmgpio>;
Signature · 1 line
2.16.1
author
#2 lore raw

PATCH v2 1/1 ARM: dts: msm8974: castor: Fix typo and add startup delay in touchscreen node

In reply to Craig Tatlor

The compatible string was mistakenly pulled from the downstream tree and the startup delay property is needed to prevent io errors on initial page select.

Signed-off-by Craig Tatlor <[email protected]>
---
 arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts +3 -1
index e87f2c99060d..701b396719c7 100644
@@ -491,7 +491,7 @@
 		pinctrl-0 = <&i2c8_pins>;
 
 		synaptics at 2c {
-			compatible = "syna,rmi-i2c";
+			compatible = "syna,rmi4-i2c";
 			reg = <0x2c>;
 
 			interrupt-parent = <&msmgpio>;

@@ -506,6 +506,8 @@
 			pinctrl-names = "default";
 			pinctrl-0 = <&ts_int_pin>;
 
+			syna,startup-delay-ms = <10>;
+
 			rmi-f01 at 1 {
 				reg = <0x1>;
 				syna,nosleep = <1>;
Signature · 1 line
2.16.1
#3 lore raw

Re: [PATCH v2] ARM: dts: msm8974: castor: Fix typo and add startup delay in touchscreen node

Quoted 4 lines · Craig Tatlor

The compatible string was mistakenly pulled from the downstream tree and the startup delay property is needed to prevent io errors on initial page select.

Signed-off-by Craig Tatlor <[email protected]>

Thanks for the patch. I'll add Bjorn's reviewed-by and apply it.

Regards,
Andy