Skip to contentSkip to conversation

lan7xxx: Require phylib

PATCH In review Alexander Graf 3 participants 5 messages Mar 15, 2018 – Mar 26, 2018 USB

lore
Share & tools
lore

Alexander Graf

author
#0 lore raw

PATCH 1/1 lan7xxx: Require phylib

The lan75xx and lan78xx drivers need to drive their phy via the generic phylib framework. Let's reflect that dependency in Kconfig, so that we don't get build errors when phylib does not get selected.

Signed-off-by Alexander Graf <[email protected]>
---
 drivers/usb/eth/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/usb/eth/Kconfig +2 -0
index 496a6d1933..2f6bfa8e71 100644
@@ -23,6 +23,7 @@ config USB_ETHER_ASIX88179
 config USB_ETHER_LAN75XX
 	bool "Microchip LAN75XX support"
 	depends on USB_HOST_ETHER
+	depends on PHYLIB
 	---help---
 	  Say Y here if you would like to support Microchip LAN75XX Hi-Speed
 	  USB 2.0 to 10/100/1000 Gigabit Ethernet controller.

@@ -32,6 +33,7 @@ config USB_ETHER_LAN75XX
 config USB_ETHER_LAN78XX
 	bool "Microchip LAN78XX support"
 	depends on USB_HOST_ETHER
+	depends on PHYLIB
 	---help---
 	  Say Y here if you would like to support Microchip LAN78XX USB 3.1
 	  Gen 1 to 10/100/1000 Gigabit Ethernet controller.
Signature · 1 line
2.12.3
#2 lore raw

PATCH 1/1 lan7xxx: Require phylib

In reply to Alexander Graf

Hi,

Quoted 14 lines · On Thu, 15 Mar 2018 15:10:20 +0100 Alexander Graf <[email protected]> wrote:

The lan75xx and lan78xx drivers need to drive their phy via the generic phylib framework. Let's reflect that dependency in Kconfig, so that we don't get build errors when phylib does not get selected.

Signed-off-by Alexander Graf <[email protected]>
---
 drivers/usb/eth/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/usb/eth/Kconfig +0 -0
index 496a6d1933..2f6bfa8e71 100644

drivers/usb/eth/Kconfig config USB_ETHER_ASIX88179 · line 26

Quoted 4 lines
drivers/usb/eth/Kconfig +1 -0
@@ -23,6 +23,7 @@ config USB_ETHER_ASIX88179
 config USB_ETHER_LAN75XX
 	bool "Microchip LAN75XX support"
 	depends on USB_HOST_ETHER
+	depends on PHYLIB

'select PHYLIB' seems more appropriate here (and there are already 17 drivers selecting it and none using 'depends on'.)

#3 lore raw

PATCH 1/1 lan7xxx: Require phylib

Quoted 14 lines · Tuomas Tynkkynen

Hi,

Quoted 9 lines · On Thu, 15 Mar 2018 15:10:20 +0100 Alexander Graf <[email protected]> wrote:

The lan75xx and lan78xx drivers need to drive their phy via the generic phylib framework. Let's reflect that dependency in Kconfig, so that we don't get build errors when phylib does not get selected.

Signed-off-by Alexander Graf <[email protected]>
---
 drivers/usb/eth/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
Quoted 12 lines

drivers/usb/eth/Kconfig config USB_ETHER_ASIX88179 · line 26

Quoted 9 lines
drivers/usb/eth/Kconfig +1 -0
index 496a6d1933..2f6bfa8e71 100644
@@ -23,6 +23,7 @@ config USB_ETHER_ASIX88179
 config USB_ETHER_LAN75XX
      bool "Microchip LAN75XX support"
      depends on USB_HOST_ETHER
+     depends on PHYLIB

'select PHYLIB' seems more appropriate here (and there are already 17 drivers selecting it and none using 'depends on'.)

Yeah, good point. Please change this.

Thanks,
-Joe