Skip to contentSkip to conversation

package/rpi-firmware: bump version

PATCH Superseded Martin Bark 6 participants 17 messages Mar 15, 2018 – Mar 16, 2018 Broadcom BCM2711/BCM2835 Arm architecture

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Martin Bark

author
#0 lore raw

PATCH 1/4 package/rpi-firmware: bump version

Signed-off-by Martin Bark <[email protected]>
---
 package/rpi-firmware/rpi-firmware.hash | 2 +-
 package/rpi-firmware/rpi-firmware.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/rpi-firmware/rpi-firmware.hash +1 -1
index 833a7fb..0e09ff5 100644
@@ -1,2 +1,2 @@
 # Locally computed
-sha256 0451e1a843bf02df81126a1625d9a15dfdf19dcb2f9e95b0613a63e59fd31ca8 rpi-firmware-2067241bc7cdf238fdeab7f5a3c22faa57dd5617.tar.gz
+sha256 8fe5ebe14cc900f67242cab0c1c9f8e29bd10369ccbdfc7d004c294a96bad975 rpi-firmware-086a8488de0f485e8879ac14ff505ff1d922eeed.tar.gz
package/rpi-firmware/rpi-firmware.mk +1 -1
index 22eaaa2..1ebdd96 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-RPI_FIRMWARE_VERSION = 2067241bc7cdf238fdeab7f5a3c22faa57dd5617
+RPI_FIRMWARE_VERSION = 086a8488de0f485e8879ac14ff505ff1d922eeed
 RPI_FIRMWARE_SITE = $(call github,raspberrypi,firmware,$(RPI_FIRMWARE_VERSION))
 RPI_FIRMWARE_LICENSE = BSD-3-Clause
 RPI_FIRMWARE_LICENSE_FILES = boot/LICENCE.broadcom
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH 2/4 configs/raspberrypi*: bump kernel version

Now based on 4.9.80 (from 4.9.79)

Signed-off-by Martin Bark <[email protected]>
---
 configs/raspberrypi0_defconfig       | 2 +-
 configs/raspberrypi2_defconfig       | 2 +-
 configs/raspberrypi3_64_defconfig    | 2 +-
 configs/raspberrypi3_defconfig       | 2 +-
 configs/raspberrypi3_qt5we_defconfig | 2 +-
 configs/raspberrypi_defconfig        | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)
configs/raspberrypi0_defconfig +1 -1
index 0fb8a99..68448e6 100644
@@ -10,7 +10,7 @@ BR2_TOOLCHAIN_BUILDROOT_CXX=y
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_GIT=y
 BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/raspberrypi/linux.git"
-BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="33ee56d5927ceff630fbc87e3f5caa409b6ae114"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="a00afce9b4231c120c8b007d2c48018547d0156f"
 BR2_LINUX_KERNEL_DEFCONFIG="bcmrpi"
 
 # Build the DTBs for A/B from the kernel sources: the zero is the same
configs/raspberrypi2_defconfig +1 -1
index 962a58c..7e7a61a 100644
@@ -13,7 +13,7 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_9=y
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_GIT=y
 BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/raspberrypi/linux.git"
-BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="33ee56d5927ceff630fbc87e3f5caa409b6ae114"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="a00afce9b4231c120c8b007d2c48018547d0156f"
 BR2_LINUX_KERNEL_DEFCONFIG="bcm2709"
 
 # Build the DTB from the kernel sources
configs/raspberrypi3_64_defconfig +1 -1
index 6a35ac3..7db5561 100644
@@ -12,7 +12,7 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_9=y
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_GIT=y
 BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/raspberrypi/linux.git"
-BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="33ee56d5927ceff630fbc87e3f5caa409b6ae114"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="a00afce9b4231c120c8b007d2c48018547d0156f"
 BR2_LINUX_KERNEL_DEFCONFIG="bcmrpi3"
 
 # Build the DTB from the kernel sources
configs/raspberrypi3_defconfig +1 -1
index 9304f0c..2fb46d3 100644
@@ -12,7 +12,7 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_9=y
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_GIT=y
 BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/raspberrypi/linux.git"
-BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="33ee56d5927ceff630fbc87e3f5caa409b6ae114"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="a00afce9b4231c120c8b007d2c48018547d0156f"
 BR2_LINUX_KERNEL_DEFCONFIG="bcm2709"
 
 # Build the DTB from the kernel sources
configs/raspberrypi3_qt5we_defconfig +1 -1
index d4ada47..dc1bf7f 100644
@@ -13,7 +13,7 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_9=y
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_GIT=y
 BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/raspberrypi/linux.git"
-BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="33ee56d5927ceff630fbc87e3f5caa409b6ae114"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="a00afce9b4231c120c8b007d2c48018547d0156f"
 BR2_LINUX_KERNEL_DEFCONFIG="bcm2709"
 
 # Build the DTB from the kernel sources
configs/raspberrypi_defconfig +1 -1
index daca836..85312c4 100644
@@ -12,7 +12,7 @@ BR2_TOOLCHAIN_BUILDROOT_CXX=y
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_GIT=y
 BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/raspberrypi/linux.git"
-BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="33ee56d5927ceff630fbc87e3f5caa409b6ae114"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="a00afce9b4231c120c8b007d2c48018547d0156f"
 BR2_LINUX_KERNEL_DEFCONFIG="bcmrpi"
 
 # Build the DTBs for A/B, A+/B+ and compute module from the kernel sources
Signature · 1 line
2.7.4
author
#2 lore raw

PATCH 3/4 board/raspberrypi: add support for rpi3 b+

In reply to Martin Bark
Signed-off-by Martin Bark <[email protected]>
---
 board/raspberrypi/genimage-raspberrypi3.cfg | 1 +
 board/raspberrypi/readme.txt                | 3 ++-
 configs/raspberrypi3_defconfig              | 2 +-
 configs/raspberrypi3_qt5we_defconfig        | 2 +-
 4 files changed, 5 insertions(+), 3 deletions(-)
board/raspberrypi/genimage-raspberrypi3.cfg +1 -0
index 98ff709..0a54724 100644
@@ -2,6 +2,7 @@ image boot.vfat {
   vfat {
     files = {
       "bcm2710-rpi-3-b.dtb",
+      "bcm2710-rpi-3-b-plus.dtb",
       "bcm2710-rpi-cm3.dtb",
       "rpi-firmware/bootcode.bin",
       "rpi-firmware/cmdline.txt",
board/raspberrypi/readme.txt +2 -1
index 9482693..9f91581 100644
@@ -30,7 +30,7 @@ For model 2 B:
 
   $ make raspberrypi2_defconfig
 
-For model 3 B:
+For model 3 B and B+:
 
   $ make raspberrypi3_defconfig
 

@@ -56,6 +56,7 @@ After building, you should obtain this tree:
     +-- bcm2708-rpi-b-plus.dtb      [1]
     +-- bcm2709-rpi-2-b.dtb         [1]
     +-- bcm2710-rpi-3-b.dtb         [1]
+    +-- bcm2710-rpi-3-b-plus.dtb    [1]
     +-- boot.vfat
     +-- rootfs.ext4
     +-- rpi-firmware/
configs/raspberrypi3_defconfig +1 -1
index 2fb46d3..40585da 100644
@@ -17,7 +17,7 @@ BR2_LINUX_KERNEL_DEFCONFIG="bcm2709"
 
 # Build the DTB from the kernel sources
 BR2_LINUX_KERNEL_DTS_SUPPORT=y
-BR2_LINUX_KERNEL_INTREE_DTS_NAME="bcm2710-rpi-3-b bcm2710-rpi-cm3"
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="bcm2710-rpi-3-b bcm2710-rpi-3-b-plus bcm2710-rpi-cm3"
 
 BR2_PACKAGE_RPI_FIRMWARE=y
configs/raspberrypi3_qt5we_defconfig +1 -1
index dc1bf7f..7830065 100644
@@ -18,7 +18,7 @@ BR2_LINUX_KERNEL_DEFCONFIG="bcm2709"
 
 # Build the DTB from the kernel sources
 BR2_LINUX_KERNEL_DTS_SUPPORT=y
-BR2_LINUX_KERNEL_INTREE_DTS_NAME="bcm2710-rpi-3-b bcm2710-rpi-cm3"
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="bcm2710-rpi-3-b bcm2710-rpi-3-b-plus bcm2710-rpi-cm3"
 
 # Build Qt5 WebEngine
 BR2_PACKAGE_LIBERATION=y
Signature · 1 line
2.7.4
#3 lore raw

PATCH 3/4 board/raspberrypi: add support for rpi3 b+

Hi Martin,

board/raspberrypi/readme.txt For model 2 B: · line 33

Quoted 10 lines · Martin Bark
board/raspberrypi/readme.txt +1 -1
index 9482693..9f91581 100644
@@ -30,7 +30,7 @@ For model 2 B:
 
   $ make raspberrypi2_defconfig
 
-For model 3 B:
+For model 3 B and B+:

This is quick. Have you tested on hardware?

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
author
#4 lore raw

PATCH 3/4 board/raspberrypi: add support for rpi3 b+

Hi Baruch,

Quoted 9 lines · Baruch Siach

Hi Martin,

Quoted 6 lines · Martin Bark
board/raspberrypi/readme.txt +0 -0
index 9482693..9f91581 100644
@@ -30,7 +30,7 @@ For model 2 B:
Quoted 6 lines

board/raspberrypi/readme.txt For model 2 B: · line 33

Quoted 4 lines
board/raspberrypi/readme.txt +1 -1
   $ make raspberrypi2_defconfig
 
-For model 3 B:
+For model 3 B and B+:

This is quick. Have you tested on hardware?

I've testing it builds and runs on the rpi3 but not tested on a rpi3b+. I should get my rpi3b+ soon to verify this. The current kernel includes all the changes needed for the rpi3b+. To add support we just need to include the bcm2710-rpi-3-b-plus.dtb.

Note that i don't see any updates to the arm64 defconfig for dtb files so raspberrypi3_64_defconfig will remain unchanged for now.

Thanks

Martin

Quoted 7 lines

baruch

--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

author
#5 lore raw

PATCH 4/4 package/rpi-firmware: improve installation of dtb files

In reply to Martin Bark

Don't list specific dtb files, instead install all dtb files in the same way as dtbo files are currently done.

Signed-off-by Martin Bark <[email protected]>
---
 package/rpi-firmware/rpi-firmware.mk | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
package/rpi-firmware/rpi-firmware.mk +3 -4
index 1ebdd96..9cc3d4a 100644
@@ -12,10 +12,9 @@ RPI_FIRMWARE_INSTALL_IMAGES = YES
 
 ifeq ($(BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS),y)
 define RPI_FIRMWARE_INSTALL_DTB
-	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b.dtb
-	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b-plus.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b-plus.dtb
-	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2709-rpi-2-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2709-rpi-2-b.dtb
-	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2710-rpi-3-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2710-rpi-3-b.dtb
+	for dtb in  $(@D)/boot/*.dtb; do \
+		$(INSTALL) -D -m 0644 $${dtb} $(BINARIES_DIR)/rpi-firmware/$${dtb##*/} || exit 1; \
+	done
 endef
 endif
Signature · 1 line
2.7.4
#6 lore raw

PATCH 4/4 package/rpi-firmware: improve installation of dtb files

Hello Martin,

Quoted 13 lines · Martin Bark

Don't list specific dtb files, instead install all dtb files in the same way as dtbo files are currently done.

Signed-off-by Martin Bark <[email protected]>
---
 package/rpi-firmware/rpi-firmware.mk | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
package/rpi-firmware/rpi-firmware.mk +0 -0
index 1ebdd96..9cc3d4a 100644

package/rpi-firmware/rpi-firmware.mk RPI_FIRMWARE_INSTALL_IMAGES = YES · line 17

Quoted 10 lines
package/rpi-firmware/rpi-firmware.mk +3 -4
@@ -12,10 +12,9 @@ RPI_FIRMWARE_INSTALL_IMAGES = YES
 
 ifeq ($(BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS),y)
 define RPI_FIRMWARE_INSTALL_DTB
-	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b.dtb
-	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b-plus.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b-plus.dtb
-	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2709-rpi-2-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2709-rpi-2-b.dtb
-	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2710-rpi-3-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2710-rpi-3-b.dtb
+	for dtb in  $(@D)/boot/*.dtb; do \
+		$(INSTALL) -D -m 0644 $${dtb} $(BINARIES_DIR)/rpi-firmware/$${dtb##*/} || exit 1; \
+	done

Which will install three additional dtb files (bcm2708-rpi-0-w.dtb, bcm2708-rpi-cm.dtb and bcm2710-rpi-cm3.dtb), not a downside of the patch, but worth mentioning....

Regards,
Peter

Quoted 3 lines
package/rpi-firmware/rpi-firmware.mk +0 -0
 endef
 endif
author
#7 lore raw

PATCH 4/4 package/rpi-firmware: improve installation of dtb files

Hi Peter,

Quoted 18 lines · Peter Seiderer

Hello Martin,

Quoted 14 lines · Martin Bark

Don't list specific dtb files, instead install all dtb files in the same way as dtbo files are currently done.

Signed-off-by Martin Bark <[email protected]>
---
 package/rpi-firmware/rpi-firmware.mk | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
package/rpi-firmware/rpi-firmware.mk +0 -0
index 1ebdd96..9cc3d4a 100644
@@ -12,10 +12,9 @@ RPI_FIRMWARE_INSTALL_IMAGES = YES
Quoted 13 lines

package/rpi-firmware/rpi-firmware.mk RPI_FIRMWARE_INSTALL_IMAGES = YES · line 17

Quoted 9 lines
package/rpi-firmware/rpi-firmware.mk +3 -4
 ifeq ($(BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS),y)
 define RPI_FIRMWARE_INSTALL_DTB
-     $(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b.dtb
-     $(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b-plus.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b-plus.dtb
-     $(INSTALL) -D -m 0644 $(@D)/boot/bcm2709-rpi-2-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2709-rpi-2-b.dtb
-     $(INSTALL) -D -m 0644 $(@D)/boot/bcm2710-rpi-3-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2710-rpi-3-b.dtb
+     for dtb in  $(@D)/boot/*.dtb; do \
+             $(INSTALL) -D -m 0644 $${dtb} $(BINARIES_DIR)/rpi-firmware/$${dtb##*/} || exit 1; \
+     done

Which will install three additional dtb files (bcm2708-rpi-0-w.dtb, bcm2708-rpi-cm.dtb and bcm2710-rpi-cm3.dtb), not a downside of the patch, but worth mentioning....

Yes, it will also install the new bcm2710-rpi-3-b-plus.dtb. This code does not seem to have been kept updated, it's missing several dtb files as you mention. I think it's better to just install all dtb files as we do for the dtbo files.

Thanks

Martin

Quoted 8 lines

Regards,
Peter

Quoted 3 lines
package/rpi-firmware/rpi-firmware.mk +0 -0
 endef
 endif
#8 lore raw

PATCH 4/4 package/rpi-firmware: improve installation of dtb files

Martin, All,

On 2018-03-15 19:58 +0000, Martin Bark spake thusly:

Quoted 30 lines · Peter Seiderer
Quoted 15 lines · Martin Bark
Quoted 14 lines

Don't list specific dtb files, instead install all dtb files in the same way as dtbo files are currently done.

Signed-off-by Martin Bark <[email protected]>
---
 package/rpi-firmware/rpi-firmware.mk | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
package/rpi-firmware/rpi-firmware.mk +0 -0
index 1ebdd96..9cc3d4a 100644
@@ -12,10 +12,9 @@ RPI_FIRMWARE_INSTALL_IMAGES = YES
Quoted 13 lines

package/rpi-firmware/rpi-firmware.mk RPI_FIRMWARE_INSTALL_IMAGES = YES · line 17

Quoted 9 lines
package/rpi-firmware/rpi-firmware.mk +3 -4
 ifeq ($(BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS),y)
 define RPI_FIRMWARE_INSTALL_DTB
-     $(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b.dtb
-     $(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b-plus.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b-plus.dtb
-     $(INSTALL) -D -m 0644 $(@D)/boot/bcm2709-rpi-2-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2709-rpi-2-b.dtb
-     $(INSTALL) -D -m 0644 $(@D)/boot/bcm2710-rpi-3-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2710-rpi-3-b.dtb
+     for dtb in  $(@D)/boot/*.dtb; do \
+             $(INSTALL) -D -m 0644 $${dtb} $(BINARIES_DIR)/rpi-firmware/$${dtb##*/} || exit 1; \
+     done

Which will install three additional dtb files (bcm2708-rpi-0-w.dtb, bcm2708-rpi-cm.dtb and bcm2710-rpi-cm3.dtb), not a downside of the patch, but worth mentioning....

Quoted 4 lines

Yes, it will also install the new bcm2710-rpi-3-b-plus.dtb. This code does not seem to have been kept updated, it's missing several dtb files as you mention. I think it's better to just install all dtb files as we do for the dtbo files.

I wonder if we should not just drop BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS now the rpi dtbs are now supposed to be in the kernel snce at least 3.19.

Besids, all our rpi defconfig are using the DT from the kernel, which is another good indication that we don't need those from rpi-firmware anymore...

If it is not yet in the kernel, it is just a matter of time before it is available there...

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
author
#9 lore raw

PATCH 4/4 package/rpi-firmware: improve installation of dtb files

Yann,

Quoted 33 lines · Yann E. MORIN

Martin, All,

On 2018-03-15 19:58 +0000, Martin Bark spake thusly:

Quoted 30 lines · Peter Seiderer
Quoted 28 lines · Martin Bark
Quoted 13 lines

Don't list specific dtb files, instead install all dtb files in the same way as dtbo files are currently done.

Signed-off-by Martin Bark <[email protected]>
---
 package/rpi-firmware/rpi-firmware.mk | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
package/rpi-firmware/rpi-firmware.mk +0 -0
index 1ebdd96..9cc3d4a 100644

package/rpi-firmware/rpi-firmware.mk RPI_FIRMWARE_INSTALL_IMAGES = YES · line 17

Quoted 10 lines
package/rpi-firmware/rpi-firmware.mk +3 -4
@@ -12,10 +12,9 @@ RPI_FIRMWARE_INSTALL_IMAGES = YES
 
 ifeq ($(BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS),y)
 define RPI_FIRMWARE_INSTALL_DTB
-     $(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b.dtb
-     $(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b-plus.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b-plus.dtb
-     $(INSTALL) -D -m 0644 $(@D)/boot/bcm2709-rpi-2-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2709-rpi-2-b.dtb
-     $(INSTALL) -D -m 0644 $(@D)/boot/bcm2710-rpi-3-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2710-rpi-3-b.dtb
+     for dtb in  $(@D)/boot/*.dtb; do \
+             $(INSTALL) -D -m 0644 $${dtb} $(BINARIES_DIR)/rpi-firmware/$${dtb##*/} || exit 1; \
+     done

Which will install three additional dtb files (bcm2708-rpi-0-w.dtb, bcm2708-rpi-cm.dtb and bcm2710-rpi-cm3.dtb), not a downside of the patch, but worth mentioning....

Quoted 7 lines
Quoted 4 lines

Yes, it will also install the new bcm2710-rpi-3-b-plus.dtb. This code does not seem to have been kept updated, it's missing several dtb files as you mention. I think it's better to just install all dtb files as we do for the dtbo files.

I wonder if we should not just drop BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS now the rpi dtbs are now supposed to be in the kernel snce at least 3.19.

Yes it would be good to remove this. It would also be good to remove BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS and have them built as part of the kernel. Really only the booloader and /op/vc code is needed from rpi-firmware.

Thanks

Martin

Quoted 18 lines

Besids, all our rpi defconfig are using the DT from the kernel, which is another good indication that we don't need those from rpi-firmware anymore...

If it is not yet in the kernel, it is just a matter of time before it is available there...

Regards,
Yann E. MORIN.

--
.-----------------.--------------------.------------------.--------------------.

|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |

'------------------------------^-------^------------------^--------------------'

#10 lore raw

PATCH 4/4 package/rpi-firmware: improve installation of dtb files

BTW: As you seem to push updates regarding Pi3+ I have some more patches at hand for you :)

https://github.com/jens-maus/RaspberryMatic/blob/master/buildroot-patches/0003-rpi-wifi-firmware.patch
https://github.com/jens-maus/RaspberryMatic/blob/master/buildroot-patches/0004-wiringpi.patch

The first is to actually get WiFi working again because the NVRAM settings file is different for the new WiFi chip of the Pi3+. The second updates the wiringpi package to the latest master version which fixes compatibility to the Pi3+.

Sorry that I am not able to submit these patches myself via patchwork to buildroot, but my time is unfortunately limited these days. However, feel free to submit these patches yourself.

Regards,
Jens

Quoted 77 lines

Am 15.03.2018 um 23:40 schrieb Martin Bark <[email protected]>:

Yann,

Quoted 33 lines · Yann E. MORIN

Martin, All,

On 2018-03-15 19:58 +0000, Martin Bark spake thusly:

Quoted 30 lines · Peter Seiderer
Quoted 28 lines · Martin Bark
Quoted 16 lines

Don't list specific dtb files, instead install all dtb files in the same way as dtbo files are currently done.

Signed-off-by Martin Bark <[email protected]>

---
package/rpi-firmware/rpi-firmware.mk | 7 +++----

1 file changed, 3 insertions(+), 4 deletions(-)
package/rpi-firmware/rpi-firmware.mk +0 -0
index 1ebdd96..9cc3d4a 100644
@@ -12,10 +12,9 @@ RPI_FIRMWARE_INSTALL_IMAGES = YES
 
 ifeq ($(BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS),y)

define RPI_FIRMWARE_INSTALL_DTB

package/rpi-firmware/rpi-firmware.mk RPI_FIRMWARE_INSTALL_IMAGES = YES · line 17

Quoted 7 lines
package/rpi-firmware/rpi-firmware.mk +3 -4
-     $(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b.dtb
-     $(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b-plus.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b-plus.dtb
-     $(INSTALL) -D -m 0644 $(@D)/boot/bcm2709-rpi-2-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2709-rpi-2-b.dtb
-     $(INSTALL) -D -m 0644 $(@D)/boot/bcm2710-rpi-3-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2710-rpi-3-b.dtb
+     for dtb in  $(@D)/boot/*.dtb; do \
+             $(INSTALL) -D -m 0644 $${dtb} $(BINARIES_DIR)/rpi-firmware/$${dtb##*/} || exit 1; \
+     done

Which will install three additional dtb files (bcm2708-rpi-0-w.dtb, bcm2708-rpi-cm.dtb and bcm2710-rpi-cm3.dtb), not a downside of the patch, but worth mentioning....

Quoted 7 lines
Quoted 4 lines

Yes, it will also install the new bcm2710-rpi-3-b-plus.dtb. This code does not seem to have been kept updated, it's missing several dtb files as you mention. I think it's better to just install all dtb files as we do for the dtbo files.

I wonder if we should not just drop BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS now the rpi dtbs are now supposed to be in the kernel snce at least 3.19.

Yes it would be good to remove this. It would also be good to remove BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS and have them built as part of the kernel. Really only the booloader and /op/vc code is needed from rpi-firmware.

Thanks

Martin

Quoted 11 lines

Besids, all our rpi defconfig are using the DT from the kernel, which is another good indication that we don't need those from rpi-firmware anymore...

If it is not yet in the kernel, it is just a matter of time before it is available there...

Regards,
Yann E. MORIN.

Quoted 7 lines

--
.-----------------.--------------------.------------------.--------------------.

|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |

'------------------------------^-------^------------------^--------------------'

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 12 lines
Jens Maus, Dresden/Germany
http://jens-maus.de/

*** Content is authentic only with digital signature  ***

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3745 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180316/8fb58798/attachment.p7s>
author
#11 lore raw

PATCH 4/4 package/rpi-firmware: improve installation of dtb files

Jenus,

Quoted 8 lines · Jens Maus

BTW: As you seem to push updates regarding Pi3+ I have some more patches at hand for you :)

https://github.com/jens-maus/RaspberryMatic/blob/master/buildroot-patches/0003-rpi-wifi-firmware.patch
https://github.com/jens-maus/RaspberryMatic/blob/master/buildroot-patches/0004-wiringpi.patch

The first is to actually get WiFi working again because the NVRAM settings file is different for the new WiFi chip of the Pi3+. The second updates the wiringpi package to the latest master version which fixes compatibility to the Pi3+.

Sorry that I am not able to submit these patches myself via patchwork to buildroot, but my time is unfortunately limited these days. However, feel free to submit these patches yourself.

Yes I'm happy to submit a patch to update rpi-wifi-firmware. I have a rpi3b+ now so i can test this. I don't use wiringpi so i think it might be better if someone else more familiar with the package updates it.

For some reason my v2 patch set disappeared into /dev/null in
patchwork. I'll include the updates to rpi-wifi-firmware and submit
a v3 patchset.

Thanks

Martin

Quoted 3 lines

Regards,
Jens

[--SNIP--]

Quoted 7 lines

--
Jens Maus, Dresden/Germany
http://jens-maus.de/

*** Content is authentic only with digital signature ***

#12 lore raw

PATCH 4/4 package/rpi-firmware: improve installation of dtb files

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Martin" == Martin Bark <[email protected]> writes:

Hi,

Quoted 3 lines

For some reason my v2 patch set disappeared into /dev/null in
patchwork. I'll include the updates to rpi-wifi-firmware and submit
a v3 patchset.

We unfortunately have some reliability issues with patchwork at the moment - Thanks for sending v3.

Signature · 1 line
Bye, Peter Korsgaard
#13 lore raw

PATCH 4/4 package/rpi-firmware: improve installation of dtb files

In reply to Martin Bark

Hi,

Quoted 6 lines

Am 16.03.2018 um 11:52 schrieb Martin Bark <[email protected]>:

Yes I'm happy to submit a patch to update rpi-wifi-firmware. I have a rpi3b+ now so i can test this. I don't use wiringpi so i think it might be better if someone else more familiar with the package updates it.

My patch for wiringpi is quite straight forward and ?just? updates to the latest 2.46 version recently released including necessary patches to the build process patch. IMHO they are quite a no-brainer and can be integrated without any bigger hassle. Thus, it would be great if someone could generate the necessary patchwork stuff accordingly.

Regards,
Jens

Signature · 12 lines
Jens Maus, Dresden/Germany
http://jens-maus.de/

*** Content is authentic only with digital signature  ***

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3745 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180316/2c74c297/attachment.p7s>
author
#14 lore raw

PATCH 4/4 package/rpi-firmware: improve installation of dtb files

Jens,

Quoted 10 lines · Jens Maus

Hi,

Quoted 6 lines

Am 16.03.2018 um 11:52 schrieb Martin Bark <[email protected]>:

Yes I'm happy to submit a patch to update rpi-wifi-firmware. I have a rpi3b+ now so i can test this. I don't use wiringpi so i think it might be better if someone else more familiar with the package updates it.

My patch for wiringpi is quite straight forward and ?just? updates to the latest 2.46 version recently released including necessary patches to the build process patch. IMHO they are quite a no-brainer and can be integrated without any bigger hassle. Thus, it would be great if someone could generate the necessary patchwork stuff accordingly.

I've just submitted a v3 patchset that additionally includes the wifi and bt firmware updates. Once this patchset is in buildroot i'll try and have a look at wiringpi

Thanks

Martin

Quoted 9 lines

Regards,
Jens
--
Jens Maus, Dresden/Germany
http://jens-maus.de/

*** Content is authentic only with digital signature ***

#15 lore raw

PATCH 1/4 package/rpi-firmware: bump version

In reply to Martin Bark

Hello Martin,

Quoted 19 lines · Martin Bark
Signed-off-by Martin Bark <[email protected]>
---
 package/rpi-firmware/rpi-firmware.hash | 2 +-
 package/rpi-firmware/rpi-firmware.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/rpi-firmware/rpi-firmware.hash +1 -1
index 833a7fb..0e09ff5 100644
@@ -1,2 +1,2 @@
 # Locally computed
-sha256 0451e1a843bf02df81126a1625d9a15dfdf19dcb2f9e95b0613a63e59fd31ca8 rpi-firmware-2067241bc7cdf238fdeab7f5a3c22faa57dd5617.tar.gz
+sha256 8fe5ebe14cc900f67242cab0c1c9f8e29bd10369ccbdfc7d004c294a96bad975 rpi-firmware-086a8488de0f485e8879ac14ff505ff1d922eeed.tar.gz
package/rpi-firmware/rpi-firmware.mk +0 -0
index 22eaaa2..1ebdd96 100644

package/rpi-firmware/rpi-firmware.mk line 7

Quoted 5 lines
package/rpi-firmware/rpi-firmware.mk +1 -1
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-RPI_FIRMWARE_VERSION = 2067241bc7cdf238fdeab7f5a3c22faa57dd5617
+RPI_FIRMWARE_VERSION = 086a8488de0f485e8879ac14ff505ff1d922eeed

This commit (and some more before) have a reference to kernel branch 4.14.x, this one with subject 'kernel: Bump to 4.14.26'...

The last commit referencing kernel branch 4.9.x is b1a7f4aea6cbd380319c2849ecc5988f9a4dba70 'kernel: Bump to 4.9.80', for consistence your should bump the firmware version to this commit (or bump the kernel versions to the latest from the 4.14.x branch)...

Regards,
Peter

Quoted 3 lines
package/rpi-firmware/rpi-firmware.mk +0 -0
 RPI_FIRMWARE_SITE = $(call github,raspberrypi,firmware,$(RPI_FIRMWARE_VERSION))
 RPI_FIRMWARE_LICENSE = BSD-3-Clause
 RPI_FIRMWARE_LICENSE_FILES = boot/LICENCE.broadcom
author
#16 lore raw

PATCH 1/4 package/rpi-firmware: bump version

Hi Peter,

Quoted 32 lines · Peter Seiderer

Hello Martin,

Quoted 19 lines · Martin Bark
Signed-off-by Martin Bark <[email protected]>
---
 package/rpi-firmware/rpi-firmware.hash | 2 +-
 package/rpi-firmware/rpi-firmware.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/rpi-firmware/rpi-firmware.hash +1 -1
index 833a7fb..0e09ff5 100644
@@ -1,2 +1,2 @@
 # Locally computed
-sha256 0451e1a843bf02df81126a1625d9a15dfdf19dcb2f9e95b0613a63e59fd31ca8 rpi-firmware-2067241bc7cdf238fdeab7f5a3c22faa57dd5617.tar.gz
+sha256 8fe5ebe14cc900f67242cab0c1c9f8e29bd10369ccbdfc7d004c294a96bad975 rpi-firmware-086a8488de0f485e8879ac14ff505ff1d922eeed.tar.gz
package/rpi-firmware/rpi-firmware.mk +0 -0
index 22eaaa2..1ebdd96 100644

package/rpi-firmware/rpi-firmware.mk line 7

Quoted 5 lines
package/rpi-firmware/rpi-firmware.mk +1 -1
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-RPI_FIRMWARE_VERSION = 2067241bc7cdf238fdeab7f5a3c22faa57dd5617
+RPI_FIRMWARE_VERSION = 086a8488de0f485e8879ac14ff505ff1d922eeed

This commit (and some more before) have a reference to kernel branch 4.14.x, this one with subject 'kernel: Bump to 4.14.26'...

Quoted 3 lines

The last commit referencing kernel branch 4.9.x is b1a7f4aea6cbd380319c2849ecc5988f9a4dba70 'kernel: Bump to 4.9.80', for consistence your should bump the firmware version to this commit (or bump the kernel versions to the latest from the 4.14.x branch)...

Good point i missed that. I'll resubmit my patches and update to the 4.14 kernel instead.

Thanks

Martin

Quoted 8 lines

Regards,
Peter

Quoted 3 lines
package/rpi-firmware/rpi-firmware.mk +0 -0
 RPI_FIRMWARE_SITE = $(call github,raspberrypi,firmware,$(RPI_FIRMWARE_VERSION))
 RPI_FIRMWARE_LICENSE = BSD-3-Clause
 RPI_FIRMWARE_LICENSE_FILES = boot/LICENCE.broadcom