4.14.28-stable review
Subsystems (3)
Greg Kroah-Hartman
maintainercover 4.14.28-stable review
This is the start of the stable review cycle for the 4.14.28 release. There are 109 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun Mar 18 15:22:53 UTC 2018. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.28-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <[email protected]>
Linux 4.14.28-rc1
Anusha Srivatsa <[email protected]>
drm/i915/glk: Disable Guc and HuC on GLK
Sinan Kaya <[email protected]>
dmaengine: qcom_hidma: check pending interrupts
Arnd Bergmann <[email protected]>
IB/mlx5: revisit -Wmaybe-uninitialized warning
Mimi Zohar <[email protected]>
ima: relax requiring a file signature for new files with zero length
Davidlohr Bueso <[email protected]>
locking/locktorture: Fix num reader/writer corner cases
SeongJae Park <[email protected]>
rcutorture/configinit: Fix build directory error message
Mahesh Bandewar <[email protected]>
ipvlan: add L2 check for packets arriving via virtual devices
Christophe Leroy <[email protected]>
Fix misannotated out-of-line _copy_to_user()
Adrian Hunter <[email protected]>
mmc: mmc_test: Ensure command queue is disabled for testing
Dan Carpenter <[email protected]>
ASoC: nuc900: Fix a loop timeout test
Horia Geantă <[email protected]>
crypto: caam/qi - use correct print specifier for size_t
Luca Coelho <[email protected]>
mac80211: remove BUG() when interface type is invalid
Adiel Aloni <[email protected]>
mac80211_hwsim: enforce PS_MANUAL_POLL to be set after PS_ENABLED
Chris Wilson <[email protected]>
agp/intel: Flush all chipset writes after updating the GGTT
Geert Uytterhoeven <[email protected]>
arm64: dts: renesas: salvator-common: Add EthernetAVB PHY reset
Nicholas Piggin <[email protected]>
powerpc/64: Don't trace irqs-off at interrupt return to soft-disabled context
Josh Poimboeuf <[email protected]>
powerpc/modules: Don't try to restore r2 after a sibling call
Yong Zhao <[email protected]>
drm/amdkfd: Fix memory leaks in kfd topology
Stephen Hemminger <[email protected]>
veth: set peer GSO values
John Fastabend <[email protected]>
net: sched: drop qdisc_reset from dev_graft_qdisc
Toshiaki Makita <[email protected]>
virtio_net: Disable interrupts if napi_complete_done rescheduled napi
Gustavo A. R. Silva <[email protected]>
media: davinci: vpif_capture: add NULL check on devm_kzalloc return value
Dan Carpenter <[email protected]>
media: cpia2: Fix a couple off by one bugs
Heinz Mauelshagen <[email protected]>
dm raid: fix raid set size revalidation
Kieran Bingham <[email protected]>
media: vsp1: Prevent suspending and resuming DRM pipelines
Xose Vazquez Perez <[email protected]>
scsi: dh: add new rdac devices
Xose Vazquez Perez <[email protected]>
scsi: devinfo: apply to HP XP the same flags as Hitachi VSP
Bart Van Assche <[email protected]>
scsi: core: scsi_get_device_flags_keyed(): Always return device flags
Michael Chan <[email protected]>
bnxt_en: Don't print "Link speed -1 no longer supported" messages.
Tobias Jordan <[email protected]>
spi: sun6i: disable/unprepare clocks on remove
Julien BOIBESSOT <[email protected]>
tools/usbip: fixes build with musl libc toolchain
Ben Greear <[email protected]>
ath10k: fix invalid STS_CAP_OFFSET_MASK
Limin Zhu <[email protected]>
mwifiex: cfg80211: do not change virtual interface during scan processing
Srinivas Kandagatla <[email protected]>
clk: qcom: msm8916: fix mnd_width for codec_digcodec
Monk Liu <[email protected]>
drm/amdgpu:fix virtual dce bug
Sara Sharon <[email protected]>
iwlwifi: mvm: avoid dumping assert log when device is stopped
Thomas Richter <[email protected]>
perf annotate: Fix objdump comment parsing for Intel mov dissassembly
Thomas Richter <[email protected]>
perf annotate: Fix unnecessary memory allocation for s390x
Takeshi Kihara <[email protected]>
pinctrl: sh-pfc: r8a7795-es1: Fix MOD_SEL1 bit[25:24] to 0x3 when using STP_ISEN_1_D
Fabrizio Castro <[email protected]>
pinctrl: sh-pfc: r8a7791: Add can_clk function
Jernej Skrabec <[email protected]>
drm/sun4i: Fix format mask in DE2 driver
Axel Lin <[email protected]>
pwm: stmpe: Fix wrong register offset for hwpwm=2 case
Li Dongyang <[email protected]>
scsi: ses: don't ask for diagnostic pages repeatedly during probe
Monk Liu <[email protected]>
drm/amdgpu:fix random missing of FLR NOTIFY
Peter Ujfalusi <[email protected]>
dmaengine: amba-pl08x: Use vchan_terminate_vdesc() instead of desc_free
Peter Ujfalusi <[email protected]>
dmaengine: bcm2835-dma: Use vchan_terminate_vdesc() instead of desc_free
Rafael J. Wysocki <[email protected]>
cpufreq: Fix governor module removal race
Manikanta Pubbisetty <[email protected]>
ath10k: update tdls teardown state to target
Peter Meerwald-Stadler <[email protected]>
iio: health: max30102: Add power enable parameter to get_temp function
Stefan Brüns <[email protected]>
iio: adc: ina2xx: Shift bus voltage register to mask flag bits
Philipp Zabel <[email protected]>
drm/etnaviv: make THERMAL selectable
Christophe JAILLET <[email protected]>
power: supply: ab8500_charger: Bail out in case of error in 'ab8500_charger_init_hw_registers()'
Christophe JAILLET <[email protected]>
power: supply: ab8500_charger: Fix an error handling path
Tero Kristo <[email protected]>
clk: ti: clkctrl: add support for retrying failed init
Bjorn Andersson <[email protected]>
leds: pm8058: Silence pointer to integer size warning
Yossef Efraim <[email protected]>
xfrm: Fix xfrm_replay_overflow_offload_esn
Eric W. Biederman <[email protected]>
userns: Don't fail follow_automount based on s_user_ns
Jagdish Gediya <[email protected]>
mtd: nand: ifc: update bufnum mask for ver >= 2.0.0
Andrew F. Davis <[email protected]>
ARM: dts: omap3-n900: Fix the audio CODEC's reset pin
Andrew F. Davis <[email protected]>
ARM: dts: am335x-pepper: Fix the audio CODEC's reset pin
Sunil Goutham <[email protected]>
net: thunderx: Set max queue count taking XDP_TX into account
Miquel Raynal <[email protected]>
mtd: nand: fix interpretation of NAND_CMD_NONE in nand_command[_lp]()
Lorenzo Colitti <[email protected]>
net: xfrm: allow clearing socket xfrm policies.
Alexey Khoroshilov <[email protected]>
rtc: brcmstb-waketimer: fix error handling in brcmstb_waketmr_probe()
Michael Hennerich <[email protected]>
net: ieee802154: adf7242: Fix bug if defined DEBUG
Luis R. Rodriguez <[email protected]>
test_firmware: fix setting old custom fw path back on exit
Colin Ian King <[email protected]>
crypto: cavium - fix memory leak on info
Pierre <[email protected]>
crypto: ecc - Fix NULL pointer deref. on no default_rng
Paul E. McKenney <[email protected]>
sched: Stop resched_cpu() from sending IPIs to offline CPUs
Paul E. McKenney <[email protected]>
sched: Stop switched_to_rt() from sending IPIs to offline CPUs
Johan Hovold <[email protected]>
USB: ledtrig-usbport: fix of-node leak
Adam Thomson <[email protected]>
typec: tcpm: fusb302: Resolve out of order messaging events
Colin Ian King <[email protected]>
staging: rtl8822be: fix missing null check on dev_alloc_skb return
Felix Kuehling <[email protected]>
drm/amdgpu: fix get_max_engine_clock_in_mhz
Simon Shields <[email protected]>
ARM: dts: exynos: Correct Trats2 panel reset line
Yixun Lan <[email protected]>
clk: meson: gxbb: fix wrong clock for SARADC/SANA
Simon Horman <[email protected]>
ARM: dts: koelsch: Move cec_clock to root node
Emmanuel Grumbach <[email protected]>
iwlwifi: mvm: rs: don't override the rate history in the search cycle
Jiri Kosina <[email protected]>
HID: elo: clear BTN_LEFT mapping
Hans de Goede <[email protected]>
HID: multitouch: Only look at non touch fields in first packet of a frame
Ville Syrjälä <[email protected]>
video/hdmi: Allow "empty" HDMI infoframes
Chris Wilson <[email protected]>
dma-buf/fence: Fix lock inversion within dma-fence-array
Jani Nikula <[email protected]>
drm/edid: set ELD connector type in drm_edid_to_eld()
Greg Kroah-Hartman <[email protected]>
Revert "btrfs: use proper endianness accessors for super_copy"
Steffen Maier <[email protected]>
dm mpath: fix passing integrity data
Greentime Hu <[email protected]>
earlycon: add reg-offset to physical address before mapping
Sebastian Andrzej Siewior <[email protected]>
serial: core: mark port as initialized in autoconfig
Nikola Ciprich <[email protected]>
serial: 8250_pci: Add Brainboxes UC-260 4 port serial device
Roger Quadros <[email protected]>
usb: dwc3: Fix lock-up on ID change during system suspend/resume
Xinyong <[email protected]>
usb: gadget: f_fs: Fix use-after-free in ffs_fs_kill_sb()
Pete Zaitcev <[email protected]>
usb: usbmon: Read text within supplied buffer size
Danilo Krummrich <[email protected]>
usb: quirks: add control message delay for 1b1c:1b20
Colin Ian King <[email protected]>
usbip: vudc: fix null pointer dereference on udc->lock
Teijo Kinnunen <[email protected]>
USB: storage: Add JMicron bridge 152d:2567 to unusual_devs.h
Joel Fernandes <[email protected]>
staging: android: ashmem: Fix lockdep issue during llseek
Frank Mori Hess <[email protected]>
staging: comedi: fix comedi_nsamples_left.
Oliver Neukum <[email protected]>
uas: fix comparison for error code
Jonas Danielsson <[email protected]>
tty/serial: atmel: add new version check for usart
Ulrich Hecht <[email protected]>
serial: sh-sci: prevent lockup on full TTY buffers
Mathias Nyman <[email protected]>
xhci: fix endpoint context tracer output
Kai-Heng Feng <[email protected]>
xhci: Fix front USB ports on ASUS PRIME B350M-A
Yoshihiro Shimoda <[email protected]>
usb: host: xhci-rcar: add support for r8a77965
Hans de Goede <[email protected]>
ASoC: rt5651: Fix regcache sync errors on resume
Richard Fitzgerald <[email protected]>
ASoC: wm_adsp: For TLV controls only register TLV get/set
Fabio Estevam <[email protected]>
ASoC: sgtl5000: Fix suspend/resume
Yong Deng <[email protected]>
ASoC: sun4i-i2s: Fix RX slot number of SUN8I
H.J. Lu <[email protected]>
x86: Treat R_X86_64_PLT32 as R_X86_64_PC32
Andrew Lunn <[email protected]>
net: phy: Restore phy_resume() locking assumption
Russell King <[email protected]>
net: phy: fix resume handling
-------------
Diffstat:
Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 + Makefile | 4 +- arch/arm/boot/dts/am335x-pepper.dts | 2 +- arch/arm/boot/dts/exynos4412-trats2.dts | 2 +- arch/arm/boot/dts/omap3-n900.dts | 4 +- arch/arm/boot/dts/r8a7791-koelsch.dts | 12 +- arch/arm64/boot/dts/renesas/salvator-common.dtsi | 1 + arch/powerpc/include/asm/code-patching.h | 1 + arch/powerpc/kernel/entry_64.S | 10 +- arch/powerpc/kernel/module_64.c | 12 +- arch/powerpc/lib/code-patching.c | 5 + arch/x86/kernel/machine_kexec_64.c | 1 + arch/x86/kernel/module.c | 1 + arch/x86/tools/relocs.c | 3 + crypto/ecc.c | 2 +- drivers/base/Kconfig | 1 + drivers/char/agp/intel-gtt.c | 2 + drivers/clk/meson/gxbb.c | 4 +- drivers/clk/qcom/gcc-msm8916.c | 1 + drivers/clk/ti/clkctrl.c | 12 +- drivers/cpufreq/cpufreq.c | 6 + drivers/crypto/caam/caamalg_qi.c | 6 +- drivers/crypto/cavium/cpt/cptvf_reqmanager.c | 3 +- drivers/dma-buf/dma-fence-array.c | 14 ++- drivers/dma/amba-pl08x.c | 11 +- drivers/dma/bcm2835-dma.c | 10 +- drivers/dma/qcom/hidma_ll.c | 9 +- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 7 +- drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 4 +- drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c | 14 ++- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 10 ++ drivers/gpu/drm/drm_edid.c | 9 +- drivers/gpu/drm/etnaviv/Kconfig | 9 ++ drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 8 +- drivers/gpu/drm/i915/intel_guc_loader.c | 9 -- drivers/gpu/drm/i915/intel_huc.c | 11 -- drivers/gpu/drm/sun4i/sun8i_mixer.h | 2 +- drivers/hid/hid-elo.c | 6 + drivers/hid/hid-multitouch.c | 17 ++- drivers/iio/adc/ina2xx-adc.c | 26 +++-- drivers/iio/health/max30102.c | 36 +++--- drivers/infiniband/hw/mlx5/mr.c | 3 + drivers/leds/leds-pm8058.c | 2 +- drivers/md/dm-mpath.c | 5 +- drivers/md/dm-raid.c | 30 +++-- drivers/media/platform/davinci/vpif_capture.c | 2 + drivers/media/platform/vsp1/vsp1_drv.c | 16 ++- drivers/media/usb/cpia2/cpia2_v4l.c | 4 +- drivers/mmc/core/mmc_test.c | 11 +- drivers/mtd/nand/fsl_ifc_nand.c | 7 ++ drivers/mtd/nand/nand_base.c | 9 +- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 10 +- drivers/net/ethernet/cavium/thunder/nicvf_main.c | 5 + drivers/net/ieee802154/adf7242.c | 4 +- drivers/net/ipvlan/ipvlan_core.c | 4 + drivers/net/phy/at803x.c | 4 - drivers/net/phy/phy.c | 9 +- drivers/net/phy/phy_device.c | 20 +++- drivers/net/veth.c | 3 + drivers/net/virtio_net.c | 9 +- drivers/net/wireless/ath/ath10k/mac.c | 10 ++ drivers/net/wireless/ath/ath10k/wmi.h | 3 +- drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 4 +- drivers/net/wireless/intel/iwlwifi/mvm/utils.c | 6 + drivers/net/wireless/mac80211_hwsim.c | 17 ++- drivers/net/wireless/marvell/mwifiex/cfg80211.c | 6 + drivers/pinctrl/sh-pfc/pfc-r8a7791.c | 22 +++- drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c | 2 +- drivers/power/supply/ab8500_charger.c | 6 +- drivers/pwm/pwm-stmpe.c | 2 +- drivers/rtc/rtc-brcmstb-waketimer.c | 15 ++- drivers/scsi/scsi_devinfo.c | 9 +- drivers/scsi/scsi_dh.c | 5 +- drivers/scsi/ses.c | 11 +- drivers/spi/spi-sun6i.c | 2 +- drivers/staging/android/ashmem.c | 15 ++- drivers/staging/comedi/drivers.c | 3 +- drivers/staging/rtlwifi/rtl8822be/fw.c | 2 + drivers/staging/typec/fusb302/fusb302.c | 21 +++- drivers/tty/serial/8250/8250_pci.c | 11 ++ drivers/tty/serial/atmel_serial.c | 1 + drivers/tty/serial/earlycon.c | 3 +- drivers/tty/serial/serial_core.c | 2 + drivers/tty/serial/sh-sci.c | 2 + drivers/usb/core/ledtrig-usbport.c | 8 +- drivers/usb/core/message.c | 4 + drivers/usb/core/quirks.c | 3 +- drivers/usb/dwc3/core.c | 2 +- drivers/usb/gadget/function/f_fs.c | 1 - drivers/usb/host/xhci-pci.c | 3 + drivers/usb/host/xhci-rcar.c | 4 + drivers/usb/host/xhci.c | 3 + drivers/usb/host/xhci.h | 23 ++-- drivers/usb/mon/mon_text.c | 126 +++++++++++++-------- drivers/usb/storage/uas.c | 2 +- drivers/usb/storage/unusual_devs.h | 7 ++ drivers/usb/usbip/vudc_sysfs.c | 8 +- drivers/video/hdmi.c | 51 +++++---- fs/btrfs/sysfs.c | 8 +- fs/btrfs/transaction.c | 20 ++-- fs/namei.c | 3 - include/linux/dma-fence-array.h | 3 + include/linux/phy.h | 1 + include/linux/usb/quirks.h | 3 + kernel/locking/locktorture.c | 76 +++++++------ kernel/sched/core.c | 3 +- kernel/sched/rt.c | 2 +- lib/usercopy.c | 2 +- net/mac80211/iface.c | 2 +- net/sched/sch_generic.c | 28 +++-- net/xfrm/xfrm_policy.c | 2 +- net/xfrm/xfrm_replay.c | 3 +- net/xfrm/xfrm_state.c | 7 ++ security/integrity/ima/ima_appraise.c | 3 +- sound/soc/codecs/rt5651.c | 1 + sound/soc/codecs/sgtl5000.c | 11 ++ sound/soc/codecs/wm_adsp.c | 14 ++- sound/soc/nuc900/nuc900-ac97.c | 4 +- sound/soc/sunxi/sun4i-i2s.c | 2 +- tools/perf/arch/s390/annotate/instructions.c | 3 +- tools/perf/util/annotate.c | 8 +- tools/testing/selftests/firmware/fw_filesystem.sh | 5 +- .../testing/selftests/rcutorture/bin/configinit.sh | 2 +- tools/usb/usbip/src/usbipd.c | 2 +- 124 files changed, 763 insertions(+), 345 deletions(-)
Greg Kroah-Hartman
maintainerPATCH 1/109 net: phy: fix resume handling
4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Russell King <[email protected]>
[ Upstream commit f5e64032a799d4f54decc7eb6aafcdffb67f9ad9 ]
When a PHY has the BMCR_PDOWN bit set, it may decide to ignore writes to other registers, or reset the registers to power-on defaults. Micrel PHYs do this for their interrupt registers.
The current structure of phylib tries to enable interrupts before resuming (and releasing) the BMCR_PDOWN bit. This fails, causing Micrel PHYs to stop working after a suspend/resume sequence if they are using interrupts.
Fix this by ensuring that the PHY driver resume methods do not take the phydev->lock mutex themselves, but the callers of phy_resume() take that lock. This then allows us to move the call to phy_resume() before we enable interrupts in phy_start().
--- drivers/net/phy/at803x.c | 4 ---- drivers/net/phy/phy.c | 9 +++------ drivers/net/phy/phy_device.c | 10 ++++++---- 3 files changed, 9 insertions(+), 14 deletions(-)
drivers/net/phy/at803x.c +0 -4
@@ -239,14 +239,10 @@ static int at803x_resume(struct phy_devi {int value; -mutex_lock (&phydev->lock); - value =phy_read (phydev,MII_BMCR ); value &= ~(BMCR_PDOWN |BMCR_ISOLATE );phy_write (phydev,MII_BMCR , value); -mutex_unlock (&phydev->lock); -return 0 ; }
drivers/net/phy/phy.c +3 -6
@@ -828,7 +828,6 @@ EXPORT_SYMBOL(phy_stop);*/ void phy_start (struct phy_device *phydev) { -bool do_resume = false;int err =0 ;mutex_lock (&phydev->lock);
@@ -841,6 +840,9 @@ void phy_start(struct phy_device *phydev phydev->state =PHY_UP ;break ;case PHY_HALTED : +/* if phy was suspended, bring the physical link up again */ +phy_resume (phydev); +/* make sure interrupts are re-enabled for the PHY */ if (phy_interrupt_is_valid (phydev)) { err =phy_enable_interrupts (phydev);
@@ -849,17 +851,12 @@ void phy_start(struct phy_device *phydev } phydev->state =PHY_RESUMING ; - do_resume = true;break ;default :break ; }mutex_unlock (&phydev->lock); -/* if phy was suspended, bring the physical link up again */ -if (do_resume) -phy_resume (phydev); -phy_trigger_machine (phydev, true); }EXPORT_SYMBOL (phy_start);
drivers/net/phy/phy_device.c +6 -4
@@ -135,7 +135,9 @@ static int mdio_bus_phy_resume(struct deif (!mdio_bus_phy_may_suspend (phydev)) goto no_resume; +mutex_lock (&phydev->lock); ret =phy_resume (phydev); +mutex_unlock (&phydev->lock);if (ret <0 )return ret;
@@ -1026,7 +1028,9 @@ int phy_attach_direct(struct net_deviceif (err) goto error; +mutex_lock (&phydev->lock);phy_resume (phydev); +mutex_unlock (&phydev->lock);phy_led_triggers_register (phydev);return err;
@@ -1157,6 +1161,8 @@ int phy_resume(struct phy_device *phydevstruct phy_driver *phydrv =to_phy_driver (phydev->mdio.dev.driver);int ret =0 ; +WARN_ON (!mutex_is_locked (&phydev->lock)); +if (phydev->drv && phydrv->resume) ret = phydrv->resume (phydev);
@@ -1639,13 +1645,9 @@ int genphy_resume(struct phy_device *phy {int value; -mutex_lock (&phydev->lock); - value =phy_read (phydev,MII_BMCR );phy_write (phydev,MII_BMCR , value & ~BMCR_PDOWN ); -mutex_unlock (&phydev->lock); -return 0 ; }EXPORT_SYMBOL (genphy_resume);
Greg Kroah-Hartman
maintainerPATCH 2/109 net: phy: Restore phy_resume() locking assumption
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Andrew Lunn <[email protected]>
commit 9c2c2e62df3fa30fb13fbeb7512a4eede729383b upstream.
commit f5e64032a799 ("net: phy: fix resume handling") changes the locking semantics for phy_resume() such that the caller now needs to hold the phy mutex. Not all call sites were adopted to this new semantic, resulting in warnings from the added WARN_ON(!mutex_is_locked(&phydev->lock)). Rather than change the semantics, add a __phy_resume() and restore the old behavior of phy_resume().
--- drivers/net/phy/phy.c | 2 +- drivers/net/phy/phy_device.c | 18 +++++++++++++----- include/linux/phy.h | 1 + 3 files changed, 15 insertions(+), 6 deletions(-)
drivers/net/phy/phy.c +1 -1
@@ -841,7 +841,7 @@ void phy_start(struct phy_device *phydevbreak ;case PHY_HALTED :/* if phy was suspended, bring the physical link up again */ -phy_resume (phydev); +__phy_resume (phydev);/* make sure interrupts are re-enabled for the PHY */ if (phy_interrupt_is_valid (phydev)) {
drivers/net/phy/phy_device.c +13 -5
@@ -135,9 +135,7 @@ static int mdio_bus_phy_resume(struct deif (!mdio_bus_phy_may_suspend (phydev)) goto no_resume; -mutex_lock (&phydev->lock); ret =phy_resume (phydev); -mutex_unlock (&phydev->lock);if (ret <0 )return ret;
@@ -1028,9 +1026,7 @@ int phy_attach_direct(struct net_deviceif (err) goto error; -mutex_lock (&phydev->lock);phy_resume (phydev); -mutex_unlock (&phydev->lock);phy_led_triggers_register (phydev);return err;
@@ -1156,7 +1152,7 @@ int phy_suspend(struct phy_device *phyde }EXPORT_SYMBOL (phy_suspend); -int phy_resume (struct phy_device *phydev) +int __phy_resume (struct phy_device *phydev) {struct phy_driver *phydrv =to_phy_driver (phydev->mdio.dev.driver);int ret =0 ;
@@ -1173,6 +1169,18 @@ int phy_resume(struct phy_device *phydevreturn ret; } +EXPORT_SYMBOL (__phy_resume); + +int phy_resume (struct phy_device *phydev) +{ +int ret; + +mutex_lock (&phydev->lock); + ret =__phy_resume (phydev); +mutex_unlock (&phydev->lock); + +return ret; +}EXPORT_SYMBOL (phy_resume);int phy_loopback (struct phy_device *phydev,bool enable)
include/linux/phy.h +1 -0
@@ -817,6 +817,7 @@ void phy_device_remove(struct phy_deviceint phy_init_hw (struct phy_device *phydev);int phy_suspend (struct phy_device *phydev);int phy_resume (struct phy_device *phydev); +int __phy_resume (struct phy_device *phydev);int phy_loopback (struct phy_device *phydev,bool enable);struct phy_device *phy_attach (struct net_device *dev,const char *bus_id,phy_interface_t interface);
Greg Kroah-Hartman
maintainerPATCH 3/109 x86: Treat R_X86_64_PLT32 as R_X86_64_PC32
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: H.J. Lu <[email protected]>
commit b21ebf2fb4cde1618915a97cc773e287ff49173e upstream.
On i386, there are 2 types of PLTs, PIC and non-PIC. PIE and shared objects must use PIC PLT. To use PIC PLT, you need to load _GLOBAL_OFFSET_TABLE_ into EBX first. There is no need for that on x86-64 since x86-64 uses PC-relative PLT.
On x86-64, for 32-bit PC-relative branches, we can generate PLT32 relocation, instead of PC32 relocation, which can also be used as a marker for 32-bit PC-relative branches. Linker can always reduce
PLT32 relocation to PC32 if function is defined locally. Local
functions should use PC32 relocation. As far as Linux kernel is concerned, R_X86_64_PLT32 can be treated the same as R_X86_64_PC32 since Linux kernel doesn't use PLT.
R_X86_64_PLT32 for 32-bit PC-relative branches has been enabled in binutils master branch which will become binutils 2.31.
[ hjl is working on having better documentation on this all, but a few
more notes from him:
"PLT32 relocation is used as marker for PC-relative branches. Because
of EBX, it looks odd to generate PLT32 relocation on i386 when EBX doesn't have GOT.
As for symbol resolution, PLT32 and PC32 relocations are almost interchangeable. But when linker sees PLT32 relocation against a protected symbol, it can resolved locally at link-time since it is used on a branch instruction. Linker can't do that for PC32 relocation"
but for the kernel use, the two are basically the same, and this commit gets things building and working with the current binutils
master - Linus ]
--- arch/x86/kernel/machine_kexec_64.c | 1 + arch/x86/kernel/module.c | 1 + arch/x86/tools/relocs.c | 3 +++ 3 files changed, 5 insertions(+)
arch/x86/kernel/machine_kexec_64.c +1 -0
@@ -542,6 +542,7 @@ int arch_kexec_apply_relocations_add(con goto overflow;break ;case R_X86_64_PC32 : +case R_X86_64_PLT32 : value -= (u64 )address; *(u32 *)location = value;break ;
arch/x86/kernel/module.c +1 -0
@@ -191,6 +191,7 @@ int apply_relocate_add(Elf64_Shdr *sechd goto overflow;break ;case R_X86_64_PC32 : +case R_X86_64_PLT32 :if (*(u32 *)loc !=0 ) goto invalid_relocation; val -= (u64 )loc;
arch/x86/tools/relocs.c +3 -0
@@ -770,9 +770,12 @@ static int do_reloc64(struct section *sebreak ;case R_X86_64_PC32 : +case R_X86_64_PLT32 :/* * PC relative relocations don't need to be adjusted unless * referencing a percpu symbol. +* +* NB: R_X86_64_PLT32 can be treated as R_X86_64_PC32. */ if (is_percpu_sym (sym, symname))add_reloc (&relocs32neg, offset);
Greg Kroah-Hartman
maintainerPATCH 4/109 ASoC: sun4i-i2s: Fix RX slot number of SUN8I
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Yong Deng <[email protected]>
commit 5a3386790a172cf738194e1574f631cd43c6140a upstream.
I2S's RX slot number of SUN8I should be shifted 4 bit to left.
--- sound/soc/sunxi/sun4i-i2s.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/sunxi/sun4i-i2s.c +1 -1
@@ -104,7 +104,7 @@#define SUN8I_I2S_CHAN_CFG_REG 0x30#define SUN8I_I2S_CHAN_CFG_RX_SLOT_NUM_MASK GENMASK(6, 4) -#define SUN8I_I2S_CHAN_CFG_RX_SLOT_NUM (chan) (chan - 1) +#define SUN8I_I2S_CHAN_CFG_RX_SLOT_NUM (chan) ((chan - 1) << 4)#define SUN8I_I2S_CHAN_CFG_TX_SLOT_NUM_MASK GENMASK(2, 0)#define SUN8I_I2S_CHAN_CFG_TX_SLOT_NUM (chan) (chan - 1)
Greg Kroah-Hartman
maintainerPATCH 5/109 ASoC: sgtl5000: Fix suspend/resume
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Fabio Estevam <[email protected]>
commit a8992973edbb2555e956b90f6fe97c4bc14d761d upstream.
Commit 8419caa72702 ("ASoC: sgtl5000: Do not disable regulators in SND_SOC_BIAS_OFF") causes the sgtl5000 to fail after a suspend/resume sequence:
Playing WAVE '/media/a2002011001-e02.wav' : Signed 16 bit Little Endian, Rate 44100 Hz, Stereo
aplay: pcm_write:2051: write error: Input/output error
The problem is caused by the fact that the aforementioned commit dropped the cache handling, so re-introduce the register map resync to fix the problem.
--- sound/soc/codecs/sgtl5000.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
sound/soc/codecs/sgtl5000.c +11 -0
@@ -871,15 +871,26 @@ static int sgtl5000_pcm_hw_params(structstatic int sgtl5000_set_bias_level (struct snd_soc_codec *codec,enum snd_soc_bias_level level) { +struct sgtl5000_priv *sgtl =snd_soc_codec_get_drvdata (codec); +int ret; +switch (level) {case SND_SOC_BIAS_ON :case SND_SOC_BIAS_PREPARE :case SND_SOC_BIAS_STANDBY : +regcache_cache_only (sgtl->regmap, false); + ret =regcache_sync (sgtl->regmap); +if (ret) { +regcache_cache_only (sgtl->regmap, true); +return ret; + } +snd_soc_update_bits (codec,SGTL5000_CHIP_ANA_POWER ,SGTL5000_REFTOP_POWERUP ,SGTL5000_REFTOP_POWERUP );break ;case SND_SOC_BIAS_OFF : +regcache_cache_only (sgtl->regmap, true);snd_soc_update_bits (codec,SGTL5000_CHIP_ANA_POWER ,SGTL5000_REFTOP_POWERUP ,0 );break ;
Greg Kroah-Hartman
maintainerPATCH 6/109 ASoC: wm_adsp: For TLV controls only register TLV get/set
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Richard Fitzgerald <[email protected]>
commit d7789f5bcdb298c4a302db471b1b20f74a20de95 upstream.
Normal 512-byte get/set of a TLV isn't supported but we were registering the normal get/set anyway and relying on omitting the SNDRV_CTL_ELEM_ACCESS_[READ|WRITE] flags to prevent them being called.
Trouble is if this gets broken in the core ALSA code - as it has been since at least 4.14 - the standard get/set can be called unexpectedly and corrupt memory.
There's no point providing functions that won't be called and it's a trivial change. The benefit is that if the ALSA core gets broken again we get a big fat immediate NULL dereference instead of a memory corruption timebomb.
--- sound/soc/codecs/wm_adsp.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)
sound/soc/codecs/wm_adsp.c +8 -6
@@ -1204,12 +1204,14 @@ static int wmfw_add_ctl(struct wm_adsp * kcontrol->put = wm_coeff_put_acked;break ;default : - kcontrol->get = wm_coeff_get; - kcontrol->put = wm_coeff_put; - - ctl->bytes_ext.max = ctl->len; - ctl->bytes_ext.get = wm_coeff_tlv_get; - ctl->bytes_ext.put = wm_coeff_tlv_put; +if (kcontrol->access &SNDRV_CTL_ELEM_ACCESS_TLV_CALLBACK ) { + ctl->bytes_ext.max = ctl->len; + ctl->bytes_ext.get = wm_coeff_tlv_get; + ctl->bytes_ext.put = wm_coeff_tlv_put; + }else { + kcontrol->get = wm_coeff_get; + kcontrol->put = wm_coeff_put; + }break ; }
Greg Kroah-Hartman
maintainerPATCH 7/109 ASoC: rt5651: Fix regcache sync errors on resume
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Hans de Goede <[email protected]>
commit 2d30e9494f1ea320aaaad0cff9ddd92c87eac355 upstream.
The ALC5651 does not like multi-write accesses, avoid them. This fixes:
rt5651 i2c-10EC5651:00: Unable to sync registers 0x27-0x28. -121
Errors on resume (and all registers after the registers in the error not being synced).
--- sound/soc/codecs/rt5651.c | 1 + 1 file changed, 1 insertion(+)
sound/soc/codecs/rt5651.c +1 -0
@@ -1694,6 +1694,7 @@ static const struct regmap_config rt5651 .num_reg_defaults = ARRAY_SIZE(rt5651_reg), .ranges = rt5651_ranges, .num_ranges = ARRAY_SIZE(rt5651_ranges), + .use_single_rw = true, };#if defined(CONFIG_OF )
Greg Kroah-Hartman
maintainerPATCH 8/109 usb: host: xhci-rcar: add support for r8a77965
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Yoshihiro Shimoda <[email protected]>
commit 015dbeb2282030bf56762e21d25f09422edfd750 upstream.
This patch adds support for r8a77965 (R-Car M3-N).
--- Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 + drivers/usb/host/xhci-rcar.c | 4 ++++ 2 files changed, 5 insertions(+)
Documentation/devicetree/bindings/usb/usb-xhci.txt +1 -0
@@ -12,6 +12,7 @@ Required properties: - "renesas,xhci-r8a7793" for r8a7793 SoC - "renesas,xhci-r8a7795" for r8a7795 SoC - "renesas,xhci-r8a7796" for r8a7796 SoC + - "renesas,xhci-r8a77965" for r8a77965 SoC - "renesas,rcar-gen2-xhci" for a generic R-Car Gen2 compatible device - "renesas,rcar-gen3-xhci" for a generic R-Car Gen3 compatible device - "xhci-platform" (deprecated)
drivers/usb/host/xhci-rcar.c +4 -0
@@ -86,6 +86,10 @@ static const struct soc_device_attribute .soc_id = "r8a7796", .data = (void *)RCAR_XHCI_FIRMWARE_V3, }, + { + .soc_id = "r8a77965", + .data = (void *)RCAR_XHCI_FIRMWARE_V3, + }, { /* sentinel */ }, };
Greg Kroah-Hartman
maintainerPATCH 9/109 xhci: Fix front USB ports on ASUS PRIME B350M-A
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Kai-Heng Feng <[email protected]>
commit 191edc5e2e515aab1075a3f0ef23599e80be5f59 upstream.
When a USB device gets plugged on ASUS PRIME B350M-A's front ports, the xHC stops working:
[ 549.114587] xhci_hcd 0000:02:00.0: WARN: xHC CMD_RUN timeout [ 549.114608] suspend_common(): xhci_pci_suspend+0x0/0xc0 returns -110 [ 549.114638] xhci_hcd 0000:02:00.0: can't suspend (hcd_pci_runtime_suspend returned -110)
Delay before running xHC command CMD_RUN can workaround the issue.
Use a new quirk to make the delay only targets to the affected xHC.
--- drivers/usb/host/xhci-pci.c | 3 +++ drivers/usb/host/xhci.c | 3 +++ drivers/usb/host/xhci.h | 1 + 3 files changed, 7 insertions(+)
drivers/usb/host/xhci-pci.c +3 -0
@@ -134,6 +134,9 @@ static void xhci_pci_quirks(struct devicif (pdev->vendor ==PCI_VENDOR_ID_AMD &&usb_amd_find_chipset_info ()) xhci->quirks |=XHCI_AMD_PLL_FIX ; +if (pdev->vendor ==PCI_VENDOR_ID_AMD && pdev->device ==0x43bb ) + xhci->quirks |=XHCI_SUSPEND_DELAY ; +if (pdev->vendor ==PCI_VENDOR_ID_AMD ) xhci->quirks |=XHCI_TRUST_TX_LENGTH ;
drivers/usb/host/xhci.c +3 -0
@@ -887,6 +887,9 @@ int xhci_suspend(struct xhci_hcd *xhci,clear_bit (HCD_FLAG_POLL_RH , &xhci->shared_hcd->flags);del_timer_sync (&xhci->shared_hcd->rh_timer); +if (xhci->quirks &XHCI_SUSPEND_DELAY ) +usleep_range (1000 ,1500 ); +spin_lock_irq (&xhci->lock);clear_bit (HCD_FLAG_HW_ACCESSIBLE , &hcd->flags);clear_bit (HCD_FLAG_HW_ACCESSIBLE , &xhci->shared_hcd->flags);
drivers/usb/host/xhci.h +1 -0
@@ -1830,6 +1830,7 @@ struct xhci_hcd {#define XHCI_LIMIT_ENDPOINT_INTERVAL_7 (1 << 26)/* Reserved. It was XHCI_U2_DISABLE_WAKE */ #define XHCI_ASMEDIA_MODIFY_FLOWCONTROL (1 << 28) +#define XHCI_SUSPEND_DELAY (1 << 30)unsigned int num_active_eps;unsigned int limit_active_eps;
Greg Kroah-Hartman
maintainerPATCH 10/109 xhci: fix endpoint context tracer output
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Mathias Nyman <[email protected]>
commit 97ef0faf575e03b352553f92c9430cb4c0431436 upstream.
Fix incorrent values showed for max Primary stream and Linear stream array (LSA) values in the endpoint context decoder.
--- drivers/usb/host/xhci.h | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-)
drivers/usb/host/xhci.h +12 -10
@@ -728,11 +728,12 @@ struct xhci_ep_ctx {/* bits 10:14 are Max Primary Streams */ /* bit 15 is Linear Stream Array */ /* Interval - period between requests to an endpoint - 125u increments. */ -#define EP_INTERVAL (p) (((p) & 0xff) << 16) -#define EP_INTERVAL_TO_UFRAMES (p) (1 << (((p) >> 16) & 0xff)) -#define CTX_TO_EP_INTERVAL (p) (((p) >> 16) & 0xff) -#define EP_MAXPSTREAMS_MASK (0x1f << 10) -#define EP_MAXPSTREAMS (p) (((p) << 10) & EP_MAXPSTREAMS_MASK) +#define EP_INTERVAL (p) (((p) & 0xff) << 16) +#define EP_INTERVAL_TO_UFRAMES (p) (1 << (((p) >> 16) & 0xff)) +#define CTX_TO_EP_INTERVAL (p) (((p) >> 16) & 0xff) +#define EP_MAXPSTREAMS_MASK (0x1f << 10) +#define EP_MAXPSTREAMS (p) (((p) << 10) & EP_MAXPSTREAMS_MASK) +#define CTX_TO_EP_MAXPSTREAMS (p) (((p) & EP_MAXPSTREAMS_MASK) >> 10)/* Endpoint is set up with a Linear Stream Array (vs. Secondary Stream Array) */ #define EP_HAS_LSA (1 << 15)/* hosts with LEC=1 use bits 31:24 as ESIT high bits. */
@@ -2540,21 +2541,22 @@ static inline const char *xhci_decode_epu8 burst;u8 cerr;u8 mult; -u8 lsa; -u8 hid; + +bool lsa; +bool hid; esit =CTX_TO_MAX_ESIT_PAYLOAD_HI (info) <<16 |CTX_TO_MAX_ESIT_PAYLOAD (tx_info); ep_state = info &EP_STATE_MASK ; - max_pstr = info &EP_MAXPSTREAMS_MASK ; + max_pstr =CTX_TO_EP_MAXPSTREAMS (info); interval =CTX_TO_EP_INTERVAL (info); mult =CTX_TO_EP_MULT (info) +1 ; - lsa = info &EP_HAS_LSA ; + lsa = !!(info &EP_HAS_LSA ); cerr = (info2 & (3 <<1 )) >>1 ; ep_type =CTX_TO_EP_TYPE (info2); - hid = info2 & (1 <<7 ); + hid = !!(info2 & (1 <<7 )); burst =CTX_TO_MAX_BURST (info2); maxp =MAX_PACKET_DECODED (info2);
Greg Kroah-Hartman
maintainerPATCH 11/109 serial: sh-sci: prevent lockup on full TTY buffers
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ulrich Hecht <[email protected]>
commit 7842055bfce4bf0170d0f61df8b2add8399697be upstream.
When the TTY buffers fill up to the configured maximum, a system lockup occurs:
[ 598.820128] INFO: rcu_preempt detected stalls on CPUs/tasks: [ 598.825796] 0-...!: (1 GPs behind) idle=5a6/2/0 softirq=1974/1974 fqs=1 [ 598.832577] (detected by 3, t=62517 jiffies, g=296, c=295, q=126) [ 598.838755] Task dump for CPU 0: [ 598.841977] swapper/0 R running task 0 0 0 0x00000022 [ 598.849023] Call trace: [ 598.851476] __switch_to+0x98/0xb0 [ 598.854870] (null)
This can be prevented by doing a dummy read of the RX data register.
This issue affects both HSCIF and SCIF ports. Reported for R-Car H3 ES2.0; reproduced and fixed on H3 ES1.1. Probably affects other R-Car platforms as well.
--- drivers/tty/serial/sh-sci.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/tty/serial/sh-sci.c +2 -0
@@ -886,6 +886,8 @@ static void sci_receive_chars(struct uar/* Tell the rest of the system the news. New characters! */ tty_flip_buffer_push (tport); }else { +/* TTY buffers full; read from RX reg to prevent lockup */ +serial_port_in (port, SCxRDR);serial_port_in (port, SCxSR);/* dummy read */ sci_clear_SCxSR (port,SCxSR_RDxF_CLEAR (port)); }
Greg Kroah-Hartman
maintainerPATCH 12/109 tty/serial: atmel: add new version check for usart
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jonas Danielsson <[email protected]>
commit fd63a8903a2c40425a9811c3371dd4d0f42c0ad3 upstream.
On our at91sam9260 based board the usart0 and usart1 ports report their versions (ATMEL_US_VERSION) as 0x10302. This version is not included in the current checks in the driver.
--- drivers/tty/serial/atmel_serial.c | 1 + 1 file changed, 1 insertion(+)
drivers/tty/serial/atmel_serial.c +1 -0
@@ -1763,6 +1763,7 @@ static void atmel_get_ip_name(struct uarswitch (version) {case 0x302 :case 0x10213 : +case 0x10302 :dev_dbg (port->dev,"This version is usart\n" ); atmel_port->has_frac_baudrate = true; atmel_port->has_hw_timer = true;
Greg Kroah-Hartman
maintainerPATCH 13/109 uas: fix comparison for error code
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Oliver Neukum <[email protected]>
commit 9a513c905bb95bef79d96feb08621c1ec8d8c4bb upstream.
A typo broke the comparison.
--- drivers/usb/storage/uas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/storage/uas.c +1 -1
@@ -1076,7 +1076,7 @@ static int uas_post_reset(struct usb_intreturn 0 ; err =uas_configure_endpoints (devinfo); -if (err && err !=ENODEV ) +if (err && err != -ENODEV )shost_printk (KERN_ERR , shost,"%s: alloc streams error %d after reset" , __func__, err);
Greg Kroah-Hartman
maintainerPATCH 14/109 staging: comedi: fix comedi_nsamples_left.
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Frank Mori Hess <[email protected]>
commit a42ae5905140c324362fe5036ae1dbb16e4d359c upstream.
A rounding error was causing comedi_nsamples_left to return the wrong value when nsamples was not a multiple of the scan length.
--- drivers/staging/comedi/drivers.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/comedi/drivers.c +1 -2
@@ -484,8 +484,7 @@ unsigned int comedi_nsamples_left(structstruct comedi_cmd *cmd = &async->cmd;if (cmd->stop_src ==TRIG_COUNT ) { -unsigned int nscans = nsamples / cmd->scan_end_arg; -unsigned int scans_left =__comedi_nscans_left (s, nscans); +unsigned int scans_left =__comedi_nscans_left (s, cmd->stop_arg);unsigned int scan_pos =comedi_bytes_to_samples (s, async->scan_progress);unsigned long long samples_left =0 ;
Greg Kroah-Hartman
maintainerPATCH 15/109 staging: android: ashmem: Fix lockdep issue during llseek
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Joel Fernandes <[email protected]>
commit cb57469c9573f6018cd1302953dd45d6e05aba7b upstream.
ashmem_mutex create a chain of dependencies like so:
(1)
mmap syscall ->
mmap_sem -> (acquired)
ashmem_mmap
ashmem_mutex (try to acquire)
(block)
(2)
llseek syscall ->
ashmem_llseek ->
ashmem_mutex -> (acquired)
inode_lock ->
inode->i_rwsem (try to acquire)
(block)
(3)
getdents ->
iterate_dir ->
inode_lock ->
inode->i_rwsem (acquired)
copy_to_user ->
mmap_sem (try to acquire)
There is a lock ordering created between mmap_sem and inode->i_rwsem causing a lockdep splat [2] during a syzcaller test, this patch fixes the issue by unlocking the mutex earlier. Functionally that's Ok since we don't need to protect vfs_llseek.
[1] https://patchwork.kernel.org/patch/10185031/
[2] https://lkml.org/lkml/2018/1/10/48
--- drivers/staging/android/ashmem.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-)
drivers/staging/android/ashmem.c +7 -8
@@ -334,24 +334,23 @@ static loff_t ashmem_llseek(struct filemutex_lock (&ashmem_mutex);if (asma->size ==0 ) { - ret = -EINVAL ; - goto out; +mutex_unlock (&ashmem_mutex); +return -EINVAL ; }if (!asma->file) { - ret = -EBADF ; - goto out; +mutex_unlock (&ashmem_mutex); +return -EBADF ; } +mutex_unlock (&ashmem_mutex); + ret =vfs_llseek (asma->file, offset, origin);if (ret <0 ) - goto out; +return ret;/** Copy f_pos from backing file, since f_ops->llseek() sets it */ file->f_pos = asma->file->f_pos; - -out: -mutex_unlock (&ashmem_mutex);return ret; }
Greg Kroah-Hartman
maintainerPATCH 16/109 USB: storage: Add JMicron bridge 152d:2567 to unusual_devs.h
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Teijo Kinnunen <[email protected]>
commit 5126a504b63d82785eaece3a9c30c660b313785a upstream.
This USB-SATA controller seems to be similar with JMicron bridge 152d:2566 already on the list. Adding it here fixes "Invalid field in cdb" errors.
--- drivers/usb/storage/unusual_devs.h | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/usb/storage/unusual_devs.h +7 -0
@@ -2137,6 +2137,13 @@ UNUSUAL_DEV( 0x152d, 0x2566, 0x0114, 0x USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_BROKEN_FUA ), +/* Reported by Teijo Kinnunen <[email protected]> */ +UNUSUAL_DEV (0x152d ,0x2567 ,0x0117 ,0x0117 , +"JMicron" , +"USB to ATA/ATAPI Bridge" , +USB_SC_DEVICE ,USB_PR_DEVICE ,NULL , +US_FL_BROKEN_FUA ), +/* Reported-by George Cherian <[email protected]> */ UNUSUAL_DEV(0x152d, 0x9561, 0x0000, 0x9999, "JMicron",
Greg Kroah-Hartman
maintainerPATCH 17/109 usbip: vudc: fix null pointer dereference on udc->lock
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Colin Ian King <[email protected]>
commit df3334c223a033f562645712e832ca4cbb326bbf upstream.
Currently the driver attempts to spin lock on udc->lock before a NULL pointer check is performed on udc, hence there is a potential null pointer dereference on udc->lock. Fix this by moving the null check on udc before the lock occurs.
--- drivers/usb/usbip/vudc_sysfs.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/usb/usbip/vudc_sysfs.c +6 -2
@@ -117,10 +117,14 @@ static ssize_t store_sockfd(struct devicif (rv !=0 )return -EINVAL ; +if (!udc) { +dev_err (dev,"no device" ); +return -ENODEV ; + }spin_lock_irqsave (&udc->lock, flags);/* Don't export what we don't have */ -if (!udc || !udc->driver || !udc->pullup) { -dev_err (dev,"no device or gadget not bound" ); +if (!udc->driver || !udc->pullup) { +dev_err (dev,"gadget not bound" ); ret = -ENODEV ; goto unlock; }
Greg Kroah-Hartman
maintainerPATCH 18/109 usb: quirks: add control message delay for 1b1c:1b20
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Danilo Krummrich <[email protected]>
commit cb88a0588717ba6c756cb5972d75766b273a6817 upstream.
Corsair Strafe RGB keyboard does not respond to usb control messages sometimes and hence generates timeouts.
Commit de3af5bf259d ("usb: quirks: add delay init quirk for Corsair Strafe RGB keyboard") tried to fix those timeouts by adding USB_QUIRK_DELAY_INIT.
Unfortunately, even with this quirk timeouts of usb_control_msg() can still be seen, but with a lower frequency (approx. 1 out of 15):
[ 29.103520] usb 1-8: string descriptor 0 read error: -110 [ 34.363097] usb 1-8: can't set config #1, error -110
Adding further delays to different locations where usb control messages are issued just moves the timeouts to other locations, e.g.:
[ 35.400533] usbhid 1-8:1.0: can't add hid device: -110 [ 35.401014] usbhid: probe of 1-8:1.0 failed with error -110
The only way to reliably avoid those issues is having a pause after each usb control message. In approx. 200 boot cycles no more timeouts were seen.
Addionaly, keep USB_QUIRK_DELAY_INIT as it turned out to be necessary to have the delay in hub_port_connect() after hub_port_init().
The overall boot time seems not to be influenced by these additional delays, even on fast machines and lightweight distributions.
--- drivers/usb/core/message.c | 4 ++++ drivers/usb/core/quirks.c | 3 ++- include/linux/usb/quirks.h | 3 +++ 3 files changed, 9 insertions(+), 1 deletion(-)
drivers/usb/core/message.c +4 -0
@@ -150,6 +150,10 @@ int usb_control_msg(struct usb_device *d ret =usb_internal_control_msg (dev, pipe, dr, data, size, timeout); +/* Linger a bit, prior to the next control message. */ +if (dev->quirks &USB_QUIRK_DELAY_CTRL_MSG ) +msleep (200 ); +kfree (dr);return ret;
drivers/usb/core/quirks.c +2 -1
@@ -229,7 +229,8 @@ static const struct usb_device_id usb_qu { USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT }, /* Corsair Strafe RGB */ - { USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT }, + { USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT | + USB_QUIRK_DELAY_CTRL_MSG }, /* Corsair K70 LUX */ { USB_DEVICE(0x1b1c, 0x1b36), .driver_info = USB_QUIRK_DELAY_INIT },
include/linux/usb/quirks.h +3 -0
@@ -57,4 +57,7 @@*/ #define USB_QUIRK_LINEAR_FRAME_INTR_BINTERVAL BIT(11) +/* Device needs a pause after every control message. */ +#define USB_QUIRK_DELAY_CTRL_MSG BIT(13) +#endif /* __LINUX_USB_QUIRKS_H */
Greg Kroah-Hartman
maintainerPATCH 19/109 usb: usbmon: Read text within supplied buffer size
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Pete Zaitcev <[email protected]>
commit a5f596830e27e15f7a0ecd6be55e433d776986d8 upstream.
This change fixes buffer overflows and silent data corruption with the usbmon device driver text file read operations.
--- drivers/usb/mon/mon_text.c | 124 +++++++++++++++++++++++++++------------------ 1 file changed, 77 insertions(+), 47 deletions(-)
drivers/usb/mon/mon_text.c +77 -47
@@ -85,6 +85,8 @@ struct mon_reader_text {wait_queue_head_t wait;int printf_size; +size_t printf_offset; +size_t printf_togo;char *printf_buf;struct mutex printf_lock;
@@ -376,75 +378,103 @@ err_alloc:return rc; } -/* -* For simplicity, we read one record in one system call and throw out -* what does not fit. This means that the following does not work: -* dd if=/dbg/usbmon/0t bs=10 -* Also, we do not allow seeks and do not bother advancing the offset. -*/ +static ssize_t mon_text_copy_to_user (struct mon_reader_text *rp, +char __user *const buf,const size_t nbytes) +{ +const size_t togo =min (nbytes, rp->printf_togo); + +if (copy_to_user (buf, &rp->printf_buf[rp->printf_offset], togo)) +return -EFAULT ; + rp->printf_togo -= togo; + rp->printf_offset += togo; +return togo; +} + +/* ppos is not advanced since the llseek operation is not permitted. */ static ssize_t mon_text_read_t (struct file *file,char __user *buf, -size_t nbytes,loff_t *ppos) +size_t nbytes,loff_t *ppos) {struct mon_reader_text *rp = file->private_data;struct mon_event_text *ep;struct mon_text_ptr ptr; +ssize_t ret; - ep =mon_text_read_wait (rp, file); -if (IS_ERR (ep)) -return PTR_ERR (ep);mutex_lock (&rp->printf_lock); - ptr.cnt =0 ; - ptr.pbuf = rp->printf_buf; - ptr.limit = rp->printf_size; - -mon_text_read_head_t (rp, &ptr, ep); -mon_text_read_statset (rp, &ptr, ep); - ptr.cnt +=snprintf (ptr.pbuf + ptr.cnt, ptr.limit - ptr.cnt, -" %d" , ep->length); -mon_text_read_data (rp, &ptr, ep); -if (copy_to_user (buf, rp->printf_buf, ptr.cnt)) - ptr.cnt = -EFAULT ; +if (rp->printf_togo ==0 ) { + + ep =mon_text_read_wait (rp, file); +if (IS_ERR (ep)) { +mutex_unlock (&rp->printf_lock); +return PTR_ERR (ep); + } + ptr.cnt =0 ; + ptr.pbuf = rp->printf_buf; + ptr.limit = rp->printf_size; + +mon_text_read_head_t (rp, &ptr, ep); +mon_text_read_statset (rp, &ptr, ep); + ptr.cnt +=snprintf (ptr.pbuf + ptr.cnt, ptr.limit - ptr.cnt, +" %d" , ep->length); +mon_text_read_data (rp, &ptr, ep); + + rp->printf_togo = ptr.cnt; + rp->printf_offset =0 ; + +kmem_cache_free (rp->e_slab, ep); + } + + ret =mon_text_copy_to_user (rp, buf, nbytes);mutex_unlock (&rp->printf_lock); -kmem_cache_free (rp->e_slab, ep); -return ptr.cnt; +return ret; } +/* ppos is not advanced since the llseek operation is not permitted. */ static ssize_t mon_text_read_u (struct file *file,char __user *buf, -size_t nbytes,loff_t *ppos) +size_t nbytes,loff_t *ppos) {struct mon_reader_text *rp = file->private_data;struct mon_event_text *ep;struct mon_text_ptr ptr; +ssize_t ret; - ep =mon_text_read_wait (rp, file); -if (IS_ERR (ep)) -return PTR_ERR (ep);mutex_lock (&rp->printf_lock); - ptr.cnt =0 ; - ptr.pbuf = rp->printf_buf; - ptr.limit = rp->printf_size; -mon_text_read_head_u (rp, &ptr, ep); -if (ep->type =='E' ) { -mon_text_read_statset (rp, &ptr, ep); - }else if (ep->xfertype ==USB_ENDPOINT_XFER_ISOC ) { -mon_text_read_isostat (rp, &ptr, ep); -mon_text_read_isodesc (rp, &ptr, ep); - }else if (ep->xfertype ==USB_ENDPOINT_XFER_INT ) { -mon_text_read_intstat (rp, &ptr, ep); - }else { -mon_text_read_statset (rp, &ptr, ep); +if (rp->printf_togo ==0 ) { + + ep =mon_text_read_wait (rp, file); +if (IS_ERR (ep)) { +mutex_unlock (&rp->printf_lock); +return PTR_ERR (ep); + } + ptr.cnt =0 ; + ptr.pbuf = rp->printf_buf; + ptr.limit = rp->printf_size; + +mon_text_read_head_u (rp, &ptr, ep); +if (ep->type =='E' ) { +mon_text_read_statset (rp, &ptr, ep); + }else if (ep->xfertype ==USB_ENDPOINT_XFER_ISOC ) { +mon_text_read_isostat (rp, &ptr, ep); +mon_text_read_isodesc (rp, &ptr, ep); + }else if (ep->xfertype ==USB_ENDPOINT_XFER_INT ) { +mon_text_read_intstat (rp, &ptr, ep); + }else { +mon_text_read_statset (rp, &ptr, ep); + } + ptr.cnt +=snprintf (ptr.pbuf + ptr.cnt, ptr.limit - ptr.cnt, +" %d" , ep->length); +mon_text_read_data (rp, &ptr, ep); + + rp->printf_togo = ptr.cnt; + rp->printf_offset =0 ; + +kmem_cache_free (rp->e_slab, ep); } - ptr.cnt +=snprintf (ptr.pbuf + ptr.cnt, ptr.limit - ptr.cnt, -" %d" , ep->length); -mon_text_read_data (rp, &ptr, ep); -if (copy_to_user (buf, rp->printf_buf, ptr.cnt)) - ptr.cnt = -EFAULT ; + ret =mon_text_copy_to_user (rp, buf, nbytes);mutex_unlock (&rp->printf_lock); -kmem_cache_free (rp->e_slab, ep); -return ptr.cnt; +return ret; } static struct mon_event_text *mon_text_read_wait(struct mon_reader_text *rp,
Greg Kroah-Hartman
maintainerPATCH 20/109 usb: gadget: f_fs: Fix use-after-free in ffs_fs_kill_sb()
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Xinyong <[email protected]>
commit 1a087f032111a88e826877449dfb93ceb22b78b9 upstream.
When I debug a kernel crash issue in funcitonfs, found ffs_data.ref overflowed, While functionfs is unmounting, ffs_data is put twice.
Commit 43938613c6fd ("drivers, usb: convert ffs_data.ref from atomic_t to refcount_t") can avoid refcount overflow, but that is risk some situations. So no need put ffs data in ffs_fs_kill_sb, already put in ffs_data_closed.
The issue can be reproduced in Mediatek mt6763 SoC, ffs for ADB device. KASAN enabled configuration reports use-after-free errro.
BUG: KASAN: use-after-free in refcount_dec_and_test+0x14/0xe0 at addr ffffffc0579386a0 Read of size 4 by task umount/4650 ====================================================
BUG kmalloc-512 (Tainted: P W O ): kasan: bad access detected
-----------------------------------------------------------------------------
INFO: Allocated in ffs_fs_mount+0x194/0x844 age=22856 cpu=2 pid=566
alloc_debug_processing+0x1ac/0x1e8
___slab_alloc.constprop.63+0x640/0x648
__slab_alloc.isra.57.constprop.62+0x24/0x34
kmem_cache_alloc_trace+0x1a8/0x2bc
ffs_fs_mount+0x194/0x844
mount_fs+0x6c/0x1d0
vfs_kern_mount+0x50/0x1b4
do_mount+0x258/0x1034
INFO: Freed in ffs_data_put+0x25c/0x320 age=0 cpu=3 pid=4650
free_debug_processing+0x22c/0x434
__slab_free+0x2d8/0x3a0
kfree+0x254/0x264
ffs_data_put+0x25c/0x320
ffs_data_closed+0x124/0x15c
ffs_fs_kill_sb+0xb8/0x110
deactivate_locked_super+0x6c/0x98
deactivate_super+0xb0/0xbc
INFO: Object 0xffffffc057938600 @offset=1536 fp=0x (null)
......
Call trace:
[<ffffff900808cf5c>] dump_backtrace+0x0/0x250
[<ffffff900808d3a0>] show_stack+0x14/0x1c
[<ffffff90084a8c04>] dump_stack+0xa0/0xc8
[<ffffff900826c2b4>] print_trailer+0x158/0x260
[<ffffff900826d9d8>] object_err+0x3c/0x40
[<ffffff90082745f0>] kasan_report_error+0x2a8/0x754
[<ffffff9008274f84>] kasan_report+0x5c/0x60
[<ffffff9008273208>] __asan_load4+0x70/0x88
[<ffffff90084cd81c>] refcount_dec_and_test+0x14/0xe0
[<ffffff9008d98f9c>] ffs_data_put+0x80/0x320
[<ffffff9008d9d904>] ffs_fs_kill_sb+0xc8/0x110
[<ffffff90082852a0>] deactivate_locked_super+0x6c/0x98
[<ffffff900828537c>] deactivate_super+0xb0/0xbc
[<ffffff90082af0c0>] cleanup_mnt+0x64/0xec
[<ffffff90082af1b0>] __cleanup_mnt+0x10/0x18
[<ffffff90080d9e68>] task_work_run+0xcc/0x124
[<ffffff900808c8c0>] do_notify_resume+0x60/0x70
[<ffffff90080866e4>] work_pending+0x10/0x14--- drivers/usb/gadget/function/f_fs.c | 1 - 1 file changed, 1 deletion(-)
drivers/usb/gadget/function/f_fs.c +0 -1
@@ -1539,7 +1539,6 @@ ffs_fs_kill_sb(struct super_block *sb)if (sb->s_fs_info) {ffs_release_dev (sb->s_fs_info);ffs_data_closed (sb->s_fs_info); -ffs_data_put (sb->s_fs_info); } }
Greg Kroah-Hartman
maintainerPATCH 21/109 usb: dwc3: Fix lock-up on ID change during system suspend/resume
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Roger Quadros <[email protected]>
commit 084a804e01205bcd74cd0849bc72cb5c88f8e648 upstream.
To reproduce the lock up do the following
- connect otg host adapter and a USB device to the dual-role port so that it is in host mode.
- suspend to mem.
- disconnect otg adapter.
- resume the system.
If we call dwc3_host_exit() before tasks are thawed xhci_plat_remove() seems to lock up at the second usb_remove_hcd() call.
To work around this we queue the _dwc3_set_mode() work on the system_freezable_wq.
--- drivers/usb/dwc3/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/dwc3/core.c +1 -1
@@ -186,7 +186,7 @@ void dwc3_set_mode(struct dwc3 *dwc, u32 dwc->desired_dr_role = mode;spin_unlock_irqrestore (&dwc->lock, flags); -queue_work (system_power_efficient_wq, &dwc->drd_work); +queue_work (system_freezable_wq, &dwc->drd_work); }u32 dwc3_core_fifo_space (struct dwc3_ep *dep,u8 type)
Greg Kroah-Hartman
maintainerPATCH 22/109 serial: 8250_pci: Add Brainboxes UC-260 4 port serial device
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Nikola Ciprich <[email protected]>
commit 9f2068f35729948bde84d87a40d135015911345d upstream.
Add PCI ids for two variants of Brainboxes UC-260 quad port PCI serial cards.
--- drivers/tty/serial/8250/8250_pci.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
drivers/tty/serial/8250/8250_pci.c +11 -0
@@ -4701,6 +4701,17 @@ static const struct pci_device_id serialPCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,/* 135a.0dc0 */ pbn_b2_4_115200 },/* +* BrainBoxes UC-260 +*/ + { PCI_VENDOR_ID_INTASHIELD, 0x0D21, +PCI_ANY_ID ,PCI_ANY_ID , +PCI_CLASS_COMMUNICATION_MULTISERIAL <<8 ,0xffff00 , + pbn_b2_4_115200 }, + { PCI_VENDOR_ID_INTASHIELD, 0x0E34, +PCI_ANY_ID ,PCI_ANY_ID , +PCI_CLASS_COMMUNICATION_MULTISERIAL <<8 ,0xffff00 , + pbn_b2_4_115200 }, +/* * Perle PCI-RAS cards */ { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030,
Greg Kroah-Hartman
maintainerPATCH 23/109 serial: core: mark port as initialized in autoconfig
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Sebastian Andrzej Siewior <[email protected]>
commit 714569064adee3c114a2a6490735b94abe269068 upstream.
This is a followup on 44117a1d1732 ("serial: core: mark port as initialized after successful IRQ change").
Nikola has been using autoconfig via setserial and reported a crash similar to what I fixed in the earlier mentioned commit. Here I do the same fixup for the autoconfig. I wasn't sure that this is the right approach. Nikola confirmed that it fixes his crash.
--- drivers/tty/serial/serial_core.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/tty/serial/serial_core.c +2 -0
@@ -1157,6 +1157,8 @@ static int uart_do_autoconfig(struct tty uport->ops->config_port (uport, flags); ret =uart_startup (tty, state,1 ); +if (ret ==0 ) +tty_port_set_initialized (port, true);if (ret >0 ) ret =0 ; }
Greg Kroah-Hartman
maintainerPATCH 24/109 earlycon: add reg-offset to physical address before mapping
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Greentime Hu <[email protected]>
commit 1f66dd36bb18437397ea0d7882c52f7e3c476e15 upstream.
It will get the wrong virtual address because port->mapbase is not added the correct reg-offset yet. We have to update it before earlycon_map() is called
--- drivers/tty/serial/earlycon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/tty/serial/earlycon.c +2 -1
@@ -253,11 +253,12 @@ int __init of_setup_earlycon(const struc } port->mapbase = addr; port->uartclk =BASE_BAUD *16 ; - port->membase =earlycon_map (port->mapbase,SZ_4K ); val =of_get_flat_dt_prop (node,"reg-offset" ,NULL );if (val) port->mapbase +=be32_to_cpu (*val); + port->membase =earlycon_map (port->mapbase,SZ_4K ); + val =of_get_flat_dt_prop (node,"reg-shift" ,NULL );if (val) port->regshift =be32_to_cpu (*val);
Greg Kroah-Hartman
maintainerPATCH 25/109 dm mpath: fix passing integrity data
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Steffen Maier <[email protected]>
commit 8c5c147339d2e201108169327b1f99aa6d57d2cd upstream.
After v4.12 commit e2460f2a4bc7 ("dm: mark targets that pass integrity data"), dm-multipath, e.g. on DIF+DIX SCSI disk paths, does not support block integrity any more. So add it to the whitelist.
This is also a pre-requisite to use block integrity with other dm layer(s) on top of multipath, such as kpartx partitions (dm-linear) or LVM.
Also, bump target version to reflect this fix.
--- drivers/md/dm-mpath.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/md/dm-mpath.c +3 -2
@@ -1941,8 +1941,9 @@ static int multipath_busy(struct dm_targ*---------------------------------------------------------------*/ static struct target_type multipath_target = { .name ="multipath" , - .version = {1 ,12 ,0 }, - .features =DM_TARGET_SINGLETON |DM_TARGET_IMMUTABLE , + .version = {1 ,13 ,0 }, + .features =DM_TARGET_SINGLETON |DM_TARGET_IMMUTABLE | +DM_TARGET_PASSES_INTEGRITY , .module =THIS_MODULE , .ctr = multipath_ctr, .dtr = multipath_dtr,
Greg Kroah-Hartman
maintainerPATCH 26/109 Revert "btrfs: use proper endianness accessors for super_copy"
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
This reverts commit 3c181c12c431fe33b669410d663beb9cceefcd1b as it causes breakage on big endian systems with btrfs images.
--- fs/btrfs/sysfs.c | 8 +++++--- fs/btrfs/transaction.c | 20 ++++++++------------ 2 files changed, 13 insertions(+), 15 deletions(-)
fs/btrfs/sysfs.c +5 -3
@@ -422,7 +422,7 @@ static ssize_t btrfs_nodesize_show(struc {struct btrfs_fs_info *fs_info =to_fs_info (kobj); -return snprintf (buf,PAGE_SIZE ,"%u\n" , fs_info->nodesize); +return snprintf (buf,PAGE_SIZE ,"%u\n" , fs_info->super_copy->nodesize); }BTRFS_ATTR (nodesize, btrfs_nodesize_show);
@@ -432,7 +432,8 @@ static ssize_t btrfs_sectorsize_show(str {struct btrfs_fs_info *fs_info =to_fs_info (kobj); -return snprintf (buf,PAGE_SIZE ,"%u\n" , fs_info->sectorsize); +return snprintf (buf,PAGE_SIZE ,"%u\n" , + fs_info->super_copy->sectorsize); }BTRFS_ATTR (sectorsize, btrfs_sectorsize_show);
@@ -442,7 +443,8 @@ static ssize_t btrfs_clone_alignment_sho {struct btrfs_fs_info *fs_info =to_fs_info (kobj); -return snprintf (buf,PAGE_SIZE ,"%u\n" , fs_info->sectorsize); +return snprintf (buf,PAGE_SIZE ,"%u\n" , + fs_info->super_copy->sectorsize); }BTRFS_ATTR (clone_alignment, btrfs_clone_alignment_show);
fs/btrfs/transaction.c +8 -12
@@ -1722,23 +1722,19 @@ static void update_super_roots(struct bt super = fs_info->super_copy; -/* update latest btrfs_super_block::chunk_root refs */ root_item = &fs_info->chunk_root->root_item; -btrfs_set_super_chunk_root (super, root_item->bytenr); -btrfs_set_super_chunk_root_generation (super, root_item->generation); -btrfs_set_super_chunk_root_level (super, root_item->level); + super->chunk_root = root_item->bytenr; + super->chunk_root_generation = root_item->generation; + super->chunk_root_level = root_item->level; -/* update latest btrfs_super_block::root refs */ root_item = &fs_info->tree_root->root_item; -btrfs_set_super_root (super, root_item->bytenr); -btrfs_set_super_generation (super, root_item->generation); -btrfs_set_super_root_level (super, root_item->level); - + super->root = root_item->bytenr; + super->generation = root_item->generation; + super->root_level = root_item->level;if (btrfs_test_opt (fs_info,SPACE_CACHE )) -btrfs_set_super_cache_generation (super, root_item->generation); + super->cache_generation = root_item->generation;if (test_bit (BTRFS_FS_UPDATE_UUID_TREE_GEN , &fs_info->flags)) -btrfs_set_super_uuid_tree_generation (super, - root_item->generation); + super->uuid_tree_generation = root_item->generation; }int btrfs_transaction_in_commit (struct btrfs_fs_info *info)
Greg Kroah-Hartman
maintainerPATCH 27/109 drm/edid: set ELD connector type in drm_edid_to_eld()
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jani Nikula <[email protected]>
[ Upstream commit 1d1c36650752b7fb81cee515a9bba4131cac4b7c ]
Since drm_edid_to_eld() knows the connector type, we can set the type in ELD while at it. Most connectors this gets called on are not DP encoders, and with the HDMI type being 0, this does not change behaviour for non-DP.
For i915 having this in place earlier would have saved a considerable amount of debugging that lead to the fix 2d8f63297b9f ("drm/i915: always update ELD connector type after get modes"). I don't see other drivers, even the ones calling drm_edid_to_eld() on DP connectors, setting the connector type in ELD.
--- drivers/gpu/drm/drm_edid.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_edid.c +7 -2
@@ -3823,8 +3823,7 @@ EXPORT_SYMBOL(drm_edid_get_monitor_name)* @edid: EDID to parse * * Fill the ELD (EDID-Like Data) buffer for passing to the audio driver. The -* Conn_Type, HDCP and Port_ID ELD fields are left for the graphics driver to -* fill in. +* HDCP and Port_ID ELD fields are left for the graphics driver to fill in. */ void drm_edid_to_eld (struct drm_connector *connector,struct edid *edid) {
@@ -3905,6 +3904,12 @@ void drm_edid_to_eld(struct drm_connecto } eld[5 ] |= total_sad_count <<4 ; +if (connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort || + connector->connector_type == DRM_MODE_CONNECTOR_eDP) + eld[DRM_ELD_SAD_COUNT_CONN_TYPE ] |=DRM_ELD_CONN_TYPE_DP ; +else + eld[DRM_ELD_SAD_COUNT_CONN_TYPE ] |=DRM_ELD_CONN_TYPE_HDMI ; + eld[DRM_ELD_BASELINE_ELD_LEN ] =DIV_ROUND_UP (drm_eld_calc_baseline_block_size (eld),4 );
Greg Kroah-Hartman
maintainerPATCH 28/109 dma-buf/fence: Fix lock inversion within dma-fence-array
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Chris Wilson <[email protected]>
[ Upstream commit 03e4e0a9e02cf703da331ff6cfd57d0be9bf5692 ]
Ages ago Rob Clark noted,
"Currently with fence-array, we have a potential deadlock situation. If we fence_add_callback() on an array-fence, the array-fence's lock is acquired first, and in it's ->enable_signaling() callback, it will install cbs on it's array-member fences, so the array-member's lock is acquired second.
But in the signal path, the array-member's lock is acquired first, and the array-fence's lock acquired second."
Rob proposed either extensive changes to dma-fence to unnest the fence-array signaling, or to defer the signaling onto a workqueue. This is a more refined version of the later, that should keep the latency of the fence signaling to a minimum by using an irq-work, which is executed asap.
References: [email protected]
--- drivers/base/Kconfig | 1 + drivers/dma-buf/dma-fence-array.c | 14 ++++++++++++-- include/linux/dma-fence-array.h | 3 +++ 3 files changed, 16 insertions(+), 2 deletions(-)
drivers/base/Kconfig +1 -0
@@ -249,6 +249,7 @@ config DMA_SHARED_BUFFER bool default n select ANON_INODES + select IRQ_WORK help This option enables the framework for buffer-sharing between multiple drivers. A buffer is associated with a file using driver
drivers/dma-buf/dma-fence-array.c +12 -2
@@ -31,6 +31,14 @@ static const char *dma_fence_array_get_treturn "unbound" ; } +static void irq_dma_fence_array_work (struct irq_work *wrk) +{ +struct dma_fence_array *array =container_of (wrk,typeof (*array), work); + +dma_fence_signal (&array->base); +dma_fence_put (&array->base); +} +static void dma_fence_array_cb_func (struct dma_fence *f,struct dma_fence_cb *cb) {
@@ -39,8 +47,9 @@ static void dma_fence_array_cb_func(strustruct dma_fence_array *array = array_cb->array;if (atomic_dec_and_test (&array->num_pending)) -dma_fence_signal (&array->base); -dma_fence_put (&array->base); +irq_work_queue (&array->work); +else +dma_fence_put (&array->base); }static bool dma_fence_array_enable_signaling (struct dma_fence *fence)
@@ -136,6 +145,7 @@ struct dma_fence_array *dma_fence_array_spin_lock_init (&array->lock);dma_fence_init (&array->base, &dma_fence_array_ops, &array->lock, context, seqno); +init_irq_work (&array->work, irq_dma_fence_array_work); array->num_fences = num_fences;atomic_set (&array->num_pending, signal_on_any ?1 : num_fences);
include/linux/dma-fence-array.h +3 -0
@@ -21,6 +21,7 @@#define __LINUX_DMA_FENCE_ARRAY_H#include <linux/dma-fence.h> +#include <linux/irq_work.h> /** * struct dma_fence_array_cb - callback helper for fence array
@@ -47,6 +48,8 @@ struct dma_fence_array {unsigned num_fences;atomic_t num_pending;struct dma_fence **fences; + +struct irq_work work; };extern const struct dma_fence_ops dma_fence_array_ops;
Greg Kroah-Hartman
maintainerPATCH 29/109 video/hdmi: Allow "empty" HDMI infoframes
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: "Ville Syrj�l�" <[email protected]>
[ Upstream commit 593f4b19a094c4426bd1e1e3cbab87a48bd13c71 ]
HDMI 2.0 Appendix F suggest that we should keep sending the infoframe when switching from 3D to 2D mode, even if the infoframe isn't strictly necessary (ie. not needed to transmit the VIC or stereo information). This is a workaround against some sinks that fail to realize that they should switch from 3D to 2D mode when the source stop transmitting the infoframe.
v2: Handle unpack() as well
Pull the length calculation into a helper
--- drivers/video/hdmi.c | 51 +++++++++++++++++++++++++++++++-------------------- 1 file changed, 31 insertions(+), 20 deletions(-)
drivers/video/hdmi.c +31 -20
@@ -321,6 +321,17 @@ int hdmi_vendor_infoframe_init(struct hd }EXPORT_SYMBOL (hdmi_vendor_infoframe_init); +static int hdmi_vendor_infoframe_length (const struct hdmi_vendor_infoframe *frame) +{ +/* for side by side (half) we also need to provide 3D_Ext_Data */ +if (frame->s3d_struct >=HDMI_3D_STRUCTURE_SIDE_BY_SIDE_HALF ) +return 6 ; +else if (frame->vic !=0 || frame->s3d_struct !=HDMI_3D_STRUCTURE_INVALID ) +return 5 ; +else +return 4 ; +} +/** * hdmi_vendor_infoframe_pack() - write a HDMI vendor infoframe to binary buffer * @frame: HDMI infoframe
@@ -341,19 +352,11 @@ ssize_t hdmi_vendor_infoframe_pack(strucu8 *ptr = buffer;size_t length; -/* empty info frame */ -if (frame->vic ==0 && frame->s3d_struct ==HDMI_3D_STRUCTURE_INVALID ) -return -EINVAL ; -/* only one of those can be supplied */ if (frame->vic !=0 && frame->s3d_struct !=HDMI_3D_STRUCTURE_INVALID )return -EINVAL ; -/* for side by side (half) we also need to provide 3D_Ext_Data */ -if (frame->s3d_struct >=HDMI_3D_STRUCTURE_SIDE_BY_SIDE_HALF ) - frame->length =6 ; -else - frame->length =5 ; + frame->length =hdmi_vendor_infoframe_length (frame); length =HDMI_INFOFRAME_HEADER_SIZE + frame->length;
@@ -372,14 +375,16 @@ ssize_t hdmi_vendor_infoframe_pack(struc ptr[5 ] =0x0c ; ptr[6 ] =0x00 ; -if (frame->vic) { - ptr[7 ] =0x1 <<5 ;/* video format */ - ptr[8 ] = frame->vic; - }else { +if (frame->s3d_struct !=HDMI_3D_STRUCTURE_INVALID ) { ptr[7 ] =0x2 <<5 ;/* video format */ ptr[8 ] = (frame->s3d_struct &0xf ) <<4 ;if (frame->s3d_struct >=HDMI_3D_STRUCTURE_SIDE_BY_SIDE_HALF ) ptr[9 ] = (frame->s3d_ext_data &0xf ) <<4 ; + }else if (frame->vic) { + ptr[7 ] =0x1 <<5 ;/* video format */ + ptr[8 ] = frame->vic; + }else { + ptr[7 ] =0x0 <<5 ;/* video format */ }hdmi_infoframe_set_checksum (buffer, length);
@@ -1165,7 +1170,7 @@ hdmi_vendor_any_infoframe_unpack(union hif (ptr[0 ] !=HDMI_INFOFRAME_TYPE_VENDOR || ptr[1 ] !=1 || - (ptr[2 ] !=5 && ptr[2 ] !=6 )) + (ptr[2 ] !=4 && ptr[2 ] !=5 && ptr[2 ] !=6 ))return -EINVAL ; length = ptr[2 ];
@@ -1193,16 +1198,22 @@ hdmi_vendor_any_infoframe_unpack(union h hvf->length = length; -if (hdmi_video_format ==0x1 ) { - hvf->vic = ptr[4 ]; - }else if (hdmi_video_format ==0x2 ) { +if (hdmi_video_format ==0x2 ) { +if (length !=5 && length !=6 ) +return -EINVAL ; hvf->s3d_struct = ptr[4 ] >>4 ;if (hvf->s3d_struct >=HDMI_3D_STRUCTURE_SIDE_BY_SIDE_HALF ) { -if (length ==6 ) - hvf->s3d_ext_data = ptr[5 ] >>4 ; -else +if (length !=6 )return -EINVAL ; + hvf->s3d_ext_data = ptr[5 ] >>4 ; } + }else if (hdmi_video_format ==0x1 ) { +if (length !=5 ) +return -EINVAL ; + hvf->vic = ptr[4 ]; + }else { +if (length !=4 ) +return -EINVAL ; }return 0 ;
Greg Kroah-Hartman
maintainerPATCH 30/109 HID: multitouch: Only look at non touch fields in first packet of a frame
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Hans de Goede <[email protected]>
[ Upstream commit 55746d28d66860bccaae20a67b55b9d5db7c14af ]
Devices in "single finger hybrid mode" will send one report per finger, on some devices only the first report of such a multi-packet frame will contain a value for BTN_LEFT, in subsequent reports (if multiple fingers are down) the value is always 0, causing hid-mt to report BTN_LEFT going 1 - 0 - 1 - 0 when pressing a clickpad and putting down a second finger. This happens for example on USB 0603:0002 mt touchpads.
This commit fixes this by only reporting non touch fields for the first packet of a (possibly) multi-packet frame.
--- drivers/hid/hid-multitouch.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-)
drivers/hid/hid-multitouch.c +15 -2
@@ -738,9 +738,11 @@ static int mt_touch_event(struct hid_dev }static void mt_process_mt_event (struct hid_device *hid,struct hid_field *field, -struct hid_usage *usage,__s32 value) +struct hid_usage *usage,__s32 value, +bool first_packet) {struct mt_device *td =hid_get_drvdata (hid); +__s32 cls = td->mtclass.name;__s32 quirks = td->mtclass.quirks;struct input_dev *input = field->hidinput->input;
@@ -794,6 +796,15 @@ static void mt_process_mt_event(struct hbreak ;default : +/* +* For Win8 PTP touchpads we should only look at +* non finger/touch events in the first_packet of +* a (possible) multi-packet frame. +*/ +if ((cls ==MT_CLS_WIN_8 || cls ==MT_CLS_WIN_8_DUAL ) && + !first_packet) +return ; +if (usage->type)input_event (input, usage->type, usage->code, value);
@@ -813,6 +824,7 @@ static void mt_touch_report(struct hid_d {struct mt_device *td =hid_get_drvdata (hid);struct hid_field *field; +bool first_packet;unsigned count;int r, n;
@@ -831,6 +843,7 @@ static void mt_touch_report(struct hid_d td->num_expected = value; } + first_packet = td->num_received ==0 ;for (r =0 ; r < report->maxfield; r++) { field = report->field[r]; count = field->report_count;
@@ -840,7 +853,7 @@ static void mt_touch_report(struct hid_dfor (n =0 ; n < count; n++)mt_process_mt_event (hid, field, &field->usage[n], - field->value[n]); + field->value[n], first_packet); }if (td->num_received >= td->num_expected)
Greg Kroah-Hartman
maintainerPATCH 31/109 HID: elo: clear BTN_LEFT mapping
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jiri Kosina <[email protected]>
[ Upstream commit 9abd04af951e5734c9d5cfee9b49790844b734cf ]
ELO devices have one Button usage in GenDesk field, which makes hid-input map it to BTN_LEFT; that confuses userspace, which then considers the device to be a mouse/touchpad instead of touchscreen.
Fix that by unmapping BTN_LEFT and keeping only BTN_TOUCH in place.
--- drivers/hid/hid-elo.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/hid/hid-elo.c +6 -0
@@ -42,6 +42,12 @@ static int elo_input_configured(struct h {struct input_dev *input = hidinput->input; +/* +* ELO devices have one Button usage in GenDesk field, which makes +* hid-input map it to BTN_LEFT; that confuses userspace, which then +* considers the device to be a mouse/touchpad instead of touchscreen. +*/ +clear_bit (BTN_LEFT , input->keybit);set_bit (BTN_TOUCH , input->keybit);set_bit (ABS_PRESSURE , input->absbit);input_set_abs_params (input,ABS_PRESSURE ,0 ,256 ,0 ,0 );
Greg Kroah-Hartman
maintainerPATCH 32/109 iwlwifi: mvm: rs: dont override the rate history in the search cycle
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Emmanuel Grumbach <[email protected]>
[ Upstream commit 992172e3aec19e5b0ea5b757ba40a146b9282d1e ]
When we are in a search cycle, we try different combinations of parameters. Those combinations are called 'columns'. When we switch to a new column, we first need to check if this column has a suitable rate, if not, we can't try it. This means we must not erase the statistics we gathered for the previous column until we are sure that we are indeed switching column.
The code that tries to switch to a new column first sets a whole bunch of things for the new column, and only then checks that we can find suitable rates in that column. While doing that, the code mistakenly erased the rate statistics. This code was right until
struct iwl_scale_tbl_info grew up for TPC.
Fix this to make sure we don't erase the rate statistics until we are sure that we can indeed switch to the new column.
Note that this bug is really harmless since it causes a change in the behavior only when we can't find any rate in the new column which should really not happen. In the case we do find a suitable we reset the rate statistics a few lines later anyway.
--- drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/net/wireless/intel/iwlwifi/mvm/rs.c +1 -3
@@ -1881,12 +1881,10 @@ static int rs_switch_to_column(struct iwstruct rs_rate *rate = &search_tbl->rate;const struct rs_tx_column *column = &rs_tx_columns[col_id];const struct rs_tx_column *curr_column = &rs_tx_columns[tbl->column]; -u32 sz = (sizeof (struct iwl_scale_tbl_info ) - - (sizeof (struct iwl_rate_scale_data ) *IWL_RATE_COUNT ));unsigned long rate_mask =0 ;u32 rate_idx =0 ; -memcpy (search_tbl, tbl, sz); +memcpy (search_tbl, tbl, offsetof(struct iwl_scale_tbl_info , win)); rate->sgi = column->sgi; rate->ant = column->ant;
Greg Kroah-Hartman
maintainerPATCH 33/109 ARM: dts: koelsch: Move cec_clock to root node
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Simon Horman <[email protected]>
[ Upstream commit d72f4f03854d1225c72d682bf0e01377e7016419 ]
cec-clock is a fixed clock generator that is not controlled by i2c5 and thus should not be a child of the i2c5 bus node. Rather, it should be a child of the root node of the DT.
--- arch/arm/boot/dts/r8a7791-koelsch.dts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
arch/arm/boot/dts/r8a7791-koelsch.dts +6 -6
@@ -278,6 +278,12 @@ }; }; + cec_clock: cec-clock { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <12000000>; + }; + hdmi-out { compatible = "hdmi-connector"; type = "a";
@@ -642,12 +648,6 @@ }; }; - cec_clock: cec-clock { - compatible = "fixed-clock"; - #clock-cells = <0>; - clock-frequency = <12000000>; - }; - hdmi@39 { compatible = "adi,adv7511w"; reg = <0x39>;
Greg Kroah-Hartman
maintainerPATCH 34/109 clk: meson: gxbb: fix wrong clock for SARADC/SANA
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Yixun Lan <[email protected]>
[ Upstream commit 75eccf5ed83250c0aeaeeb76f7288254ac0a87b4 ]
According to the datasheet, in Meson-GXBB/GXL series, The clock gate bit for SARADC is HHI_GCLK_MPEG2 bit[22], while clock gate bit for SANA is HHI_GCLK_MPEG0 bit[10].
Test passed at gxl-s905x-p212 board.
The following published datasheets are wrong and should be updated
[1] GXBB v1.1.4
[2] GXL v0.3_20170314
--- drivers/clk/meson/gxbb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/meson/gxbb.c +2 -2
@@ -1139,7 +1139,7 @@ static MESON_GATE(gxbb_pl301, HHI_GCLK_M static MESON_GATE(gxbb_periphs, HHI_GCLK_MPEG0, 7); static MESON_GATE(gxbb_spicc, HHI_GCLK_MPEG0, 8); static MESON_GATE(gxbb_i2c, HHI_GCLK_MPEG0, 9); -static MESON_GATE(gxbb_sar_adc, HHI_GCLK_MPEG0, 10); +static MESON_GATE(gxbb_sana, HHI_GCLK_MPEG0, 10); static MESON_GATE(gxbb_smart_card, HHI_GCLK_MPEG0, 11); static MESON_GATE(gxbb_rng0, HHI_GCLK_MPEG0, 12); static MESON_GATE(gxbb_uart0, HHI_GCLK_MPEG0, 13);
@@ -1190,7 +1190,7 @@ static MESON_GATE(gxbb_usb0_ddr_bridge, static MESON_GATE(gxbb_mmc_pclk, HHI_GCLK_MPEG2, 11); static MESON_GATE(gxbb_dvin, HHI_GCLK_MPEG2, 12); static MESON_GATE(gxbb_uart2, HHI_GCLK_MPEG2, 15); -static MESON_GATE(gxbb_sana, HHI_GCLK_MPEG2, 22); +static MESON_GATE(gxbb_sar_adc, HHI_GCLK_MPEG2, 22); static MESON_GATE(gxbb_vpu_intr, HHI_GCLK_MPEG2, 25); static MESON_GATE(gxbb_sec_ahb_ahb3_bridge, HHI_GCLK_MPEG2, 26); static MESON_GATE(gxbb_clk81_a53, HHI_GCLK_MPEG2, 29);
Greg Kroah-Hartman
maintainerPATCH 35/109 ARM: dts: exynos: Correct Trats2 panel reset line
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Simon Shields <[email protected]>
[ Upstream commit 1b377924841df1e13ab5b225be3a83f807a92b52 ]
Trats2 uses gpf2-1 as the panel reset GPIO. gpy4-5 was only used on early revisions of the board.
--- arch/arm/boot/dts/exynos4412-trats2.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos4412-trats2.dts +1 -1
@@ -395,7 +395,7 @@ reg = <0>; vdd3-supply = <&lcd_vdd3_reg>; vci-supply = <&ldo25_reg>; - reset-gpios = <&gpy4 5 GPIO_ACTIVE_HIGH>; + reset-gpios = <&gpf2 1 GPIO_ACTIVE_HIGH>; power-on-delay= <50>; reset-delay = <100>; init-delay = <100>;
Greg Kroah-Hartman
maintainerPATCH 36/109 drm/amdgpu: fix get_max_engine_clock_in_mhz
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Felix Kuehling <[email protected]>
[ Upstream commit a9efcc19161e20623c285fac967a32842972cebe ]
Use proper powerplay function. This fixes OpenCL initialization problems.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c +5 -2
@@ -265,6 +265,9 @@ uint32_t get_max_engine_clock_in_mhz(str {struct amdgpu_device *adev = (struct amdgpu_device *)kgd; -/* The sclk is in quantas of 10kHz */ -return adev->pm.dpm.dyn_state.max_clock_voltage_on_ac.sclk /100 ; +/* the sclk is in quantas of 10kHz */ +if (amdgpu_sriov_vf (adev)) +return adev->clock.default_sclk /100 ; + +return amdgpu_dpm_get_sclk (adev, false) /100 ; }
Greg Kroah-Hartman
maintainerPATCH 37/109 staging: rtl8822be: fix missing null check on dev_alloc_skb return
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Colin Ian King <[email protected]>
[ Upstream commit 3eb23426e1749a0483bc4c9b18e51f657569e3ed ]
dev_alloc_skb can potentially return NULL, so add a null check to avoid a null pointer dereference on skb
Detected by CoverityScan, CID#1454558 ("Dereference on null return")
--- drivers/staging/rtlwifi/rtl8822be/fw.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/staging/rtlwifi/rtl8822be/fw.c +2 -0
@@ -464,6 +464,8 @@ bool rtl8822b_halmac_cb_write_data_rsvd_int count; skb =dev_alloc_skb (size); +if (!skb) +return false;memcpy ((u8 *)skb_put (skb, size), buf, size);if (!_rtl8822be_send_bcn_or_cmd_packet (rtlpriv->hw, skb,BEACON_QUEUE ))
Greg Kroah-Hartman
maintainerPATCH 38/109 typec: tcpm: fusb302: Resolve out of order messaging events
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Adam Thomson <[email protected]>
[ Upstream commit ab69f61321140ff632d560775bc226259a78dfa2 ]
The expectation in the FUSB302 driver is that a TX_SUCCESS event should occur after a message has been sent, but before a GCRCSENT event is raised to indicate successful receipt of a message from the partner. However in some circumstances it is possible to see the hardware raise a GCRCSENT event before a TX_SUCCESS event is raised. The upshot of this is that the GCRCSENT handling portion of code ends up reporting the GoodCRC message to TCPM because the TX_SUCCESS event hasn't yet arrived to trigger a consumption of it. When TX_SUCCESS is then raised by the chip it ends up consuming the actual message that was meant for TCPM, and this incorrect sequence results in a hard reset from TCPM.
To avoid this problem, this commit updates the message reading code to check whether a GoodCRC message was received or not. Based on this check it will either report that the previous transmission has completed or it will pass the msg data to TCPM for futher processing. This way the incorrect ordering of the events no longer matters.
--- drivers/staging/typec/fusb302/fusb302.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-)
drivers/staging/typec/fusb302/fusb302.c +17 -4
@@ -1552,6 +1552,21 @@ static int fusb302_pd_read_message(strucfusb302_log (chip,"PD message header: %x" , msg->header);fusb302_log (chip,"PD message len: %d" , len); +/* +* Check if we've read off a GoodCRC message. If so then indicate to +* TCPM that the previous transmission has completed. Otherwise we pass +* the received message over to TCPM for processing. +* +* We make this check here instead of basing the reporting decision on +* the IRQ event type, as it's possible for the chip to report the +* TX_SUCCESS and GCRCSENT events out of order on occasion, so we need +* to check the message type to ensure correct reporting to TCPM. +*/ +if ((!len) && (pd_header_type_le (msg->header) ==PD_CTRL_GOOD_CRC )) +tcpm_pd_transmit_complete (chip->tcpm_port,TCPC_TX_SUCCESS ); +else +tcpm_pd_receive (chip->tcpm_port, msg); +return ret; }
@@ -1659,13 +1674,12 @@ static irqreturn_t fusb302_irq_intn(intif (interrupta &FUSB_REG_INTERRUPTA_TX_SUCCESS ) {fusb302_log (chip,"IRQ: PD tx success" ); -/* read out the received good CRC */ ret =fusb302_pd_read_message (chip, &pd_msg);if (ret <0 ) { -fusb302_log (chip,"cannot read in GCRC, ret=%d" , ret); +fusb302_log (chip, +"cannot read in PD message, ret=%d" , ret); goto done; } -tcpm_pd_transmit_complete (chip->tcpm_port,TCPC_TX_SUCCESS ); }if (interrupta &FUSB_REG_INTERRUPTA_HARDRESET ) {
@@ -1686,7 +1700,6 @@ static irqreturn_t fusb302_irq_intn(int "cannot read in PD message, ret=%d", ret); goto done; } -tcpm_pd_receive (chip->tcpm_port, &pd_msg); } done:mutex_unlock (&chip->lock);
Greg Kroah-Hartman
maintainerPATCH 39/109 USB: ledtrig-usbport: fix of-node leak
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Johan Hovold <[email protected]>
[ Upstream commit 03310a15484ab6a8f6d91bbf7fe486b17275c09a ]
This code looks up a USB device node from a given parent USB device but never dropped its reference to the returned node.
As only the address of the node is used for a later matching, the reference can be dropped immediately.
Note that this trigger implementation confuses the description of the USB device connected to a port with the port itself (which does not have a device-tree representation).
--- drivers/usb/core/ledtrig-usbport.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/usb/core/ledtrig-usbport.c +7 -1
@@ -140,11 +140,17 @@ static bool usbport_trig_port_observed(sif (!led_np)return false; -/* Get node of port being added */ +/* +* Get node of port being added +* +* FIXME: This is really the device node of the connected device +*/ port_np =usb_of_get_child_node (usb_dev->dev.of_node, port1);if (!port_np)return false; +of_node_put (port_np); +/* Amount of trigger sources for this LED */ count =of_count_phandle_with_args (led_np,"trigger-sources" ,"#trigger-source-cells" );
Greg Kroah-Hartman
maintainerPATCH 40/109 sched: Stop switched_to_rt() from sending IPIs to offline CPUs
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: "Paul E. McKenney" <[email protected]>
[ Upstream commit 2fe2582649aa2355f79acddb86bd4d6c5363eb63 ]
The rcutorture test suite occasionally provokes a splat due to invoking rt_mutex_lock() which needs to boost the priority of a task currently sitting on a runqueue that belongs to an offline CPU:
WARNING: CPU: 0 PID: 12 at /home/paulmck/public_git/linux-rcu/arch/x86/kernel/smp.c:128 native_smp_send_reschedule+0x37/0x40 Modules linked in: CPU: 0 PID: 12 Comm: rcub/7 Not tainted 4.14.0-rc4+ #1 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Ubuntu-1.8.2-1ubuntu1 04/01/2014 task: ffff9ed3de5f8cc0 task.stack: ffffbbf80012c000 RIP: 0010:native_smp_send_reschedule+0x37/0x40 RSP: 0018:ffffbbf80012fd10 EFLAGS: 00010082 RAX: 000000000000002f RBX: ffff9ed3dd9cb300 RCX: 0000000000000004 RDX: 0000000080000004 RSI: 0000000000000086 RDI: 00000000ffffffff RBP: ffffbbf80012fd10 R08: 000000000009da7a R09: 0000000000007b9d R10: 0000000000000001 R11: ffffffffbb57c2cd R12: 000000000000000d R13: ffff9ed3de5f8cc0 R14: 0000000000000061 R15: ffff9ed3ded59200 FS: 0000000000000000(0000) GS:ffff9ed3dea00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00000000080686f0 CR3: 000000001b9e0000 CR4: 00000000000006f0 Call Trace: resched_curr+0x61/0xd0 switched_to_rt+0x8f/0xa0 rt_mutex_setprio+0x25c/0x410 task_blocks_on_rt_mutex+0x1b3/0x1f0 rt_mutex_slowlock+0xa9/0x1e0 rt_mutex_lock+0x29/0x30 rcu_boost_kthread+0x127/0x3c0 kthread+0x104/0x140 ? rcu_report_unblock_qs_rnp+0x90/0x90 ? kthread_create_on_node+0x40/0x40 ret_from_fork+0x22/0x30 Code: f0 00 0f 92 c0 84 c0 74 14 48 8b 05 34 74 c5 00 be fd 00 00 00 ff 90 a0 00 00 00 5d c3 89 fe 48 c7 c7 a0 c6 fc b9 e8 d5 b5 06 00 <0f> ff 5d c3 0f 1f 44 00 00 8b 05 a2 d1 13 02 85 c0 75 38 55 48
But the target task's priority has already been adjusted, so the only purpose of switched_to_rt() invoking resched_curr() is to wake up the CPU running some task that needs to be preempted by the boosted task. But the CPU is offline, which presumably means that the task must be migrated to some other CPU, and that this other CPU will undertake any needed preemption at the time of migration. Because the runqueue lock is held when resched_curr() is invoked, we know that the boosted task cannot go anywhere, so it is not necessary to invoke resched_curr() in this particular case.
This commit therefore makes switched_to_rt() refrain from invoking resched_curr() when the target CPU is offline.
--- kernel/sched/rt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/rt.c +1 -1
@@ -2218,7 +2218,7 @@ static void switched_to_rt(struct rq *rqif (p->nr_cpus_allowed >1 && rq->rt.overloaded)queue_push_tasks (rq);#endif /* CONFIG_SMP */ -if (p->prio < rq->curr->prio) +if (p->prio < rq->curr->prio &&cpu_online (cpu_of (rq)))resched_curr (rq); } }
Greg Kroah-Hartman
maintainerPATCH 41/109 sched: Stop resched_cpu() from sending IPIs to offline CPUs
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: "Paul E. McKenney" <[email protected]>
[ Upstream commit a0982dfa03efca6c239c52cabebcea4afb93ea6b ]
The rcutorture test suite occasionally provokes a splat due to invoking resched_cpu() on an offline CPU:
WARNING: CPU: 2 PID: 8 at /home/paulmck/public_git/linux-rcu/arch/x86/kernel/smp.c:128 native_smp_send_reschedule+0x37/0x40 Modules linked in: CPU: 2 PID: 8 Comm: rcu_preempt Not tainted 4.14.0-rc4+ #1 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Ubuntu-1.8.2-1ubuntu1 04/01/2014 task: ffff902ede9daf00 task.stack: ffff96c50010c000 RIP: 0010:native_smp_send_reschedule+0x37/0x40 RSP: 0018:ffff96c50010fdb8 EFLAGS: 00010096 RAX: 000000000000002e RBX: ffff902edaab4680 RCX: 0000000000000003 RDX: 0000000080000003 RSI: 0000000000000000 RDI: 00000000ffffffff RBP: ffff96c50010fdb8 R08: 0000000000000000 R09: 0000000000000001 R10: 0000000000000000 R11: 00000000299f36ae R12: 0000000000000001 R13: ffffffff9de64240 R14: 0000000000000001 R15: ffffffff9de64240 FS: 0000000000000000(0000) GS:ffff902edfc80000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00000000f7d4c642 CR3: 000000001e0e2000 CR4: 00000000000006e0 Call Trace: resched_curr+0x8f/0x1c0 resched_cpu+0x2c/0x40 rcu_implicit_dynticks_qs+0x152/0x220 force_qs_rnp+0x147/0x1d0 ? sync_rcu_exp_select_cpus+0x450/0x450 rcu_gp_kthread+0x5a9/0x950 kthread+0x142/0x180 ? force_qs_rnp+0x1d0/0x1d0 ? kthread_create_on_node+0x40/0x40 ret_from_fork+0x27/0x40 Code: 14 01 0f 92 c0 84 c0 74 14 48 8b 05 14 4f f4 00 be fd 00 00 00 ff 90 a0 00 00 00 5d c3 89 fe 48 c7 c7 38 89 ca 9d e8 e5 56 08 00 <0f> ff 5d c3 0f 1f 44 00 00 8b 05 52 9e 37 02 85 c0 75 38 55 48 ---[ end trace 26df9e5df4bba4ac ]---
This splat cannot be generated by expedited grace periods because they always invoke resched_cpu() on the current CPU, which is good because expedited grace periods require that resched_cpu() unconditionally succeed. However, other parts of RCU can tolerate resched_cpu() acting as a no-op, at least as long as it doesn't happen too often.
This commit therefore makes resched_cpu() invoke resched_curr() only if the CPU is either online or is the current CPU.
--- kernel/sched/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
kernel/sched/core.c +2 -1
@@ -506,7 +506,8 @@ void resched_cpu(int cpu)unsigned long flags;raw_spin_lock_irqsave (&rq->lock, flags); -resched_curr (rq); +if (cpu_online (cpu) || cpu ==smp_processor_id ()) +resched_curr (rq);raw_spin_unlock_irqrestore (&rq->lock, flags); }
Greg Kroah-Hartman
maintainerPATCH 42/109 crypto: ecc - Fix NULL pointer deref. on no default_rng
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Pierre <[email protected]>
[ Upstream commit 4c0e22c90510308433272d7ba281b1eb4eda8209 ]
If crypto_get_default_rng returns an error, the function ecc_gen_privkey should return an error. Instead, it currently tries to use the default_rng nevertheless, thus creating a kernel panic with a NULL pointer dereference.
Returning the error directly, as was supposedly intended when looking at the code, fixes this.
--- crypto/ecc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
crypto/ecc.c +1 -1
@@ -964,7 +964,7 @@ int ecc_gen_privkey(unsigned int curve_i* DRBG with a security strength of 256. */ if (crypto_get_default_rng ()) - err = -EFAULT ; +return -EFAULT ; err =crypto_rng_get_bytes (crypto_default_rng, (u8 *)priv, nbytes);crypto_put_default_rng ();
Greg Kroah-Hartman
maintainerPATCH 43/109 crypto: cavium - fix memory leak on info
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Colin Ian King <[email protected]>
[ Upstream commit 87aae50af730a28dc1d8846d86dca5e9aa724a9f ]
The object info is being leaked on an error return path, fix this by setting ret to -ENOMEM and exiting via the request_cleanup path that will free info.
Detected by CoverityScan, CID#1408439 ("Resource Leak")
--- drivers/crypto/cavium/cpt/cptvf_reqmanager.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/crypto/cavium/cpt/cptvf_reqmanager.c +2 -1
@@ -459,7 +459,8 @@ int process_request(struct cpt_vf *cptvf info->completion_addr =kzalloc (sizeof (union cpt_res_s ),GFP_KERNEL );if (unlikely (!info->completion_addr)) {dev_err (&pdev->dev,"Unable to allocate memory for completion_addr\n" ); -return -ENOMEM ; + ret = -ENOMEM ; + goto request_cleanup; } result = (union cpt_res_s *)info->completion_addr;
Greg Kroah-Hartman
maintainerPATCH 44/109 test_firmware: fix setting old custom fw path back on exit
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: "Luis R. Rodriguez" <[email protected]>
[ Upstream commit 65c79230576873b312c3599479c1e42355c9f349 ]
The file /sys/module/firmware_class/parameters/path can be used to set a custom firmware path. The fw_filesystem.sh script creates a temporary directory to add a test firmware file to be used during testing, in order for this to work it uses the custom path syfs file and it was supposed to reset back the file on execution exit. The script failed to do this due to a typo, it was using OLD_PATH instead of OLD_FWPATH, since its inception since v3.17.
Its not as easy to just keep the old setting, it turns out that resetting an empty setting won't actually do what we want, we need to check if it was empty and set an empty space.
Without this we end up having the temporary path always set after we run these tests.
--- tools/testing/selftests/firmware/fw_filesystem.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
tools/testing/selftests/firmware/fw_filesystem.sh +4 -1
@@ -45,7 +45,10 @@ test_finish() if [ "$HAS_FW_LOADER_USER_HELPER" = "yes" ]; then echo "$OLD_TIMEOUT" >/sys/class/firmware/timeout fi - echo -n "$OLD_PATH" >/sys/module/firmware_class/parameters/path + if [ "$OLD_FWPATH" = "" ]; then + OLD_FWPATH=" " + fi + echo -n "$OLD_FWPATH" >/sys/module/firmware_class/parameters/path rm -f "$FW" rmdir "$FWPATH" }
Greg Kroah-Hartman
maintainerPATCH 45/109 net: ieee802154: adf7242: Fix bug if defined DEBUG
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Michael Hennerich <[email protected]>
[ Upstream commit 388b3b2b03701f3b3c10975c272892d7f78080df ]
This fixes undefined reference to struct adf7242_local *lp in case DEBUG is defined.
--- drivers/net/ieee802154/adf7242.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ieee802154/adf7242.c +2 -2
@@ -888,7 +888,7 @@ static const struct ieee802154_ops adf72 .set_cca_ed_level = adf7242_set_cca_ed_level, }; -static void adf7242_debug (u8 irq1) +static void adf7242_debug (struct adf7242_local *lp,u8 irq1) {#ifdef DEBUG u8 stat;
@@ -932,7 +932,7 @@ static irqreturn_t adf7242_isr(int irq,dev_err (&lp->spi->dev,"%s :ERROR IRQ1 = 0x%X\n" , __func__, irq1); -adf7242_debug (irq1); +adf7242_debug (lp, irq1); xmit =test_bit (FLAG_XMIT , &lp->flags);
Greg Kroah-Hartman
maintainerPATCH 46/109 rtc: brcmstb-waketimer: fix error handling in brcmstb_waketmr_probe()
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alexey Khoroshilov <[email protected]>
[ Upstream commit f2eef045de9defbc6fc6b72b17f0941cbe26c81d ]
brcmstb_waketmr_probe() does not disable timer->clk on error paths.
Found by Linux Driver Verification project (linuxtesting.org).
--- drivers/rtc/rtc-brcmstb-waketimer.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-)
drivers/rtc/rtc-brcmstb-waketimer.c +12 -3
@@ -253,7 +253,7 @@ static int brcmstb_waketmr_probe(struct ret =devm_request_irq (dev, timer->irq, brcmstb_waketmr_irq,0 ,"brcmstb-waketimer" , timer);if (ret <0 ) -return ret; + goto err_clk; timer->reboot_notifier.notifier_call = brcmstb_waketmr_reboot;register_reboot_notifier (&timer->reboot_notifier);
@@ -262,12 +262,21 @@ static int brcmstb_waketmr_probe(struct &brcmstb_waketmr_ops, THIS_MODULE);if (IS_ERR (timer->rtc)) {dev_err (dev,"unable to register device\n" ); -unregister_reboot_notifier (&timer->reboot_notifier); -return PTR_ERR (timer->rtc); + ret =PTR_ERR (timer->rtc); + goto err_notifier; }dev_info (dev,"registered, with irq %d\n" , timer->irq); +return 0 ; + +err_notifier: +unregister_reboot_notifier (&timer->reboot_notifier); + +err_clk: +if (timer->clk) +clk_disable_unprepare (timer->clk); +return ret; }
Greg Kroah-Hartman
maintainerPATCH 47/109 net: xfrm: allow clearing socket xfrm policies.
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Lorenzo Colitti <[email protected]>
[ Upstream commit be8f8284cd897af2482d4e54fbc2bdfc15557259 ]
Currently it is possible to add or update socket policies, but not clear them. Therefore, once a socket policy has been applied, the socket cannot be used for unencrypted traffic.
This patch allows (privileged) users to clear socket policies by passing in a NULL pointer and zero length argument to the {IP,IPV6}_{IPSEC,XFRM}_POLICY setsockopts. This results in both the incoming and outgoing policies being cleared.
The simple approach taken in this patch cannot clear socket policies in only one direction. If desired this could be added in the future, for example by continuing to pass in a length of zero (which currently is guaranteed to return EMSGSIZE) and making the policy be a pointer to an integer that contains one of the XFRM_POLICY_{IN,OUT} enum values.
An alternative would have been to interpret the length as a signed integer and use XFRM_POLICY_IN (i.e., 0) to clear the input policy and -XFRM_POLICY_OUT (i.e., -1) to clear the output policy.
Tested: https://android-review.googlesource.com/539816
--- net/xfrm/xfrm_policy.c | 2 +- net/xfrm/xfrm_state.c | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-)
net/xfrm/xfrm_policy.c +1 -1
@@ -1257,7 +1257,7 @@ EXPORT_SYMBOL(xfrm_policy_delete);int xfrm_sk_policy_insert (struct sock *sk,int dir,struct xfrm_policy *pol) { -struct net *net =xp_net (pol); +struct net *net =sock_net (sk);struct xfrm_policy *old_pol;#ifdef CONFIG_XFRM_SUB_POLICY
net/xfrm/xfrm_state.c +7 -0
@@ -2050,6 +2050,13 @@ int xfrm_user_policy(struct sock *sk, instruct xfrm_mgr *km;struct xfrm_policy *pol =NULL ; +if (!optval && !optlen) { +xfrm_sk_policy_insert (sk,XFRM_POLICY_IN ,NULL ); +xfrm_sk_policy_insert (sk,XFRM_POLICY_OUT ,NULL ); +__sk_dst_reset (sk); +return 0 ; + } +if (optlen <=0 || optlen >PAGE_SIZE )return -EMSGSIZE ;
Greg Kroah-Hartman
maintainerPATCH 48/109 mtd: nand: fix interpretation of NAND_CMD_NONE in nand_command[_lp]()
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Miquel Raynal <[email protected]>
[ Upstream commit df467899da0b71465760b4e35127bce837244eee ]
Some drivers (like nand_hynix.c) call ->cmdfunc() with NAND_CMD_NONE and a column address and expect the controller to only send address cycles. Right now, the default ->cmdfunc() implementations provided by the core do not filter out the command cycle in this case and forwards the request to the controller driver through the ->cmd_ctrl() method. The thing is, NAND controller drivers can get this wrong and send a command cycle with a NAND_CMD_NONE opcode and since NAND_CMD_NONE is -1, and the command field is usually casted to an u8, we end up sending the 0xFF command which is actually a RESET operation.
Add conditions in nand_command[_lp]() functions to sending the initial command cycle when command == NAND_CMD_NONE.
--- drivers/mtd/nand/nand_base.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/mtd/nand/nand_base.c +7 -2
@@ -710,7 +710,8 @@ static void nand_command(struct mtd_info chip->cmd_ctrl (mtd, readcmd, ctrl); ctrl &= ~NAND_CTRL_CHANGE ; } - chip->cmd_ctrl (mtd, command, ctrl); +if (command !=NAND_CMD_NONE ) + chip->cmd_ctrl (mtd, command, ctrl);/* Address cycle, when necessary */ ctrl =NAND_CTRL_ALE |NAND_CTRL_CHANGE ;
@@ -739,6 +740,7 @@ static void nand_command(struct mtd_info*/ switch (command) { +case NAND_CMD_NONE :case NAND_CMD_PAGEPROG :case NAND_CMD_ERASE1 :case NAND_CMD_ERASE2 :
@@ -832,7 +834,9 @@ static void nand_command_lp(struct mtd_i }/* Command latch cycle */ - chip->cmd_ctrl (mtd, command,NAND_NCE |NAND_CLE |NAND_CTRL_CHANGE ); +if (command !=NAND_CMD_NONE ) + chip->cmd_ctrl (mtd, command, +NAND_NCE |NAND_CLE |NAND_CTRL_CHANGE );if (column !=-1 || page_addr !=-1 ) {int ctrl =NAND_CTRL_CHANGE |NAND_NCE |NAND_ALE ;
@@ -868,6 +872,7 @@ static void nand_command_lp(struct mtd_i*/ switch (command) { +case NAND_CMD_NONE :case NAND_CMD_CACHEDPROG :case NAND_CMD_PAGEPROG :case NAND_CMD_ERASE1 :
Greg Kroah-Hartman
maintainerPATCH 49/109 net: thunderx: Set max queue count taking XDP_TX into account
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Sunil Goutham <[email protected]>
[ Upstream commit 87de083857aa269fb171ef0b39696b2888361c58 ]
on T81 there are only 4 cores, hence setting max queue count to 4 would leave nothing for XDP_TX. This patch fixes this by doubling max queue count in above scenarios.
--- drivers/net/ethernet/cavium/thunder/nicvf_main.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/net/ethernet/cavium/thunder/nicvf_main.c +5 -0
@@ -1832,6 +1832,11 @@ static int nicvf_probe(struct pci_dev *p nic->pdev = pdev; nic->pnicvf = nic; nic->max_queues = qcount; +/* If no of CPUs are too low, there won't be any queues left +* for XDP_TX, hence double it. +*/ +if (!nic->t88) + nic->max_queues *=2 ;/* MAP VF's configuration registers */ nic->reg_base =pcim_iomap (pdev,PCI_CFG_REG_BAR_NUM ,0 );
Greg Kroah-Hartman
maintainerPATCH 50/109 ARM: dts: am335x-pepper: Fix the audio CODECs reset pin
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: "Andrew F. Davis" <[email protected]>
[ Upstream commit e153db03c6b7a035c797bcdf35262586f003ee93 ]
The correct DT property for specifying a GPIO used for reset is "reset-gpios", fix this here.
--- arch/arm/boot/dts/am335x-pepper.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/am335x-pepper.dts +1 -1
@@ -139,7 +139,7 @@ &audio_codec { status = "okay"; - gpio-reset = <&gpio1 16 GPIO_ACTIVE_LOW>; + reset-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>; AVDD-supply = <&ldo3_reg>; IOVDD-supply = <&ldo3_reg>; DRVDD-supply = <&ldo3_reg>;
Greg Kroah-Hartman
maintainerPATCH 51/109 ARM: dts: omap3-n900: Fix the audio CODECs reset pin
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: "Andrew F. Davis" <[email protected]>
[ Upstream commit 7be4b5dc7ffa9499ac6ef33a5ffa9ff43f9b7057 ]
The correct DT property for specifying a GPIO used for reset is "reset-gpios", fix this here.
--- arch/arm/boot/dts/omap3-n900.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/omap3-n900.dts +2 -2
@@ -558,7 +558,7 @@ tlv320aic3x: tlv320aic3x@18 { compatible = "ti,tlv320aic3x"; reg = <0x18>; - gpio-reset = <&gpio2 28 GPIO_ACTIVE_HIGH>; /* 60 */ + reset-gpios = <&gpio2 28 GPIO_ACTIVE_LOW>; /* 60 */ ai3x-gpio-func = < 0 /* AIC3X_GPIO1_FUNC_DISABLED */ 5 /* AIC3X_GPIO2_FUNC_DIGITAL_MIC_INPUT */
@@ -575,7 +575,7 @@ tlv320aic3x_aux: tlv320aic3x@19 { compatible = "ti,tlv320aic3x"; reg = <0x19>; - gpio-reset = <&gpio2 28 GPIO_ACTIVE_HIGH>; /* 60 */ + reset-gpios = <&gpio2 28 GPIO_ACTIVE_LOW>; /* 60 */ AVDD-supply = <&vmmc2>; DRVDD-supply = <&vmmc2>;
Greg Kroah-Hartman
maintainerPATCH 52/109 mtd: nand: ifc: update bufnum mask for ver >= 2.0.0
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jagdish Gediya <[email protected]>
[ Upstream commit bccb06c353af3764ca86d9da47652458e6c2eb41 ]
Bufnum mask is used to calculate page position in the internal SRAM.
As IFC version 2.0.0 has 16KB of internal SRAM as compared to older versions which had 8KB. Hence bufnum mask needs to be updated.
--- drivers/mtd/nand/fsl_ifc_nand.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/mtd/nand/fsl_ifc_nand.c +7 -0
@@ -916,6 +916,13 @@ static int fsl_ifc_chip_init(struct fsl_if (ctrl->version >=FSL_IFC_VERSION_1_1_0 )fsl_ifc_sram_init (priv); +/* +* As IFC version 2.0.0 has 16KB of internal SRAM as compared to older +* versions which had 8KB. Hence bufnum mask needs to be updated. +*/ +if (ctrl->version >=FSL_IFC_VERSION_2_0_0 ) + priv->bufnum_mask = (priv->bufnum_mask *2 ) +1 ; +return 0 ; }
Greg Kroah-Hartman
maintainerPATCH 53/109 userns: Dont fail follow_automount based on s_user_ns
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: "Eric W. Biederman" <[email protected]>
[ Upstream commit bbc3e471011417598e598707486f5d8814ec9c01 ]
When vfs_submount was added the test to limit automounts from filesystems that with s_user_ns != &init_user_ns accidentially left in follow_automount. The test was never about any security concerns and was always about how do we implement this for filesystems whose s_user_ns != &init_user_ns.
At the moment this check makes no difference as there are no filesystems that both set FS_USERNS_MOUNT and implement d_automount.
Remove this check now while I am thinking about it so there will not be odd booby traps for someone who does want to make this combination work.
vfs_submount still needs improvements to allow this combination to work, and vfs_submount contains a check that presents a warning.
The autofs4 filesystem could be modified to set FS_USERNS_MOUNT and it would need not work on this code path, as userspace performs the mounts.
--- fs/namei.c | 3 --- 1 file changed, 3 deletions(-)
fs/namei.c +0 -3
@@ -1133,9 +1133,6 @@ static int follow_automount(struct path path->dentry->d_inode)return -EISDIR ; -if (path->dentry->d_sb->s_user_ns != &init_user_ns) -return -EACCES ; - nd->total_link_count++;if (nd->total_link_count >=40 )return -ELOOP ;
Greg Kroah-Hartman
maintainerPATCH 54/109 xfrm: Fix xfrm_replay_overflow_offload_esn
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Yossef Efraim <[email protected]>
[ Upstream commit 0ba23a211360af7b6658e4fcfc571970bbbacc55 ]
In case of wrap around, replay_esn->oseq_hi is not updated before it is tested for it's actual value, leading function to fail with overflow indication and packets being dropped.
This patch updates replay_esn->oseq_hi in the right place.
--- net/xfrm/xfrm_replay.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
net/xfrm/xfrm_replay.c +1 -2
@@ -666,7 +666,7 @@ static int xfrm_replay_overflow_offload_if (unlikely (oseq < replay_esn->oseq)) {XFRM_SKB_CB (skb)->seq.output.hi = ++oseq_hi; xo->seq.hi = oseq_hi; - + replay_esn->oseq_hi = oseq_hi;if (replay_esn->oseq_hi ==0 ) { replay_esn->oseq--; replay_esn->oseq_hi--;
@@ -678,7 +678,6 @@ static int xfrm_replay_overflow_offload_ } replay_esn->oseq = oseq; - replay_esn->oseq_hi = oseq_hi;if (xfrm_aevent_is_on (net)) x->repl->notify (x,XFRM_REPLAY_UPDATE );
Greg Kroah-Hartman
maintainerPATCH 55/109 leds: pm8058: Silence pointer to integer size warning
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Bjorn Andersson <[email protected]>
[ Upstream commit 8f52df50d9366f770a894d14ef724e5e04574e98 ]
The pointer returned by of_device_get_match_data() doesn't have the same size as u32 on 64-bit architectures, causing a compile warning when compile-testing the driver on such platform.
Cast the return value of of_device_get_match_data() to unsigned long and then to u32 to silence this warning.
--- drivers/leds/leds-pm8058.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/leds/leds-pm8058.c +1 -1
@@ -106,7 +106,7 @@ static int pm8058_led_probe(struct platfif (!led)return -ENOMEM ; - led->ledtype = (u32 )of_device_get_match_data (&pdev->dev); + led->ledtype = (u32 )(unsigned long )of_device_get_match_data (&pdev->dev); map =dev_get_regmap (pdev->dev.parent,NULL );if (!map) {
Greg Kroah-Hartman
maintainerPATCH 56/109 clk: ti: clkctrl: add support for retrying failed init
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Tero Kristo <[email protected]>
[ Upstream commit 729e13bf58e643b9accd2a14c55b555958702fb0 ]
In case the clkctrl node contains assigned-clock-* entries, registering the provider can fail with -EPROBE_DEFER. In this case, add the provider to the retry_init clock list so it will be cleaned up later.
--- drivers/clk/ti/clkctrl.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)
drivers/clk/ti/clkctrl.c +11 -1
@@ -400,6 +400,12 @@ _ti_clkctrl_setup_subclks(struct omap_cl } } +static void __init _clkctrl_add_provider (void *data, +struct device_node *np) +{ +of_clk_add_hw_provider (np, _ti_omap4_clkctrl_xlate, data); +} +static void __init _ti_omap4_clkctrl_setup (struct device_node *node) {struct omap_clkctrl_provider *provider;
@@ -411,6 +417,7 @@ static void __init _ti_omap4_clkctrl_setstruct omap_clkctrl_clk *clkctrl_clk;const __be32 *addrp;u32 addr; +int ret; addrp =of_get_address (node,0 ,NULL ,NULL ); addr = (u32 )of_translate_address (node, addrp);
@@ -485,7 +492,10 @@ static void __init _ti_omap4_clkctrl_set reg_data++; } -of_clk_add_hw_provider (node, _ti_omap4_clkctrl_xlate, provider); + ret =of_clk_add_hw_provider (node, _ti_omap4_clkctrl_xlate, provider); +if (ret == -EPROBE_DEFER ) +ti_clk_retry_init (node, provider, _clkctrl_add_provider); +return ; cleanup:
Re: [PATCH 4.14 056/109] clk: ti: clkctrl: add support for retrying failed init
Quoted 9 lines · Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Tero Kristo <[email protected]>
[ Upstream commit
729e13bf58e643b9accd2a14c55b555958702fb0]
Quoted 8 lines
In case the clkctrl node contains assigned-clock-* entries, registering the provider can fail with -EPROBE_DEFER. In this case, add the provider to the
retry_initclock list so it will be cleaned up later.Signed-off-by Tero Kristo <[email protected]>Acked-by Stephen Boyd <[email protected]>Signed-off-by Sasha Levin <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
This fails to build for me on arm32:
$ make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- O=build-arm multi_v7_defconfig $ make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- O=build-arm
...
../drivers/clk/ti/clkctrl.c: In function ‘_ti_omap4_clkctrl_setup’:../drivers/clk/ti/clkctrl.c:497:27: error: passing argument 2 of ‘ti_clk_retry_init’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
ti_clk_retry_init(node, provider, _clkctrl_add_provider);
^~~~~~~~In file included from ../drivers/clk/ti/clkctrl.c:24:0:../drivers/clk/ti/clock.h:265:5: note: expected ‘struct clk_hw *’ but argument is of type ‘struct omap_clkctrl_prov ider *’
int ti_clk_retry_init(struct device_node *node, struct clk_hw *hw,
^~~~~~~~~~~~~~~~~ ../drivers/clk/ti/clkctrl.c:497:37: error: passing argument 3 of ‘ti_clk_retry_init’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
ti_clk_retry_init(node, provider, _clkctrl_add_provider);
^~~~~~~~~~~~~~~~~~~~~
In file included from ../drivers/clk/ti/clkctrl.c:24:0: ../drivers/clk/ti/clock.h:265:5: note: expected ‘ti_of_clk_init_cb_t {aka void (*)(struct clk_hw *, struct device_n
ode *)}’ but argument is of type ‘void (*)(void *, struct device_node *)’
int ti_clk_retry_init(struct device_node *node, struct clk_hw *hw,
^~~~~~~~~~~~~~~~~cc1: some warnings being treated as errors
make[4]: *** [../scripts/Makefile.build:329: drivers/clk/ti/clkctrl.o] Error 1 make[3]: *** [../scripts/Makefile.build:587: drivers/clk/ti] Error 2 make[2]: *** [../scripts/Makefile.build:587: drivers/clk] Error 2 make[1]: *** [/home/drue/src/linux/4.14-rc/Makefile:1031: drivers] Error 2 make[1]: Leaving directory '/home/drue/src/linux/4.14-rc/build-arm'
make: *** [Makefile:146: sub-make] Error 2
Quoted 41 lines
--- drivers/clk/ti/clkctrl.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)drivers/clk/ti/clkctrl.c +11
-1@@ -400,6 +400,12 @@ _ti_clkctrl_setup_subclks(struct omap_cl } } +static void __init _clkctrl_add_provider (void *data, +struct device_node *np) +{ +of_clk_add_hw_provider (np, _ti_omap4_clkctrl_xlate, data); +} +static void __init _ti_omap4_clkctrl_setup (struct device_node *node) {struct omap_clkctrl_provider *provider;@@ -411,6 +417,7 @@ static void __init _ti_omap4_clkctrl_setstruct omap_clkctrl_clk *clkctrl_clk;const __be32 *addrp;u32 addr; +int ret; addrp =of_get_address (node,0 ,NULL ,NULL ); addr = (u32 )of_translate_address (node, addrp);@@ -485,7 +492,10 @@ static void __init _ti_omap4_clkctrl_set reg_data++; } -of_clk_add_hw_provider (node, _ti_omap4_clkctrl_xlate, provider); + ret =of_clk_add_hw_provider (node, _ti_omap4_clkctrl_xlate, provider); +if (ret == -EPROBE_DEFER ) +ti_clk_retry_init (node, provider, _clkctrl_add_provider); +return ; cleanup:
Re: [PATCH 4.14 056/109] clk: ti: clkctrl: add support for retrying failed init
Quoted 19 lines · Dan Rue
Quoted 9 lines · Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Tero Kristo <[email protected]>
[ Upstream commit
729e13bf58e643b9accd2a14c55b555958702fb0]Quoted 8 lines
In case the clkctrl node contains assigned-clock-* entries, registering the provider can fail with -EPROBE_DEFER. In this case, add the provider to the
retry_initclock list so it will be cleaned up later.Signed-off-by Tero Kristo <[email protected]>Acked-by Stephen Boyd <[email protected]>Signed-off-by Sasha Levin <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
Quoted 4 lines
This fails to build for me on arm32:
$ make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- O=build-arm multi_v7_defconfig $ make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- O=build-arm
This actually needs commit ffb009b24388b896d9ca8b54e39a879302142518 ("clk: ti: convert retry_init param to use void data type") as prerequisite, otherwise it fails building.
-Tero
Quoted 66 lines
...
../drivers/clk/ti/clkctrl.c: In function ‘_ti_omap4_clkctrl_setup’:../drivers/clk/ti/clkctrl.c:497:27: error: passing argument 2 of ‘ti_clk_retry_init’ from incompatible pointer type
[-Werror=incompatible-pointer-types]ti_clk_retry_init(node, provider, _clkctrl_add_provider); ^~~~~~~~In file included from
../drivers/clk/ti/clkctrl.c:24:0:../drivers/clk/ti/clock.h:265:5: note: expected ‘structclk_hw*’ but argument is of type ‘structomap_clkctrl_provider *’
int ti_clk_retry_init(structdevice_node*node, structclk_hw*hw,
^~~~~~~~~~~~~~~~~../drivers/clk/ti/clkctrl.c:497:37: error: passing argument 3 of ‘ti_clk_retry_init’ from incompatible pointer type
[-Werror=incompatible-pointer-types]ti_clk_retry_init(node, provider, _clkctrl_add_provider); ^~~~~~~~~~~~~~~~~~~~~ In file included from ../drivers/clk/ti/clkctrl.c:24:0: ../drivers/clk/ti/clock.h:265:5: note: expected ‘ti_of_clk_init_cb_t {aka void (*)(struct clk_hw *, struct device_n ode *)}’ but argument is of type ‘void (*)(void *, struct device_node *)’ int ti_clk_retry_init(struct device_node *node, struct clk_hw *hw, ^~~~~~~~~~~~~~~~~cc1: some warnings being treated as errors
make[4]: *** [../scripts/Makefile.build:329:drivers/clk/ti/clkctrl.o] Error 1 make[3]: *** [../scripts/Makefile.build:587:drivers/clk/ti] Error 2 make[2]: *** [../scripts/Makefile.build:587:drivers/clk] Error 2 make[1]: *** [/home/drue/src/linux/4.14-rc/Makefile:1031: drivers] Error 2 make[1]: Leaving directory '/home/drue/src/linux/4.14-rc/build-arm'
make: *** [Makefile:146: sub-make] Error 2Quoted 38 lines
--- drivers/clk/ti/clkctrl.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)drivers/clk/ti/clkctrl.c +11
-1@@ -400,6 +400,12 @@ _ti_clkctrl_setup_subclks(struct omap_cl } } +static void __init _clkctrl_add_provider (void *data, +struct device_node *np) +{ +of_clk_add_hw_provider (np, _ti_omap4_clkctrl_xlate, data); +} +static void __init _ti_omap4_clkctrl_setup (struct device_node *node) {struct omap_clkctrl_provider *provider;@@ -411,6 +417,7 @@ static void __init _ti_omap4_clkctrl_setstruct omap_clkctrl_clk *clkctrl_clk;const __be32 *addrp;u32 addr; +int ret; addrp =of_get_address (node,0 ,NULL ,NULL ); addr = (u32 )of_translate_address (node, addrp);@@ -485,7 +492,10 @@ static void __init _ti_omap4_clkctrl_set reg_data++; } -of_clk_add_hw_provider (node, _ti_omap4_clkctrl_xlate, provider); + ret =of_clk_add_hw_provider (node, _ti_omap4_clkctrl_xlate, provider); +if (ret == -EPROBE_DEFER ) +ti_clk_retry_init (node, provider, _clkctrl_add_provider); +return ;
Quoted 3 lines
drivers/clk/ti/clkctrl.c static void __init _ti_omap4_clkctrl_set · line 501
Quoted 3 lines
drivers/clk/ti/clkctrl.c +0
-0cleanup:
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Greg Kroah-Hartman
maintainerRe: [PATCH 4.14 056/109] clk: ti: clkctrl: add support for retrying failed init
Quoted 20 lines · Tero Kristo
Quoted 19 lines · Dan Rue
Quoted 17 lines · Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Tero Kristo <[email protected]>
[ Upstream commit
729e13bf58e643b9accd2a14c55b555958702fb0]In case the clkctrl node contains assigned-clock-* entries, registering the provider can fail with -EPROBE_DEFER. In this case, add the provider to the
retry_initclock list so it will be cleaned up later.Signed-off-by Tero Kristo <[email protected]>Acked-by Stephen Boyd <[email protected]>Signed-off-by Sasha Levin <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
Quoted 8 lines
Quoted 4 lines
This fails to build for me on arm32:
$ make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- O=build-arm multi_v7_defconfig $ make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- O=build-armThis actually needs commit
ffb009b24388b896d9ca8b54e39a879302142518("clk:
ti: convertretry_initparam to use void data type") as prerequisite, otherwise it fails building.
Thanks, I'll just drop this patch from the trees now, as that seems to make more sense.
Sasha, if you want to pick both of these up for your next round of patches to submit, that's fine.
thanks,
greg k-h
Re: [PATCH 4.14 056/109] clk: ti: clkctrl: add support for retrying failed init
In reply to Tero KristoQuoted 20 lines · Tero Kristo
Quoted 19 lines · Dan Rue
Quoted 17 lines · Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Tero Kristo <[email protected]>
[ Upstream commit
729e13bf58e643b9accd2a14c55b555958702fb0]In case the clkctrl node contains assigned-clock-* entries, registering the provider can fail with -EPROBE_DEFER. In this case, add the provider to the
retry_initclock list so it will be cleaned up later.Signed-off-by Tero Kristo <[email protected]>Acked-by Stephen Boyd <[email protected]>Signed-off-by Sasha Levin <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
Quoted 8 lines
Quoted 4 lines
This fails to build for me on arm32:
$ make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- O=build-arm multi_v7_defconfig $ make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- O=build-armThis actually needs commit
ffb009b24388b896d9ca8b54e39a879302142518("clk: ti: convertretry_initparam to use void data type") as prerequisite, otherwise it fails building.
I'll pick both up for the next cycle, thanks!
Signature · 2 lines
Thanks, Sasha
Greg Kroah-Hartman
maintainerPATCH 57/109 power: supply: ab8500_charger: Fix an error handling path
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Christophe JAILLET <[email protected]>
[ Upstream commit bf59fddde1c3eab89eb8dca8f3d3dc097887d2bb ]
'ret' is know to be 0 at this point, because it has not been updated by the the previous call to 'abx500_mask_and_set_register_interruptible()'.
Fix it by updating 'ret' before checking if an error occurred.
--- drivers/power/supply/ab8500_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/power/supply/ab8500_charger.c +1 -1
@@ -3218,7 +3218,7 @@ static int ab8500_charger_init_hw_regist }/* Enable backup battery charging */ -abx500_mask_and_set_register_interruptible (di->dev, + ret =abx500_mask_and_set_register_interruptible (di->dev,AB8500_RTC ,AB8500_RTC_CTRL_REG ,RTC_BUP_CH_ENA ,RTC_BUP_CH_ENA );if (ret <0 )
Greg Kroah-Hartman
maintainerPATCH 58/109 power: supply: ab8500_charger: Bail out in case of error in ab8500_charger_init_hw_registers()
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Christophe JAILLET <[email protected]>
[ Upstream commit 09edcb647542487864e23aa8d2ef26be3e08978a ]
If an error occurs when we enable the backup battery charging, we should go through the error handling path directly.
Before commit db43e6c473b5 ("ab8500-bm: Add usb power path support") this was the case, but this commit has added some code between the last test and the 'out' label.
So, in case of error, this added code is executed and the error may be silently ignored.
Fix it by adding the missing 'goto out', as done in all other error handling paths.
--- drivers/power/supply/ab8500_charger.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/power/supply/ab8500_charger.c +3 -1
@@ -3221,8 +3221,10 @@ static int ab8500_charger_init_hw_regist ret =abx500_mask_and_set_register_interruptible (di->dev,AB8500_RTC ,AB8500_RTC_CTRL_REG ,RTC_BUP_CH_ENA ,RTC_BUP_CH_ENA ); -if (ret <0 ) +if (ret <0 ) {dev_err (di->dev,"%s mask and set failed\n" , __func__); + goto out; + }if (is_ab8540 (di->parent)) { ret = abx500_mask_and_set_register_interruptible(di->dev,
Greg Kroah-Hartman
maintainerPATCH 59/109 drm/etnaviv: make THERMAL selectable
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Philipp Zabel <[email protected]>
[ Upstream commit 49b82c389d2a40eaef1355aaa35868b367aec9d1 ]
The etnaviv driver causes a link failure if it is built-in but THERMAL is built as a module:
drivers/gpu/drm/etnaviv/etnaviv_gpu.o: In function `etnaviv_gpu_bind':
etnaviv_gpu.c:(.text+0x4c4): undefined reference to thermal_of_cooling_device_register' etnaviv_gpu.c:(.text+0x600): undefined reference to thermal_cooling_device_unregister' drivers/gpu/drm/etnaviv/etnaviv_gpu.o: In function `etnaviv_gpu_unbind':
etnaviv_gpu.c:(.text+0x2aac): undefined reference to `thermal_cooling_device_unregister'
Adding a Kconfig dependency on THERMAL || !THERMAL to avoid this causes a dependency loop on x86_64:
drivers/gpu/drm/tve200/Kconfig:1:error: recursive dependency detected! For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations"
drivers/gpu/drm/tve200/Kconfig:1: symbol DRM_TVE200 depends on CMA
For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" mm/Kconfig:489: symbol CMA is selected by DRM_ETNAVIV
For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations"
drivers/gpu/drm/etnaviv/Kconfig:2: symbol DRM_ETNAVIV depends on THERMAL
For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations"
drivers/thermal/Kconfig:5: symbol THERMAL is selected by ACPI_VIDEO
For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations"
drivers/acpi/Kconfig:189: symbol ACPI_VIDEO is selected by BACKLIGHT_CLASS_DEVICE
For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations"
drivers/video/backlight/Kconfig:158: symbol BACKLIGHT_CLASS_DEVICE is selected by DRM_PARADE_PS8622
For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations"
drivers/gpu/drm/bridge/Kconfig:62: symbol DRM_PARADE_PS8622 depends on DRM_BRIDGE
For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations"
drivers/gpu/drm/bridge/Kconfig:1: symbol DRM_BRIDGE is selected by DRM_TVE200
To work around this, add a new option DRM_ETNAVIV_THERMAL to optionally enable thermal throttling support and make DRM_ETNAVIV select THERMAL at the same time.
--- drivers/gpu/drm/etnaviv/Kconfig | 9 +++++++++ drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 8 +++++--- 2 files changed, 14 insertions(+), 3 deletions(-)
drivers/gpu/drm/etnaviv/Kconfig +9 -0
@@ -6,6 +6,7 @@ config DRM_ETNAVIV depends on MMU select SHMEM select SYNC_FILE + select THERMAL if DRM_ETNAVIV_THERMAL select TMPFS select IOMMU_API select IOMMU_SUPPORT
@@ -15,6 +16,14 @@ config DRM_ETNAVIV help DRM driver for Vivante GPUs. +config DRM_ETNAVIV_THERMAL + bool "enable ETNAVIV thermal throttling" + depends on DRM_ETNAVIV + default y + help + Compile in support for thermal throttling. + Say Y unless you want to risk burning your SoC. + config DRM_ETNAVIV_REGISTER_LOGGING bool "enable ETNAVIV register logging" depends on DRM_ETNAVIV
drivers/gpu/drm/etnaviv/etnaviv_gpu.c +5 -3
@@ -1622,7 +1622,7 @@ static int etnaviv_gpu_bind(struct devicstruct etnaviv_gpu *gpu =dev_get_drvdata (dev);int ret; -if (IS_ENABLED (CONFIG_THERMAL )) { +if (IS_ENABLED (CONFIG_DRM_ETNAVIV_THERMAL )) { gpu->cooling =thermal_of_cooling_device_register (dev->of_node, (char *)dev_name (dev), gpu, &cooling_ops);if (IS_ERR (gpu->cooling))
@@ -1635,7 +1635,8 @@ static int etnaviv_gpu_bind(struct devic ret =etnaviv_gpu_clk_enable (gpu);#endif if (ret <0 ) { -thermal_cooling_device_unregister (gpu->cooling); +if (IS_ENABLED (CONFIG_DRM_ETNAVIV_THERMAL )) +thermal_cooling_device_unregister (gpu->cooling);return ret; }
@@ -1692,7 +1693,8 @@ static void etnaviv_gpu_unbind(struct de gpu->drm =NULL ; -thermal_cooling_device_unregister (gpu->cooling); +if (IS_ENABLED (CONFIG_DRM_ETNAVIV_THERMAL )) +thermal_cooling_device_unregister (gpu->cooling); gpu->cooling =NULL ; }
Greg Kroah-Hartman
maintainerPATCH 60/109 iio: adc: ina2xx: Shift bus voltage register to mask flag bits
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: "Stefan Br�ns" <[email protected]>
[ Upstream commit 2e64438487697f3f099946edc8acd4ceea6b1ab2 ]
Lower bits of the INA219/220 bus voltage register are conversion status flags, properly shift the value.
When reading via IIO buffer, the value is passed on unaltered, shifting is the responsibility of the user.
--- drivers/iio/adc/ina2xx-adc.c | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-)
drivers/iio/adc/ina2xx-adc.c +17 -9
@@ -44,7 +44,6 @@#define INA226_MASK_ENABLE 0x06#define INA226_CVRF BIT(3) -#define INA219_CNVR BIT(1)#define INA2XX_MAX_REGISTERS 8
@@ -79,6 +78,11 @@#define INA226_ITS_MASK GENMASK(5, 3)#define INA226_SHIFT_ITS (val) ((val) << 3) +/* INA219 Bus voltage register, low bits are flags */ +#define INA219_OVF BIT(0) +#define INA219_CNVR BIT(1) +#define INA219_BUS_VOLTAGE_SHIFT 3 +/* Cosmetic macro giving the sampling period for a full P=UxI cycle */ #define SAMPLING_PERIOD (c) ((c->int_time_vbus + c->int_time_vshunt) \ * c->avg)
@@ -112,7 +116,7 @@ struct ina2xx_config {u16 config_default;int calibration_factor;int shunt_div; -int bus_voltage_shift; +int bus_voltage_shift;/* position of lsb */ int bus_voltage_lsb;/* uV */ int power_lsb;/* uW */ enum ina2xx_ids chip_id;
@@ -135,7 +139,7 @@ static const struct ina2xx_config ina2xx .config_default = INA219_CONFIG_DEFAULT, .calibration_factor = 40960000, .shunt_div = 100, - .bus_voltage_shift = 3, + .bus_voltage_shift = INA219_BUS_VOLTAGE_SHIFT, .bus_voltage_lsb = 4000, .power_lsb = 20000, .chip_id = ina219,
@@ -170,6 +174,9 @@ static int ina2xx_read_raw(struct iio_deelse *val = regval; +if (chan->address ==INA2XX_BUS_VOLTAGE ) + *val >>= chip->config->bus_voltage_shift; +return IIO_VAL_INT ;case IIO_CHAN_INFO_OVERSAMPLING_RATIO :
@@ -203,9 +210,9 @@ static int ina2xx_read_raw(struct iio_dereturn IIO_VAL_FRACTIONAL ;case INA2XX_BUS_VOLTAGE : -/* processed (mV) = raw*lsb (uV) / (1000 << shift) */ +/* processed (mV) = raw * lsb (uV) / 1000 */ *val = chip->config->bus_voltage_lsb; - *val2 =1000 << chip->config->bus_voltage_shift; + *val2 =1000 ;return IIO_VAL_FRACTIONAL ;case INA2XX_POWER :
@@ -532,7 +539,7 @@ static ssize_t ina2xx_shunt_resistor_sto* Sampling Freq is a consequence of the integration times of * the Voltage channels. */ -#define INA219_CHAN_VOLTAGE (_index, _address) { \ +#define INA219_CHAN_VOLTAGE (_index, _address, _shift) { \ .type = IIO_VOLTAGE, \ .address = (_address), \ .indexed = 1, \
@@ -544,7 +551,8 @@ static ssize_t ina2xx_shunt_resistor_sto .scan_index = (_index), \ .scan_type = { \ .sign = 'u', \ - .realbits = 16, \ + .shift = _shift, \ + .realbits = 16 - _shift, \ .storagebits = 16, \ .endianness = IIO_LE, \ } \
@@ -579,8 +587,8 @@ static const struct iio_chan_spec ina226 };static const struct iio_chan_spec ina219_channels[] = { -INA219_CHAN_VOLTAGE (0 ,INA2XX_SHUNT_VOLTAGE ), -INA219_CHAN_VOLTAGE (1 ,INA2XX_BUS_VOLTAGE ), +INA219_CHAN_VOLTAGE (0 ,INA2XX_SHUNT_VOLTAGE ,0 ), +INA219_CHAN_VOLTAGE (1 ,INA2XX_BUS_VOLTAGE ,INA219_BUS_VOLTAGE_SHIFT ),INA219_CHAN (IIO_POWER ,2 ,INA2XX_POWER ),INA219_CHAN (IIO_CURRENT ,3 ,INA2XX_CURRENT ),IIO_CHAN_SOFT_TIMESTAMP (4 ),
Greg Kroah-Hartman
maintainerPATCH 61/109 iio: health: max30102: Add power enable parameter to get_temp function
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Peter Meerwald-Stadler <[email protected]>
[ Upstream commit a9c47abbdd71dceeaf1b923e5ce10e700e036905 ]
Chip must not be in shutdown for reading temperature, so briefly leave shutdown if buffer is not already running
--- drivers/iio/health/max30102.c | 36 +++++++++++++++++++++++------------- 1 file changed, 23 insertions(+), 13 deletions(-)
drivers/iio/health/max30102.c +23 -13
@@ -329,20 +329,31 @@ static int max30102_read_temp(struct maxreturn 0 ; } -static int max30102_get_temp (struct max30102_data *data,int *val) +static int max30102_get_temp (struct max30102_data *data,int *val,bool en) {int ret; +if (en) { + ret =max30102_set_powermode (data, true); +if (ret) +return ret; + } +/* start acquisition */ ret =regmap_update_bits (data->regmap,MAX30102_REG_TEMP_CONFIG ,MAX30102_REG_TEMP_CONFIG_TEMP_EN ,MAX30102_REG_TEMP_CONFIG_TEMP_EN );if (ret) -return ret; + goto out;msleep (35 ); + ret =max30102_read_temp (data, val); + +out: +if (en) +max30102_set_powermode (data, false); -return max30102_read_temp (data, val); +return ret; } static int max30102_read_raw(struct iio_dev *indio_dev,
@@ -355,20 +366,19 @@ static int max30102_read_raw(struct iio_switch (mask) {case IIO_CHAN_INFO_RAW :/* -* Temperature reading can only be acquired while engine -* is running +* Temperature reading can only be acquired when not in +* shutdown; leave shutdown briefly when buffer not running */ mutex_lock (&indio_dev->mlock); -if (!iio_buffer_enabled (indio_dev)) - ret = -EBUSY ; -else { - ret =max30102_get_temp (data, val); -if (!ret) - ret =IIO_VAL_INT ; - } - + ret =max30102_get_temp (data, val, true); +else + ret =max30102_get_temp (data, val, false);mutex_unlock (&indio_dev->mlock); +if (ret) +return ret; + + ret =IIO_VAL_INT ;break ;case IIO_CHAN_INFO_SCALE : *val =1000 ;/* 62.5 */
Greg Kroah-Hartman
maintainerPATCH 62/109 ath10k: update tdls teardown state to target
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Manikanta Pubbisetty <[email protected]>
[ Upstream commit 424ea0d174e82365f85c6770225dba098b8f1d5f ]
It is required to update the teardown state of the peer when a tdls link with that peer is terminated. This information is useful for the target to perform some cleanups wrt the tdls peer.
Without proper cleanup, target assumes that the peer is connected and blocks future connection requests, updating the teardown state of the peer addresses the problem.
Tested this change on QCA9888 with 10.4-3.5.1-00018 fw version.
--- drivers/net/wireless/ath/ath10k/mac.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/net/wireless/ath/ath10k/mac.c +10 -0
@@ -6183,6 +6183,16 @@ static int ath10k_sta_state(struct ieee8"mac vdev %d peer delete %pM sta %pK (sta gone)\n" , arvif->vdev_id, sta->addr, sta); +if (sta->tdls) { + ret =ath10k_mac_tdls_peer_update (ar, arvif->vdev_id, + sta, +WMI_TDLS_PEER_STATE_TEARDOWN ); +if (ret) +ath10k_warn (ar,"failed to update tdls peer state for %pM state %d: %i\n" , + sta->addr, +WMI_TDLS_PEER_STATE_TEARDOWN , ret); + } + ret =ath10k_peer_delete (ar, arvif->vdev_id, sta->addr);if (ret) ath10k_warn(ar, "failed to delete peer %pM for vdev %d: %i\n",
Greg Kroah-Hartman
maintainerPATCH 63/109 cpufreq: Fix governor module removal race
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: "Rafael J. Wysocki" <[email protected]>
[ Upstream commit a8b149d32b663c1a4105273295184b78f53d33cf ]
It is possible to remove a cpufreq governor module after cpufreq_parse_governor() has returned success in store_scaling_governor() and before cpufreq_set_policy() acquires a reference to it, because the governor list is not protected during that period and nothing prevents the governor from being unregistered then.
Prevent that from happening by acquiring an extra reference to the governor module temporarily in cpufreq_parse_governor(), under cpufreq_governor_mutex, and dropping it in store_scaling_governor(), when cpufreq_set_policy() returns.
Note that the second cpufreq_parse_governor() call site is fine, because it only cares about the policy member of new_policy.
--- drivers/cpufreq/cpufreq.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/cpufreq/cpufreq.c +6 -0
@@ -631,6 +631,8 @@ static int cpufreq_parse_governor(char * *governor = t; err =0 ; } +if (t && !try_module_get (t->owner)) + t =NULL ;mutex_unlock (&cpufreq_governor_mutex); }
@@ -759,6 +761,10 @@ static ssize_t store_scaling_governor(streturn -EINVAL ; ret =cpufreq_set_policy (policy, &new_policy); + +if (new_policy.governor) +module_put (new_policy.governor->owner); +return ret ? ret : count; }
Greg Kroah-Hartman
maintainerPATCH 64/109 dmaengine: bcm2835-dma: Use vchan_terminate_vdesc() instead of desc_free
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Peter Ujfalusi <[email protected]>
[ Upstream commit de92436ac40ffe9933230aa503e24dbb5ede9201 ]
To avoid race with vchan_complete, use the race free way to terminate running transfer.
Implement the device_synchronize callback to make sure that the terminated descriptor is freed.
--- drivers/dma/bcm2835-dma.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/dma/bcm2835-dma.c +9 -1
@@ -812,7 +812,7 @@ static int bcm2835_dma_terminate_all(str* c->desc is NULL and exit.) */ if (c->desc) { -bcm2835_dma_desc_free (&c->desc->vd); +vchan_terminate_vdesc (&c->desc->vd); c->desc =NULL ;bcm2835_dma_abort (c->chan_base);
@@ -836,6 +836,13 @@ static int bcm2835_dma_terminate_all(strreturn 0 ; } +static void bcm2835_dma_synchronize (struct dma_chan *chan) +{ +struct bcm2835_chan *c =to_bcm2835_dma_chan (chan); + +vchan_synchronize (&c->vc); +} +static int bcm2835_dma_chan_init (struct bcm2835_dmadev *d,int chan_id,int irq,unsigned int irq_flags) {
@@ -942,6 +949,7 @@ static int bcm2835_dma_probe(struct plat od->ddev.device_prep_dma_memcpy = bcm2835_dma_prep_dma_memcpy; od->ddev.device_config = bcm2835_dma_slave_config; od->ddev.device_terminate_all = bcm2835_dma_terminate_all; + od->ddev.device_synchronize = bcm2835_dma_synchronize; od->ddev.src_addr_widths =BIT (DMA_SLAVE_BUSWIDTH_4_BYTES ); od->ddev.dst_addr_widths =BIT (DMA_SLAVE_BUSWIDTH_4_BYTES ); od->ddev.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV) |
Re: [PATCH 4.14 064/109] dmaengine: bcm2835-dma: Use vchan_terminate_vdesc() instead of desc_free
Quoted 12 lines · Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Peter Ujfalusi <[email protected]>
[ Upstream commit
de92436ac40ffe9933230aa503e24dbb5ede9201]To avoid race with
vchan_complete, use the race free way to terminate running transfer.
Quoted 8 lines
Implement the
device_synchronizecallback to make sure that the terminated descriptor is freed.Signed-off-by Peter Ujfalusi <[email protected]>Acked-by Eric Anholt <[email protected]>Signed-off-by Vinod Koul <[email protected]>Signed-off-by Sasha Levin <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
This patch is causing a build error on arm and arm64 per i.e.
https://kernelci.org/build/id/5aac017e59b5141cb1b3a4d5/
Builds are also failing for arm/arm64 on 4.15 and this patch seems to be a problem there as well, but I have not verified it yet.
#
# make -j10 -k -s ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- O=build-arm64 defconfig # # # make -j10 -k -s ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- O=build-arm64 # arch/arm64/Makefile:48: Detected assembler with broken .inst; disassembly will be unreliable ../drivers/dma/bcm2835-dma.c: In function 'bcm2835_dma_terminate_all': ../drivers/dma/bcm2835-dma.c:815:3: error: implicit declaration of function 'vchan_terminate_vdesc' [-Werror=implicit-function-declaration] vchan_terminate_vdesc(&c->desc->vd); ^ cc1: some warnings being treated as errors ../scripts/Makefile.build:334: recipe for target 'drivers/dma/bcm2835-dma.o' failed make[3]: *** [drivers/dma/bcm2835-dma.o] Error 1 make[3]: Target '__build' not remade because of errors. ../scripts/Makefile.build:587: recipe for target 'drivers/dma' failed make[2]: *** [drivers/dma] Error 2 make[2]: Target '__build' not remade because of errors. /home/buildslave/workspace/kernel-single-defconfig-builder/defconfig/defconfig/label/builder/Makefile:1031: recipe for target 'drivers' failed make[1]: *** [drivers] Error 2 make[1]: Target '_all' not remade because of errors. Makefile:146: recipe for target 'sub-make' failed make: *** [sub-make] Error 2 make: Target '_all' not remade because of errors.
Quoted 39 lines
--- drivers/dma/bcm2835-dma.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)drivers/dma/bcm2835-dma.c +9
-1@@ -812,7 +812,7 @@ static int bcm2835_dma_terminate_all(str* c->desc is NULL and exit.) */ if (c->desc) { -bcm2835_dma_desc_free (&c->desc->vd); +vchan_terminate_vdesc (&c->desc->vd); c->desc =NULL ;bcm2835_dma_abort (c->chan_base);@@ -836,6 +836,13 @@ static int bcm2835_dma_terminate_all(strreturn 0 ; } +static void bcm2835_dma_synchronize (struct dma_chan *chan) +{ +struct bcm2835_chan *c =to_bcm2835_dma_chan (chan); + +vchan_synchronize (&c->vc); +} +static int bcm2835_dma_chan_init (struct bcm2835_dmadev *d,int chan_id,int irq,unsigned int irq_flags) {@@ -942,6 +949,7 @@ static int bcm2835_dma_probe(struct plat od->ddev.device_prep_dma_memcpy = bcm2835_dma_prep_dma_memcpy; od->ddev.device_config = bcm2835_dma_slave_config; od->ddev.device_terminate_all = bcm2835_dma_terminate_all; + od->ddev.device_synchronize = bcm2835_dma_synchronize; od->ddev.src_addr_widths =BIT (DMA_SLAVE_BUSWIDTH_4_BYTES ); od->ddev.dst_addr_widths =BIT (DMA_SLAVE_BUSWIDTH_4_BYTES ); od->ddev.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV) |
Re: [PATCH 4.14 064/109] dmaengine: bcm2835-dma: Use vchan_terminate_vdesc() instead of desc_free
Quoted 22 lines · Dan Rue
Quoted 12 lines · Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Peter Ujfalusi <[email protected]>
[ Upstream commit
de92436ac40ffe9933230aa503e24dbb5ede9201]To avoid race with
vchan_complete, use the race free way to terminate running transfer.Quoted 8 lines
Implement the
device_synchronizecallback to make sure that the terminated descriptor is freed.Signed-off-by Peter Ujfalusi <[email protected]>Acked-by Eric Anholt <[email protected]>Signed-off-by Vinod Koul <[email protected]>Signed-off-by Sasha Levin <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
Quoted 5 lines
This patch is causing a build error on arm and arm64 per i.e.
https://kernelci.org/build/id/5aac017e59b5141cb1b3a4d5/Builds are also failing for arm/arm64 on 4.15 and this patch seems to be a problem there as well, but I have not verified it yet.
I think we are missing commit 1c7f072d94e8. Pls cherrypick that as well
commit 1c7f072d94e8b697fd9b70cdb268622a18faf522
Author: Peter Ujfalusi <[email protected]> Date: Tue Nov 14 16:32:04 2017 +0200
dmaengine: virt-dma: Support for race free transfer termination
This adds vchan_terminate_vdesc API..
Quoted 65 lines
#
# make -j10 -k -s ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- O=build-arm64 defconfig # # # make -j10 -k -s ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- O=build-arm64 # arch/arm64/Makefile:48: Detected assembler with broken .inst; disassembly will be unreliable ../drivers/dma/bcm2835-dma.c: In function 'bcm2835_dma_terminate_all': ../drivers/dma/bcm2835-dma.c:815:3: error: implicit declaration of function 'vchan_terminate_vdesc' [-Werror=implicit-function-declaration] vchan_terminate_vdesc(&c->desc->vd); ^ cc1: some warnings being treated as errors ../scripts/Makefile.build:334: recipe for target 'drivers/dma/bcm2835-dma.o' failed make[3]: *** [drivers/dma/bcm2835-dma.o] Error 1 make[3]: Target '__build' not remade because of errors. ../scripts/Makefile.build:587: recipe for target 'drivers/dma' failed make[2]: *** [drivers/dma] Error 2 make[2]: Target '__build' not remade because of errors. /home/buildslave/workspace/kernel-single-defconfig-builder/defconfig/defconfig/label/builder/Makefile:1031: recipe for target 'drivers' failed make[1]: *** [drivers] Error 2 make[1]: Target '_all' not remade because of errors. Makefile:146: recipe for target 'sub-make' failed make: *** [sub-make] Error 2 make: Target '_all' not remade because of errors.Quoted 39 lines
--- drivers/dma/bcm2835-dma.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)drivers/dma/bcm2835-dma.c +9
-1@@ -812,7 +812,7 @@ static int bcm2835_dma_terminate_all(str* c->desc is NULL and exit.) */ if (c->desc) { -bcm2835_dma_desc_free (&c->desc->vd); +vchan_terminate_vdesc (&c->desc->vd); c->desc =NULL ;bcm2835_dma_abort (c->chan_base);@@ -836,6 +836,13 @@ static int bcm2835_dma_terminate_all(strreturn 0 ; } +static void bcm2835_dma_synchronize (struct dma_chan *chan) +{ +struct bcm2835_chan *c =to_bcm2835_dma_chan (chan); + +vchan_synchronize (&c->vc); +} +static int bcm2835_dma_chan_init (struct bcm2835_dmadev *d,int chan_id,int irq,unsigned int irq_flags) {@@ -942,6 +949,7 @@ static int bcm2835_dma_probe(struct plat od->ddev.device_prep_dma_memcpy = bcm2835_dma_prep_dma_memcpy; od->ddev.device_config = bcm2835_dma_slave_config; od->ddev.device_terminate_all = bcm2835_dma_terminate_all; + od->ddev.device_synchronize = bcm2835_dma_synchronize; od->ddev.src_addr_widths =BIT (DMA_SLAVE_BUSWIDTH_4_BYTES ); od->ddev.dst_addr_widths =BIT (DMA_SLAVE_BUSWIDTH_4_BYTES ); od->ddev.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV) |
Signature · 1 line
~Vinod
Greg Kroah-Hartman
maintainerRe: [PATCH 4.14 064/109] dmaengine: bcm2835-dma: Use vchan_terminate_vdesc() instead of desc_free
Quoted 31 lines · Vinod Koul
Quoted 22 lines · Dan Rue
Quoted 12 lines · Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Peter Ujfalusi <[email protected]>
[ Upstream commit
de92436ac40ffe9933230aa503e24dbb5ede9201]To avoid race with
vchan_complete, use the race free way to terminate running transfer.Quoted 8 lines
Implement the
device_synchronizecallback to make sure that the terminated descriptor is freed.Signed-off-by Peter Ujfalusi <[email protected]>Acked-by Eric Anholt <[email protected]>Signed-off-by Vinod Koul <[email protected]>Signed-off-by Sasha Levin <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>Quoted 5 lines
This patch is causing a build error on arm and arm64 per i.e.
https://kernelci.org/build/id/5aac017e59b5141cb1b3a4d5/Builds are also failing for arm/arm64 on 4.15 and this patch seems to be a problem there as well, but I have not verified it yet.
I think we are missing commit
1c7f072d94e8. Pls cherrypick that as well
Quoted 7 lines
commit
1c7f072d94e8b697fd9b70cdb268622a18faf522Author: Peter Ujfalusi <[email protected]> Date: Tue Nov 14 16:32:04 2017 +0200dmaengine: virt-dma: Support for race free transfer termination
This adds
vchan_terminate_vdescAPI..
Thanks, that helped. I've now added this and send out a -rc2 for this kernel.
greg k-h
Greg Kroah-Hartman
maintainerRe: [PATCH 4.14 064/109] dmaengine: bcm2835-dma: Use vchan_terminate_vdesc() instead of desc_free
Quoted 36 lines · Greg Kroah-Hartman
Quoted 35 lines · Vinod Koul
Quoted 22 lines · Dan Rue
Quoted 12 lines · Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Peter Ujfalusi <[email protected]>
[ Upstream commit
de92436ac40ffe9933230aa503e24dbb5ede9201]To avoid race with
vchan_complete, use the race free way to terminate running transfer.Quoted 8 lines
Implement the
device_synchronizecallback to make sure that the terminated descriptor is freed.Signed-off-by Peter Ujfalusi <[email protected]>Acked-by Eric Anholt <[email protected]>Signed-off-by Vinod Koul <[email protected]>Signed-off-by Sasha Levin <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>Quoted 5 lines
This patch is causing a build error on arm and arm64 per i.e.
https://kernelci.org/build/id/5aac017e59b5141cb1b3a4d5/Builds are also failing for arm/arm64 on 4.15 and this patch seems to be a problem there as well, but I have not verified it yet.
I think we are missing commit
1c7f072d94e8. Pls cherrypick that as wellcommit
1c7f072d94e8b697fd9b70cdb268622a18faf522Author: Peter Ujfalusi <[email protected]> Date: Tue Nov 14 16:32:04 2017 +0200
Quoted 6 lines
Quoted 3 lines
dmaengine: virt-dma: Support for race free transfer termination
This adds
vchan_terminate_vdescAPI..Thanks, that helped. I've now added this and send out a -rc2 for this kernel.
Oops, no, that broke the build for all arches :(
Let me just go drop this patch, and the two dmaengine patches that relied on this one. If you think these should be applied to the stable trees, can you send me a series of working patches?
thanks,
greg k-h
Re: [PATCH 4.14 064/109] dmaengine: bcm2835-dma: Use vchan_terminate_vdesc() instead of desc_free
Quoted 17 lines · Greg Kroah-Hartman
Quoted 16 lines · Greg Kroah-Hartman
Quoted 15 lines
Quoted 5 lines
This patch is causing a build error on arm and arm64 per i.e.
https://kernelci.org/build/id/5aac017e59b5141cb1b3a4d5/Builds are also failing for arm/arm64 on 4.15 and this patch seems to be a problem there as well, but I have not verified it yet.
I think we are missing commit
1c7f072d94e8. Pls cherrypick that as wellcommit
1c7f072d94e8b697fd9b70cdb268622a18faf522Author: Peter Ujfalusi <[email protected]> Date: Tue Nov 14 16:32:04 2017 +0200dmaengine: virt-dma: Support for race free transfer termination
This adds
vchan_terminate_vdescAPI..
Quoted 8 lines
Quoted 2 lines
Thanks, that helped. I've now added this and send out a -rc2 for this kernel.
Oops, no, that broke the build for all arches :(
Let me just go drop this patch, and the two dmaengine patches that relied on this one. If you think these should be applied to the stable trees, can you send me a series of working patches?
Okay let me grab your tree and cherry-pick all that is required and send you. Stay tuned...
Thanks
Signature · 1 line
~Vinod
Re: [PATCH 4.14 064/109] dmaengine: bcm2835-dma: Use vchan_terminate_vdesc() instead of desc_free
Quoted 21 lines · Vinod Koul
Quoted 20 lines · Greg Kroah-Hartman
Quoted 18 lines · Greg Kroah-Hartman
Quoted 8 lines
Quoted 5 lines
This patch is causing a build error on arm and arm64 per i.e.
https://kernelci.org/build/id/5aac017e59b5141cb1b3a4d5/Builds are also failing for arm/arm64 on 4.15 and this patch seems to be a problem there as well, but I have not verified it yet.
I think we are missing commit
1c7f072d94e8. Pls cherrypick that as wellQuoted 7 lines
commit
1c7f072d94e8b697fd9b70cdb268622a18faf522Author: Peter Ujfalusi <[email protected]> Date: Tue Nov 14 16:32:04 2017 +0200dmaengine: virt-dma: Support for race free transfer termination
This adds
vchan_terminate_vdescAPI..Thanks, that helped. I've now added this and send out a -rc2 for this kernel.
Quoted 8 lines
Quoted 5 lines
Oops, no, that broke the build for all arches :(
Let me just go drop this patch, and the two dmaengine patches that relied on this one. If you think these should be applied to the stable trees, can you send me a series of working patches?
Okay let me grab your tree and cherry-pick all that is required and send you. Stay tuned...
I think these are the patches that need to be picked for this to work/compile:
2c6929d2ea70 dmaengine: s3c24xx-dma: Use vchan_terminate_vdesc() instead of desc_free 3ee7e42f3c9b dmaengine: k3dma: Use vchan_terminate_vdesc() instead of desc_free 397c59bce6cb dmaengine: img-mdc-dma: Use vchan_terminate_vdesc() instead of desc_free 47d71bc75d07 dmaengine: amba-pl08x: Use vchan_terminate_vdesc() instead of desc_free f0dd52c85d61 dmaengine: dma-jz4780: Use vchan_terminate_vdesc() instead of desc_free de92436ac40f dmaengine: bcm2835-dma: Use vchan_terminate_vdesc() instead of desc_free 174334bcd9f8 dmaengine: edma: Use vchan_terminate_vdesc() instead of desc_free b1faf0f564ff dmaengine: omap-dma: Use vchan_terminate_vdesc() instead of desc_free 1c7f072d94e8 dmaengine: virt-dma: Support for race free transfer termination 6af149d2b142 dmaengine: virt-dma: Add helper to free/reuse a descriptor
Most probably we missed the 6af149d2b142 and that caused the build failures.
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Re: [PATCH 4.14 064/109] dmaengine: bcm2835-dma: Use vchan_terminate_vdesc() instead of desc_free
Quoted 46 lines · Peter Ujfalusi
Quoted 21 lines · Vinod Koul
Quoted 20 lines · Greg Kroah-Hartman
Quoted 18 lines · Greg Kroah-Hartman
Quoted 8 lines
Quoted 5 lines
This patch is causing a build error on arm and arm64 per i.e.
https://kernelci.org/build/id/5aac017e59b5141cb1b3a4d5/Builds are also failing for arm/arm64 on 4.15 and this patch seems to be a problem there as well, but I have not verified it yet.
I think we are missing commit
1c7f072d94e8. Pls cherrypick that as wellQuoted 7 lines
commit
1c7f072d94e8b697fd9b70cdb268622a18faf522Author: Peter Ujfalusi <[email protected]> Date: Tue Nov 14 16:32:04 2017 +0200dmaengine: virt-dma: Support for race free transfer termination
This adds
vchan_terminate_vdescAPI..Thanks, that helped. I've now added this and send out a -rc2 for this kernel.
Quoted 8 lines
Quoted 5 lines
Oops, no, that broke the build for all arches :(
Let me just go drop this patch, and the two dmaengine patches that relied on this one. If you think these should be applied to the stable trees, can you send me a series of working patches?
Okay let me grab your tree and cherry-pick all that is required and send you. Stay tuned...
I think these are the patches that need to be picked for this to work/compile:
2c6929d2ea70dmaengine: s3c24xx-dma: Usevchan_terminate_vdesc()instead ofdesc_free3ee7e42f3c9bdmaengine: k3dma: Usevchan_terminate_vdesc()instead ofdesc_free397c59bce6cbdmaengine: img-mdc-dma: Usevchan_terminate_vdesc()instead ofdesc_free47d71bc75d07dmaengine: amba-pl08x: Usevchan_terminate_vdesc()instead ofdesc_freef0dd52c85d61dmaengine: dma-jz4780: Usevchan_terminate_vdesc()instead ofdesc_freede92436ac40fdmaengine: bcm2835-dma: Usevchan_terminate_vdesc()instead ofdesc_free174334bcd9f8dmaengine: edma: Usevchan_terminate_vdesc()instead ofdesc_freeb1faf0f564ffdmaengine: omap-dma: Usevchan_terminate_vdesc()instead ofdesc_free1c7f072d94e8dmaengine: virt-dma: Support for race free transfer termination6af149d2b142dmaengine: virt-dma: Add helper to free/reuse a descriptor
Quoted 1 line
Most probably we missed the
6af149d2b142and that caused the build failures.
Yeah that looks to be the case, I have pushed out topic/dmaengine_stable after cherry-picking the old topic branch for these. My build tests passed, waiting for Fenguuang's bit to bless it and send :)
Signature · 1 line
~Vinod
Re: [PATCH 4.14 064/109] dmaengine: bcm2835-dma: Use vchan_terminate_vdesc() instead of desc_free
Quoted 11 lines · Vinod Koul
Quoted 10 lines · Peter Ujfalusi
Quoted 9 lines · Vinod Koul
Quoted 5 lines · Greg Kroah-Hartman
On Sun, Mar 18, 2018 at 11:24:17AM +0100, Greg Kroah-Hartman wrote:
Let me just go drop this patch, and the two dmaengine patches that relied on this one. If you think these should be applied to the stable trees, can you send me a series of working patches?
Okay let me grab your tree and cherry-pick all that is required and send you. Stay tuned...
As Peter pointed out we missed 6af149d2b142.
Here is the complete list of patches:
3ee7e42f3c9b dmaengine: k3dma: Use vchan_terminate_vdesc() instead of desc_free 397c59bce6cb dmaengine: img-mdc-dma: Use vchan_terminate_vdesc() instead of desc_free 47d71bc75d07 dmaengine: amba-pl08x: Use vchan_terminate_vdesc() instead of desc_free f0dd52c85d61 dmaengine: dma-jz4780: Use vchan_terminate_vdesc() instead of desc_free de92436ac40f dmaengine: bcm2835-dma: Use vchan_terminate_vdesc() instead of desc_free 174334bcd9f8 dmaengine: edma: Use vchan_terminate_vdesc() instead of desc_free b1faf0f564ff dmaengine: omap-dma: Use vchan_terminate_vdesc() instead of desc_free 1c7f072d94e8 dmaengine: virt-dma: Support for race free transfer termination 6af149d2b142 dmaengine: virt-dma: Add helper to free/reuse a descriptor
Last time we missed 6af149d2b142.
Also I have got a 4.9 break report which is also due to missing 6af149d2b142 and 1c7f072d94e8
Thanks
Signature · 1 line
~Vinod
Greg Kroah-Hartman
maintainerPATCH 65/109 dmaengine: amba-pl08x: Use vchan_terminate_vdesc() instead of desc_free
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Peter Ujfalusi <[email protected]>
[ Upstream commit 47d71bc75d072ce25c1063aa629e55e1cfb961b2 ]
To avoid race with vchan_complete, use the race free way to terminate running transfer.
Implement the device_synchronize callback to make sure that the terminated descriptor is freed.
--- drivers/dma/amba-pl08x.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)
drivers/dma/amba-pl08x.c +10 -1
@@ -2182,7 +2182,7 @@ static int pl08x_terminate_all(struct dm }/* Dequeue jobs and free LLIs */ if (plchan->at) { -pl08x_desc_free (&plchan->at->vd); +vchan_terminate_vdesc (&plchan->at->vd); plchan->at =NULL ; }/* Dequeue jobs not yet fired as well */
@@ -2193,6 +2193,13 @@ static int pl08x_terminate_all(struct dmreturn 0 ; } +static void pl08x_synchronize (struct dma_chan *chan) +{ +struct pl08x_dma_chan *plchan =to_pl08x_chan (chan); + +vchan_synchronize (&plchan->vc); +} +static int pl08x_pause (struct dma_chan *chan) {struct pl08x_dma_chan *plchan =to_pl08x_chan (chan);
@@ -2773,6 +2780,7 @@ static int pl08x_probe(struct amba_devic pl08x->memcpy.device_pause = pl08x_pause; pl08x->memcpy.device_resume = pl08x_resume; pl08x->memcpy.device_terminate_all = pl08x_terminate_all; + pl08x->memcpy.device_synchronize = pl08x_synchronize; pl08x->memcpy.src_addr_widths =PL80X_DMA_BUSWIDTHS ; pl08x->memcpy.dst_addr_widths =PL80X_DMA_BUSWIDTHS ; pl08x->memcpy.directions =BIT (DMA_MEM_TO_MEM );
@@ -2802,6 +2810,7 @@ static int pl08x_probe(struct amba_devic pl08x->slave.device_pause = pl08x_pause; pl08x->slave.device_resume = pl08x_resume; pl08x->slave.device_terminate_all = pl08x_terminate_all; + pl08x->slave.device_synchronize = pl08x_synchronize; pl08x->slave.src_addr_widths =PL80X_DMA_BUSWIDTHS ; pl08x->slave.dst_addr_widths =PL80X_DMA_BUSWIDTHS ; pl08x->slave.directions =
Greg Kroah-Hartman
maintainerPATCH 66/109 drm/amdgpu:fix random missing of FLR NOTIFY
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Monk Liu <[email protected]>
[ Upstream commit 34a4d2bf06b3ab92024b8e26d6049411369d1f1a ]
--- drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c +11 -3
@@ -276,9 +276,17 @@ static int xgpu_ai_mailbox_rcv_irq(struc/* see what event we get */ r =xgpu_ai_mailbox_rcv_msg (adev,IDH_FLR_NOTIFICATION ); -/* only handle FLR_NOTIFY now */ -if (!r) -schedule_work (&adev->virt.flr_work); +/* sometimes the interrupt is delayed to inject to VM, so under such case +* the IDH_FLR_NOTIFICATION is overwritten by VF FLR from GIM side, thus +* above recieve message could be failed, we should schedule the flr_work +* anyway +*/ +if (r) { +DRM_ERROR ("FLR_NOTIFICATION is missed\n" ); +xgpu_ai_mailbox_send_ack (adev); + } + +schedule_work (&adev->virt.flr_work); }return 0 ;
Greg Kroah-Hartman
maintainerPATCH 67/109 scsi: ses: dont ask for diagnostic pages repeatedly during probe
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Li Dongyang <[email protected]>
[ Upstream commit 9c0a50022b8ac7e863e6ec8342fa476fe5d1d75c ]
We are testing if there is a match with the ses device in a loop by calling ses_match_to_enclosure(), which will issue scsi receive diagnostics commands to the ses device for every device on the same host. On one of our boxes with 840 disks, it takes a long time to load the driver:
[root@g1b-oss06 ~]# time modprobe ses
real 40m48.247s
user 0m0.001s
sys 0m0.196s
With the patch:
[root@g1b-oss06 ~]# time modprobe ses
real 0m17.915s
user 0m0.008s
sys 0m0.053s
Note that we still need to refresh page 10 when we see a new disk to create the link.
--- drivers/scsi/ses.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)
drivers/scsi/ses.c +7 -4
@@ -615,13 +615,16 @@ static void ses_enclosure_data_process(s }static void ses_match_to_enclosure (struct enclosure_device *edev, -struct scsi_device *sdev) +struct scsi_device *sdev, +int refresh) { +struct scsi_device *edev_sdev =to_scsi_device (edev->edev.parent);struct efd efd = { .addr =0 , }; -ses_enclosure_data_process (edev,to_scsi_device (edev->edev.parent),0 ); +if (refresh) +ses_enclosure_data_process (edev, edev_sdev,0 );if (scsi_is_sas_rphy (sdev->sdev_target->dev.parent)) efd.addr =sas_get_address (sdev);
@@ -652,7 +655,7 @@ static int ses_intf_add(struct device *cstruct enclosure_device *prev =NULL ;while ((edev =enclosure_find (&sdev->host->shost_gendev, prev)) !=NULL ) { -ses_match_to_enclosure (edev, sdev); +ses_match_to_enclosure (edev, sdev,1 ); prev = edev; }return -ENODEV ;
@@ -768,7 +771,7 @@ page2_not_supported:shost_for_each_device (tmp_sdev, sdev->host) {if (tmp_sdev->lun !=0 ||scsi_device_enclosure (tmp_sdev))continue ; -ses_match_to_enclosure (edev, tmp_sdev); +ses_match_to_enclosure (edev, tmp_sdev,0 ); }return 0 ;
Greg Kroah-Hartman
maintainerPATCH 68/109 pwm: stmpe: Fix wrong register offset for hwpwm=2 case
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Axel Lin <[email protected]>
[ Upstream commit 8472b529e113e0863ea064fdee51bf73c3f86fd6 ]
Fix trivial copy/paste bug.
--- drivers/pwm/pwm-stmpe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pwm/pwm-stmpe.c +1 -1
@@ -145,7 +145,7 @@ static int stmpe_24xx_pwm_config(structbreak ;case 2 : - offset =STMPE24XX_PWMIC1 ; + offset =STMPE24XX_PWMIC2 ;break ;default :
Greg Kroah-Hartman
maintainerPATCH 69/109 drm/sun4i: Fix format mask in DE2 driver
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jernej Skrabec <[email protected]>
[ Upstream commit a2407f4bd1f3001d6b46f6d32eb1cc98a60f5a43 ]
Format mask is one bit too short. Fix it.
--- drivers/gpu/drm/sun4i/sun8i_mixer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/sun4i/sun8i_mixer.h +1 -1
@@ -80,7 +80,7 @@#define SUN8I_MIXER_CHAN_UI_LAYER_ATTR_EN BIT(0)#define SUN8I_MIXER_CHAN_UI_LAYER_ATTR_ALPHA_MODE_MASK GENMASK(2, 1) -#define SUN8I_MIXER_CHAN_UI_LAYER_ATTR_FBFMT_MASK GENMASK(11, 8) +#define SUN8I_MIXER_CHAN_UI_LAYER_ATTR_FBFMT_MASK GENMASK(12, 8)#define SUN8I_MIXER_CHAN_UI_LAYER_ATTR_ALPHA_MASK GENMASK(31, 24)#define SUN8I_MIXER_CHAN_UI_LAYER_ATTR_ALPHA_MODE_DEF (1 << 1)#define SUN8I_MIXER_CHAN_UI_LAYER_ATTR_FBFMT_ARGB8888 (0 << 8)
Greg Kroah-Hartman
maintainerPATCH 70/109 pinctrl: sh-pfc: r8a7791: Add can_clk function
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Fabrizio Castro <[email protected]>
[ Upstream commit 57eec02caee60332b8052615e7257f932ae07abc ]
This patch adds can_clk function to r8a7743/r8a7791 which is cleaner, and allows for independent configuration.
We keep the can_clk* pins definitions from within can0_groups and can1_groups for uniformity and backwards compatibility.
--- drivers/pinctrl/sh-pfc/pfc-r8a7791.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-)
drivers/pinctrl/sh-pfc/pfc-r8a7791.c +21 -1
@@ -4826,6 +4826,10 @@ static const char * const can0_groups[]"can0_data_d" ,"can0_data_e" ,"can0_data_f" , +/* +* Retained for backwards compatibility, use can_clk_groups in new +* designs. +*/ "can_clk" ,"can_clk_b" , "can_clk_c",
@@ -4837,6 +4841,21 @@ static const char * const can1_groups[]"can1_data_b" ,"can1_data_c" ,"can1_data_d" , +/* +* Retained for backwards compatibility, use can_clk_groups in new +* designs. +*/ +"can_clk" , +"can_clk_b" , +"can_clk_c" , + "can_clk_d", +}; + +/* +* can_clk_groups allows for independent configuration, use can_clk function +* in new designs. +*/ +static const char *const can_clk_groups[] = {"can_clk" ,"can_clk_b" , "can_clk_c",
@@ -5308,7 +5327,7 @@ static const char * const vin2_groups[] };static const struct { -struct sh_pfc_function common[56 ]; +struct sh_pfc_function common[57 ];struct sh_pfc_function r8a779x[2 ]; } pinmux_functions = { .common = {
@@ -5316,6 +5335,7 @@ static const struct {SH_PFC_FUNCTION (avb),SH_PFC_FUNCTION (can0),SH_PFC_FUNCTION (can1), +SH_PFC_FUNCTION (can_clk),SH_PFC_FUNCTION (du),SH_PFC_FUNCTION (du0), SH_PFC_FUNCTION(du1),
Greg Kroah-Hartman
maintainerPATCH 71/109 pinctrl: sh-pfc: r8a7795-es1: Fix MOD_SEL1 bit[25:24] to 0x3 when using STP_ISEN_1_D
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Takeshi Kihara <[email protected]>
[ Upstream commit b16cd900de7911f96af17327a081a2141a0b763f ]
This patch fixes the implementation incorrect of MOD_SEL1 bit[25:24] value when STP_ISEN_1_D pin function is selected for IPSR16 bit[27:24].
This is a correction to the incorrect implementation of MOD_SEL register pin assignment for R8A7795 SoC specification of R-Car Gen3 Hardware User's Manual Rev.0.51E.
--- drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c +1 -1
@@ -1397,7 +1397,7 @@ static const u16 pinmux_data[] = {PINMUX_IPSR_MSEL (IP16_27_24 ,AUDIO_CLKOUT_B ,SEL_ADG_1 ),PINMUX_IPSR_MSEL (IP16_27_24 ,SSI_SCK2_B ,SEL_SSI_1 ),PINMUX_IPSR_MSEL (IP16_27_24 ,TS_SDEN1_D ,SEL_TSIF1_3 ), -PINMUX_IPSR_MSEL (IP16_27_24 ,STP_ISEN_1_D ,SEL_SSP1_1_2 ), +PINMUX_IPSR_MSEL (IP16_27_24 ,STP_ISEN_1_D ,SEL_SSP1_1_3 ),PINMUX_IPSR_MSEL (IP16_27_24 ,STP_OPWM_0_E ,SEL_SSP1_0_4 ),PINMUX_IPSR_MSEL (IP16_27_24 ,RIF3_D0_B ,SEL_DRIF3_1 ), PINMUX_IPSR_MSEL(IP16_27_24, TCLK2_B, SEL_TIMER_TMU_1),
Greg Kroah-Hartman
maintainerPATCH 72/109 perf annotate: Fix unnecessary memory allocation for s390x
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Thomas Richter <[email protected]>
[ Upstream commit 36c263607d36c6a3788c09301d9f5fe35404048a ]
This patch fixes a bug introduced with commit d9f8dfa9baf9 ("perf annotate s390: Implement jump types for perf annotate").
'perf annotate' displays annotated assembler output by reading output of command objdump and parsing the disassembled lines. For each shown mnemonic this function sequence is executed:
disasm_line__new()
|
+--> disasm_line__init_ins()
|
+--> ins__find()
|
+--> arch->associate_instruction_ops()The s390x specific function assigned to function pointer associate_instruction_ops refers to function s390__associate_ins_ops().
This function checks for supported mnemonics and assigns a NULL pointer to unsupported mnemonics. However even the NULL pointer is added to the architecture dependend instruction array.
This leads to an extremely large architecture instruction array (due to array resize logic in function arch__grow_instructions()).
Depending on the objdump output being parsed the array can end up with several ten-thousand elements.
This patch checks if a mnemonic is supported and only adds supported ones into the architecture instruction array. The array does not contain elements with NULL pointers anymore.
Before the patch (With some debug printf output):
[root@s35lp76 perf]# time ./perf annotate --stdio > /tmp/xxxbb
real 8m49.679s
user 7m13.008s
sys 0m1.649s
[root@s35lp76 perf]# fgrep '__ins__find sorted:1 nr_instructions:'
/tmp/xxxbb | tail -1__ins__find sorted:1 nr_instructions:87433 ins:0x341583c0 [root@s35lp76 perf]#
The number of different s390x branch/jump/call/return instructions entered into the array is 87433.
After the patch (With some printf debug output:)
[root@s35lp76 perf]# time ./perf annotate --stdio > /tmp/xxxaa
real 1m24.553s
user 0m0.587s
sys 0m1.530s
[root@s35lp76 perf]# fgrep '__ins__find sorted:1 nr_instructions:'
/tmp/xxxaa | tail -1__ins__find sorted:1 nr_instructions:56 ins:0x3f406570 [root@s35lp76 perf]#
The number of different s390x branch/jump/call/return instructions entered into the array is 56 which is sensible.
--- tools/perf/arch/s390/annotate/instructions.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
tools/perf/arch/s390/annotate/instructions.c +2 -1
@@ -16,7 +16,8 @@ static struct ins_ops *s390__associate_iif (!strcmp (name,"br" )) ops = &ret_ops; -arch__associate_ins_ops (arch, name, ops); +if (ops) +arch__associate_ins_ops (arch, name, ops);return ops; }
Greg Kroah-Hartman
maintainerPATCH 73/109 perf annotate: Fix objdump comment parsing for Intel mov dissassembly
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Thomas Richter <[email protected]>
[ Upstream commit 35a8a148d8c1ee9e5ae18f9565a880490f816f89 ]
The command 'perf annotate' parses the output of objdump and also investigates the comments produced by objdump. For example the output of objdump produces (on x86):
23eee: 4c 8b 3d 13 01 21 00 mov 0x210113(%rip),%r15
# 234008 <stderr@@GLIBC_2.2.5+0x9a8>
and the function mov__parse() is called to investigate the complete line. Mov__parse() breaks this line into several parts and finally calls function comment__symbol() to parse the data after the comment character '#'. Comment__symbol() expects a hexadecimal address followed by a symbol in '<' and '>' brackets.
However the 2nd parameter given to function comment__symbol() always points to the comment character '#'. The address parsing always returns 0 because the character '#' is not a digit and strtoull() fails without being noticed.
Fix this by advancing the second parameter to function comment__symbol() by one byte before invocation and add an error check after strtoull() has been called.
--- tools/perf/util/annotate.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
tools/perf/util/annotate.c +5 -3
@@ -323,6 +323,8 @@ static int comment__symbol(char *raw, chreturn 0 ; *addrp =strtoull (comment, &endptr,16 ); +if (endptr == comment) +return 0 ; name =strchr (endptr,'<' );if (name ==NULL )return -1 ;
@@ -436,8 +438,8 @@ static int mov__parse(struct arch *arch,return 0 ; comment =ltrim (comment); -comment__symbol (ops->source.raw, comment, &ops->source.addr, &ops->source.name); -comment__symbol (ops->target.raw, comment, &ops->target.addr, &ops->target.name); +comment__symbol (ops->source.raw, comment +1 , &ops->source.addr, &ops->source.name); +comment__symbol (ops->target.raw, comment +1 , &ops->target.addr, &ops->target.name);return 0 ;
@@ -481,7 +483,7 @@ static int dec__parse(struct arch *archreturn 0 ; comment =ltrim (comment); -comment__symbol (ops->target.raw, comment, &ops->target.addr, &ops->target.name); +comment__symbol (ops->target.raw, comment +1 , &ops->target.addr, &ops->target.name);return 0 ; }
Greg Kroah-Hartman
maintainerPATCH 74/109 iwlwifi: mvm: avoid dumping assert log when device is stopped
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Sara Sharon <[email protected]>
[ Upstream commit 6362ab721ef5c4ecfa01f53ad4137d3d984f0c6c ]
We might erroneously get to error dumping code when the device is already stopped.
In that case the driver will detect a defective value and will try to reset the HW, assuming it is only a bus issue. The driver than proceeds with the dumping.
The result has two side effects:
1. The device won't be stopped again, since the transport status is already stopped, so the device remains powered on while it actually should be stopped.
2. The dump in that case is completely garbaged and useless.
Detect and avoid this. It will also make debugging such issues easier.
--- drivers/net/wireless/intel/iwlwifi/mvm/utils.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/net/wireless/intel/iwlwifi/mvm/utils.c +6 -0
@@ -603,6 +603,12 @@ static void iwl_mvm_dump_lmac_error_log(void iwl_mvm_dump_nic_error_log (struct iwl_mvm *mvm) { +if (!test_bit (STATUS_DEVICE_ENABLED , &mvm->trans->status)) { +IWL_ERR (mvm, +"DEVICE_ENABLED bit is not set. Aborting dump.\n" ); +return ; + } +iwl_mvm_dump_lmac_error_log (mvm, mvm->error_event_table[0 ]);if (mvm->error_event_table[1 ])
Greg Kroah-Hartman
maintainerPATCH 75/109 drm/amdgpu:fix virtual dce bug
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Monk Liu <[email protected]>
[ Upstream commit 129d65c18ecfb249aceb540c31fdaf79bd5a11ff ]
this fix the issue that access memory after freed after driver unloaded.
--- drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/dce_virtual.c +3 -1
@@ -437,6 +437,8 @@ static int dce_virtual_sw_fini(void *handrm_kms_helper_poll_fini (adev->ddev);drm_mode_config_cleanup (adev->ddev); +/* clear crtcs pointer to avoid dce irq finish routine access freed data */ +memset (adev->mode_info.crtcs,0 ,sizeof (adev->mode_info.crtcs[0 ]) *AMDGPU_MAX_CRTCS ); adev->mode_info.mode_config_initialized = false;return 0 ; }
@@ -723,7 +725,7 @@ static void dce_virtual_set_crtc_vblank_ int crtc, enum amdgpu_interrupt_state state) { -if (crtc >= adev->mode_info.num_crtc) { +if (crtc >= adev->mode_info.num_crtc || !adev->mode_info.crtcs[crtc]) {DRM_DEBUG ("invalid crtc %d\n" , crtc);return ; }
Greg Kroah-Hartman
maintainerPATCH 76/109 clk: qcom: msm8916: fix mnd_width for codec_digcodec
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Srinivas Kandagatla <[email protected]>
[ Upstream commit d8e488e8242ecf129eebc440c92d800a99ca109d ]
This patch fixes missing mnd_width for codec_digital clk, this is now set to 8 inline with datasheet.
--- drivers/clk/qcom/gcc-msm8916.c | 1 + 1 file changed, 1 insertion(+)
drivers/clk/qcom/gcc-msm8916.c +1 -0
@@ -1438,6 +1438,7 @@ static const struct freq_tbl ftbl_codec_static struct clk_rcg2 codec_digcodec_clk_src = { .cmd_rcgr =0x1c09c , + .mnd_width =8 , .hid_width =5 , .parent_map = gcc_xo_gpll1_emclk_sleep_map, .freq_tbl = ftbl_codec_clk,
Greg Kroah-Hartman
maintainerPATCH 77/109 mwifiex: cfg80211: do not change virtual interface during scan processing
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Limin Zhu <[email protected]>
[ Upstream commit c61cfe49f0f0f0d1f8b56d0b045838d597e8c3a3 ]
(1) Change virtual interface operation in cfg80211 process reset and reinitilize private data structure.
(2) Scan result event processed in main process will dereference private data structure concurrently, ocassionly crash the kernel.
The cornel case could be trigger by below steps:
(1) wpa_cli mlan0 scan
(2) ./hostapd mlan0.conf
Cfg80211 asynchronous scan procedure is not all the time operated under rtnl lock, here we add the protect to serialize the cfg80211 scan and change_virtual interface operation.
--- drivers/net/wireless/marvell/mwifiex/cfg80211.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/net/wireless/marvell/mwifiex/cfg80211.c +6 -0
@@ -1116,6 +1116,12 @@ mwifiex_cfg80211_change_virtual_intf(strstruct mwifiex_private *priv =mwifiex_netdev_get_priv (dev);enum nl80211_iftype curr_iftype = dev->ieee80211_ptr->iftype; +if (priv->scan_request) { +mwifiex_dbg (priv->adapter,ERROR , +"change virtual interface: scan in process\n" ); +return -EBUSY ; + } +switch (curr_iftype) {case NL80211_IFTYPE_ADHOC :switch (type) {
Greg Kroah-Hartman
maintainerPATCH 78/109 ath10k: fix invalid STS_CAP_OFFSET_MASK
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ben Greear <[email protected]>
[ Upstream commit 8cec57f5277ef0e354e37a0bf909dc71bc1f865b ]
The 10.4 firmware defines this as a 3-bit field, as does the mac80211 stack. The 4th bit is defined as CONF_IMPLICIT_BF at least in the firmware header I have seen. This patch fixes the ath10k wmi header to match the firmware.
--- drivers/net/wireless/ath/ath10k/wmi.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/wireless/ath/ath10k/wmi.h +2 -1
@@ -5235,7 +5235,8 @@ enum wmi_10_4_vdev_param {#define WMI_VDEV_PARAM_TXBF_MU_TX_BFER BIT(3)#define WMI_TXBF_STS_CAP_OFFSET_LSB 4 -#define WMI_TXBF_STS_CAP_OFFSET_MASK 0xf0 +#define WMI_TXBF_STS_CAP_OFFSET_MASK 0x70 +#define WMI_TXBF_CONF_IMPLICIT_BF BIT(7)#define WMI_BF_SOUND_DIM_OFFSET_LSB 8#define WMI_BF_SOUND_DIM_OFFSET_MASK 0xf00
Greg Kroah-Hartman
maintainerPATCH 79/109 tools/usbip: fixes build with musl libc toolchain
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Julien BOIBESSOT <[email protected]>
[ Upstream commit 77be4c878c72e411ad22af96b6f81dd45c26450a ]
Indeed musl doesn't define old SIGCLD signal name but only new one SIGCHLD. SIGCHLD is the new POSIX name for that signal so it doesn't change anything on other libcs.
This fixes this kind of build error:
usbipd.c: In function ‘set_signal’:
usbipd.c:459:12: error: 'SIGCLD' undeclared (first use in this function)
sigaction(SIGCLD, &act, NULL);
^~~~~~usbipd.c:459:12: note: each undeclared identifier is reported only once
for each function it appears in
Makefile:407: recipe for target 'usbipd.o' failed
make[3]: *** [usbipd.o] Error 1
--- tools/usb/usbip/src/usbipd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/usb/usbip/src/usbipd.c +1 -1
@@ -456,7 +456,7 @@ static void set_signal(void)sigaction (SIGTERM , &act,NULL );sigaction (SIGINT , &act,NULL ); act.sa_handler =SIG_IGN ; -sigaction (SIGCLD , &act,NULL ); +sigaction (SIGCHLD , &act,NULL ); }static const char *pid_file;
Greg Kroah-Hartman
maintainerPATCH 80/109 spi: sun6i: disable/unprepare clocks on remove
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Tobias Jordan <[email protected]>
[ Upstream commit 2d9bbd02c54094ceffa555143b0d68cd06504d63 ]
sun6i_spi_probe() uses sun6i_spi_runtime_resume() to prepare/enable clocks, so sun6i_spi_remove() should use sun6i_spi_runtime_suspend() to disable/unprepare them if we're not suspended.
Replacing pm_runtime_disable() by pm_runtime_force_suspend() will ensure that sun6i_spi_runtime_suspend() is called if needed.
Found by Linux Driver Verification project (linuxtesting.org).
--- drivers/spi/spi-sun6i.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-sun6i.c +1 -1
@@ -541,7 +541,7 @@ err_free_master:static int sun6i_spi_remove (struct platform_device *pdev) { -pm_runtime_disable (&pdev->dev); +pm_runtime_force_suspend (&pdev->dev);return 0 ; }
Greg Kroah-Hartman
maintainerPATCH 81/109 bnxt_en: Dont print "Link speed -1 no longer supported" messages.
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Michael Chan <[email protected]>
[ Upstream commit a8168b6cee6e9334dfebb4b9108e8d73794f6088 ]
On some dual port NICs, the 2 ports have to be configured with compatible link speeds. Under some conditions, a port's configured speed may no longer be supported. The firmware will send a message to the driver when this happens.
Improve this logic that prints out the warning by only printing it if we can determine the link speed that is no longer supported. If the speed is unknown or it is in autoneg mode, skip the warning message.
--- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/net/ethernet/broadcom/bnxt/bnxt.c +7 -3
@@ -1698,12 +1698,16 @@ static int bnxt_async_event_process(struif (BNXT_VF (bp)) goto async_event_process_exit; -if (data1 &0x20000 ) { + +/* print unsupported speed warning in forced speed mode only */ +if (!(link_info->autoneg &BNXT_AUTONEG_SPEED ) && + (data1 &0x20000 )) {u16 fw_speed = link_info->force_link_speed;u32 speed =bnxt_fw_to_ethtool_speed (fw_speed); -netdev_warn (bp->dev,"Link speed %d no longer supported\n" , - speed); +if (speed !=SPEED_UNKNOWN ) +netdev_warn (bp->dev,"Link speed %d no longer supported\n" , + speed); }set_bit (BNXT_LINK_SPEED_CHNG_SP_EVENT , &bp->sp_event);/* fall thru */
Greg Kroah-Hartman
maintainerPATCH 82/109 scsi: core: scsi_get_device_flags_keyed(): Always return device flags
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Bart Van Assche <[email protected]>
[ Upstream commit a44c9d36509c83cf64f33b93f6ab2e63822c01eb ]
Since scsi_get_device_flags_keyed() callers do not check whether or not the returned value is an error code, change that function such that it returns a flags value even if the 'key' argument is invalid. Note:
since commit 28a0bc4120d3 ("scsi: sd: Implement blacklist option for WRITE SAME w/ UNMAP") bit 31 is a valid device information flag so checking whether bit 31 is set in the return value is not sufficient to tell the difference between an error code and a flags value.
--- drivers/scsi/scsi_devinfo.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/scsi/scsi_devinfo.c +1 -6
@@ -595,17 +595,12 @@ int scsi_get_device_flags_keyed(struct s int key) {struct scsi_dev_info_list *devinfo; -int err; devinfo =scsi_dev_info_list_find (vendor, model, key);if (!IS_ERR (devinfo))return devinfo->flags; - err =PTR_ERR (devinfo); -if (err != -ENOENT ) -return err; - -/* nothing found, return nothing */ +/* key or device not found: return nothing */ if (key !=SCSI_DEVINFO_GLOBAL )return 0 ;
Greg Kroah-Hartman
maintainerPATCH 83/109 scsi: devinfo: apply to HP XP the same flags as Hitachi VSP
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Xose Vazquez Perez <[email protected]>
[ Upstream commit b369a0471503130cfc74f9f62071db97f48948c3 ]
Commit 56f3d383f37b ("scsi: scsi_devinfo: Add TRY_VPD_PAGES to HITACHI OPEN-V blacklist entry") modified some Hitachi entries:
HITACHI is always supporting VPD pages, even though it's claiming to support SCSI Revision 3 only.
The same should have been done also for HP-rebranded.
[mkp: checkpatch and tweaked commit message]
--- drivers/scsi/scsi_devinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/scsi_devinfo.c +1 -1
@@ -181,7 +181,7 @@ static struct { {"HITACHI", "6586-", "*", BLIST_SPARSELUN | BLIST_LARGELUN}, {"HITACHI", "6588-", "*", BLIST_SPARSELUN | BLIST_LARGELUN}, {"HP", "A6189A", NULL, BLIST_SPARSELUN | BLIST_LARGELUN}, /* HP VA7400 */ - {"HP", "OPEN-", "*", BLIST_REPORTLUN2}, /* HP XP Arrays */ + {"HP", "OPEN-", "*", BLIST_REPORTLUN2 | BLIST_TRY_VPD_PAGES}, /* HP XP Arrays */ {"HP", "NetRAID-4M", NULL, BLIST_FORCELUN}, {"HP", "HSV100", NULL, BLIST_REPORTLUN2 | BLIST_NOSTARTONADD}, {"HP", "C1557A", NULL, BLIST_FORCELUN},
Greg Kroah-Hartman
maintainerPATCH 84/109 scsi: dh: add new rdac devices
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Xose Vazquez Perez <[email protected]>
[ Upstream commit 4b3aec2bbbce1c35f50e7475a9fd78d24b9ea4ea ]
Add IBM 3542 and 3552, arrays: FAStT200 and FAStT500.
Add full STK OPENstorage family, arrays: 9176, D173, D178, D210, D220, D240 and D280.
Add STK BladeCtlr family, arrays: B210, B220, B240 and B280.
These changes were done in multipath-tools time ago.
--- drivers/scsi/scsi_dh.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/scsi/scsi_dh.c +4 -1
@@ -56,10 +56,13 @@ static const struct scsi_dh_blist scsi_d {"IBM", "1815", "rdac", }, {"IBM", "1818", "rdac", }, {"IBM", "3526", "rdac", }, + {"IBM", "3542", "rdac", }, + {"IBM", "3552", "rdac", }, {"SGI", "TP9", "rdac", }, {"SGI", "IS", "rdac", }, - {"STK", "OPENstorage D280", "rdac", }, + {"STK", "OPENstorage", "rdac", }, {"STK", "FLEXLINE 380", "rdac", }, + {"STK", "BladeCtlr", "rdac", }, {"SUN", "CSM", "rdac", }, {"SUN", "LCSM100", "rdac", }, {"SUN", "STK6580_6780", "rdac", },
Greg Kroah-Hartman
maintainerPATCH 85/109 media: vsp1: Prevent suspending and resuming DRM pipelines
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Kieran Bingham <[email protected]>
[ Upstream commit a17d2d6cd9985ca09a9e384f1bc71d710f7e5203 ]
When used as part of a display pipeline, the VSP is stopped and restarted explicitly by the DU from its suspend and resume handlers. There is thus no need to stop or restart pipelines in the VSP suspend and resume handlers, and doing so would cause the hardware to be left in a misconfigured state.
Ensure that the VSP suspend and resume handlers do not affect DRM-based pipelines.
--- drivers/media/platform/vsp1/vsp1_drv.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-)
drivers/media/platform/vsp1/vsp1_drv.c +14 -2
@@ -571,7 +571,13 @@ static int __maybe_unused vsp1_pm_suspen {struct vsp1_device *vsp1 =dev_get_drvdata (dev); -vsp1_pipelines_suspend (vsp1); +/* +* When used as part of a display pipeline, the VSP is stopped and +* restarted explicitly by the DU. +*/ +if (!vsp1->drm) +vsp1_pipelines_suspend (vsp1); +pm_runtime_force_suspend (vsp1->dev);return 0 ;
@@ -582,7 +588,13 @@ static int __maybe_unused vsp1_pm_resumestruct vsp1_device *vsp1 =dev_get_drvdata (dev);pm_runtime_force_resume (vsp1->dev); -vsp1_pipelines_resume (vsp1); + +/* +* When used as part of a display pipeline, the VSP is stopped and +* restarted explicitly by the DU. +*/ +if (!vsp1->drm) +vsp1_pipelines_resume (vsp1);return 0 ; }
Greg Kroah-Hartman
maintainerPATCH 86/109 dm raid: fix raid set size revalidation
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Heinz Mauelshagen <[email protected]>
[ Upstream commit 61e06e2c3ebd986050958513bfa40dceed756f8f ]
The raid set size is being revalidated unconditionally before a reshaping conversion is started. MD requires the size to only be reduced in case of a stripe removing (i.e. shrinking) reshape but not when growing because the raid array has to stay small until after the growing reshape finishes.
Fix by avoiding the size revalidation in preresume unless a shrinking reshape is requested.
--- drivers/md/dm-raid.c | 30 ++++++++++++++++++++---------- 1 file changed, 20 insertions(+), 10 deletions(-)
drivers/md/dm-raid.c +20 -10
@@ -675,15 +675,11 @@ static struct raid_type *get_raid_type_breturn NULL ; } -/* -* Conditionally change bdev capacity of @rs -* in case of a disk add/remove reshape -*/ -static void rs_set_capacity (struct raid_set *rs) +/* Adjust rdev sectors */ +static void rs_set_rdev_sectors (struct raid_set *rs) {struct mddev *mddev = &rs->md;struct md_rdev *rdev; -struct gendisk *gendisk =dm_disk (dm_table_get_md (rs->ti->table));/* * raid10 sets rdev->sector to the device size, which
@@ -692,8 +688,16 @@ static void rs_set_capacity(struct raid_rdev_for_each (rdev, mddev)if (!test_bit (Journal, &rdev->flags)) rdev->sectors = mddev->dev_sectors; +} -set_capacity (gendisk, mddev->array_sectors); +/* +* Change bdev capacity of @rs in case of a disk add/remove reshape +*/ +static void rs_set_capacity (struct raid_set *rs) +{ +struct gendisk *gendisk =dm_disk (dm_table_get_md (rs->ti->table)); + +set_capacity (gendisk, rs->md.array_sectors);revalidate_disk (gendisk); }
@@ -1674,8 +1678,11 @@ static void do_table_event(struct work_s struct raid_set *rs = container_of(ws, struct raid_set, md.event_work);smp_rmb ();/* Make sure we access most actual mddev properties */ -if (!rs_is_reshaping (rs)) +if (!rs_is_reshaping (rs)) { +if (rs_is_raid10 (rs)) +rs_set_rdev_sectors (rs);rs_set_capacity (rs); + }dm_table_event (rs->ti->table); }
@@ -3845,11 +3852,10 @@ static int raid_preresume(struct dm_targ mddev->resync_min = mddev->recovery_cp; } -rs_set_capacity (rs); -/* Check for any reshape request unless new raid set */ if (test_and_clear_bit (RT_FLAG_RESHAPE_RS , &rs->runtime_flags)) {/* Initiate a reshape. */ +rs_set_rdev_sectors (rs);mddev_lock_nointr (mddev); r =rs_start_reshape (rs);mddev_unlock (mddev);
@@ -3878,6 +3884,10 @@ static void raid_resume(struct dm_target mddev->ro =0 ; mddev->in_sync =0 ; +/* Only reduce raid set size before running a disk removing reshape. */ +if (mddev->delta_disks <0 ) +rs_set_capacity (rs); +/* * Keep the RAID set frozen if reshape/rebuild flags are set. * The RAID set is unfrozen once the next table load/resume,
Greg Kroah-Hartman
maintainerPATCH 87/109 media: cpia2: Fix a couple off by one bugs
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dan Carpenter <[email protected]>
[ Upstream commit d5ac225c7d64c9c3ef821239edc035634e594ec9 ]
The cam->buffers[] array has cam->num_frames elements so the > needs to be changed to >= to avoid going beyond the end of the array. The ->buffers[] array is allocated in cpia2_allocate_buffers() if you want to confirm.
--- drivers/media/usb/cpia2/cpia2_v4l.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/usb/cpia2/cpia2_v4l.c +2 -2
@@ -808,7 +808,7 @@ static int cpia2_querybuf(struct file *fstruct camera_data *cam =video_drvdata (file);if (buf->type !=V4L2_BUF_TYPE_VIDEO_CAPTURE || - buf->index > cam->num_frames) + buf->index >= cam->num_frames)return -EINVAL ; buf->m.offset = cam->buffers[buf->index].data - cam->frame_buffer;
@@ -859,7 +859,7 @@ static int cpia2_qbuf(struct file *file,if (buf->type !=V4L2_BUF_TYPE_VIDEO_CAPTURE || buf->memory !=V4L2_MEMORY_MMAP || - buf->index > cam->num_frames) + buf->index >= cam->num_frames)return -EINVAL ;DBG ("QBUF #%d\n" , buf->index);
Greg Kroah-Hartman
maintainerPATCH 88/109 media: davinci: vpif_capture: add NULL check on devm_kzalloc return value
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: "Gustavo A. R. Silva" <[email protected]>
[ Upstream commit 5a18c2434f8bfc8bc2fb0f8af3e44f7408d63e4f ]
Check return value from call to devm_kzalloc() in order to prevent a NULL pointer dereference.
This issue was detected with the help of Coccinelle.
--- drivers/media/platform/davinci/vpif_capture.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/media/platform/davinci/vpif_capture.c +2 -0
@@ -1545,6 +1545,8 @@ vpif_capture_get_pdata(struct platform_dsizeof (*chan->inputs) *VPIF_CAPTURE_NUM_CHANNELS , GFP_KERNEL); +if (!chan->inputs) +return NULL ; chan->input_count++; chan->inputs[i].input.type =V4L2_INPUT_TYPE_CAMERA ;
Greg Kroah-Hartman
maintainerPATCH 89/109 virtio_net: Disable interrupts if napi_complete_done rescheduled napi
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Toshiaki Makita <[email protected]>
[ Upstream commit fdaa767aefc1685f9a41e91f447c9aea94103df6 ]
Since commit 39e6c8208d7b ("net: solve a NAPI race") napi has been able to be rescheduled within napi_complete_done() even in non-busypoll case, but virtnet_poll() always enabled interrupts before complete, and when napi was rescheduled within napi_complete_done() it did not disable interrupts.
This caused more interrupts when event idx is disabled.
According to commit cbdadbbf0c79 ("virtio_net: fix race in RX VQ processing") we cannot place virtqueue_enable_cb_prepare() after NAPI_STATE_SCHED is cleared, so disable interrupts again if napi_complete_done() returned false.
Tested with vhost-user of OVS 2.7 on host, which does not have the event idx feature.
* Before patch:
$ netperf -t UDP_STREAM -H 192.168.150.253 -l 60 -- -m 1472 MIGRATED UDP STREAM TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET to 192.168.150.253 () port 0 AF_INET Socket Message Elapsed Messages Size Size Time Okay Errors Throughput bytes bytes secs # # 10^6bits/sec
212992 1472 60.00 32763206 0 6430.32 212992 60.00 23384299 4589.56
Interrupts on guest: 9872369 Packets/interrupt: 2.37
* After patch
$ netperf -t UDP_STREAM -H 192.168.150.253 -l 60 -- -m 1472 MIGRATED UDP STREAM TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET to 192.168.150.253 () port 0 AF_INET Socket Message Elapsed Messages Size Size Time Okay Errors Throughput bytes bytes secs # # 10^6bits/sec
212992 1472 60.00 32794646 0 6436.49 212992 60.00 32793501 6436.27
Interrupts on guest: 4941299 Packets/interrupt: 6.64
--- drivers/net/virtio_net.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/net/virtio_net.c +6 -3
@@ -260,9 +260,12 @@ static void virtqueue_napi_complete(struint opaque; opaque =virtqueue_enable_cb_prepare (vq); -if (napi_complete_done (napi, processed) && -unlikely (virtqueue_poll (vq, opaque))) -virtqueue_napi_schedule (napi, vq); +if (napi_complete_done (napi, processed)) { +if (unlikely (virtqueue_poll (vq, opaque))) +virtqueue_napi_schedule (napi, vq); + }else { +virtqueue_disable_cb (vq); + } }static void skb_xmit_done (struct virtqueue *vq)
Greg Kroah-Hartman
maintainerPATCH 90/109 net: sched: drop qdisc_reset from dev_graft_qdisc
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: John Fastabend <[email protected]>
[ Upstream commit 7bbde83b1860c28a1cc35516352c4e7e5172c29a ]
In qdisc_graft_qdisc a "new" qdisc is attached and the 'qdisc_destroy' operation is called on the old qdisc. The destroy operation will wait a rcu grace period and call qdisc_rcu_free(). At which point gso_cpu_skb is free'd along with all stats so no need to zero stats and gso_cpu_skb from the graft operation itself.
Further after dropping the qdisc locks we can not continue to call qdisc_reset before waiting an rcu grace period so that the qdisc is detached from all cpus. By removing the qdisc_reset() here we get the correct property of waiting an rcu grace period and letting the qdisc_destroy operation clean up the qdisc correctly.
Note, a refcnt greater than 1 would cause the destroy operation to be aborted however if this ever happened the reference to the qdisc would be lost and we would have a memory leak.
--- net/sched/sch_generic.c | 28 +++++++++++++++++++--------- 1 file changed, 19 insertions(+), 9 deletions(-)
net/sched/sch_generic.c +19 -9
@@ -743,10 +743,6 @@ struct Qdisc *dev_graft_qdisc(struct net root_lock =qdisc_lock (oqdisc);spin_lock_bh (root_lock); -/* Prune old scheduler */ -if (oqdisc &&refcount_read (&oqdisc->refcnt) <=1 ) -qdisc_reset (oqdisc); -/* ... and graft new one */ if (qdisc ==NULL ) qdisc = &noop_qdisc;
@@ -897,6 +893,16 @@ static bool some_qdisc_is_busy(struct nereturn false; } +static void dev_qdisc_reset (struct net_device *dev, +struct netdev_queue *dev_queue, +void *none) +{ +struct Qdisc *qdisc = dev_queue->qdisc_sleeping; + +if (qdisc) +qdisc_reset (qdisc); +} +/** * dev_deactivate_many - deactivate transmissions on several devices * @head: list of devices to deactivate
@@ -907,7 +913,6 @@ static bool some_qdisc_is_busy(struct nevoid dev_deactivate_many (struct list_head *head) {struct net_device *dev; -bool sync_needed = false;list_for_each_entry (dev, head, close_list) { netdev_for_each_tx_queue(dev, dev_deactivate_queue,
@@ -917,20 +922,25 @@ void dev_deactivate_many(struct list_hea &noop_qdisc);dev_watchdog_down (dev); - sync_needed |= !dev->dismantle; }/* Wait for outstanding qdisc-less dev_queue_xmit calls. * This is avoided if all devices are in dismantle phase : * Caller will call synchronize_net() for us */ -if (sync_needed) -synchronize_net (); +synchronize_net ();/* Wait for outstanding qdisc_run calls. */ -list_for_each_entry (dev, head, close_list) +list_for_each_entry (dev, head, close_list) {while (some_qdisc_is_busy (dev))yield (); +/* The new qdisc is assigned at this point so we can safely +* unwind stale skb lists and qdisc statistics +*/ +netdev_for_each_tx_queue (dev, dev_qdisc_reset,NULL ); +if (dev_ingress_queue (dev)) +dev_qdisc_reset (dev,dev_ingress_queue (dev),NULL ); + } }void dev_deactivate (struct net_device *dev)
Greg Kroah-Hartman
maintainerPATCH 91/109 veth: set peer GSO values
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Stephen Hemminger <[email protected]>
[ Upstream commit 72d24955b44a4039db54a1c252b5031969eeaac3 ]
When new veth is created, and GSO values have been configured on one device, clone those values to the peer.
For example:
# ip link add dev vm1 gso_max_size 65530 type veth peer name vm2
This should create vm1 <--> vm2 with both having GSO maximum size set to 65530.
--- drivers/net/veth.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/net/veth.c +3 -0
@@ -410,6 +410,9 @@ static int veth_newlink(struct net *src_if (ifmp && (dev->ifindex !=0 )) peer->ifindex = ifmp->ifi_index; + peer->gso_max_size = dev->gso_max_size; + peer->gso_max_segs = dev->gso_max_segs; + err =register_netdevice (peer);put_net (net); net =NULL ;
Greg Kroah-Hartman
maintainerPATCH 92/109 drm/amdkfd: Fix memory leaks in kfd topology
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Yong Zhao <[email protected]>
[ Upstream commit 5108d768408abc80e4e8d99f5b406a73cb04056b ]
Kobject created using kobject_create_and_add() can be freed using kobject_put() when there is no referenece any more. However, kobject memory allocated with kzalloc() has to set up a release callback in order to free it when the counter decreases to 0. Otherwise it causes memory leak.
--- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/gpu/drm/amd/amdkfd/kfd_topology.c +10 -0
@@ -501,11 +501,17 @@ static ssize_t sysprops_show(struct kobjreturn ret; } +static void kfd_topology_kobj_release (struct kobject *kobj) +{ +kfree (kobj); +} +static const struct sysfs_ops sysprops_ops = { .show = sysprops_show, };static struct kobj_type sysprops_type = { + .release = kfd_topology_kobj_release, .sysfs_ops = &sysprops_ops, };
@@ -541,6 +547,7 @@ static const struct sysfs_ops iolink_ops };static struct kobj_type iolink_type = { + .release = kfd_topology_kobj_release, .sysfs_ops = &iolink_ops, };
@@ -568,6 +575,7 @@ static const struct sysfs_ops mem_ops = };static struct kobj_type mem_type = { + .release = kfd_topology_kobj_release, .sysfs_ops = &mem_ops, };
@@ -607,6 +615,7 @@ static const struct sysfs_ops cache_ops };static struct kobj_type cache_type = { + .release = kfd_topology_kobj_release, .sysfs_ops = &cache_ops, };
@@ -729,6 +738,7 @@ static const struct sysfs_ops node_ops = };static struct kobj_type node_type = { + .release = kfd_topology_kobj_release, .sysfs_ops = &node_ops, };
Greg Kroah-Hartman
maintainerPATCH 93/109 powerpc/modules: Dont try to restore r2 after a sibling call
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Josh Poimboeuf <[email protected]>
[ Upstream commit b9eab08d012fa093947b230f9a87257c27fb829b ]
When attempting to load a livepatch module, I got the following error:
module_64: patch_module: Expect noop after relocate, got 3c820000
The error was triggered by the following code inunregister_netdevice_queue():
14c: 00 00 00 48 b 14c <unregister_netdevice_queue+0x14c>
14c: R_PPC64_REL24 net_set_todo
150: 00 00 82 3c addis r4,r2,0
GCC didn't insert a nop after the branch to net_set_todo() because it's a sibling call, so it never returns. The nop isn't needed after the branch in that case.
--- arch/powerpc/include/asm/code-patching.h | 1 + arch/powerpc/kernel/module_64.c | 12 +++++++++++- arch/powerpc/lib/code-patching.c | 5 +++++ 3 files changed, 17 insertions(+), 1 deletion(-)
arch/powerpc/include/asm/code-patching.h +1 -0
@@ -33,6 +33,7 @@ int patch_branch(unsigned int *addr, unsint patch_instruction (unsigned int *addr,unsigned int instr);int instr_is_relative_branch (unsigned int instr); +int instr_is_relative_link_branch (unsigned int instr);int instr_is_branch_to_addr (const unsigned int *instr,unsigned long addr);unsigned long branch_target (const unsigned int *instr); unsigned int translate_branch(const unsigned int *dest,
arch/powerpc/kernel/module_64.c +11 -1
@@ -486,7 +486,17 @@ static bool is_early_mcount_callsite(u32restore r2. */ static int restore_r2 (u32 *instruction,struct module *me) { -if (is_early_mcount_callsite (instruction -1 )) +u32 *prev_insn = instruction -1 ; + +if (is_early_mcount_callsite (prev_insn)) +return 1 ; + +/* +* Make sure the branch isn't a sibling call. Sibling calls aren't +* "link" branches and they don't return, so they don't need the r2 +* restore afterwards. +*/ +if (!instr_is_relative_link_branch (*prev_insn))return 1 ;if (*instruction !=PPC_INST_NOP ) {
arch/powerpc/lib/code-patching.c +5 -0
@@ -302,6 +302,11 @@ int instr_is_relative_branch(unsigned inreturn instr_is_branch_iform (instr) ||instr_is_branch_bform (instr); } +int instr_is_relative_link_branch (unsigned int instr) +{ +return instr_is_relative_branch (instr) && (instr &BRANCH_SET_LINK ); +} +static unsigned long branch_iform_target (const unsigned int *instr) {signed long imm;
Greg Kroah-Hartman
maintainerPATCH 94/109 powerpc/64: Dont trace irqs-off at interrupt return to soft-disabled context
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Nicholas Piggin <[email protected]>
[ Upstream commit acb1feab320e38588fccc568e3767761f494976f ]
When an interrupt is returning to a soft-disabled context (which can happen for non-maskable interrupts or synchronous interrupts), it goes through the motions of soft-disabling again, including calling TRACE_DISABLE_INTS (i.e., trace_hardirqs_off()).
This is not necessary, because we must already be soft-disabled in the interrupt context, it also may be causing crashes in the irq tracing code to re-enter as an nmi. Replace it with a warning to ensure that soft-interrupts are still disabled.
--- arch/powerpc/kernel/entry_64.S | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
arch/powerpc/kernel/entry_64.S +7 -3
@@ -939,9 +939,13 @@ END_FTR_SECTION_IFSET(CPU_FTR_HAS_PPR) beq 1f rlwinm r7,r7,0,~PACA_IRQ_HARD_DIS stb r7,PACAIRQHAPPENED(r13) -1: li r0,0 - stb r0,PACASOFTIRQEN(r13); - TRACE_DISABLE_INTS +1: +#if defined(CONFIG_TRACE_IRQFLAGS) && defined(CONFIG_BUG) + /* The interrupt should not have soft enabled. */ + lbz r7,PACASOFTIRQEN(r13) +1: tdnei r7,0 + EMIT_BUG_ENTRY 1b,__FILE__,__LINE__,BUGFLAG_WARNING +#endif b .Ldo_restore /*
Greg Kroah-Hartman
maintainerPATCH 95/109 arm64: dts: renesas: salvator-common: Add EthernetAVB PHY reset
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Geert Uytterhoeven <[email protected]>
[ Upstream commit f5bbcd533a9d1af97b8a0862a421bb8455f1bf6d ]
Describe the GPIO used to reset the Ethernet PHY for EthernetAVB. This allows the driver to reset the PHY during probe and after system resume.
This fixes Ethernet operation after resume from s2ram on Salvator-XS, where the enable pin of the regulator providing PHY power is connected to PRESETn, and PSCI powers down the SoC during system suspend.
On Salvator-X, the enable pin is always pulled high, but the driver may still need to reset the PHY if this wasn't done by the bootloader before.
Inspired by patches in the BSP for the individual Salvator-X/XS boards by Kazuya Mizuguchi.
--- arch/arm64/boot/dts/renesas/salvator-common.dtsi | 1 + 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/renesas/salvator-common.dtsi +1 -0
@@ -264,6 +264,7 @@ reg = <0>; interrupt-parent = <&gpio2>; interrupts = <11 IRQ_TYPE_LEVEL_LOW>; + reset-gpios = <&gpio2 10 GPIO_ACTIVE_LOW>; }; };
Greg Kroah-Hartman
maintainerPATCH 96/109 agp/intel: Flush all chipset writes after updating the GGTT
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Chris Wilson <[email protected]>
[ Upstream commit 8516673a996870ea0ceb337ee4f83c33c5ec3111 ]
Before accessing the GGTT we must flush the PTE writes and make them visible to the chipset, or else the indirect access may end up in the wrong page. In commit 3497971a71d8 ("agp/intel: Flush chipset writes after updating a single PTE"), we noticed corruption of the uploads for pwrite and for capturing GPU error states, but it was presumed that the explicit calls to intel_gtt_chipset_flush() were sufficient for the execbuffer path. However, we have not been flushing the chipset between the PTE writes and access via the GTT itself.
For simplicity, do the flush after any PTE update rather than try and batch the flushes on a just-in-time basis.
References: 3497971a71d8 ("agp/intel: Flush chipset writes after updating a single PTE")
--- drivers/char/agp/intel-gtt.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/char/agp/intel-gtt.c +2 -0
@@ -872,6 +872,8 @@ void intel_gtt_insert_sg_entries(struct } }wmb (); +if (intel_private.driver->chipset_flush) + intel_private.driver->chipset_flush (); }EXPORT_SYMBOL (intel_gtt_insert_sg_entries);
Greg Kroah-Hartman
maintainerPATCH 97/109 mac80211_hwsim: enforce PS_MANUAL_POLL to be set after PS_ENABLED
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Adiel Aloni <[email protected]>
[ Upstream commit e16ea4bb516bc21ea2202f2107718b29218bea59 ]
Enforce using PS_MANUAL_POLL in ps hwsim debugfs to trigger a poll, only if PS_ENABLED was set before.
This is required due to commit c9491367b759 ("mac80211: always update the PM state of a peer on MGMT / DATA frames") that enforces the ap to check only mgmt/data frames ps bit, and then update station's power save accordingly.
When sending only ps-poll (control frame) the ap will not be aware that the station entered power save.
Setting ps enable before triggering ps_poll, will send NDP with PM bit enabled first.
--- drivers/net/wireless/mac80211_hwsim.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-)
drivers/net/wireless/mac80211_hwsim.c +11 -6
@@ -727,16 +727,21 @@ static int hwsim_fops_ps_write(void *dat val != PS_MANUAL_POLL)return -EINVAL ; - old_ps = data->ps; - data->ps = val; - -local_bh_disable ();if (val ==PS_MANUAL_POLL ) { +if (data->ps !=PS_ENABLED ) +return -EINVAL ; +local_bh_disable ();ieee80211_iterate_active_interfaces_atomic ( data->hw,IEEE80211_IFACE_ITER_NORMAL , hwsim_send_ps_poll, data); - data->ps_poll_pending = true; - }else if (old_ps ==PS_DISABLED && val !=PS_DISABLED ) { +local_bh_enable (); +return 0 ; + } + old_ps = data->ps; + data->ps = val; + +local_bh_disable (); +if (old_ps ==PS_DISABLED && val !=PS_DISABLED ) {ieee80211_iterate_active_interfaces_atomic ( data->hw,IEEE80211_IFACE_ITER_NORMAL , hwsim_send_nullfunc_ps, data);
Greg Kroah-Hartman
maintainerPATCH 98/109 mac80211: remove BUG() when interface type is invalid
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Luca Coelho <[email protected]>
[ Upstream commit c7976f5272486e4ff406014c4b43e2fa3b70b052 ]
In the ieee80211_setup_sdata() we check if the interface type is valid and, if not, call BUG(). This should never happen, but if there is something wrong with the code, it will not be caught until the bug happens when an interface is being set up. Calling BUG() is too extreme for this and a WARN_ON() would be better used instead. Change that.
--- net/mac80211/iface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/mac80211/iface.c +1 -1
@@ -1493,7 +1493,7 @@ static void ieee80211_setup_sdata(structbreak ;case NL80211_IFTYPE_UNSPECIFIED :case NUM_NL80211_IFTYPES : -BUG (); +WARN_ON (1 );break ; }
Greg Kroah-Hartman
maintainerPATCH 99/109 crypto: caam/qi - use correct print specifier for size_t
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: "Horia Geantă" <[email protected]>
[ Upstream commit 9db09e3bad65393dc23b0279beb7f3754d77065c ]
Fix below warnings on ARMv7 by using %zu for printing size_t values:
drivers/crypto/caam/caamalg_qi.c: In function aead_edesc_alloc:drivers/crypto/caam/caamalg_qi.c:417:17: warning: format %lu expects argument of type long unsigned int, but argument 4 has type unsigned int [-Wformat=]
sizeof(struct qm_sg_entry))
^
drivers/crypto/caam/caamalg_qi.c:672:16: note: in expansion of macro CAAM_QI_MAX_AEAD_SG
qm_sg_ents, CAAM_QI_MAX_AEAD_SG);
^
drivers/crypto/caam/caamalg_qi.c: In function ablkcipher_edesc_alloc:
drivers/crypto/caam/caamalg_qi.c:440:17: warning: format %lu expects argument of type long unsigned int, but argument 4 has type unsigned int [-Wformat=]
sizeof(struct qm_sg_entry))
^
drivers/crypto/caam/caamalg_qi.c:909:16: note: in expansion of macro CAAM_QI_MAX_ABLKCIPHER_SG
qm_sg_ents, CAAM_QI_MAX_ABLKCIPHER_SG);
^
drivers/crypto/caam/caamalg_qi.c: In function ablkcipher_giv_edesc_alloc:
drivers/crypto/caam/caamalg_qi.c:440:17: warning: format %lu expects argument of type long unsigned int, but argument 4 has type unsigned int [-Wformat=]
sizeof(struct qm_sg_entry))
^
drivers/crypto/caam/caamalg_qi.c:1062:16: note: in expansion of macro CAAM_QI_MAX_ABLKCIPHER_SG
qm_sg_ents, CAAM_QI_MAX_ABLKCIPHER_SG);
^--- drivers/crypto/caam/caamalg_qi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/crypto/caam/caamalg_qi.c +3 -3
@@ -668,7 +668,7 @@ static struct aead_edesc *aead_edesc_all qm_sg_ents =1 + !!ivsize + mapped_src_nents + (mapped_dst_nents >1 ? mapped_dst_nents :0 );if (unlikely (qm_sg_ents >CAAM_QI_MAX_AEAD_SG )) { -dev_err (qidev,"Insufficient S/G entries: %d > %lu\n" , +dev_err (qidev,"Insufficient S/G entries: %d > %zu\n" , qm_sg_ents,CAAM_QI_MAX_AEAD_SG );caam_unmap (qidev, req->src, req->dst, src_nents, dst_nents, iv_dma, ivsize, op_type,0 ,0 );
@@ -905,7 +905,7 @@ static struct ablkcipher_edesc *ablkciph qm_sg_ents += mapped_dst_nents >1 ? mapped_dst_nents :0 ;if (unlikely (qm_sg_ents >CAAM_QI_MAX_ABLKCIPHER_SG )) { -dev_err (qidev,"Insufficient S/G entries: %d > %lu\n" , +dev_err (qidev,"Insufficient S/G entries: %d > %zu\n" , qm_sg_ents,CAAM_QI_MAX_ABLKCIPHER_SG );caam_unmap (qidev, req->src, req->dst, src_nents, dst_nents, iv_dma, ivsize, op_type,0 ,0 );
@@ -1058,7 +1058,7 @@ static struct ablkcipher_edesc *ablkciph }if (unlikely (qm_sg_ents >CAAM_QI_MAX_ABLKCIPHER_SG )) { -dev_err (qidev,"Insufficient S/G entries: %d > %lu\n" , +dev_err (qidev,"Insufficient S/G entries: %d > %zu\n" , qm_sg_ents,CAAM_QI_MAX_ABLKCIPHER_SG );caam_unmap (qidev, req->src, req->dst, src_nents, dst_nents, iv_dma, ivsize,GIVENCRYPT ,0 ,0 );
Greg Kroah-Hartman
maintainerPATCH 100/109 ASoC: nuc900: Fix a loop timeout test
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dan Carpenter <[email protected]>
[ Upstream commit 65a12b3aafed5fc59f4ce41b22b752b1729e6701 ]
We should be finishing the loop with timeout set to zero but because this is a post-op we finish with timeout == -1.
--- sound/soc/nuc900/nuc900-ac97.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/nuc900/nuc900-ac97.c +2 -2
@@ -67,7 +67,7 @@ static unsigned short nuc900_ac97_read(s/* polling the AC_R_FINISH */ while (!(AUDIO_READ (nuc900_audio->mmio +ACTL_ACCON ) &AC_R_FINISH ) - && timeout--) + && --timeout)mdelay (1 );if (!timeout) {
@@ -121,7 +121,7 @@ static void nuc900_ac97_write(struct snd/* polling the AC_W_FINISH */ while ((AUDIO_READ (nuc900_audio->mmio +ACTL_ACCON ) &AC_W_FINISH ) - && timeout--) + && --timeout)mdelay (1 );if (!timeout)
Greg Kroah-Hartman
maintainerPATCH 101/109 mmc: mmc_test: Ensure command queue is disabled for testing
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Adrian Hunter <[email protected]>
[ Upstream commit 23a185254ace8e63dc4ca36e0315aed9440ae749 ]
mmc_test disables the command queue because none of the tests use the command queue. However the Reset Test will re-enable it, so disable it in that case too.
--- drivers/mmc/core/mmc_test.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
drivers/mmc/core/mmc_test.c +9 -2
@@ -2328,10 +2328,17 @@ static int mmc_test_reset(struct mmc_tesint err; err =mmc_hw_reset (host); -if (!err) +if (!err) { +/* +* Reset will re-enable the card's command queue, but tests +* expect it to be disabled. +*/ +if (card->ext_csd.cmdq_en) +mmc_cmdq_disable (card);return RESULT_OK ; -else if (err == -EOPNOTSUPP ) + }else if (err == -EOPNOTSUPP ) {return RESULT_UNSUP_HOST ; + }return RESULT_FAIL ; }
Greg Kroah-Hartman
maintainerPATCH 102/109 Fix misannotated out-of-line _copy_to_user()
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Christophe Leroy <[email protected]>
[ Upstream commit a0e94598e6b6c0d1df6a5fa14eb7c767ca817a20 ]
Destination is a kernel pointer and source - a userland one in _copy_from_user(); _copy_to_user() is the other way round.
--- lib/usercopy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/usercopy.c +1 -1
@@ -20,7 +20,7 @@ EXPORT_SYMBOL(_copy_from_user);#endif #ifndef INLINE_COPY_TO_USER -unsigned long _copy_to_user (void *to,const void __user *from,unsigned long n) +unsigned long _copy_to_user (void __user *to,const void *from,unsigned long n) {might_fault ();if (likely (access_ok (VERIFY_WRITE , to, n))) {
Greg Kroah-Hartman
maintainerPATCH 103/109 ipvlan: add L2 check for packets arriving via virtual devices
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Mahesh Bandewar <[email protected]>
[ Upstream commit 92ff42645028fa6f9b8aa767718457b9264316b4 ]
Packets that don't have dest mac as the mac of the master device should not be entertained by the IPvlan rx-handler. This is mostly true as the packet path mostly takes care of that, except when the master device is a virtual device. As demonstrated in the following case -
ip netns add ns1
ip link add ve1 type veth peer name ve2
ip link add link ve2 name iv1 type ipvlan mode l2 ip link set dev iv1 netns ns1
ip link set ve1 up
ip link set ve2 up
ip -n ns1 link set iv1 up
ip addr add 192.168.10.1/24 dev ve1
ip -n ns1 addr 192.168.10.2/24 dev iv1 ping -c2 192.168.10.2
<Works!>
ip neigh show dev ve1
ip neigh show 192.168.10.2 lladdr <random> dev ve1 ping -c2 192.168.10.2
<Still works! Wrong!!>
This patch adds that missing check in the IPvlan rx-handler.
--- drivers/net/ipvlan/ipvlan_core.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/net/ipvlan/ipvlan_core.c +4 -0
@@ -304,6 +304,10 @@ static int ipvlan_rcv_frame(struct ipvl_if (dev_forward_skb (ipvlan->dev, skb) ==NET_RX_SUCCESS ) success = true; }else { +if (!ether_addr_equal_64bits (eth_hdr (skb)->h_dest, + ipvlan->phy_dev->dev_addr)) + skb->pkt_type =PACKET_OTHERHOST ; + ret =RX_HANDLER_ANOTHER ; success = true; }
Greg Kroah-Hartman
maintainerPATCH 104/109 rcutorture/configinit: Fix build directory error message
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: SeongJae Park <[email protected]>
[ Upstream commit 2adfa4210f8f35cdfb4e08318cc06b99752964c2 ]
The 'configinit.sh' script checks the format of optional argument for the build directory, printing an error message if the format is not valid. However, the error message uses the wrong variable, indicating an empty string even though the user entered a non-empty (but erroneous) string. This commit fixes the script to use the correct variable.
--- tools/testing/selftests/rcutorture/bin/configinit.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/rcutorture/bin/configinit.sh +1 -1
@@ -51,7 +51,7 @@ then mkdir $builddir fi else - echo Bad build directory: \"$builddir\" + echo Bad build directory: \"$buildloc\" exit 2 fi fi
Greg Kroah-Hartman
maintainerPATCH 105/109 locking/locktorture: Fix num reader/writer corner cases
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Davidlohr Bueso <[email protected]>
[ Upstream commit 2ce77d16db4240dd2e422fc0a5c26d3e2ec03446 ]
Things can explode for locktorture if the user does combinations of nwriters_stress=0 nreaders_stress=0. Fix this by not assuming we always want to torture writer threads.
--- kernel/locking/locktorture.c | 76 ++++++++++++++++++++++++------------------- 1 file changed, 44 insertions(+), 32 deletions(-)
kernel/locking/locktorture.c +44 -32
@@ -715,8 +715,7 @@ static void __torture_print_stats(char * {bool fail =0 ;int i, n_stress; -long max =0 ; -long min = statp[0 ].n_lock_acquired; +long max =0 , min = statp ? statp[0 ].n_lock_acquired :0 ;long long sum =0 ; n_stress = write ? cxt.nrealwriters_stress : cxt.nrealreaders_stress;
@@ -823,7 +822,7 @@ static void lock_torture_cleanup(void)* such, only perform the underlying torture-specific cleanups, * and avoid anything related to locktorture. */ -if (!cxt.lwsa) +if (!cxt.lwsa && !cxt.lrsa) goto end;if (writer_tasks) {
@@ -898,6 +897,13 @@ static int __init lock_torture_init(void firsterr = -EINVAL ; goto unwind; } + +if (nwriters_stress ==0 && nreaders_stress ==0 ) { +pr_alert ("lock-torture: must run at least one locking thread\n" ); + firsterr = -EINVAL ; + goto unwind; + } +if (cxt.cur_ops->init) cxt.cur_ops->init ();
@@ -921,17 +927,19 @@ static int __init lock_torture_init(void#endif /* Initialize the statistics so that each run gets its own numbers. */ +if (nwriters_stress) { + lock_is_write_held =0 ; + cxt.lwsa =kmalloc (sizeof (*cxt.lwsa) * cxt.nrealwriters_stress,GFP_KERNEL ); +if (cxt.lwsa ==NULL ) { +VERBOSE_TOROUT_STRING ("cxt.lwsa: Out of memory" ); + firsterr = -ENOMEM ; + goto unwind; + } - lock_is_write_held =0 ; - cxt.lwsa =kmalloc (sizeof (*cxt.lwsa) * cxt.nrealwriters_stress,GFP_KERNEL ); -if (cxt.lwsa ==NULL ) { -VERBOSE_TOROUT_STRING ("cxt.lwsa: Out of memory" ); - firsterr = -ENOMEM ; - goto unwind; - } -for (i =0 ; i < cxt.nrealwriters_stress; i++) { - cxt.lwsa[i].n_lock_fail =0 ; - cxt.lwsa[i].n_lock_acquired =0 ; +for (i =0 ; i < cxt.nrealwriters_stress; i++) { + cxt.lwsa[i].n_lock_fail =0 ; + cxt.lwsa[i].n_lock_acquired =0 ; + } }if (cxt.cur_ops->readlock) {
@@ -948,19 +956,21 @@ static int __init lock_torture_init(void cxt.nrealreaders_stress = cxt.nrealwriters_stress; } - lock_is_read_held =0 ; - cxt.lrsa =kmalloc (sizeof (*cxt.lrsa) * cxt.nrealreaders_stress,GFP_KERNEL ); -if (cxt.lrsa ==NULL ) { -VERBOSE_TOROUT_STRING ("cxt.lrsa: Out of memory" ); - firsterr = -ENOMEM ; -kfree (cxt.lwsa); - cxt.lwsa =NULL ; - goto unwind; - } - -for (i =0 ; i < cxt.nrealreaders_stress; i++) { - cxt.lrsa[i].n_lock_fail =0 ; - cxt.lrsa[i].n_lock_acquired =0 ; +if (nreaders_stress) { + lock_is_read_held =0 ; + cxt.lrsa =kmalloc (sizeof (*cxt.lrsa) * cxt.nrealreaders_stress,GFP_KERNEL ); +if (cxt.lrsa ==NULL ) { +VERBOSE_TOROUT_STRING ("cxt.lrsa: Out of memory" ); + firsterr = -ENOMEM ; +kfree (cxt.lwsa); + cxt.lwsa =NULL ; + goto unwind; + } + +for (i =0 ; i < cxt.nrealreaders_stress; i++) { + cxt.lrsa[i].n_lock_fail =0 ; + cxt.lrsa[i].n_lock_acquired =0 ; + } } }
@@ -990,12 +1000,14 @@ static int __init lock_torture_init(void goto unwind; } - writer_tasks =kzalloc (cxt.nrealwriters_stress *sizeof (writer_tasks[0 ]), -GFP_KERNEL ); -if (writer_tasks ==NULL ) { -VERBOSE_TOROUT_ERRSTRING ("writer_tasks: Out of memory" ); - firsterr = -ENOMEM ; - goto unwind; +if (nwriters_stress) { + writer_tasks =kzalloc (cxt.nrealwriters_stress *sizeof (writer_tasks[0 ]), +GFP_KERNEL ); +if (writer_tasks ==NULL ) { +VERBOSE_TOROUT_ERRSTRING ("writer_tasks: Out of memory" ); + firsterr = -ENOMEM ; + goto unwind; + } }if (cxt.cur_ops->readlock) {
Greg Kroah-Hartman
maintainerPATCH 106/109 ima: relax requiring a file signature for new files with zero length
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Mimi Zohar <[email protected]>
[ Upstream commit b7e27bc1d42e8e0cc58b602b529c25cd0071b336 ]
Custom policies can require file signatures based on LSM labels. These files are normally created and only afterwards labeled, requiring them to be signed.
Instead of requiring file signatures based on LSM labels, entire filesystems could require file signatures. In this case, we need the ability of writing new files without requiring file signatures.
The definition of a "new" file was originally defined as any file with a length of zero. Subsequent patches redefined a "new" file to be based on the FILE_CREATE open flag. By combining the open flag with a file size of zero, this patch relaxes the file signature requirement.
--- security/integrity/ima/ima_appraise.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
security/integrity/ima/ima_appraise.c +2 -1
@@ -223,7 +223,8 @@ int ima_appraise_measurement(enum ima_hoif (opened &FILE_CREATED ) iint->flags |=IMA_NEW_FILE ;if ((iint->flags &IMA_NEW_FILE ) && - !(iint->flags &IMA_DIGSIG_REQUIRED )) + (!(iint->flags &IMA_DIGSIG_REQUIRED ) || + (inode->i_size ==0 ))) status =INTEGRITY_PASS ; goto out; }
Greg Kroah-Hartman
maintainerPATCH 107/109 IB/mlx5: revisit -Wmaybe-uninitialized warning
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Arnd Bergmann <[email protected]>
[ Upstream commit 1b19b95169cd52fe82cd442fec0b279fe25cc838 ]
A warning that I thought I had fixed before occasionally comes back in rare randconfig builds (I found 7 instances in the last 100000 builds, originally it was much more frequent):
drivers/infiniband/hw/mlx5/mr.c: In function 'mlx5_ib_reg_user_mr':drivers/infiniband/hw/mlx5/mr.c:1229:5: error: 'order' may be used uninitialized in this function [-Werror=maybe-uninitialized]
if (order <= mr_cache_max_order(dev)) {
^drivers/infiniband/hw/mlx5/mr.c:1247:8: error: 'ncont' may be used uninitialized in this function [-Werror=maybe-uninitialized] drivers/infiniband/hw/mlx5/mr.c:1247:8: error: 'page_shift' may be used uninitialized in this function [-Werror=maybe-uninitialized] drivers/infiniband/hw/mlx5/mr.c:1260:2: error: 'npages' may be used uninitialized in this function [-Werror=maybe-uninitialized]
I've looked at all those findings again and noticed that they are all with CONFIG_INFINIBAND_USER_MEM=n, which means ib_umem_get() returns an error unconditionally and we never initialize or use those variables. This triggers a condition in gcc iff mr_umem_get() is partially but not entirely inlined, which in turn depends on the exact combination of optimization settings. This is a known problem with gcc, with no easy solution in the compiler, so this adds another workaround that should be more reliable than my previous attempt.
Returning an error from mlx5_ib_reg_user_mr() earlier means that we can completely bypass the logic that caused the warning, the compiler can now see that the variable is never accessed.
--- drivers/infiniband/hw/mlx5/mr.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/infiniband/hw/mlx5/mr.c +3 -0
@@ -1206,6 +1206,9 @@ struct ib_mr *mlx5_ib_reg_user_mr(structint err;bool use_umr = true; +if (!IS_ENABLED (CONFIG_INFINIBAND_USER_MEM )) +return ERR_PTR (-EINVAL ); +mlx5_ib_dbg (dev,"start 0x%llx, virt_addr 0x%llx, length 0x%llx, access_flags 0x%x\n" , start, virt_addr, length, access_flags);
Greg Kroah-Hartman
maintainerPATCH 108/109 dmaengine: qcom_hidma: check pending interrupts
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Sinan Kaya <[email protected]>
[ Upstream commit 38680bc6b1e3592bc9e18adc1d6e259667df27ce ]
Driver is missing the interrupts if two requests are queued up at the same time as the interrupt handler is servicing a request that was just delivered.
The ISR clears the interrupt at the end but it could be clearing the interrupt for an outstanding event. Therefore, second interrupt never arrives.
Clear the interrupt first and then check for completions.
Also, make sure that request start and interrupt clear do not overlap in time by using a spinlock.
--- drivers/dma/qcom/hidma_ll.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/dma/qcom/hidma_ll.c +6 -3
@@ -393,6 +393,8 @@ static int hidma_ll_reset(struct hidma_l*/ static void hidma_ll_int_handler_internal (struct hidma_lldev *lldev,int cause) { +unsigned long irqflags; +if (cause &HIDMA_ERR_INT_MASK ) {dev_err (lldev->dev,"error 0x%x, disabling...\n" , cause);
@@ -410,6 +412,10 @@ static void hidma_ll_int_handler_internareturn ; } +spin_lock_irqsave (&lldev->lock, irqflags); +writel_relaxed (cause, lldev->evca +HIDMA_EVCA_IRQ_CLR_REG ); +spin_unlock_irqrestore (&lldev->lock, irqflags); +/* * Fine tuned for this HW... *
@@ -421,9 +427,6 @@ static void hidma_ll_int_handler_interna* Try to consume as many EVREs as possible. */ hidma_handle_tre_completion (lldev); - -/* We consumed TREs or there are pending TREs or EVREs. */ -writel_relaxed (cause, lldev->evca +HIDMA_EVCA_IRQ_CLR_REG ); }irqreturn_t hidma_ll_inthandler (int chirq,void *arg)
Greg Kroah-Hartman
maintainerPATCH 109/109 drm/i915/glk: Disable Guc and HuC on GLK
In reply to Greg Kroah-Hartman4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Anusha Srivatsa <[email protected]>
commit 2afba81c7909ac259720c0d3e7616cf54d4a5368 upstream.
Since the firmwares are not yet released to public repo, disable them on Geminilake.
v2: Remove the firmware versions (Michal)
v3: Remove unwanted defines (Rodrigo)
Correct commit message (Michal)
--- drivers/gpu/drm/i915/intel_guc_loader.c | 9 --------- drivers/gpu/drm/i915/intel_huc.c | 11 ----------- 2 files changed, 20 deletions(-)
drivers/gpu/drm/i915/intel_guc_loader.c +0 -9
@@ -61,9 +61,6 @@#define KBL_FW_MAJOR 9#define KBL_FW_MINOR 14 -#define GLK_FW_MAJOR 10 -#define GLK_FW_MINOR 56 -#define GUC_FW_PATH (platform, major, minor) \ "i915/" __stringify(platform) "_guc_ver" __stringify(major) "_" __stringify(minor) ".bin"
@@ -76,8 +73,6 @@ MODULE_FIRMWARE(I915_BXT_GUC_UCODE);#define I915_KBL_GUC_UCODE GUC_FW_PATH(kbl, KBL_FW_MAJOR, KBL_FW_MINOR)MODULE_FIRMWARE (I915_KBL_GUC_UCODE ); -#define I915_GLK_GUC_UCODE GUC_FW_PATH(glk, GLK_FW_MAJOR, GLK_FW_MINOR) -static u32 get_gttype (struct drm_i915_private *dev_priv) {
@@ -406,10 +401,6 @@ int intel_guc_select_fw(struct intel_guc guc->fw.path =I915_KBL_GUC_UCODE ; guc->fw.major_ver_wanted =KBL_FW_MAJOR ; guc->fw.minor_ver_wanted =KBL_FW_MINOR ; - }else if (IS_GEMINILAKE (dev_priv)) { - guc->fw.path =I915_GLK_GUC_UCODE ; - guc->fw.major_ver_wanted =GLK_FW_MAJOR ; - guc->fw.minor_ver_wanted =GLK_FW_MINOR ; }else {DRM_ERROR ("No GuC firmware known for platform with GuC!\n" );return -ENOENT ;
drivers/gpu/drm/i915/intel_huc.c +0 -11
@@ -52,10 +52,6 @@#define KBL_HUC_FW_MINOR 00#define KBL_BLD_NUM 1810 -#define GLK_HUC_FW_MAJOR 02 -#define GLK_HUC_FW_MINOR 00 -#define GLK_BLD_NUM 1748 -#define HUC_FW_PATH (platform, major, minor, bld_num) \ "i915/" __stringify(platform) "_huc_ver" __stringify(major) "_" \ __stringify(minor) "_" __stringify(bld_num) ".bin"
@@ -72,9 +68,6 @@ MODULE_FIRMWARE(I915_BXT_HUC_UCODE); KBL_HUC_FW_MINOR, KBL_BLD_NUM)MODULE_FIRMWARE (I915_KBL_HUC_UCODE ); -#define I915_GLK_HUC_UCODE HUC_FW_PATH(glk, GLK_HUC_FW_MAJOR, \ - GLK_HUC_FW_MINOR, GLK_BLD_NUM) -/** * huc_ucode_xfer() - DMA's the firmware * @dev_priv: the drm_i915_private device
@@ -171,10 +164,6 @@ void intel_huc_select_fw(struct intel_hu huc->fw.path =I915_KBL_HUC_UCODE ; huc->fw.major_ver_wanted =KBL_HUC_FW_MAJOR ; huc->fw.minor_ver_wanted =KBL_HUC_FW_MINOR ; - }else if (IS_GEMINILAKE (dev_priv)) { - huc->fw.path =I915_GLK_HUC_UCODE ; - huc->fw.major_ver_wanted =GLK_HUC_FW_MAJOR ; - huc->fw.minor_ver_wanted =GLK_HUC_FW_MINOR ; }else {DRM_ERROR ("No HuC firmware known for platform with HuC!\n" );return ;
Quoted 153 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.14.28 release. There are 109 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun Mar 18 15:22:53 UTC 2018. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.28-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.14.y
and the diffstat can be found below.thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:Greg Kroah-Hartman <[email protected]>
Linux 4.14.28-rc1Anusha Srivatsa <[email protected]>
drm/i915/glk: Disable Guc and HuC on GLKSinan Kaya <[email protected]>
dmaengine:qcom_hidma: check pending interruptsArnd Bergmann <[email protected]>
IB/mlx5: revisit -Wmaybe-uninitialized warningMimi Zohar <[email protected]>
ima: relax requiring a file signature for new files with zero lengthDavidlohr Bueso <[email protected]>
locking/locktorture: Fix num reader/writer corner casesSeongJae Park <[email protected]>
rcutorture/configinit: Fix build directory error messageMahesh Bandewar <[email protected]>
ipvlan: add L2 check for packets arriving via virtual devicesChristophe Leroy <[email protected]>
Fix misannotated out-of-line_copy_to_user()Adrian Hunter <[email protected]>
mmc:mmc_test: Ensure command queue is disabled for testingDan Carpenter <[email protected]>
ASoC: nuc900: Fix a loop timeout testHoria Geantă <[email protected]>
crypto: caam/qi - use correct print specifier forsize_tLuca Coelho <[email protected]>
mac80211: removeBUG()when interface type is invalidAdiel Aloni <[email protected]>
mac80211_hwsim: enforcePS_MANUAL_POLLto be set afterPS_ENABLEDChris Wilson <[email protected]>
agp/intel: Flush all chipset writes after updating the GGTTGeert Uytterhoeven <[email protected]>
arm64: dts: renesas: salvator-common: Add EthernetAVB PHY resetNicholas Piggin <[email protected]>
powerpc/64: Don't trace irqs-off at interrupt return to soft-disabled contextJosh Poimboeuf <[email protected]>
powerpc/modules: Don't try to restore r2 after a sibling callYong Zhao <[email protected]>
drm/amdkfd: Fix memory leaks in kfd topologyStephen Hemminger <[email protected]>
veth: set peer GSO valuesJohn Fastabend <[email protected]>
net: sched: dropqdisc_resetfromdev_graft_qdiscToshiaki Makita <[email protected]>
virtio_net: Disable interrupts ifnapi_complete_donerescheduled napiGustavo A. R. Silva <[email protected]>
media: davinci:vpif_capture: add NULL check ondevm_kzallocreturn valueDan Carpenter <[email protected]>
media: cpia2: Fix a couple off by one bugsHeinz Mauelshagen <[email protected]>
dm raid: fix raid set size revalidationKieran Bingham <[email protected]>
media: vsp1: Prevent suspending and resuming DRM pipelinesXose Vazquez Perez <[email protected]>
scsi: dh: add new rdac devicesXose Vazquez Perez <[email protected]>
scsi: devinfo: apply to HP XP the same flags as Hitachi VSPBart Van Assche <[email protected]>
scsi: core:scsi_get_device_flags_keyed(): Always return device flagsMichael Chan <[email protected]>
bnxt_en: Don't print "Link speed -1 no longer supported" messages.Tobias Jordan <[email protected]>
spi: sun6i: disable/unprepare clocks on removeJulien BOIBESSOT <[email protected]>
tools/usbip: fixes build with musl libc toolchainBen Greear <[email protected]>
ath10k: fix invalidSTS_CAP_OFFSET_MASKLimin Zhu <[email protected]>
mwifiex: cfg80211: do not change virtual interface during scan processingSrinivas Kandagatla <[email protected]>
clk: qcom: msm8916: fixmnd_widthforcodec_digcodecMonk Liu <[email protected]>
drm/amdgpu:fix virtual dce bugSara Sharon <[email protected]>
iwlwifi: mvm: avoid dumping assert log when device is stoppedThomas Richter <[email protected]>
perf annotate: Fix objdump comment parsing for Intel mov dissassemblyThomas Richter <[email protected]>
perf annotate: Fix unnecessary memory allocation for s390xTakeshi Kihara <[email protected]>
pinctrl: sh-pfc: r8a7795-es1: Fix MOD_SEL1 bit[25:24] to 0x3 when using STP_ISEN_1_DFabrizio Castro <[email protected]>
pinctrl: sh-pfc: r8a7791: Addcan_clkfunctionJernej Skrabec <[email protected]>
drm/sun4i: Fix format mask in DE2 driverAxel Lin <[email protected]>
pwm: stmpe: Fix wrong register offset for hwpwm=2 caseLi Dongyang <[email protected]>
scsi: ses: don't ask for diagnostic pages repeatedly during probe
Quoted 8 lines
Monk Liu <[email protected]>
drm/amdgpu:fix random missing of FLR NOTIFYPeter Ujfalusi <[email protected]>
dmaengine: amba-pl08x: Usevchan_terminate_vdesc()instead ofdesc_freePeter Ujfalusi <[email protected]>
dmaengine: bcm2835-dma: Usevchan_terminate_vdesc()instead ofdesc_free
arm and arm64 build broken due to this patch for 4.14 and 4.15
drivers/dma/bcm2835-dma.c:815:3: error: implicit declaration of function 'vchan_terminate_vdesc' [-Werror=implicit-function-declaration]
vchan_terminate_vdesc(&c->desc->vd);
^
cc1: some warnings being treated as errors
FYI, build using GCCVERSION = "linaro-6.2"
Greg Kroah-Hartman
maintainerQuoted 7 lines · Naresh Kamboju
Quoted 2 lines · Greg Kroah-Hartman
Peter Ujfalusi <[email protected]>
dmaengine: bcm2835-dma: Usevchan_terminate_vdesc()instead ofdesc_freearm and arm64 build broken due to this patch for 4.14 and 4.15
Quoted 7 lines
drivers/dma/bcm2835-dma.c:815:3: error: implicit declaration of function 'vchan_terminate_vdesc' [-Werror=implicit-function-declaration]vchan_terminate_vdesc(&c->desc->vd); ^cc1: some warnings being treated as errors
FYI, build using GCCVERSION = "linaro-6.2"
Should now be resolved, thanks.
greg k-h
stable-rc/linux-4.14.y boot: 46 boots: 0 failed, 40 passed with 5 offline, 1 untried/unknown (v4.14.27-110-g96676597127d)
stable-rc/linux-4.14.y boot: 46 boots: 0 failed, 40 passed with 5 offline, 1 untried/unknown (v4.14.27-110-g96676597127d)
Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.14.y/kernel/v4.14.27-110-g96676597127d/
Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.14.y/kernel/v4.14.27-110-g96676597127d/
Tree: stable-rc
Branch: linux-4.14.y
Git Describe: v4.14.27-110-g96676597127d
Git Commit: 96676597127d70db4be4679b97ad4936b6337a3d
Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
Tested: 38 unique boards, 11 SoC families, 13 builds out of 185
Offline Platforms:
arm:
tegra_defconfig:
tegra124-jetson-tk1: 1 offline lab
sunxi_defconfig:
sun5i-r8-chip: 1 offline lab
exynos_defconfig:
exynos5410-odroidxu: 1 offline lab
imx_v6_v7_defconfig:
vf610-colibri-eval-v3: 1 offline lab
sama5_defconfig:
at91-sama5d4_xplained: 1 offline lab
---
For more info write to <[email protected]>
Quoted 8 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.14.28 release. There are 109 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun Mar 18 15:22:53 UTC 2018. Anything received after that time might be too late.
Build results:
total: 145 pass: 140 fail: 5 Failed builds: arm:allmodconfig arm:lpc32xx_defconfig arm:nhk8815_defconfig arm:bcm2835_defconfig arm64:allmodconfig Qemu test results: total: 141 pass: 122 fail: 19 Failed tests: arm:beagle:multi_v7_defconfig:omap3-beagle arm:beaglexm:multi_v7_defconfig:omap3-beagle-xm arm:overo:multi_v7_defconfig:omap3-overo-tobi arm:sabrelite:multi_v7_defconfig:imx6dl-sabrelite arm:vexpress-a9:multi_v7_defconfig:vexpress-v2p-ca9 arm:vexpress-a15:multi_v7_defconfig:vexpress-v2p-ca15-tc1 arm:vexpress-a15-a7:multi_v7_defconfig:vexpress-v2p-ca15_a7 arm:xilinx-zynq-a9:multi_v7_defconfig:zynq-zc702 arm:xilinx-zynq-a9:multi_v7_defconfig:zynq-zc706 arm:xilinx-zynq-a9:multi_v7_defconfig:zynq-zed arm:midway:multi_v7_defconfig:ecx-2000 arm:smdkc210:multi_v7_defconfig:exynos4210-smdkv310 arm64:virt:smp:defconfig:initrd arm64:virt:smp:defconfig:rootfs arm64:xlnx-zcu102:smp:defconfig:initrd:zynqmp-ep108 arm64:xlnx-zcu102:smp:defconfig:rootfs:zynqmp-ep108 arm64:virt:nosmp:defconfig:initrd arm64:xlnx-zcu102:nosmp:defconfig:initrd:zynqmp-ep108 arm64:xlnx-zcu102:nosmp:defconfig:rootfs:zynqmp-ep108
The failure, as already reported, is
drivers/dma/bcm2835-dma.c: In function 'bcm2835_dma_terminate_all':drivers/dma/bcm2835-dma.c:815:3: error: implicit declaration of function 'vchan_terminate_vdesc'
Further details are available at http://kerneltests.org/builders.
Guenter
Greg Kroah-Hartman
maintainerQuoted 6 lines · Guenter Roeck
Quoted 5 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.14.28 release. There are 109 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Quoted 6 lines
Quoted 3 lines
Responses should be made by Sun Mar 18 15:22:53 UTC 2018. Anything received after that time might be too late.
Build results:
total: 145 pass: 140 fail: 5
Thanks, I've pushed out a -rc2 to hopefully fix this build issue.
greg k-h
Greg Kroah-Hartman
maintainerQuoted 5 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.14.28 release. There are 109 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Quoted 8 lines
Responses should be made by Sun Mar 18 15:22:53 UTC 2018. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.28-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.14.y
and the diffstat can be found below.
-rc2 is out to fix a build problem on some configs:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.28-rc2.gz
thanks,
greg k-h
Greg Kroah-Hartman
maintainerQuoted 15 lines · Greg Kroah-Hartman
Quoted 13 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.14.28 release. There are 109 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun Mar 18 15:22:53 UTC 2018. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.28-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.14.y
and the diffstat can be found below.
Review
Quoted 2 lines
(quoted diff) +0
-1-rc2 is out to fix a build problem on some configs: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.28-rc2.gz
Ok, that sucked, let's try this again...
-rc3 is out, and this time it at least passed _my_ build tests:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.28-rc3.gz
thanks,
greg k-h
Quoted 16 lines · Greg Kroah-Hartman
Quoted 15 lines · Greg Kroah-Hartman
Quoted 13 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.14.28 release. There are 109 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun Mar 18 15:22:53 UTC 2018. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.28-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.14.y
and the diffstat can be found below.
Quoted 8 lines
Quoted 2 lines
-rc2 is out to fix a build problem on some configs:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.28-rc2.gzOk, that sucked, let's try this again...
-rc3 is out, and this time it at least passed _my_ build tests:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.28-rc3.gz
For v4.14.27-108-gde586f0:
Build results:
total: 145 pass: 145 fail: 0 Qemu test results: total: 141 pass: 141 fail: 0
Guenter
Greg Kroah-Hartman
maintainerQuoted 26 lines · Guenter Roeck
Quoted 16 lines · Greg Kroah-Hartman
Quoted 15 lines · Greg Kroah-Hartman
Quoted 13 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.14.28 release. There are 109 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun Mar 18 15:22:53 UTC 2018. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.28-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.14.y
and the diffstat can be found below.Quoted 8 lines
Quoted 2 lines
-rc2 is out to fix a build problem on some configs:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.28-rc2.gzOk, that sucked, let's try this again...
-rc3 is out, and this time it at least passed _my_ build tests:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.28-rc3.gz
Quoted 6 lines
For v4.14.27-108-gde586f0:
Build results:
total: 145 pass: 145 fail: 0 Qemu test results: total: 141 pass: 141 fail: 0
Thanks for testing both of these again and letting me know.
greg k-h
Quoted 16 lines · Greg Kroah-Hartman
Quoted 15 lines · Greg Kroah-Hartman
Quoted 13 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.14.28 release. There are 109 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun Mar 18 15:22:53 UTC 2018. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.28-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.14.y
and the diffstat can be found below.
Quoted 7 lines
Review
Quoted 2 lines
(quoted diff) +0
-1-rc2 is out to fix a build problem on some configs: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.28-rc2.gzOk, that sucked, let's try this again...
-rc3 is out, and this time it at least passed _my_ build tests:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.28-rc3.gz
As reported, arm32 build failed and so tests did not run. No regressions on arm64 or x86_64.
There are two 'regressions' listed below which are not regressions. reuseport_bpf is a test issue that's fixed in mainline kselftest, which we'll pick up when 4.16 is released. sigreturn_64 is an intermittent failure that we've been seeing on qemu only. It works fine on real hardware.
Summary
------------------------------------------------------------------------
kernel: 4.14.28-rc3
git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git branch: linux-4.14.y
git commit: de586f09b77dafe110c0689218b860aefd7e4ed6
git describe: v4.14.27-108-gde586f09b77d
Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-4.14-oe/build/v4.14.27-108-gde586f09b77d
Regressions (compared to build v4.14.27-110-g96676597127d)
------------------------------------------------------------------------
qemu_x86_64:
kselftest-vsyscall-mode-native:
* reuseport_bpf
* sigreturn_64
* test src: not informed
kselftest-vsyscall-mode-none:
* sigreturn_64
* test src: not informed
Boards, architectures and test suites:
-------------------------------------
dragonboard-410c
* boot - pass: 20
* kselftest - skip: 20, pass: 45
* libhugetlbfs - skip: 1, pass: 90
* ltp-cap_bounds-tests - pass: 2
* ltp-containers-tests - skip: 17, pass: 64
* ltp-fcntl-locktests-tests - pass: 2
* ltp-filecaps-tests - pass: 2
* ltp-fs-tests - skip: 2, pass: 61
* ltp-fs_bind-tests - pass: 2
* ltp-fs_perms_simple-tests - pass: 19
* ltp-fsx-tests - pass: 2
* ltp-hugetlb-tests - skip: 1, pass: 21
* ltp-io-tests - pass: 3
* ltp-ipc-tests - pass: 9
* ltp-math-tests - pass: 11
* ltp-nptl-tests - pass: 2
* ltp-pty-tests - pass: 4
* ltp-sched-tests - pass: 14
* ltp-securebits-tests - pass: 4
* ltp-syscalls-tests - skip: 148, pass: 1002
* ltp-timers-tests - skip: 1, pass: 12
hi6220-hikey - arm64
* boot - pass: 20
* kselftest - skip: 17, pass: 48
* libhugetlbfs - skip: 1, pass: 90
* ltp-cap_bounds-tests - pass: 2
* ltp-containers-tests - skip: 17, pass: 64
* ltp-fcntl-locktests-tests - pass: 2
* ltp-filecaps-tests - pass: 2
* ltp-fs-tests - skip: 2, pass: 61
* ltp-fs_bind-tests - pass: 2
* ltp-fs_perms_simple-tests - pass: 19
* ltp-fsx-tests - pass: 2
* ltp-hugetlb-tests - skip: 1, pass: 21
* ltp-io-tests - pass: 3
* ltp-ipc-tests - pass: 9
* ltp-math-tests - pass: 11
* ltp-nptl-tests - pass: 2
* ltp-pty-tests - pass: 4
* ltp-sched-tests - skip: 4, pass: 10
* ltp-securebits-tests - pass: 4
* ltp-syscalls-tests - skip: 151, pass: 999
* ltp-timers-tests - skip: 1, pass: 12
juno-r2 - arm64
* boot - pass: 20
* kselftest - skip: 17, pass: 48
* libhugetlbfs - skip: 1, pass: 90
* ltp-cap_bounds-tests - pass: 2
* ltp-containers-tests - skip: 17, pass: 64
* ltp-fcntl-locktests-tests - pass: 2
* ltp-filecaps-tests - pass: 2
* ltp-fs-tests - skip: 2, pass: 61
* ltp-fs_bind-tests - pass: 2
* ltp-fs_perms_simple-tests - pass: 19
* ltp-fsx-tests - pass: 2
* ltp-hugetlb-tests - pass: 22
* ltp-io-tests - pass: 3
* ltp-ipc-tests - pass: 9
* ltp-math-tests - pass: 11
* ltp-nptl-tests - pass: 2
* ltp-pty-tests - pass: 4
* ltp-sched-tests - skip: 4, pass: 10
* ltp-securebits-tests - pass: 4
* ltp-syscalls-tests - skip: 149, pass: 1001
* ltp-timers-tests - skip: 1, pass: 12
qemu_x86_64
* boot - pass: 28
* kselftest - skip: 20, pass: 62
* kselftest-vsyscall-mode-native - skip: 40, fail: 2, pass: 122
* kselftest-vsyscall-mode-none - skip: 40, fail: 1, pass: 123
* libhugetlbfs - skip: 2, pass: 180
* ltp-cap_bounds-tests - pass: 4
* ltp-containers-tests - skip: 34, pass: 128
* ltp-fcntl-locktests-tests - pass: 4
* ltp-filecaps-tests - pass: 2
* ltp-fs-tests - skip: 6, pass: 57
* ltp-fs_bind-tests - pass: 2
* ltp-fs_perms_simple-tests - pass: 19
* ltp-fsx-tests - pass: 2
* ltp-hugetlb-tests - pass: 22
* ltp-io-tests - pass: 3
* ltp-ipc-tests - pass: 9
* ltp-math-tests - pass: 11
* ltp-nptl-tests - pass: 2
* ltp-pty-tests - pass: 4
* ltp-sched-tests - skip: 1, pass: 13
* ltp-securebits-tests - pass: 4
* ltp-syscalls-tests - skip: 148, pass: 1002
* ltp-timers-tests - skip: 1, pass: 12
x86_64
* boot - pass: 22
* kselftest - skip: 19, pass: 61
* kselftest-vsyscall-mode-native - skip: 19, pass: 61
* kselftest-vsyscall-mode-none - skip: 19, fail: 1, pass: 60
* libhugetlbfs - skip: 1, pass: 89
* ltp-cap_bounds-tests - pass: 2
* ltp-containers-tests - skip: 17, pass: 64
* ltp-fcntl-locktests-tests - pass: 2
* ltp-filecaps-tests - pass: 2
* ltp-fs-tests - skip: 1, pass: 62
* ltp-fs_bind-tests - pass: 2
* ltp-fs_perms_simple-tests - pass: 19
* ltp-fsx-tests - pass: 2
* ltp-hugetlb-tests - pass: 22
* ltp-io-tests - pass: 3
* ltp-ipc-tests - pass: 9
* ltp-math-tests - pass: 11
* ltp-nptl-tests - pass: 2
* ltp-pty-tests - pass: 4
* ltp-sched-tests - skip: 5, pass: 9
* ltp-securebits-tests - pass: 4
* ltp-syscalls-tests - skip: 119, pass: 1031
* ltp-timers-tests - skip: 1, pass: 12
--
Linaro QA (beta)
https://qa-reports.linaro.org
_______________________________________________
Kernel-build-reports mailing list
[email protected]
https://lists.linaro.org/mailman/listinfo/kernel-build-reports
Quoted 7 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.14.28 release. There are 109 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun Mar 18 15:22:53 UTC 2018. Anything received after that time might be too late.
Any chance to get the k10temp change for Threadripper 1900X offset reporting included [https://patchwork.kernel.org/patch/10175457/]?
Kash Pande
Quoted 6 lines · Kash Pande
Quoted 5 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.14.28 release. There are 109 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Quoted 6 lines
Quoted 2 lines
Responses should be made by Sun Mar 18 15:22:53 UTC 2018. Anything received after that time might be too late.
Any chance to get the k10temp change for Threadripper 1900X offset reporting included [https://patchwork.kernel.org/patch/10175457/]?
Ryzen and Threadripper are only supported in v4.15+.
Guenter
Quoted 1 line · Guenter Roeck
Ryzen and Threadripper are only supported in v4.15+.
Nope, the offset for 1900X is not available in 4.15, I've had to manually patch all systems otherwise monitoring complains they idle at 53C.
Greg Kroah-Hartman
maintainerQuoted 6 lines · Kash Pande
Quoted 1 line · Guenter Roeck
Ryzen and Threadripper are only supported in v4.15+.
Nope, the offset for 1900X is not available in 4.15, I've had to manually patch all systems otherwise monitoring complains they idle at 53C.
I don't understand, what patch are you talking about here?
greg k-h
Quoted 10 lines · Greg Kroah-Hartman
Quoted 6 lines · Kash Pande
Quoted 1 line · Guenter Roeck
Ryzen and Threadripper are only supported in v4.15+.
Nope, the offset for 1900X is not available in 4.15, I've had to manually patch all systems otherwise monitoring complains they idle at 53C.
I don't understand, what patch are you talking about here?
6509614fdd2d, but you'll also want aef17ca12719 if that isn't queued already.
Guenter
Greg Kroah-Hartman
maintainerQuoted 6 lines · Guenter Roeck
Quoted 5 lines · Greg Kroah-Hartman
Quoted 4 lines · Kash Pande
Quoted 1 line · Guenter Roeck
Ryzen and Threadripper are only supported in v4.15+.
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
Nope, the offset for 1900X is not available in 4.15, I've had to manually patch all systems otherwise monitoring complains they idle at 53C.
I don't understand, what patch are you talking about here?
6509614fdd2d, but you'll also wantaef17ca12719if that isn't queued already.
Both now queued up, thanks.
greg k-h
Den 27.03.2018 kl. 09:37, skrev Guenter Roeck:
Quoted 9 lines · Greg Kroah-Hartman
Quoted 8 lines · Kash Pande
Quoted 6 lines · Guenter Roeck
Quoted 1 line
Ryzen and Threadripper are only supported in v4.15+.
Nope, the offset for 1900X is not available in 4.15, I've had to manually patch all systems otherwise monitoring complains they idle at 53C.
Quoted 7 lines
Quoted 2 lines
I don't understand, what patch are you talking about here?
6509614fdd2d, but you'll also wantaef17ca12719if that isn't queued already.Guenter
And if you ant it to work in 4.14 longterm, you want the series:
68546abf7a3a63f199e53d6dcaa7375df37a6aaa hwmon: (k10temp) Move chip specific code into probe function 9af0a9aecdb945cd5513941ffdcbcc031009b402 hwmon: (k10temp) Add support for family 17h 1b50b776355fa6c6d7b3281a63c275d5c18d629d hwmon: (k10temp) Add support for temperature offsets ab5ee24615f9dd8b0cd199403959f8b13309e7b1 hwmon: (k10temp) Correct model name for Ryzen 1600X 6509614fdd2d05c6926d50901a45d5dfb852b715 hwmon: (k10temp) Add temperature offset for Ryzen 1900X aef17ca1271948ee57cc39b2493d31110cc42625 hwmon: (k10temp) Only apply temperature offset if result is positive
We have it in Mageia, and I've confirmed it works on a Ryzen 7 1700 and ThreadRipper 1950X
--
Thomas
Greg Kroah-Hartman
maintainerQuoted 36 lines · Thomas Backlund
Den 27.03.2018 kl. 09:37, skrev Guenter Roeck:
Quoted 10 lines · Greg Kroah-Hartman
Quoted 9 lines · Kash Pande
Quoted 7 lines · Guenter Roeck
Quoted 1 line
Ryzen and Threadripper are only supported in v4.15+.
Nope, the offset for 1900X is not available in 4.15, I've had to manually patch all systems otherwise monitoring complains they idle at 53C.
Quoted 8 lines
Quoted 2 lines
I don't understand, what patch are you talking about here?
6509614fdd2d, but you'll also wantaef17ca12719if that isn't queued already.Guenter
And if you ant it to work in 4.14 longterm, you want the series:
68546abf7a3a63f199e53d6dcaa7375df37a6aaahwmon: (k10temp) Move chip specific code into probe function9af0a9aecdb945cd5513941ffdcbcc031009b402hwmon: (k10temp) Add support for family 17h1b50b776355fa6c6d7b3281a63c275d5c18d629dhwmon: (k10temp) Add support for temperature offsetsab5ee24615f9dd8b0cd199403959f8b13309e7b1hwmon: (k10temp) Correct model name for Ryzen 1600X6509614fdd2d05c6926d50901a45d5dfb852b715hwmon: (k10temp) Add temperature offset for Ryzen 1900Xaef17ca1271948ee57cc39b2493d31110cc42625hwmon: (k10temp) Only apply temperature offset if result is positive
Quoted 2 lines
We have it in Mageia, and I've confirmed it works on a Ryzen 7 1700 and ThreadRipper 1950X
I'd like an ack from the hwmon maintainer before adding all of those, as it really feels like a "backport new hardware support" type of request that is a bit bigger than a normal "add some new device ids and quirks".
thanks,
greg k-h
Quoted 37 lines · Greg Kroah-Hartman
Quoted 36 lines · Thomas Backlund
Den 27.03.2018 kl. 09:37, skrev Guenter Roeck:
Quoted 10 lines · Greg Kroah-Hartman
Quoted 9 lines · Kash Pande
Quoted 7 lines · Guenter Roeck
Quoted 1 line
Ryzen and Threadripper are only supported in v4.15+.
Nope, the offset for 1900X is not available in 4.15, I've had to manually patch all systems otherwise monitoring complains they idle at 53C.
Quoted 8 lines
Quoted 2 lines
I don't understand, what patch are you talking about here?
6509614fdd2d, but you'll also wantaef17ca12719if that isn't queued already.Guenter
And if you ant it to work in 4.14 longterm, you want the series:
68546abf7a3a63f199e53d6dcaa7375df37a6aaahwmon: (k10temp) Move chip specific code into probe function9af0a9aecdb945cd5513941ffdcbcc031009b402hwmon: (k10temp) Add support for family 17h1b50b776355fa6c6d7b3281a63c275d5c18d629dhwmon: (k10temp) Add support for temperature offsetsab5ee24615f9dd8b0cd199403959f8b13309e7b1hwmon: (k10temp) Correct model name for Ryzen 1600X6509614fdd2d05c6926d50901a45d5dfb852b715hwmon: (k10temp) Add temperature offset for Ryzen 1900Xaef17ca1271948ee57cc39b2493d31110cc42625hwmon: (k10temp) Only apply temperature offset if result is positive
Quoted 7 lines
Quoted 2 lines
We have it in Mageia, and I've confirmed it works on a Ryzen 7 1700 and ThreadRipper 1950X
I'd like an ack from the hwmon maintainer before adding all of those, as it really feels like a "backport new hardware support" type of request that is a bit bigger than a normal "add some new device ids and quirks".
That is why I did not request it. It is ok with me if you are willing to accept it, though.
Guenter