Skip to contentSkip to conversation

GPU: drm: Fixed Spacing issue

PATCH In review Paul McQuade 2 participants 5 messages Mar 19, 2018

Subsystems (2)
DRM drivers DRM misc
lore
Share & tools
lore

Paul McQuade

author
#0 lore raw

PATCH 1/4 GPU: drm: Fixed Spacing issue

"foo * bar" should be "foo *bar"

Signed-off-by Paul McQuade <[email protected]>
---
 drivers/gpu/drm/drm_bufs.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/drm_bufs.c +4 -4
index 1ee84dd802d4..83b3d0801262 100644
@@ -129,7 +129,7 @@ static int drm_map_handle(struct drm_device *dev, struct drm_hash_item *hash,
  * type.  Adds the map to the map list drm_device::maplist. Adds MTRR's where
  * applicable and if supported by the kernel.
  */
-static int drm_addmap_core(struct drm_device * dev, resource_size_t offset,
+static int drm_addmap_core(struct drm_device *dev, resource_size_t offset,
 			   unsigned int size, enum drm_map_type type,
 			   enum drm_map_flags flags,
 			   struct drm_map_list ** maplist)

@@ -361,7 +361,7 @@ static int drm_addmap_core(struct drm_device * dev, resource_size_t offset,
 	return 0;
 }
 
-int drm_legacy_addmap(struct drm_device * dev, resource_size_t offset,
+int drm_legacy_addmap(struct drm_device *dev, resource_size_t offset,
 		      unsigned int size, enum drm_map_type type,
 		      enum drm_map_flags flags, struct drm_local_map **map_ptr)
 {

@@ -637,8 +637,8 @@ int drm_legacy_rmmap_ioctl(struct drm_device *dev, void *data,
  *
  * Frees any pages and buffers associated with the given entry.
  */
-static void drm_cleanup_buf_error(struct drm_device * dev,
-				  struct drm_buf_entry * entry)
+static void drm_cleanup_buf_error(struct drm_device *dev,
+				  struct drm_buf_entry *entry)
 {
 	int i;
Signature · 1 line
2.16.2
author
#1 lore raw

PATCH 2/4 GPU: drm: Fixed Spacing issue

"foo ** bar" should be "foo **bar"

Signed-off-by Paul McQuade <[email protected]>
---
 drivers/gpu/drm/drm_bufs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/drm_bufs.c +1 -1
index 83b3d0801262..9af9efd84ee7 100644
@@ -132,7 +132,7 @@ static int drm_map_handle(struct drm_device *dev, struct drm_hash_item *hash,
 static int drm_addmap_core(struct drm_device *dev, resource_size_t offset,
 			   unsigned int size, enum drm_map_type type,
 			   enum drm_map_flags flags,
-			   struct drm_map_list ** maplist)
+			   struct drm_map_list **maplist)
 {
 	struct drm_local_map *map;
 	struct drm_map_list *list;
Signature · 1 line
2.16.2
author
#2 lore raw

PATCH 3/4 GPU: drm: Fixed Spacing issue

In reply to Paul McQuade

space prohibited after that open parenthesis '('

Signed-off-by Paul McQuade <[email protected]>
---
 drivers/gpu/drm/drm_bufs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/drm_bufs.c +1 -1
index 9af9efd84ee7..8e345ba16858 100644
@@ -224,7 +224,7 @@ static int drm_addmap_core(struct drm_device *dev, resource_size_t offset,
 	case _DRM_SHM:
 		list = drm_find_matching_map(dev, map);
 		if (list != NULL) {
-			if(list->map->size != map->size) {
+			if (list->map->size != map->size) {
 				DRM_DEBUG("Matching maps of type %d with "
 					  "mismatched sizes, (%ld vs %ld)\n",
 					  map->type, map->size, list->map->size);
Signature · 1 line
2.16.2
author
#3 lore raw

PATCH 4/4 GPU: drm: Fixed Coding issue

In reply to Paul McQuade

code indent should use tabs where possible

Signed-off-by Paul McQuade <[email protected]>
---
 drivers/gpu/drm/drm_bufs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_bufs.c +2 -2
index 8e345ba16858..ba8cfe65c65b 100644
@@ -1446,8 +1446,8 @@ int drm_legacy_freebufs(struct drm_device *dev, void *data,
 int __drm_legacy_mapbufs(struct drm_device *dev, void *data, int *p,
 			 void __user **v,
 			 int (*f)(void *, int, unsigned long,
-				  struct drm_buf *),
-		         struct drm_file *file_priv)
+				 struct drm_buf *),
+				 struct drm_file *file_priv)
 {
 	struct drm_device_dma *dma = dev->dma;
 	int retcode = 0;
Signature · 1 line
2.16.2
#4 lore raw
In reply to Paul McQuade
Quoted 3 lines · Paul McQuade

"foo * bar" should be "foo *bar"

Signed-off-by Paul McQuade <[email protected]>

Thank you for your patches. I've squashed them all into one, fixed up the commit message and applied them to drm-misc-next.

Sean

Quoted 40 lines
---
 drivers/gpu/drm/drm_bufs.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/drm_bufs.c +4 -4
index 1ee84dd802d4..83b3d0801262 100644
@@ -129,7 +129,7 @@ static int drm_map_handle(struct drm_device *dev, struct drm_hash_item *hash,
  * type.  Adds the map to the map list drm_device::maplist. Adds MTRR's where
  * applicable and if supported by the kernel.
  */
-static int drm_addmap_core(struct drm_device * dev, resource_size_t offset,
+static int drm_addmap_core(struct drm_device *dev, resource_size_t offset,
 			   unsigned int size, enum drm_map_type type,
 			   enum drm_map_flags flags,
 			   struct drm_map_list ** maplist)

@@ -361,7 +361,7 @@ static int drm_addmap_core(struct drm_device * dev, resource_size_t offset,
 	return 0;
 }
 
-int drm_legacy_addmap(struct drm_device * dev, resource_size_t offset,
+int drm_legacy_addmap(struct drm_device *dev, resource_size_t offset,
 		      unsigned int size, enum drm_map_type type,
 		      enum drm_map_flags flags, struct drm_local_map **map_ptr)
 {

@@ -637,8 +637,8 @@ int drm_legacy_rmmap_ioctl(struct drm_device *dev, void *data,
  *
  * Frees any pages and buffers associated with the given entry.
  */
-static void drm_cleanup_buf_error(struct drm_device * dev,
-				  struct drm_buf_entry * entry)
+static void drm_cleanup_buf_error(struct drm_device *dev,
+				  struct drm_buf_entry *entry)
 {
 	int i;
Signature · 1 line
2.16.2
Signature · 5 lines
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel