Skip to contentSkip to conversation

video: exynos: remove redundant assignments

PATCH New Heinrich Schuchardt 2 participants 3 messages Mar 18, 2018 – Mar 19, 2018

Subsystems (2)
Framebuffer layer Arm Samsung Exynos
lore
Share & tools
lore

Heinrich Schuchardt

author
#0 lore raw

PATCH 1/1 video: exynos: remove redundant assignments

No need to initialize variables if the next usage is an assignment.

Signed-off-by Heinrich Schuchardt <[email protected]>
---
 drivers/video/exynos/exynos_dp.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/video/exynos/exynos_dp.c +6 -6
index 30e4020686..2f724ee745 100644
@@ -321,7 +321,7 @@ static unsigned int exynos_dp_link_start(struct exynos_dp *regs,
 
 static unsigned int exynos_dp_training_pattern_dis(struct exynos_dp *regs)
 {
-	unsigned int ret = EXYNOS_DP_SUCCESS;
+	unsigned int ret;
 
 	exynos_dp_set_training_pattern(regs, DP_NONE);
 

@@ -339,7 +339,7 @@ static unsigned int exynos_dp_enable_rx_to_enhanced_mode(
 		struct exynos_dp *regs, unsigned char enable)
 {
 	unsigned char data;
-	unsigned int ret = EXYNOS_DP_SUCCESS;
+	unsigned int ret;
 
 	ret = exynos_dp_read_byte_from_dpcd(regs, DPCD_LANE_COUNT_SET,
 					    &data);

@@ -366,7 +366,7 @@ static unsigned int exynos_dp_enable_rx_to_enhanced_mode(
 static unsigned int exynos_dp_set_enhanced_mode(struct exynos_dp *regs,
 						unsigned char enhance_mode)
 {
-	unsigned int ret = EXYNOS_DP_SUCCESS;
+	unsigned int ret
 
 	ret = exynos_dp_enable_rx_to_enhanced_mode(regs, enhance_mode);
 	if (ret != EXYNOS_DP_SUCCESS) {

@@ -416,7 +416,7 @@ static int exynos_dp_read_dpcd_lane_stat(struct exynos_dp *regs,
 static unsigned int exynos_dp_read_dpcd_adj_req(struct exynos_dp *regs,
 		unsigned char lane_num, unsigned char *sw, unsigned char *em)
 {
-	unsigned int ret = EXYNOS_DP_SUCCESS;
+	unsigned int ret;
 	unsigned char buf;
 	unsigned int dpcd_addr;
 	unsigned char shift_val[DP_LANE_CNT_4] = {0, 4, 0, 4};

@@ -484,7 +484,7 @@ static int exynos_dp_reduce_link_rate(struct exynos_dp *regs,
 static unsigned int exynos_dp_process_clock_recovery(struct exynos_dp *regs,
 					struct exynos_dp_priv *priv)
 {
-	unsigned int ret = EXYNOS_DP_SUCCESS;
+	unsigned int ret;
 	unsigned char lane_stat;
 	unsigned char lt_ctl_val[DP_LANE_CNT_4] = {0, };
 	unsigned int i;

@@ -594,7 +594,7 @@ static unsigned int exynos_dp_process_clock_recovery(struct exynos_dp *regs,
 static unsigned int exynos_dp_process_equalizer_training(
 		struct exynos_dp *regs, struct exynos_dp_priv *priv)
 {
-	unsigned int ret = EXYNOS_DP_SUCCESS;
+	unsigned int ret;
 	unsigned char lane_stat, adj_req_sw, adj_req_em, i;
 	unsigned char lt_ctl_val[DP_LANE_CNT_4] = {0,};
 	unsigned char interlane_aligned = 0;
Signature · 1 line
2.16.2
author
#1 lore raw

PATCH 1/1 video: exynos: remove redundant assignments

No need to initialize variables if the next usage is an assignment.

Signed-off-by Heinrich Schuchardt <[email protected]>

---
v2
add missing semicolon

---
 drivers/video/exynos/exynos_dp.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/video/exynos/exynos_dp.c +6 -6
index 30e4020686..2f724ee745 100644
@@ -321,7 +321,7 @@ static unsigned int exynos_dp_link_start(struct exynos_dp *regs,
 
 static unsigned int exynos_dp_training_pattern_dis(struct exynos_dp *regs)
 {
-	unsigned int ret = EXYNOS_DP_SUCCESS;
+	unsigned int ret;
 
 	exynos_dp_set_training_pattern(regs, DP_NONE);
 

@@ -339,7 +339,7 @@ static unsigned int exynos_dp_enable_rx_to_enhanced_mode(
 		struct exynos_dp *regs, unsigned char enable)
 {
 	unsigned char data;
-	unsigned int ret = EXYNOS_DP_SUCCESS;
+	unsigned int ret;
 
 	ret = exynos_dp_read_byte_from_dpcd(regs, DPCD_LANE_COUNT_SET,
 					    &data);

@@ -366,7 +366,7 @@ static unsigned int exynos_dp_enable_rx_to_enhanced_mode(
 static unsigned int exynos_dp_set_enhanced_mode(struct exynos_dp *regs,
 						unsigned char enhance_mode)
 {
-	unsigned int ret = EXYNOS_DP_SUCCESS;
+	unsigned int ret;
 
 	ret = exynos_dp_enable_rx_to_enhanced_mode(regs, enhance_mode);
 	if (ret != EXYNOS_DP_SUCCESS) {

@@ -416,7 +416,7 @@ static int exynos_dp_read_dpcd_lane_stat(struct exynos_dp *regs,
 static unsigned int exynos_dp_read_dpcd_adj_req(struct exynos_dp *regs,
 		unsigned char lane_num, unsigned char *sw, unsigned char *em)
 {
-	unsigned int ret = EXYNOS_DP_SUCCESS;
+	unsigned int ret;
 	unsigned char buf;
 	unsigned int dpcd_addr;
 	unsigned char shift_val[DP_LANE_CNT_4] = {0, 4, 0, 4};

@@ -484,7 +484,7 @@ static int exynos_dp_reduce_link_rate(struct exynos_dp *regs,
 static unsigned int exynos_dp_process_clock_recovery(struct exynos_dp *regs,
 					struct exynos_dp_priv *priv)
 {
-	unsigned int ret = EXYNOS_DP_SUCCESS;
+	unsigned int ret;
 	unsigned char lane_stat;
 	unsigned char lt_ctl_val[DP_LANE_CNT_4] = {0, };
 	unsigned int i;

@@ -594,7 +594,7 @@ static unsigned int exynos_dp_process_clock_recovery(struct exynos_dp *regs,
 static unsigned int exynos_dp_process_equalizer_training(
 		struct exynos_dp *regs, struct exynos_dp_priv *priv)
 {
-	unsigned int ret = EXYNOS_DP_SUCCESS;
+	unsigned int ret;
 	unsigned char lane_stat, adj_req_sw, adj_req_em, i;
 	unsigned char lt_ctl_val[DP_LANE_CNT_4] = {0,};
 	unsigned char interlane_aligned = 0;
Signature · 1 line
2.16.2
#2 lore raw

PATCH 1/1 video: exynos: remove redundant assignments

Quoted 9 lines · On Mon, 19 Mar 2018 07:46:08 +0100 Heinrich Schuchardt xypron.glpk at gmx.de…

No need to initialize variables if the next usage is an assignment.

Signed-off-by Heinrich Schuchardt <[email protected]>

---
v2
add missing semicolon

---
 drivers/video/exynos/exynos_dp.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Applied to u-boot-video/master, thanks!

--
Anatolij