Skip to contentSkip to conversation

apparmor: signedness bug in aa_xattrs_match()

PATCH In review Dan Carpenter 2 participants 2 messages Mar 19, 2018 – Mar 24, 2018

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 apparmor: signedness bug in aa_xattrs_match()

The "size" variable needs to be signed ssize_t so that the error handling works correctly.

Fixes 8e51f9087f40 ("apparmor: Add support for attaching profiles via xattr, presence and value")
security/apparmor/domain.c +1 -1
index 57cc892e05a2..590b7e8cd21c 100644
@@ -314,7 +314,7 @@ static int aa_xattrs_match(const struct linux_binprm *bprm,
 			   struct aa_profile *profile, unsigned int state)
 {
 	int i;
-	size_t size;
+	ssize_t size;
 	struct dentry *d;
 	char *value = NULL;
 	int value_size = 0, ret = profile->xattr_count;
maintainer
#1 lore raw
Quoted 6 lines · Dan Carpenter

The "size" variable needs to be signed ssize_t so that the error handling works correctly.

Fixes 8e51f9087f40 ("apparmor: Add support for attaching profiles via xattr, presence and value")

yep thanks I have pulled this in to apparmor-next

Quoted 14 lines
security/apparmor/domain.c +1 -1
index 57cc892e05a2..590b7e8cd21c 100644
@@ -314,7 +314,7 @@ static int aa_xattrs_match(const struct linux_binprm *bprm,
 			   struct aa_profile *profile, unsigned int state)
 {
 	int i;
-	size_t size;
+	ssize_t size;
 	struct dentry *d;
 	char *value = NULL;
 	int value_size = 0, ret = profile->xattr_count;