drm: remove drm_mode_object_{un/reference} aliases
Subsystems (3)
PATCH 1/1 drm: remove drm_mode_object_{un/reference} aliases
This patch remove the compatibility aliases drm_mode_object_{reference/unreference} of drm_mode_object_{get/put} since all callers have been converted to the prefered _{get/put}.
Remove the helpers from the semantic patch drm-get-put-cocci.
Signed-off-by Haneen Mohammed <[email protected]>
--- include/drm/drm_mode_object.h | 24 ------------------------ scripts/coccinelle/api/drm-get-put.cocci | 10 ---------- 2 files changed, 34 deletions(-)
include/drm/drm_mode_object.h +0 -24
@@ -120,30 +120,6 @@ struct drm_mode_object *drm_mode_object_find(struct drm_device *dev,void drm_mode_object_get (struct drm_mode_object *obj);void drm_mode_object_put (struct drm_mode_object *obj); -/** -* drm_mode_object_reference - acquire a mode object reference -* @obj: DRM mode object -* -* This is a compatibility alias for drm_mode_object_get() and should not be -* used by new code. -*/ -static inline void drm_mode_object_reference (struct drm_mode_object *obj) -{ -drm_mode_object_get (obj); -} - -/** -* drm_mode_object_unreference - release a mode object reference -* @obj: DRM mode object -* -* This is a compatibility alias for drm_mode_object_put() and should not be -* used by new code. -*/ -static inline void drm_mode_object_unreference (struct drm_mode_object *obj) -{ -drm_mode_object_put (obj); -} -int drm_object_property_set_value (struct drm_mode_object *obj,struct drm_property *property,uint64_t val);
scripts/coccinelle/api/drm-get-put.cocci +0 -10
@@ -16,12 +16,6 @@ expression object; @@ ( -- drm_mode_object_reference(object) -+ drm_mode_object_get(object) -| -- drm_mode_object_unreference(object) -+ drm_mode_object_put(object) -| - drm_connector_reference(object) + drm_connector_get(object) |
@@ -62,10 +56,6 @@ position p; @@ ( -drm_mode_object_unreference@p(object) -| -drm_mode_object_reference@p(object) -| drm_connector_unreference@p(object) | drm_connector_reference@p(object)
Signature · 1 line
2.7.4
Quoted 7 lines · Haneen Mohammed
This patch remove the compatibility aliases drm_mode_object_{reference/unreference} of drm_mode_object_{get/put} since all callers have been converted to the prefered _{get/put}.
Remove the helpers from the semantic patch drm-get-put-cocci.
Signed-off-by Haneen Mohammed <[email protected]>
Thanks for your patch, applied to drm-misc-next.
Sean
Quoted 71 lines
--- include/drm/drm_mode_object.h | 24 ------------------------ scripts/coccinelle/api/drm-get-put.cocci | 10 ---------- 2 files changed, 34 deletions(-)include/drm/drm_mode_object.h +0
-24@@ -120,30 +120,6 @@ struct drm_mode_object *drm_mode_object_find(struct drm_device *dev,void drm_mode_object_get (struct drm_mode_object *obj);void drm_mode_object_put (struct drm_mode_object *obj); -/** -* drm_mode_object_reference - acquire a mode object reference -* @obj: DRM mode object -* -* This is a compatibility alias for drm_mode_object_get() and should not be -* used by new code. -*/ -static inline void drm_mode_object_reference (struct drm_mode_object *obj) -{ -drm_mode_object_get (obj); -} - -/** -* drm_mode_object_unreference - release a mode object reference -* @obj: DRM mode object -* -* This is a compatibility alias for drm_mode_object_put() and should not be -* used by new code. -*/ -static inline void drm_mode_object_unreference (struct drm_mode_object *obj) -{ -drm_mode_object_put (obj); -} -int drm_object_property_set_value (struct drm_mode_object *obj,struct drm_property *property,uint64_t val);scripts/coccinelle/api/drm-get-put.cocci +0
-10@@ -16,12 +16,6 @@ expression object; @@ ( -- drm_mode_object_reference(object) -+ drm_mode_object_get(object) -| -- drm_mode_object_unreference(object) -+ drm_mode_object_put(object) -| - drm_connector_reference(object) + drm_connector_get(object) |@@ -62,10 +56,6 @@ position p; @@ ( -drm_mode_object_unreference@p(object) -| -drm_mode_object_reference@p(object) -| drm_connector_unreference@p(object) | drm_connector_reference@p(object)Signature · 1 line
2.7.4
Signature · 5 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 7 lines · Haneen Mohammed
This patch remove the compatibility aliases drm_mode_object_{reference/unreference} of drm_mode_object_{get/put} since all callers have been converted to the prefered _{get/put}.
Remove the helpers from the semantic patch drm-get-put-cocci.
Signed-off-by Haneen Mohammed <[email protected]>
Yay, one set down, a few more to go!
Thanks for taking care of this.
-Daniel
Quoted 77 lines
--- include/drm/drm_mode_object.h | 24 ------------------------ scripts/coccinelle/api/drm-get-put.cocci | 10 ---------- 2 files changed, 34 deletions(-)include/drm/drm_mode_object.h +0
-24@@ -120,30 +120,6 @@ struct drm_mode_object *drm_mode_object_find(struct drm_device *dev,void drm_mode_object_get (struct drm_mode_object *obj);void drm_mode_object_put (struct drm_mode_object *obj); -/** -* drm_mode_object_reference - acquire a mode object reference -* @obj: DRM mode object -* -* This is a compatibility alias for drm_mode_object_get() and should not be -* used by new code. -*/ -static inline void drm_mode_object_reference (struct drm_mode_object *obj) -{ -drm_mode_object_get (obj); -} - -/** -* drm_mode_object_unreference - release a mode object reference -* @obj: DRM mode object -* -* This is a compatibility alias for drm_mode_object_put() and should not be -* used by new code. -*/ -static inline void drm_mode_object_unreference (struct drm_mode_object *obj) -{ -drm_mode_object_put (obj); -} -int drm_object_property_set_value (struct drm_mode_object *obj,struct drm_property *property,uint64_t val);scripts/coccinelle/api/drm-get-put.cocci +0
-10@@ -16,12 +16,6 @@ expression object; @@ ( -- drm_mode_object_reference(object) -+ drm_mode_object_get(object) -| -- drm_mode_object_unreference(object) -+ drm_mode_object_put(object) -| - drm_connector_reference(object) + drm_connector_get(object) |@@ -62,10 +56,6 @@ position p; @@ ( -drm_mode_object_unreference@p(object) -| -drm_mode_object_reference@p(object) -| drm_connector_unreference@p(object) | drm_connector_reference@p(object)Signature · 8 lines
2.7.4 -- You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20180319055820.GA17502%40haneen-VirtualBox. For more options, visit https://groups.google.com/d/optout.
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch