Skip to contentSkip to conversation

ata: add Amiga Gayle PATA controller driver

PATCH Applied Bartlomiej Zolnierkiewicz 3 participants 5 messages Mar 16, 2018 – Mar 23, 2018 1 message not in the archive libata

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): CGME20180316161549epcas1p23166605ea9922198486e0c07bd184ed8@epcas1p2.samsung.com

Bartlomiej Zolnierkiewicz

author
#1 lore raw

PATCH v3 1/1 ata: add Amiga Gayle PATA controller driver

Add Amiga Gayle PATA controller driver. It enables libata support for the on-board IDE interfaces on some Amiga models (A600, A1200, A4000 and A4000T) and also for IDE interfaces on the Zorro expansion bus (M-Tech E-Matrix 530 expansion card).

Thanks to John Paul Adrian Glaubitz and Michael Schmitz for help with testing the driver.

Tested-by John Paul Adrian Glaubitz <[email protected]>
Cc Michael Schmitz <[email protected]>
Cc Geert Uytterhoeven <[email protected]>
Cc Philippe Ombredanne <[email protected]>
Cc Andy Shevchenko <[email protected]>
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

---
v3:
- fix minor issues reported by Andy

v2:
- clarify license version (it should be GPL 2.0)
- use SPDX header

 drivers/ata/Kconfig      |   12 ++
 drivers/ata/Makefile     |    1 
 drivers/ata/pata_gayle.c |  219 +++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 232 insertions(+)
drivers/ata/Kconfig +12 -0
Index: b/drivers/ata/Kconfig
===================================================================
@@ -954,6 +954,18 @@ config PATA_FALCON
 
 	  If unsure, say N.
 
+config PATA_GAYLE
+	tristate "Amiga Gayle PATA support"
+	depends on M68K && AMIGA
+	help
+	  This option enables support for the on-board IDE
+	  interfaces on some Amiga models (A600, A1200,
+	  A4000 and A4000T) and also for IDE interfaces on
+	  the Zorro expansion bus (M-Tech E-Matrix 530
+	  expansion card).
+
+	  If unsure, say N.
+
 config PATA_ISAPNP
 	tristate "ISA Plug and Play PATA support"
 	depends on ISAPNP
drivers/ata/Makefile +1 -0
Index: b/drivers/ata/Makefile
===================================================================
@@ -97,6 +97,7 @@ obj-$(CONFIG_PATA_WINBOND)	+= pata_sl82c
 # SFF PIO only
 obj-$(CONFIG_PATA_CMD640_PCI)	+= pata_cmd640.o
 obj-$(CONFIG_PATA_FALCON)	+= pata_falcon.o
+obj-$(CONFIG_PATA_GAYLE)	+= pata_gayle.o
 obj-$(CONFIG_PATA_ISAPNP)	+= pata_isapnp.o
 obj-$(CONFIG_PATA_IXP4XX_CF)	+= pata_ixp4xx_cf.o
 obj-$(CONFIG_PATA_MPIIX)	+= pata_mpiix.o
drivers/ata/pata_gayle.c new file +219 -0

219 lines not on this page · raw message

Acked-by on v3 1/1
#2 lore raw
Quoted 14 lines · Bartlomiej Zolnierkiewicz

Add Amiga Gayle PATA controller driver. It enables libata support for the on-board IDE interfaces on some Amiga models (A600, A1200, A4000 and A4000T) and also for IDE interfaces on the Zorro expansion bus (M-Tech E-Matrix 530 expansion card).

Thanks to John Paul Adrian Glaubitz and Michael Schmitz for help with testing the driver.

Tested-by John Paul Adrian Glaubitz <[email protected]>
Cc Michael Schmitz <[email protected]>
Cc Geert Uytterhoeven <[email protected]>
Cc Philippe Ombredanne <[email protected]>
Cc Andy Shevchenko <[email protected]>
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
Quoted 7 lines

---
v3:
- fix minor issues reported by Andy

v2:
- clarify license version (it should be GPL 2.0)
- use SPDX header

For the use of SPDX ids, you have my ack: (I am not qualified for the rest)

Acked-by Philippe Ombredanne <[email protected]>
Signature · 2 lines
Cordially
Philippe Ombredanne
#3 lore raw

Hello,

Quoted 7 lines · Philippe Ombredanne
Quoted 3 lines

v2:
- clarify license version (it should be GPL 2.0)
- use SPDX header

For the use of SPDX ids, you have my ack: (I am not qualified for the rest)

Acked-by Philippe Ombredanne <[email protected]>

I don't think it's a good idea to add this acked-by when it's purely based on a single liner license tag. I understand that you want to encourage use of the new tags but this can be misleading and it'd be great if you reconsider sending out acks like this.

Thanks.

Signature · 1 line
tejun
#4 lore raw

Tejun,

Quoted 9 lines · Tejun Heo

Hello,

Quoted 6 lines · Philippe Ombredanne
Quoted 3 lines

v2:
- clarify license version (it should be GPL 2.0)
- use SPDX header

For the use of SPDX ids, you have my ack: (I am not qualified for the rest)

Quoted 8 lines
Quoted 1 line
Acked-by Philippe Ombredanne <[email protected]>

I don't think it's a good idea to add this acked-by when it's purely based on a single liner license tag. I understand that you want to encourage use of the new tags but this can be misleading and it'd be great if you reconsider sending out acks like this.

Thanks.

You have a good point. I find it confusing myself. Please, remove this ack!

Signature · 2 lines
Cordially
Philippe Ombredanne
Applied
#5 lore raw
In reply to Bartlomiej Zolnierkiewicz
Quoted 8 lines · Bartlomiej Zolnierkiewicz

Add Amiga Gayle PATA controller driver. It enables libata support for the on-board IDE interfaces on some Amiga models (A600, A1200, A4000 and A4000T) and also for IDE interfaces on the Zorro expansion bus (M-Tech E-Matrix 530 expansion card).

Thanks to John Paul Adrian Glaubitz and Michael Schmitz for help with testing the driver.

Quoted 6 lines
Tested-by John Paul Adrian Glaubitz <[email protected]>
Cc Michael Schmitz <[email protected]>
Cc Geert Uytterhoeven <[email protected]>
Cc Philippe Ombredanne <[email protected]>
Cc Andy Shevchenko <[email protected]>
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

Applied to libata/for-4.17.

Thanks, Bart.

Signature · 1 line
tejun