Skip to contentSkip to conversation

video: rk3288_mipi: Combine NULL check into IS_ERR_OR_NULL()

PATCH New Punit Agrawal 3 participants 10 messages Mar 19, 2018 – Mar 28, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 video: rk3288_mipi: Combine NULL check into IS_ERR_OR_NULL()

---
 drivers/video/rockchip/rk3288_mipi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/rockchip/rk3288_mipi.c +1 -1
index 27d125f77e..a7fa9c5110 100644
@@ -136,7 +136,7 @@ static int rk_mipi_ofdata_to_platdata(struct udevice *dev)
 	struct rk_mipi_priv *priv = dev_get_priv(dev);
 
 	priv->grf = syscon_get_first_range(ROCKCHIP_SYSCON_GRF);
-	if (!priv->grf || IS_ERR(priv->grf)) {
+	if (IS_ERR_OR_NULL(priv->grf)) {
 		debug("%s: Get syscon grf failed (ret=%p)\n",
 		      __func__, priv->grf);
 		return  -ENXIO;
Signature · 1 line
2.16.1
#1 lore raw

PATCH 2/2 video: rk3399_mipi: Combine NULL check into IS_ERR_OR_NULL()

---
 drivers/video/rockchip/rk3399_mipi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/rockchip/rk3399_mipi.c +1 -1
index c6987ff042..b936fcec9b 100644
@@ -128,7 +128,7 @@ static int rk_mipi_ofdata_to_platdata(struct udevice *dev)
 	struct rk_mipi_priv *priv = dev_get_priv(dev);
 
 	priv->grf = syscon_get_first_range(ROCKCHIP_SYSCON_GRF);
-	if (!priv->grf || IS_ERR(priv->grf)) {
+	if (IS_ERR_OR_NULL(priv->grf)) {
 		debug("%s: Get syscon grf failed (ret=%p)\n",
 		      __func__, priv->grf);
 		return  -ENXIO;
Signature · 1 line
2.16.1
#2 lore raw

PATCH 2/2 video: rk3399_mipi: Combine NULL check into IS_ERR_OR_NULL()

Quoted 1 line · Punit Agrawal
Quoted 18 lines
---
 drivers/video/rockchip/rk3399_mipi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/rockchip/rk3399_mipi.c +1 -1
index c6987ff042..b936fcec9b 100644
@@ -128,7 +128,7 @@ static int rk_mipi_ofdata_to_platdata(struct udevice *dev)
 	struct rk_mipi_priv *priv = dev_get_priv(dev);
 
 	priv->grf = syscon_get_first_range(ROCKCHIP_SYSCON_GRF);
-	if (!priv->grf || IS_ERR(priv->grf)) {
+	if (IS_ERR_OR_NULL(priv->grf)) {
 		debug("%s: Get syscon grf failed (ret=%p)\n",
 		      __func__, priv->grf);
 		return  -ENXIO;
#6 lore raw

PATCH 1/2 video: rk3288_mipi: Combine NULL check into IS_ERR_OR_NULL()

In reply to Punit Agrawal
Quoted 1 line · Punit Agrawal
Quoted 18 lines
---
 drivers/video/rockchip/rk3288_mipi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/rockchip/rk3288_mipi.c +1 -1
index 27d125f77e..a7fa9c5110 100644
@@ -136,7 +136,7 @@ static int rk_mipi_ofdata_to_platdata(struct udevice *dev)
 	struct rk_mipi_priv *priv = dev_get_priv(dev);
 
 	priv->grf = syscon_get_first_range(ROCKCHIP_SYSCON_GRF);
-	if (!priv->grf || IS_ERR(priv->grf)) {
+	if (IS_ERR_OR_NULL(priv->grf)) {
 		debug("%s: Get syscon grf failed (ret=%p)\n",
 		      __func__, priv->grf);
 		return  -ENXIO;