Skip to contentSkip to conversation

libv4l: qv4l2 doesn't support GLES

PATCH New Phil Eichinger 3 participants 5 messages Mar 19, 2018 – Oct 20, 2018

lore
Share & tools
lore

Phil Eichinger

author
#0 lore raw

PATCH 1/1 libv4l: qv4l2 doesn't support GLES

qv4l2 explicitly sets QT_NO_OPENGL_ES_2 because GLES is not supported yet. So compiling with Qt5 which has only GLES enabled fails.

https://git.linuxtv.org/v4l-utils.git/commit/utils/qv4l2?id=c185420d494d8985ec3aab6b2a28f858046052b5

Signed-off-by Phil Eichinger <[email protected]>
---
 package/libv4l/libv4l.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libv4l/libv4l.mk +1 -1
index 11061306c7..5eb26ee16c 100644
@@ -51,7 +51,7 @@ endif
 ifeq ($(BR2_PACKAGE_LIBV4L_UTILS),y)
 LIBV4L_CONF_OPTS += --enable-v4l-utils
 LIBV4L_DEPENDENCIES += $(TARGET_NLS_DEPENDENCIES)
-ifeq ($(BR2_PACKAGE_QT5BASE)$(BR2_PACKAGE_QT5BASE_GUI)$(BR2_PACKAGE_QT5BASE_WIDGETS),yyy)
+ifeq ($(BR2_PACKAGE_QT5BASE)$(BR2_PACKAGE_QT5BASE_GUI)$(BR2_PACKAGE_QT5BASE_WIDGETS)$(BR2_PACKAGE_QT5BASE_OPENGL_DESKTOP),yyyy)
 LIBV4L_CONF_OPTS += --enable-qv4l2
 LIBV4L_DEPENDENCIES += qt5base
 # protect against host version detection of moc-qt5/rcc-qt5/uic-qt5
Signature · 1 line
2.11.0
NAK
#1 lore raw

PATCH 1/1 libv4l: qv4l2 doesn't support GLES

Hello Phil,

Quoted 14 lines · Phil Eichinger

qv4l2 explicitly sets QT_NO_OPENGL_ES_2 because GLES is not supported yet. So compiling with Qt5 which has only GLES enabled fails.

https://git.linuxtv.org/v4l-utils.git/commit/utils/qv4l2?id=c185420d494d8985ec3aab6b2a28f858046052b5

Signed-off-by Phil Eichinger <[email protected]>
---
 package/libv4l/libv4l.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libv4l/libv4l.mk +0 -0
index 11061306c7..5eb26ee16c 100644

package/libv4l/libv4l.mk endif · line 54

Quoted 5 lines
package/libv4l/libv4l.mk +1 -1
@@ -51,7 +51,7 @@ endif
 ifeq ($(BR2_PACKAGE_LIBV4L_UTILS),y)
 LIBV4L_CONF_OPTS += --enable-v4l-utils
 LIBV4L_DEPENDENCIES += $(TARGET_NLS_DEPENDENCIES)
-ifeq ($(BR2_PACKAGE_QT5BASE)$(BR2_PACKAGE_QT5BASE_GUI)$(BR2_PACKAGE_QT5BASE_WIDGETS),yyy)
+ifeq ($(BR2_PACKAGE_QT5BASE)$(BR2_PACKAGE_QT5BASE_GUI)$(BR2_PACKAGE_QT5BASE_WIDGETS)$(BR2_PACKAGE_QT5BASE_OPENGL_DESKTOP),yyyy)

NAK, qv4l2 builds just fine with framebuffer/widgets support, see libv4l-1.14.1/config.h HAVE_QTGL configure logic and libv4l-1.14.1/utils/qv4l2/* conditional compile logic...

Do your have a (minimal) buildroot defconfig which failes to build libv4l?

Regards,
Peter

Quoted 3 lines
package/libv4l/libv4l.mk +0 -0
 LIBV4L_CONF_OPTS += --enable-qv4l2
 LIBV4L_DEPENDENCIES += qt5base
 # protect against host version detection of moc-qt5/rcc-qt5/uic-qt5
author
#2 lore raw

PATCH 1/1 libv4l: qv4l2 doesn't support GLES

Quoted 13 lines · Peter Seiderer

Hello Phil,

Quoted 9 lines · Phil Eichinger

qv4l2 explicitly sets QT_NO_OPENGL_ES_2 because GLES is not supported yet. So compiling with Qt5 which has only GLES enabled fails.

https://git.linuxtv.org/v4l-utils.git/commit/utils/qv4l2?id=c185420d494d8985ec3aab6b2a28f858046052b5

Signed-off-by Phil Eichinger <[email protected]>
---
 package/libv4l/libv4l.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines

package/libv4l/libv4l.mk endif · line 54

Quoted 10 lines
package/libv4l/libv4l.mk +1 -1
index 11061306c7..5eb26ee16c 100644
@@ -51,7 +51,7 @@ endif
 ifeq ($(BR2_PACKAGE_LIBV4L_UTILS),y)
 LIBV4L_CONF_OPTS += --enable-v4l-utils
 LIBV4L_DEPENDENCIES += $(TARGET_NLS_DEPENDENCIES)
-ifeq ($(BR2_PACKAGE_QT5BASE)$(BR2_PACKAGE_QT5BASE_GUI)$(BR2_PACKAGE_QT5BASE_WIDGETS),yyy)
+ifeq ($(BR2_PACKAGE_QT5BASE)$(BR2_PACKAGE_QT5BASE_GUI)$(BR2_PACKAGE_QT5BASE_WIDGETS)$(BR2_PACKAGE_QT5BASE_OPENGL_DESKTOP),yyyy)

NAK, qv4l2 builds just fine with framebuffer/widgets support, see libv4l-1.14.1/config.h HAVE_QTGL configure logic and libv4l-1.14.1/utils/qv4l2/* conditional compile logic...

Oh, that was a misunderstanding on my part, I haven't taken non-GL
builds into account. I only need to disable it if BR2_PACKAGE_QT5BASE_OPENGL_ES2 is enabled. Because then it gets built with HAVE_QTGL which won't work.
I'll come up with a v2 then.

Regards

Phil

#3 lore raw

PATCH 1/1 libv4l: qv4l2 doesn't support GLES

Hello Phil,

Quoted 34 lines

Gesendet: Dienstag, 20. M?rz 2018 um 09:41 Uhr
Von: "phil eichinger" <[email protected]>
An: "Peter Seiderer" <[email protected]>
Cc: buildroot at buildroot.org
Betreff: Re: [Buildroot] [PATCH 1/1] libv4l: qv4l2 doesn't support GLES

Quoted 13 lines · Peter Seiderer

Hello Phil,

Quoted 9 lines · Phil Eichinger

qv4l2 explicitly sets QT_NO_OPENGL_ES_2 because GLES is not supported yet. So compiling with Qt5 which has only GLES enabled fails.

https://git.linuxtv.org/v4l-utils.git/commit/utils/qv4l2?id=c185420d494d8985ec3aab6b2a28f858046052b5

Signed-off-by Phil Eichinger <[email protected]>
---
 package/libv4l/libv4l.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines

package/libv4l/libv4l.mk endif · line 54

Quoted 10 lines
package/libv4l/libv4l.mk +1 -1
index 11061306c7..5eb26ee16c 100644
@@ -51,7 +51,7 @@ endif
 ifeq ($(BR2_PACKAGE_LIBV4L_UTILS),y)
 LIBV4L_CONF_OPTS += --enable-v4l-utils
 LIBV4L_DEPENDENCIES += $(TARGET_NLS_DEPENDENCIES)
-ifeq ($(BR2_PACKAGE_QT5BASE)$(BR2_PACKAGE_QT5BASE_GUI)$(BR2_PACKAGE_QT5BASE_WIDGETS),yyy)
+ifeq ($(BR2_PACKAGE_QT5BASE)$(BR2_PACKAGE_QT5BASE_GUI)$(BR2_PACKAGE_QT5BASE_WIDGETS)$(BR2_PACKAGE_QT5BASE_OPENGL_DESKTOP),yyyy)

NAK, qv4l2 builds just fine with framebuffer/widgets support, see libv4l-1.14.1/config.h HAVE_QTGL configure logic and libv4l-1.14.1/utils/qv4l2/* conditional compile logic...

Quoted 4 lines

Oh, that was a misunderstanding on my part, I haven't taken non-GL
builds into account. I only need to disable it if BR2_PACKAGE_QT5BASE_OPENGL_ES2 is enabled. Because then it gets built with HAVE_QTGL which won't work.
I'll come up with a v2 then.

It depends, I have a IMX.6/etnaviv config, BR2_PACKAGE_QT5BASE_OPENGL_ES2 enabled, no compile problems (but HAVE_QTGL is disabled), maybe it is possible to do some fine tuning with the build/libv4l-1.14.1/configure.ac logic?

Can you provide your defconfig?

Regards,
Peter

Quoted 6 lines

Regards

Phil

#4 lore raw

PATCH 1/1 libv4l: qv4l2 doesn't support GLES

In reply to Phil Eichinger

Hello,

Quoted 8 lines · Phil Eichinger

qv4l2 explicitly sets QT_NO_OPENGL_ES_2 because GLES is not supported yet. So compiling with Qt5 which has only GLES enabled fails.

https://git.linuxtv.org/v4l-utils.git/commit/utils/qv4l2?id=c185420d494d8985ec3aab6b2a28f858046052b5

Signed-off-by Phil Eichinger <[email protected]>
---
 package/libv4l/libv4l.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Following the feedback from Peter Seiderer, I've marked this patch as Rejected in patchwork. We also don't have build failures that match this issue it seems.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com