New Defects reported by Coverity Scan for batctl
A message that is not in the archive (sent off-list or not yet received): [email protected]
On Mon, Mar 19, 2018 at 01:17:37AM +0000, [email protected] wrote:
[...]
Quoted 6 lines
________________________________________________________________________________________________________
*** CID 174547: Incorrect expression (COPY_PASTE_ERROR) /netlink.c: 255 ininfo_callback()
249 else
250mcast_flags=-EOPNOTSUPP;
251
Quoted 6 lines
252 if (attrs[BATADV_ATTR_MCAST_FLAGS_PRIV]) 253 mcast_flags_priv = nla_get_u32(attrs[BATADV_ATTR_MCAST_FLAGS_PRIV]); 254 else >>> CID 174547: Incorrect expression (COPY_PASTE_ERROR) >>> "mcast_flags" in "mcast_flags = -95L" looks like a copy-paste error. 255 mcast_flags = -EOPNOTSUPP;
[...]
Now this is officially the second time a code/patch reviewing algorithm creeps me out :D.
"Looks like", yeah... and even worse, the AI is actually right... I will send a fix :).
Cheers