Skip to contentSkip to conversation

meson: drop unneeded dependency to libudev

PATCH In review Eric Engestrom 2 participants 4 messages Mar 20, 2018 Arm/Amlogic Meson SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 meson: drop unneeded dependency to libudev

libdrm only needed libudev for a few days 3 years ago, between fde4969176822fe54197 and its revert 5b0e76f143887c4ec7db.

---
 meson.build | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
meson.build +1 -7
index 74a541e8d835ae27c7f4..ade90be1da9458b5d473 100644
@@ -166,12 +166,6 @@ if _libkms != 'false'
 endif
 
 config.set10('UDEV', with_udev)
-if with_udev
-  dep_udev = dependency('udev')
-else
-  dep_udev = []
-endif
-
 # Among others FreeBSD does not have a separate dl library.
 if not cc.has_function('dlsym')
   dep_dl = cc.find_library('dl', required : with_nouveau)
@@ -294,7 +288,7 @@ libdrm = shared_library(
    config_file,
   ],
   c_args : warn_c_args,
-  dependencies : [dep_udev, dep_valgrind, dep_rt, dep_m],
+  dependencies : [dep_valgrind, dep_rt, dep_m],
   include_directories : inc_drm,
   version : '2.4.0',
   install : true,
Signature · 7 lines
Cheers,
  Eric

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw

PATCH 2/3 meson: move line to allow using `config` earlier

---
 meson.build | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meson.build +2 -2
index ade90be1da9458b5d473..ddcd25ff0e428ce4a591 100644
@@ -29,12 +29,12 @@ project(
 
 pkg = import('pkgconfig')
 
+config = configuration_data()
+
 with_udev = get_option('udev')
 with_freedreno_kgsl = get_option('freedreno-kgsl')
 with_install_tests = get_option('install-test-programs')
 
-config = configuration_data()
-
 if ['freebsd', 'dragonfly', 'netbsd'].contains(host_machine.system())
   dep_pthread_stubs = dependency('pthread-stubs', version : '>= 0.4')
 else
Signature · 7 lines
Cheers,
  Eric

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#2 lore raw

PATCH 3/3 meson: drop unnecessary variable

In reply to Eric Engestrom
---
 meson.build | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
meson.build +1 -2
index ddcd25ff0e428ce4a591..961ee59cff6dc3c2cbb9 100644
@@ -31,7 +31,7 @@ pkg = import('pkgconfig')
 
 config = configuration_data()
 
-with_udev = get_option('udev')
+config.set10('UDEV', get_option('udev'))
 with_freedreno_kgsl = get_option('freedreno-kgsl')
 with_install_tests = get_option('install-test-programs')
 
@@ -165,7 +165,6 @@ if _libkms != 'false'
   with_libkms = _libkms == 'true' or ['linux', 'freebsd', 'dragonfly'].contains(host_machine.system())
 endif
 
-config.set10('UDEV', with_udev)
 # Among others FreeBSD does not have a separate dl library.
 if not cc.has_function('dlsym')
   dep_dl = cc.find_library('dl', required : with_nouveau)
Signature · 7 lines
Cheers,
  Eric

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v1 1/3
#3 lore raw
In reply to Eric Engestrom
Quoted 5 lines · Eric Engestrom

libdrm only needed libudev for a few days 3 years ago, between fde4969176822fe54197 and its revert 5b0e76f143887c4ec7db.

The series is

-Emil
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel