Skip to contentSkip to conversation

workqueue: fix the comments of nr_idle

PATCH Applied Lai Jiangshan 2 participants 2 messages Mar 20, 2018 Workqueue

lore
Share & tools
lore

Lai Jiangshan

author reviewer
#0 lore raw

PATCH 1/1 workqueue: fix the comments of nr_idle

Since the worker rebinding behavior was refactored, there is no idle worker off the idle_list now. The comment is outdated and can be just removed.

It also groups nr_workers and nr_idle together.

---
 kernel/workqueue.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
kernel/workqueue.c +2 -3
index bb9a519cbf50..19785a092026 100644
@@ -153,10 +153,9 @@ struct worker_pool {
 	unsigned long		watchdog_ts;	/* L: watchdog timestamp */
 
 	struct list_head	worklist;	/* L: list of pending works */
-	int			nr_workers;	/* L: total number of workers */
 
-	/* nr_idle includes the ones off idle_list for rebinding */
-	int			nr_idle;	/* L: currently idle ones */
+	int			nr_workers;	/* L: total number of workers */
+	int			nr_idle;	/* L: currently idle workers */
 
 	struct list_head	idle_list;	/* X: list of idle workers */
 	struct timer_list	idle_timer;	/* L: worker idle timeout */
Signature · 1 line
2.14.3 (Apple Git-98)
maintainer Applied
#1 lore raw
Quoted 7 lines · Lai Jiangshan

Since the worker rebinding behavior was refactored, there is no idle worker off the idle_list now. The comment is outdated and can be just removed.

It also groups nr_workers and nr_idle together.

Applied to wq/for-4.17.

Thanks.

Signature · 1 line
tejun