Test the plane formats on the Chamelium
cover Test the plane formats on the Chamelium
Hi,
Here is an RFC at starting to test the plane formats using the Chamelium over the HDMI. This was tested using the vc4 DRM driver found on the RaspberryPi.
This is still pretty rough around the edges at this point, but I'd like to get feedback on a few issues before getting any further.
* I've used pixman for now to convert back and forth the pattern and the captured frame. While this worked quite well for the RGB formats since pixman supports most (but not all) of them. However, the long term plan is to also test YUV and more exotic (like vendor specific) formats that pixman has 0 support for. So I really wonder whether this is the right approach compared to:
- Using something else (but what?)?
- Rolling our own format conversion library?
* I've so far had a single big test that will test all the formats exposed by the planes that have a pixman representation. I wonder whether this is preferrable, or if we want to have a subtest per format. I guess the latter will be slightly better since we would be able to catch regressions in the number of formats exposed that we wouldn't be able to with the former.
* Kind of related, I'm not sure what is the policy when it comes to tests, and whether I should merge this tests with kms_chamelium or leave it as a separate file.
* One of the biggest challenge of the serie is to support formats that have less bits than the reference frame. Indeed, the flow of patterns is this one: the pattern will first be generated in ARGB8888. It will then be converted to whatever format we want to test, be fed into the display engine, that will output it, and the Chamelium will capture it in ARGB8888.
However, when the plane format has less than 8 bits per color, some upsampling will happen, where the less significant bits will be filled with values that probably depend on the display engine. Another side effect is that the CRC used in the Chamelium tests cannot be used anymore.
The way I'm testing currently is that I'm retrieving the frame, and then compare each pixels on their most significant bits. This sounds inefficient, and it is, especially on the RPi that doesn't have the best networking throughput out there.
I guess we could also generate a CRC for both an upsampling with the lowest bits set to 1, and one for the lowest bits set to 0, and try to see if one of them match. I guess this should cover most of the situation.
Let me know what you think,
Thanks!
Maxime
Maxime Ripard (3):
tests/chamelium: Move some functions and structures to a common place tests/chamelium: Add test case for plane formats
tests: Add vc4 test suite
tests/Makefile.am | 1 + tests/Makefile.sources | 10 + tests/helpers_chamelium.c | 165 +++++++++++++++++ tests/helpers_chamelium.h | 65 +++++++ tests/kms_chamelium.c | 170 +---------------- tests/kms_chamelium_formats.c | 305 +++++++++++++++++++++++++++++++ tests/meson.build | 1 + tests/vc4_ci/vc4-chamelium-fast.testlist | 4 + tests/vc4_ci/vc4-chamelium.testlist | 9 + tests/vc4_ci/vc4.testlist | 35 ++++ 10 files changed, 596 insertions(+), 169 deletions(-) create mode 100644 tests/helpers_chamelium.c create mode 100644 tests/helpers_chamelium.h create mode 100644 tests/kms_chamelium_formats.c create mode 100644 tests/vc4_ci/vc4-chamelium-fast.testlist create mode 100644 tests/vc4_ci/vc4-chamelium.testlist create mode 100644 tests/vc4_ci/vc4.testlist
Signature · 6 lines
2.14.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
RFC PATCH 1/3 tests/chamelium: Move some functions and structures to a common place
We are going to use a few functions already defined in kms_chamelium in other tests. Let's move them out in a separate file / header.
--- tests/Makefile.sources | 5 ++ tests/helpers_chamelium.c | 165 ++++++++++++++++++++++++++++++++++++++++++++ tests/helpers_chamelium.h | 65 ++++++++++++++++++ tests/kms_chamelium.c | 170 +--------------------------------------------- 4 files changed, 236 insertions(+), 169 deletions(-) create mode 100644 tests/helpers_chamelium.c create mode 100644 tests/helpers_chamelium.h
tests/Makefile.sources +5 -0
@@ -275,6 +275,11 @@ scripts = \ IMAGES = pass.png 1080p-left.png 1080p-right.png +kms_chamelium_SOURCES = \ + kms_chamelium.c \ + helpers_chamelium.h \ + helpers_chamelium.c + testdisplay_SOURCES = \ testdisplay.c \ testdisplay.h \
tests/helpers_chamelium.c new file +165 -0
165 lines not on this page · raw message
tests/helpers_chamelium.h new file +65 -0
65 lines not on this page · raw message
tests/kms_chamelium.c +1 -169
199 lines not on this page · raw message
Signature · 6 lines
2.14.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
RFC PATCH 2/3 tests/chamelium: Add test case for plane formats
In reply to Maxime RipardKMS can support a lot of different plane formats that are not being tested by the current chamelium tests.
Add some preliminary tests to exert the RGB formats exposed by the KMS planes.
--- tests/Makefile.am | 1 + tests/Makefile.sources | 5 + tests/kms_chamelium_formats.c | 305 ++++++++++++++++++++++++++++++++++++++++++ tests/meson.build | 1 + 4 files changed, 312 insertions(+) create mode 100644 tests/kms_chamelium_formats.c
tests/Makefile.am +1 -0
@@ -17,6 +17,7 @@ endif if HAVE_CHAMELIUM TESTS_progs += \ kms_chamelium \ + kms_chamelium_formats \ $(NULL) endif
tests/Makefile.sources +5 -0
@@ -280,6 +280,11 @@ kms_chamelium_SOURCES = \ helpers_chamelium.h \ helpers_chamelium.c +kms_chamelium_formats_SOURCES = \ + kms_chamelium_formats.c \ + helpers_chamelium.h \ + helpers_chamelium.c + testdisplay_SOURCES = \ testdisplay.c \ testdisplay.h \
tests/kms_chamelium_formats.c new file +305 -0
305 lines not on this page · raw message
tests/meson.build +1 -0
@@ -244,6 +244,7 @@ endif if chamelium.found() test_progs += [ 'kms_chamelium', + 'kms_chamelium_formats', ] test_deps += chamelium endif
Signature · 6 lines
2.14.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [RFC PATCH i-g-t 2/3] tests/chamelium: Add test case for plane formats
Quoted 5 lines · Maxime Ripard
KMS can support a lot of different plane formats that are not being tested by the current chamelium tests.
Add some preliminary tests to exert the RGB formats exposed by the KMS planes.
I'm really excited for this test. A few comments...
Quoted 124 lines
--- tests/Makefile.am | 1 + tests/Makefile.sources | 5 + tests/kms_chamelium_formats.c | 305 ++++++++++++++++++++++++++++++++++++++++++ tests/meson.build | 1 + 4 files changed, 312 insertions(+) create mode 100644 tests/kms_chamelium_formats.ctests/Makefile.am +1
-0@@ -17,6 +17,7 @@ endif if HAVE_CHAMELIUM TESTS_progs += \ kms_chamelium \ + kms_chamelium_formats \ $(NULL) endiftests/Makefile.sources +5
-0@@ -280,6 +280,11 @@ kms_chamelium_SOURCES = \ helpers_chamelium.h \ helpers_chamelium.c +kms_chamelium_formats_SOURCES = \ + kms_chamelium_formats.c \ + helpers_chamelium.h \ + helpers_chamelium.c + testdisplay_SOURCES = \ testdisplay.c \ testdisplay.h \tests/kms_chamelium_formats.c new file +82
-0@@ -0,0 +1,305 @@ +/* +* Copyright © 2016 Red Hat Inc. +* +* Permission is hereby granted, free of charge, to any person obtaining a +* copy of this software and associated documentation files (the "Software"), +* to deal in the Software without restriction, including without limitation +* the rights to use, copy, modify, merge, publish, distribute, sublicense, +* and/or sell copies of the Software, and to permit persons to whom the +* Software is furnished to do so, subject to the following conditions: +* +* The above copyright notice and this permission notice (including the next +* paragraph) shall be included in all copies or substantial portions of the +* Software. +* +* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL +* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING +* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS +* IN THE SOFTWARE. +* +* Authors: +* Lyude Paul <[email protected]> +*/ + +#include "config.h" +#include "helpers_chamelium.h" +#include "igt.h" + +#include <fcntl.h> +#include <pixman.h> +#include <string.h> + +struct formats { +uint32_t drm_fmt; +pixman_format_code_t pixman_fmt; +} formats_map[] = { + {DRM_FORMAT_XRGB8888 , PIXMAN_x8r8g8b8 }, + {DRM_FORMAT_ARGB8888 , PIXMAN_a8r8g8b8 }, + {DRM_FORMAT_ABGR8888 , PIXMAN_a8b8g8r8 }, + {DRM_FORMAT_RGB565 , PIXMAN_r5g6b5 }, + {DRM_FORMAT_BGR565 , PIXMAN_b5g6r5 }, + {DRM_FORMAT_ARGB1555 , PIXMAN_a1r5g5b5 }, + {DRM_FORMAT_XRGB1555 , PIXMAN_x1r5g5b5 }, +}; + +static pixman_image_t *paint_ar24_pattern (size_t width,size_t height) +{ +uint32_t colors[] = {0xff000000 , +0xffff0000 , +0xff00ff00 , +0xff0000ff , +0xffffffff }; +unsigned i, j; +uint32_t *data; + + data =malloc (width * height *sizeof (*data)); +igt_assert (data); + +for (i =0 ; i < height; i++) +for (j =0 ; j < width; j++) + *(data + i * width + j) = colors[((j /64 ) + (i /64 )) %5 ]; + +return pixman_image_create_bits (PIXMAN_a8r8g8b8, width, height, + data, width *4 ); +} + +static void free_pattern (pixman_image_t *pattern) +{ +void *data =pixman_image_get_data (pattern); + +pixman_image_unref (pattern); +free (data); +} + +static pixman_image_t *pattern_to_fb (pixman_image_t *pattern,struct igt_fb *fb, +pixman_format_code_t pixman_fmt) +{ +pixman_image_t *converted; +void *ptr; +
tests/kms_chamelium_formats.c line 92
Quoted 10 lines
tests/kms_chamelium_formats.c new file +10
-0+igt_assert (fb->is_dumb); + + ptr =kmstest_dumb_map_buffer (fb->fd, fb->gem_handle, fb->size, +PROT_READ |PROT_WRITE ); +igt_assert (ptr); + + converted =pixman_image_create_bits (pixman_fmt, fb->width, fb->height, + ptr, fb->stride); +pixman_image_composite (PIXMAN_OP_ADD , pattern,NULL , converted, +0 ,0 ,0 ,0 ,0 ,0 , fb->width, fb->height);
If you're trying to fill the FB with the incoming pattern, then PIXMAN_OP_SRC is the thing you want (and will be *much* faster).
Quoted 9 lines
tests/kms_chamelium_formats.c new file +9
-0+ +return converted; +} + +static pixman_image_t *convert_frame_format (pixman_image_t *src, +int format) +{ +pixman_image_t *converted; +unsigned int w =pixman_image_get_width (src);
tests/kms_chamelium_formats.c line 111
Quoted 10 lines
tests/kms_chamelium_formats.c new file +10
-0+unsigned int h =pixman_image_get_height (src); +void *data =malloc (w * h *4 ); + +memset (data,0 , w * h *4 ); + converted =pixman_image_create_bits (format, w, h, data, +PIXMAN_FORMAT_BPP (format) /8 * w); +pixman_image_composite (PIXMAN_OP_ADD , src,NULL , converted, +0 ,0 ,0 ,0 ,0 ,0 , w, h); +return converted; +}
Instead of the memset, you could just use PIXMAN_OP_SRC.
Also, instead of "* 4", probably want "* PIXMAN_FORMAT_BPP(format) / 8" there too.
tests/kms_chamelium_formats.c line 113
Quoted 1 line
tests/kms_chamelium_formats.c new file +1
-0+#define PIXEL_MASK 0x00f8f8f8
If we're going to have some tolerance, the tolerance should probably depend on the lowest depth of the channel involved. However, I'm not sure this is needed -- we should be able to get bit-exact from VC4 by filling in the size-extension bits in the HVS.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [RFC PATCH i-g-t 2/3] tests/chamelium: Add test case for plane formats
Hi Eric,
Quoted 9 lines · Eric Anholt
Quoted 9 lines
tests/kms_chamelium_formats.c new file +9
-0+static pixman_image_t *convert_frame_format (pixman_image_t *src, +int format) +{ +pixman_image_t *converted; +unsigned int w =pixman_image_get_width (src); +unsigned int h =pixman_image_get_height (src); +void *data =malloc (w * h *4 ); + +memset (data,0 , w * h *4 );
Quoted 8 lines
tests/kms_chamelium_formats.c line 111
Quoted 6 lines
tests/kms_chamelium_formats.c new file +6
-0+ converted =pixman_image_create_bits (format, w, h, data, +PIXMAN_FORMAT_BPP (format) /8 * w); +pixman_image_composite (PIXMAN_OP_ADD , src,NULL , converted, +0 ,0 ,0 ,0 ,0 ,0 , w, h); +return converted; +}Instead of the memset, you could just use
PIXMAN_OP_SRC.
I guess PIXMAN_OP_ADD will do a composition between the existing buffer content and the new one, while PIXMAN_OP_SRC will just take whatever comes from the buffer and overwrite the previous content?
Quoted 2 lines
Also, instead of "* 4", probably want "*
PIXMAN_FORMAT_BPP(format)/ 8" there too.
Ah, yes, definitely.
Quoted 4 lines
Quoted 1 line
+#define
PIXEL_MASK0x00f8f8f8If we're going to have some tolerance, the tolerance should probably depend on the lowest depth of the channel involved.
Indeed, yes.
Quoted 2 lines
However, I'm not sure this is needed -- we should be able to get bit-exact from VC4 by filling in the size-extension bits in the HVS.
I guess it really depends on what we're aiming for here. While it would probably work with VC4, I think this part is rather generic, so I guess we could end up in scenarios where the CRTC will not fill the bits to our expected value and where it wouldn't be something we can change.
I just looked at the Allwinner display engine for example, and it didn't have such configuration (documented, at least).
That's why I went with this approach here (but I can definitely change it if we want to deal with that theorical case later).
Maxime
Signature · 3 lines
Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
RFC PATCH 3/3 tests: Add vc4 test suite
In reply to Maxime RipardAdd some various test suites relevant for the vc4 drm driver.
--- tests/vc4_ci/vc4-chamelium-fast.testlist | 4 ++++ tests/vc4_ci/vc4-chamelium.testlist | 9 ++++++++ tests/vc4_ci/vc4.testlist | 35 ++++++++++++++++++++++++++++++++ 3 files changed, 48 insertions(+) create mode 100644 tests/vc4_ci/vc4-chamelium-fast.testlist create mode 100644 tests/vc4_ci/vc4-chamelium.testlist create mode 100644 tests/vc4_ci/vc4.testlist
tests/vc4_ci/vc4-chamelium-fast.testlist new file +4 -0
@@ -0,0 +1,4 @@ +igt@kms_chamelium@hdmi-crc-fast +igt@kms_chamelium@hdmi-edid-read +igt@kms_chamelium@hdmi-hpd +igt@kms_chamelium@hdmi-hpd-fast
tests/vc4_ci/vc4-chamelium.testlist new file +9 -0
@@ -0,0 +1,9 @@ +igt@kms_chamelium@hdmi-crc-single +igt@kms_chamelium@hdmi-crc-multiple +igt@kms_chamelium@hdmi-frame-dump +igt@kms_chamelium@hdmi-hpd-storm +igt@kms_chamelium@hdmi-hpd-storm-disable +igt@kms_chamelium@hdmi-crc-fast +igt@kms_chamelium@hdmi-edid-read +igt@kms_chamelium@hdmi-hpd +igt@kms_chamelium@hdmi-hpd-fast
tests/vc4_ci/vc4.testlist new file +35 -0
@@ -0,0 +1,35 @@ +igt@vc4_create_bo@create-bo-0 +igt@vc4_create_bo@create-bo-4096 +igt@vc4_create_bo@create-bo-zeroed +igt@vc4_dmabuf_poll@poll-read-waits-until-write-done +igt@vc4_dmabuf_poll@poll-write-waits-until-write-done +igt@vc4_label_bo@set-label +igt@vc4_label_bo@set-bad-handle +igt@vc4_label_bo@set-bad-name +igt@vc4_label_bo@set-kernel-name +igt@vc4_lookup_fail@bad-color-write +igt@vc4_purgeable_bo@mark-willneed +igt@vc4_purgeable_bo@mark-purgeable +igt@vc4_purgeable_bo@mark-purgeable-twice +igt@vc4_purgeable_bo@access-purgeable-bo-mem +igt@vc4_purgeable_bo@access-purged-bo-mem +igt@vc4_purgeable_bo@mark-unpurgeable-check-retained +igt@vc4_purgeable_bo@mark-unpurgeable-purged +igt@vc4_purgeable_bo@free-purged-bo +igt@vc4_tiling@get-bad-handle +igt@vc4_tiling@set-bad-handle +igt@vc4_tiling@get-bad-flags +igt@vc4_tiling@set-bad-flags +igt@vc4_tiling@get-bad-modifier +igt@vc4_tiling@set-bad-modifier +igt@vc4_tiling@set-get +igt@vc4_tiling@get-after-free +igt@vc4_wait_bo@bad-bo +igt@vc4_wait_bo@bad-pad +igt@vc4_wait_bo@unused-bo-0ns +igt@vc4_wait_bo@unused-bo-1ns +igt@vc4_wait_bo@used-bo +igt@vc4_wait_bo@used-bo-0ns +igt@vc4_wait_bo@used-bo-1ns +igt@vc4_wait_seqno@bad-seqno-0ns +igt@vc4_wait_seqno@bad-seqno-1ns
Signature · 6 lines
2.14.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [RFC PATCH i-g-t 3/3] tests: Add vc4 test suite
Quoted 11 lines · Maxime Ripard
Add some various test suites relevant for the vc4 drm driver.
Signed-off-by Maxime Ripard <[email protected]>--- tests/vc4_ci/vc4-chamelium-fast.testlist | 4 ++++ tests/vc4_ci/vc4-chamelium.testlist | 9 ++++++++ tests/vc4_ci/vc4.testlist | 35 ++++++++++++++++++++++++++++++++ 3 files changed, 48 insertions(+) create mode 100644 tests/vc4_ci/vc4-chamelium-fast.testlist create mode 100644 tests/vc4_ci/vc4-chamelium.testlist create mode 100644 tests/vc4_ci/vc4.testlist
Can you also add a README explaining where vc4_ci results can be found (or statement for the lack of a public view) and how these testlist files are used?
No general kms tests in vc4.testlist?
What is the contact information for people who will be responsible for tests/vc4_ci?
FWIW,
Quoted 74 lines
tests/vc4_ci/vc4-chamelium-fast.testlist new file +4
-0@@ -0,0 +1,4 @@ +igt@kms_chamelium@hdmi-crc-fast +igt@kms_chamelium@hdmi-edid-read +igt@kms_chamelium@hdmi-hpd +igt@kms_chamelium@hdmi-hpd-fasttests/vc4_ci/vc4-chamelium.testlist new file +9
-0@@ -0,0 +1,9 @@ +igt@kms_chamelium@hdmi-crc-single +igt@kms_chamelium@hdmi-crc-multiple +igt@kms_chamelium@hdmi-frame-dump +igt@kms_chamelium@hdmi-hpd-storm +igt@kms_chamelium@hdmi-hpd-storm-disable +igt@kms_chamelium@hdmi-crc-fast +igt@kms_chamelium@hdmi-edid-read +igt@kms_chamelium@hdmi-hpd +igt@kms_chamelium@hdmi-hpd-fasttests/vc4_ci/vc4.testlist new file +35
-0@@ -0,0 +1,35 @@ +igt@vc4_create_bo@create-bo-0 +igt@vc4_create_bo@create-bo-4096 +igt@vc4_create_bo@create-bo-zeroed +igt@vc4_dmabuf_poll@poll-read-waits-until-write-done +igt@vc4_dmabuf_poll@poll-write-waits-until-write-done +igt@vc4_label_bo@set-label +igt@vc4_label_bo@set-bad-handle +igt@vc4_label_bo@set-bad-name +igt@vc4_label_bo@set-kernel-name +igt@vc4_lookup_fail@bad-color-write +igt@vc4_purgeable_bo@mark-willneed +igt@vc4_purgeable_bo@mark-purgeable +igt@vc4_purgeable_bo@mark-purgeable-twice +igt@vc4_purgeable_bo@access-purgeable-bo-mem +igt@vc4_purgeable_bo@access-purged-bo-mem +igt@vc4_purgeable_bo@mark-unpurgeable-check-retained +igt@vc4_purgeable_bo@mark-unpurgeable-purged +igt@vc4_purgeable_bo@free-purged-bo +igt@vc4_tiling@get-bad-handle +igt@vc4_tiling@set-bad-handle +igt@vc4_tiling@get-bad-flags +igt@vc4_tiling@set-bad-flags +igt@vc4_tiling@get-bad-modifier +igt@vc4_tiling@set-bad-modifier +igt@vc4_tiling@set-get +igt@vc4_tiling@get-after-free +igt@vc4_wait_bo@bad-bo +igt@vc4_wait_bo@bad-pad +igt@vc4_wait_bo@unused-bo-0ns +igt@vc4_wait_bo@unused-bo-1ns +igt@vc4_wait_bo@used-bo +igt@vc4_wait_bo@used-bo-0ns +igt@vc4_wait_bo@used-bo-1ns +igt@vc4_wait_seqno@bad-seqno-0ns +igt@vc4_wait_seqno@bad-seqno-1nsSignature · 6 lines
2.14.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [RFC PATCH i-g-t 3/3] tests: Add vc4 test suite
Hi,
Quoted 13 lines · Petri Latvala
Quoted 11 lines · Maxime Ripard
Add some various test suites relevant for the vc4 drm driver.
Signed-off-by Maxime Ripard <[email protected]>--- tests/vc4_ci/vc4-chamelium-fast.testlist | 4 ++++ tests/vc4_ci/vc4-chamelium.testlist | 9 ++++++++ tests/vc4_ci/vc4.testlist | 35 ++++++++++++++++++++++++++++++++ 3 files changed, 48 insertions(+) create mode 100644 tests/vc4_ci/vc4-chamelium-fast.testlist create mode 100644 tests/vc4_ci/vc4-chamelium.testlist create mode 100644 tests/vc4_ci/vc4.testlist
Quoted 3 lines
Can you also add a README explaining where
vc4_ciresults can be found (or statement for the lack of a public view) and how these testlist files are used?
There isn't any publicly visible CI plan at the moment (that I know of). This patch was more to get a list of meaningful tests into the tree so that the various people involved could share the tests run for now at least. I'm not sure what the policy is for that to be honest.
Quoted 4 lines
No general kms tests in vc4.testlist?
What is the contact information for people who will be responsible for tests/vc4_ci?
Eric? I guess that would be you?
Maxime
Signature · 3 lines
Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [RFC PATCH i-g-t 3/3] tests: Add vc4 test suite
Quoted 16 lines · Maxime Ripard
Hi,
Quoted 13 lines · Petri Latvala
Quoted 11 lines · Maxime Ripard
Add some various test suites relevant for the vc4 drm driver.
Signed-off-by Maxime Ripard <[email protected]>--- tests/vc4_ci/vc4-chamelium-fast.testlist | 4 ++++ tests/vc4_ci/vc4-chamelium.testlist | 9 ++++++++ tests/vc4_ci/vc4.testlist | 35 ++++++++++++++++++++++++++++++++ 3 files changed, 48 insertions(+) create mode 100644 tests/vc4_ci/vc4-chamelium-fast.testlist create mode 100644 tests/vc4_ci/vc4-chamelium.testlist create mode 100644 tests/vc4_ci/vc4.testlist
Quoted 8 lines
Quoted 3 lines
Can you also add a README explaining where
vc4_ciresults can be found (or statement for the lack of a public view) and how these testlist files are used?There isn't any publicly visible CI plan at the moment (that I know of). This patch was more to get a list of meaningful tests into the tree so that the various people involved could share the tests run for now at least. I'm not sure what the policy is for that to be honest.
From IGT's side the policy is that the people who need such a directory will set it up and it becomes their turf, in both directions. Their responsibility to maintain, and their ack is required for changes.
Signature · 5 lines
Petri Latvala _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [RFC PATCH i-g-t 3/3] tests: Add vc4 test suite
Hi,
Quoted 26 lines · Petri Latvala
Quoted 16 lines · Maxime Ripard
Hi,
Quoted 13 lines · Petri Latvala
Quoted 11 lines · Maxime Ripard
Add some various test suites relevant for the vc4 drm driver.
Signed-off-by Maxime Ripard <[email protected]>--- tests/vc4_ci/vc4-chamelium-fast.testlist | 4 ++++ tests/vc4_ci/vc4-chamelium.testlist | 9 ++++++++ tests/vc4_ci/vc4.testlist | 35 ++++++++++++++++++++++++++++++++ 3 files changed, 48 insertions(+) create mode 100644 tests/vc4_ci/vc4-chamelium-fast.testlist create mode 100644 tests/vc4_ci/vc4-chamelium.testlist create mode 100644 tests/vc4_ci/vc4.testlistQuoted 8 lines
Quoted 3 lines
Can you also add a README explaining where
vc4_ciresults can be found (or statement for the lack of a public view) and how these testlist files are used?There isn't any publicly visible CI plan at the moment (that I know of). This patch was more to get a list of meaningful tests into the tree so that the various people involved could share the tests run for now at least. I'm not sure what the policy is for that to be honest.
Quoted 4 lines
From IGT's side the policy is that the people who need such a directory will set it up and it becomes their turf, in both directions. Their responsibility to maintain, and their ack is required for changes.
Ok, so I guess it would become mostly Eric's garden then :)
Eric, are you ok with such a test suite?
Maxime
Signature · 7 lines
Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for Test the plane formats on the Chamelium
In reply to Maxime Ripard== Series Details ==
== Series Details ==
Series: Test the plane formats on the Chamelium
URL : https://patchwork.freedesktop.org/series/39380/
State : success
== Summary ==
IGT patchset tested on top of latest successful build 23f7da18a92059610792299cfdb03d2c922a9948 lib/igt_pm: Restore runtime pm state on test exit
with latest DRM-Tip kernel build CI_DRM_38724a3784737699 drm-tip: 2018y-03m-05d-14h-32m-57s UTC integration manifest
Testlist changes:
+igt@kms_chamelium_formats@hdmi-frame-dump
---- Known issues:
Test gem_mmap_gtt:
Subgroup basic-small-bo-tiledx:
pass -> FAIL (fi-gdg-551) fdo#102575
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> INCOMPLETE (fi-snb-2520m) fdo#103713
Test prime_vgem:
Subgroup basic-fence-flip:
fail -> PASS (fi-ilk-650) fdo#104008fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:416s fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:423s fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:373s fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:484s fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:279s fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:485s fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:487s fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:470s fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:463s fi-cfl-8700k total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:394s fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:563s fi-cfl-u total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:493s fi-cnl-y3 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:572s fi-elk-e7500 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:414s fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:293s fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:506s fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:392s fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:414s fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:449s fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:410s fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:451s fi-kbl-7560u total:108 pass:104 dwarn:0 dfail:0 fail:0 skip:3 fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:452s fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:494s fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:581s fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:428s fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:504s fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:521s fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:491s fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:493s fi-skl-guc total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:406s fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:431s fi-snb-2520m total:245 pass:211 dwarn:0 dfail:0 fail:0 skip:33 fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:394s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1061/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: warning for Test the plane formats on the Chamelium
In reply to Maxime Ripard== Series Details ==
== Series Details ==
Series: Test the plane formats on the Chamelium
URL : https://patchwork.freedesktop.org/series/39380/
State : warning
== Summary ==
---- Possible new issues:
Test gem_exec_blt:
Subgroup cold-max:
pass -> DMESG-WARN (shard-hsw)
Test kms_flip:
Subgroup flip-vs-modeset-interruptible:
pass -> DMESG-WARN (shard-hsw)
Test kms_vblank:
Subgroup pipe-a-ts-continuation-modeset:
skip -> PASS (shard-snb)---- Known issues:
Test gem_eio:
Subgroup in-flight-contexts:
pass -> INCOMPLETE (shard-apl) fdo#104945
Test kms_chv_cursor_fail:
Subgroup pipe-b-256x256-right-edge:
dmesg-warn -> PASS (shard-snb) fdo#105185
Test kms_cursor_legacy:
Subgroup flip-vs-cursor-atomic:
skip -> PASS (shard-snb) fdo#102670
Test kms_flip:
Subgroup dpms-vs-vblank-race:
fail -> PASS (shard-hsw) fdo#103060
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-primscrn-spr-indfb-draw-render:
pass -> DMESG-FAIL (shard-hsw) fdo#103167fdo#104945 https://bugs.freedesktop.org/show_bug.cgi?id=104945
fdo#105185 https://bugs.freedesktop.org/show_bug.cgi?id=105185
fdo#102670 https://bugs.freedesktop.org/show_bug.cgi?id=102670
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
shard-apl total:3424 pass:1802 dwarn:1 dfail:0 fail:7 skip:1612 time:11586s shard-hsw total:3469 pass:1771 dwarn:3 dfail:1 fail:1 skip:1692 time:11814s shard-snb total:3469 pass:1365 dwarn:1 dfail:0 fail:1 skip:2102 time:7171s
Blacklisted hosts:
shard-kbl total:3424 pass:1928 dwarn:1 dfail:0 fail:7 skip:1487 time:8867s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1061/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hi,
Quoted 38 lines · Maxime Ripard
Here is an RFC at starting to test the plane formats using the Chamelium over the HDMI. This was tested using the vc4 DRM driver found on the RaspberryPi.
This is still pretty rough around the edges at this point, but I'd like to get feedback on a few issues before getting any further.
* I've used pixman for now to convert back and forth the pattern and the captured frame. While this worked quite well for the RGB formats since pixman supports most (but not all) of them. However, the long term plan is to also test YUV and more exotic (like vendor specific) formats that pixman has 0 support for. So I really wonder whether this is the right approach compared to:
- Using something else (but what?)?
- Rolling our own format conversion library?* I've so far had a single big test that will test all the formats exposed by the planes that have a pixman representation. I wonder whether this is preferrable, or if we want to have a subtest per format. I guess the latter will be slightly better since we would be able to catch regressions in the number of formats exposed that we wouldn't be able to with the former.
* Kind of related, I'm not sure what is the policy when it comes to tests, and whether I should merge this tests with
kms_chameliumor leave it as a separate file.* One of the biggest challenge of the serie is to support formats that have less bits than the reference frame. Indeed, the flow of patterns is this one: the pattern will first be generated in ARGB8888. It will then be converted to whatever format we want to test, be fed into the display engine, that will output it, and the Chamelium will capture it in ARGB8888.
However, when the plane format has less than 8 bits per color, some upsampling will happen, where the less significant bits will be filled with values that probably depend on the display engine. Another side effect is that the CRC used in the Chamelium tests cannot be used anymore.
Quoted 8 lines
The way I'm testing currently is that I'm retrieving the frame, and then compare each pixels on their most significant bits. This sounds inefficient, and it is, especially on the RPi that doesn't have the best networking throughput out there.
I guess we could also generate a CRC for both an upsampling with the lowest bits set to 1, and one for the lowest bits set to 0, and try to see if one of them match. I guess this should cover most of the situation.
Any comments on these points?
Maxime
Signature · 3 lines
Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 19 lines · Maxime Ripard
[ Unknown signature status ]
Hi,Quoted 15 lines · Maxime Ripard
Here is an RFC at starting to test the plane formats using the Chamelium over the HDMI. This was tested using the vc4 DRM driver found on the RaspberryPi.
This is still pretty rough around the edges at this point, but I'd like to get feedback on a few issues before getting any further.
* I've used pixman for now to convert back and forth the pattern and the captured frame. While this worked quite well for the RGB formats since pixman supports most (but not all) of them. However, the long term plan is to also test YUV and more exotic (like vendor specific) formats that pixman has 0 support for. So I really wonder whether this is the right approach compared to:
- Using something else (but what?)?
- Rolling our own format conversion library?
Let's start with pixman and either extend pixman if we have formats we need (they should be pretty amenable for non-yuv channel layouts), or roll our own YUV bits. For tiling, I think we can just take pixman-generated linear image content and do the tiling in igt.
Quoted 6 lines
Quoted 6 lines
* I've so far had a single big test that will test all the formats exposed by the planes that have a pixman representation. I wonder whether this is preferrable, or if we want to have a subtest per format. I guess the latter will be slightly better since we would be able to catch regressions in the number of formats exposed that we wouldn't be able to with the former.
Yeah, exposing the formats as subtests is probably a good idea.
Quoted 3 lines
Quoted 3 lines
* Kind of related, I'm not sure what is the policy when it comes to tests, and whether I should merge this tests with
kms_chameliumor leave it as a separate file.
I'll leave this up to the original test author.
Quoted 11 lines
Quoted 11 lines
* One of the biggest challenge of the serie is to support formats that have less bits than the reference frame. Indeed, the flow of patterns is this one: the pattern will first be generated in ARGB8888. It will then be converted to whatever format we want to test, be fed into the display engine, that will output it, and the Chamelium will capture it in ARGB8888.
However, when the plane format has less than 8 bits per color, some upsampling will happen, where the less significant bits will be filled with values that probably depend on the display engine. Another side effect is that the CRC used in the Chamelium tests cannot be used anymore.
Quoted 8 lines
Quoted 8 lines
The way I'm testing currently is that I'm retrieving the frame, and then compare each pixels on their most significant bits. This sounds inefficient, and it is, especially on the RPi that doesn't have the best networking throughput out there.
I guess we could also generate a CRC for both an upsampling with the lowest bits set to 1, and one for the lowest bits set to 0, and try to see if one of them match. I guess this should cover most of the situation.
I still think that we should expect the top bits to be replicated into the low bits, until we find hardware that just can't do that.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hi Eric,
Thanks for your input.
Quoted 22 lines · Eric Anholt
Quoted 19 lines · Maxime Ripard
[ Unknown signature status ]
Hi,Quoted 15 lines · Maxime Ripard
Here is an RFC at starting to test the plane formats using the Chamelium over the HDMI. This was tested using the vc4 DRM driver found on the RaspberryPi.
This is still pretty rough around the edges at this point, but I'd like to get feedback on a few issues before getting any further.
* I've used pixman for now to convert back and forth the pattern and the captured frame. While this worked quite well for the RGB formats since pixman supports most (but not all) of them. However, the long term plan is to also test YUV and more exotic (like vendor specific) formats that pixman has 0 support for. So I really wonder whether this is the right approach compared to:
- Using something else (but what?)?
- Rolling our own format conversion library?
Quoted 4 lines
Let's start with pixman and either extend pixman if we have formats we need (they should be pretty amenable for non-yuv channel layouts), or roll our own YUV bits. For tiling, I think we can just take pixman-generated linear image content and do the tiling in igt.
Ok. I guess another alternative could be to use libv4lconvert that already has a number of rgb to yuv conversions routines. I'm not sure whether adding a new dependency is ok though.
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
* I've so far had a single big test that will test all the formats exposed by the planes that have a pixman representation. I wonder whether this is preferrable, or if we want to have a subtest per format. I guess the latter will be slightly better since we would be able to catch regressions in the number of formats exposed that we wouldn't be able to with the former.
Yeah, exposing the formats as subtests is probably a good idea.
I'll do that then.
Quoted 26 lines
Quoted 3 lines
Quoted 3 lines
* Kind of related, I'm not sure what is the policy when it comes to tests, and whether I should merge this tests with
kms_chameliumor leave it as a separate file.I'll leave this up to the original test author.
Quoted 11 lines
Quoted 11 lines
* One of the biggest challenge of the serie is to support formats that have less bits than the reference frame. Indeed, the flow of patterns is this one: the pattern will first be generated in ARGB8888. It will then be converted to whatever format we want to test, be fed into the display engine, that will output it, and the Chamelium will capture it in ARGB8888.
However, when the plane format has less than 8 bits per color, some upsampling will happen, where the less significant bits will be filled with values that probably depend on the display engine. Another side effect is that the CRC used in the Chamelium tests cannot be used anymore.Quoted 8 lines
Quoted 8 lines
The way I'm testing currently is that I'm retrieving the frame, and then compare each pixels on their most significant bits. This sounds inefficient, and it is, especially on the RPi that doesn't have the best networking throughput out there.
I guess we could also generate a CRC for both an upsampling with the lowest bits set to 1, and one for the lowest bits set to 0, and try to see if one of them match. I guess this should cover most of the situation.
Quoted 2 lines
I still think that we should expect the top bits to be replicated into the low bits, until we find hardware that just can't do that.
That works for me then.
I'll try to have all these changes, and send a new version then.
Thanks!
Maxime
Signature · 3 lines
Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx