Skip to contentSkip to conversation

Bluetooth: Set HCI_QUIRK_SIMULTANEOUS_DISCOVERY for BTUSB_QCA_ROME

PATCH In review Vic Wei 3 participants 4 messages Mar 21, 2018

Subsystems (3)
lore
Share & tools
lore

Vic Wei

author
#0 lore raw

PATCH 1/1 Bluetooth: Set HCI_QUIRK_SIMULTANEOUS_DISCOVERY for BTUSB_QCA_ROME

QCA Rome controllers can do both LE scan and BR/EDR inquiry at once.

Change-Id I89e1412d635f4cd7b2500f7492f37430ea139f0c
---
 drivers/bluetooth/btusb.c | 1 +
 1 file changed, 1 insertion(+)
drivers/bluetooth/btusb.c +1 -0
index 60bf04b..b94ff37 100644
@@ -3050,6 +3050,7 @@ static int btusb_probe(struct usb_interface *intf,
 	if (id->driver_info & BTUSB_QCA_ROME) {
 		data->setup_on_usb = btusb_setup_qca;
 		hdev->set_bdaddr = btusb_set_bdaddr_ath3012;
+		set_bit(HCI_QUIRK_SIMULTANEOUS_DISCOVERY, &hdev->quirks);
 	}
 
 #ifdef CONFIG_BT_HCIBTUSB_RTL
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 3 lines · Vic Wei

QCA Rome controllers can do both LE scan and BR/EDR inquiry at once.

Change-Id: I89e1412d635f4cd7b2500f7492f37430ea139f0c

What is this line for?

Quoted 4 lines
---
 drivers/bluetooth/btusb.c | 1 +
 1 file changed, 1 insertion(+)

<formletter>

This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

#2 lore raw
Quoted 6 lines · Greg KH
Quoted 3 lines · Vic Wei

QCA Rome controllers can do both LE scan and BR/EDR inquiry at once.

Change-Id: I89e1412d635f4cd7b2500f7492f37430ea139f0c

What is this line for?

That's the Change ID required by everything that goes through Gerrit. CAF (I'm assuming Vic is from CodeAurora Forums judging by the email) uses Gerrit as their review platform for the Android for MSM project.

maintainer
#3 lore raw
Quoted 11 lines · Harsh Shandilya
Quoted 6 lines · Greg KH
Quoted 3 lines · Vic Wei

QCA Rome controllers can do both LE scan and BR/EDR inquiry at once.

Change-Id: I89e1412d635f4cd7b2500f7492f37430ea139f0c

What is this line for?

That's the Change ID required by everything that goes through Gerrit. CAF (I'm assuming Vic is from CodeAurora Forums judging by the email) uses Gerrit as their review platform for the Android for MSM project.

It was a rhetorical question, I know what it is, and the fact that it should not be in a kernel patch submission, I wanted the submitter to learn to read their own patches _before_ they send them in.

Also, if they used checkpatch.pl, it would have told them to remove this.

It's like saying to a kid, "what is this mess on the floor"...

greg k-h