Skip to contentSkip to conversation

configs: k2g_hs_evm: Resync defconfig with non-HS defconfig

PATCH New Andrew F. Davis 3 participants 9 messages Mar 22, 2018 – Apr 7, 2018

lore
Share & tools
lore

Andrew F. Davis

author
#0 lore raw

PATCH 1/3 configs: k2g_hs_evm: Resync defconfig with non-HS defconfig

Signed-off-by Andrew F. Davis <[email protected]>
---
 configs/k2g_hs_evm_defconfig | 4 ++++
 1 file changed, 4 insertions(+)
configs/k2g_hs_evm_defconfig +4 -0
index 5402cd3214..b0c0e08584 100644
@@ -11,6 +11,7 @@ CONFIG_OF_BOARD_SETUP=y
 # CONFIG_USE_BOOTCOMMAND is not set
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_VERSION_VARIABLE=y
+CONFIG_BOARD_EARLY_INIT_F=y
 # CONFIG_CMD_FLASH is not set
 # CONFIG_CMD_GPIO is not set
 # CONFIG_CMD_GPT is not set

@@ -20,6 +21,9 @@ CONFIG_MTDIDS_DEFAULT="nand0=davinci_nand.0"
 CONFIG_MTDPARTS_DEFAULT="mtdparts=davinci_nand.0:1024k(bootloader)ro,512k(params)ro,-(ubifs)"
 CONFIG_CMD_UBI=y
 CONFIG_OF_CONTROL=y
+CONFIG_OF_LIST="keystone-k2g-generic keystone-k2g-evm keystone-k2g-ice"
+CONFIG_DTB_RESELECT=y
+CONFIG_MULTI_DTB_FIT=y
 CONFIG_DM=y
 # CONFIG_BLK is not set
 CONFIG_DM_MMC=y
Signature · 1 line
2.16.2
author
#1 lore raw

PATCH 2/3 configs: k2e_hs_evm: Resync defconfig with non-HS defconfig

Signed-off-by Andrew F. Davis <[email protected]>
---
 configs/k2e_hs_evm_defconfig | 3 +++
 1 file changed, 3 insertions(+)
configs/k2e_hs_evm_defconfig +3 -0
index a79ce6060f..6224222129 100644
@@ -11,6 +11,7 @@ CONFIG_OF_BOARD_SETUP=y
 # CONFIG_USE_BOOTCOMMAND is not set
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_VERSION_VARIABLE=y
+CONFIG_BOARD_EARLY_INIT_F=y
 # CONFIG_CMD_FLASH is not set
 # CONFIG_CMD_GPIO is not set
 # CONFIG_CMD_GPT is not set

@@ -21,6 +22,8 @@ CONFIG_MTDIDS_DEFAULT="nand0=davinci_nand.0"
 CONFIG_MTDPARTS_DEFAULT="mtdparts=davinci_nand.0:1024k(bootloader)ro,512k(params)ro,-(ubifs)"
 CONFIG_CMD_UBI=y
 CONFIG_OF_CONTROL=y
+CONFIG_DTB_RESELECT=y
+CONFIG_MULTI_DTB_FIT=y
 CONFIG_ENV_IS_IN_NAND=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_DM=y
Signature · 1 line
2.16.2
#2 lore raw

PATCH 2/3 configs: k2e_hs_evm: Resync defconfig with non-HS defconfig

Quoted 1 line · Andrew F. Davis
Signed-off-by Andrew F. Davis <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180407/cf7d0ab2/attachment.sig>
author
#3 lore raw

PATCH 3/3 configs: k2hk_hs_evm: Resync defconfig with non-HS defconfig

In reply to Andrew F. Davis
Signed-off-by Andrew F. Davis <[email protected]>
---
 configs/k2hk_hs_evm_defconfig | 3 +++
 1 file changed, 3 insertions(+)
configs/k2hk_hs_evm_defconfig +3 -0
index 09ac21e8f3..1cca0caef8 100644
@@ -11,6 +11,7 @@ CONFIG_OF_BOARD_SETUP=y
 # CONFIG_USE_BOOTCOMMAND is not set
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_VERSION_VARIABLE=y
+CONFIG_BOARD_EARLY_INIT_F=y
 # CONFIG_CMD_FLASH is not set
 # CONFIG_CMD_GPIO is not set
 # CONFIG_CMD_GPT is not set

@@ -21,6 +22,8 @@ CONFIG_MTDIDS_DEFAULT="nand0=davinci_nand.0"
 CONFIG_MTDPARTS_DEFAULT="mtdparts=davinci_nand.0:1024k(bootloader)ro,512k(params)ro,-(ubifs)"
 CONFIG_CMD_UBI=y
 CONFIG_OF_CONTROL=y
+CONFIG_DTB_RESELECT=y
+CONFIG_MULTI_DTB_FIT=y
 CONFIG_ENV_IS_IN_NAND=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_DM=y
Signature · 1 line
2.16.2
#4 lore raw

PATCH 3/3 configs: k2hk_hs_evm: Resync defconfig with non-HS defconfig

Quoted 18 lines · Andrew F. Davis
Signed-off-by Andrew F. Davis <[email protected]>
---
 configs/k2hk_hs_evm_defconfig | 3 +++
 1 file changed, 3 insertions(+)
configs/k2hk_hs_evm_defconfig +1 -0
index 09ac21e8f3..1cca0caef8 100644
@@ -11,6 +11,7 @@ CONFIG_OF_BOARD_SETUP=y
 # CONFIG_USE_BOOTCOMMAND is not set
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_VERSION_VARIABLE=y
+CONFIG_BOARD_EARLY_INIT_F=y
 # CONFIG_CMD_FLASH is not set
 # CONFIG_CMD_GPIO is not set
 # CONFIG_CMD_GPT is not set

configs/k2hk_hs_evm_defconfig CONFIG_MTDIDS_DEFAULT="nand0=davinci_nand.0" · line 26

Quoted 5 lines
configs/k2hk_hs_evm_defconfig +2 -0
@@ -21,6 +22,8 @@ CONFIG_MTDIDS_DEFAULT="nand0=davinci_nand.0"
 CONFIG_MTDPARTS_DEFAULT="mtdparts=davinci_nand.0:1024k(bootloader)ro,512k(params)ro,-(ubifs)"
 CONFIG_CMD_UBI=y
 CONFIG_OF_CONTROL=y
+CONFIG_DTB_RESELECT=y
+CONFIG_MULTI_DTB_FIT=y

I understand you just synced with gp defconfig, but wondering why we require DTB_RESELECT for k2hk? If not required we should probably disable it in gp as well.

Thanks and regards,
Lokesh

Quoted 4 lines
configs/k2hk_hs_evm_defconfig +0 -0
 CONFIG_ENV_IS_IN_NAND=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_DM=y
author
#5 lore raw

PATCH 3/3 configs: k2hk_hs_evm: Resync defconfig with non-HS defconfig

Quoted 22 lines · Lokesh Vutla
Quoted 19 lines · Andrew F. Davis
Signed-off-by Andrew F. Davis <[email protected]>
---
 configs/k2hk_hs_evm_defconfig | 3 +++
 1 file changed, 3 insertions(+)
configs/k2hk_hs_evm_defconfig +1 -0
index 09ac21e8f3..1cca0caef8 100644
@@ -11,6 +11,7 @@ CONFIG_OF_BOARD_SETUP=y
 # CONFIG_USE_BOOTCOMMAND is not set
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_VERSION_VARIABLE=y
+CONFIG_BOARD_EARLY_INIT_F=y
 # CONFIG_CMD_FLASH is not set
 # CONFIG_CMD_GPIO is not set
 # CONFIG_CMD_GPT is not set

@@ -21,6 +22,8 @@ CONFIG_MTDIDS_DEFAULT="nand0=davinci_nand.0"
 CONFIG_MTDPARTS_DEFAULT="mtdparts=davinci_nand.0:1024k(bootloader)ro,512k(params)ro,-(ubifs)"
Quoted 9 lines

configs/k2hk_hs_evm_defconfig CONFIG_MTDIDS_DEFAULT="nand0=davinci_nand.0" · line 26

Quoted 4 lines
configs/k2hk_hs_evm_defconfig +2 -0
 CONFIG_CMD_UBI=y
 CONFIG_OF_CONTROL=y
+CONFIG_DTB_RESELECT=y
+CONFIG_MULTI_DTB_FIT=y

I understand you just synced with gp defconfig, but wondering why we require DTB_RESELECT for k2hk? If not required we should probably disable it in gp as well.

I'm not sure if it is needed either, but I'm not sure which one of these fixed the boot issue, so as you noticed I just did a full sync and the board started booting again.

If that config is removed for GP it should be removed for HS, I'll check for any further breaks later, but so far what works for GP works for HS.

If I didn't have plans for merging the GP and HS configs at some point I would say defconfig fragments for U-Boot would be something to look into..

Thanks,
Andrew

Quoted 7 lines

Thanks and regards,
Lokesh

Quoted 4 lines
configs/k2hk_hs_evm_defconfig +0 -0
 CONFIG_ENV_IS_IN_NAND=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_DM=y
#6 lore raw

PATCH 3/3 configs: k2hk_hs_evm: Resync defconfig with non-HS defconfig

Quoted 34 lines · Andrew F. Davis
Quoted 22 lines · Lokesh Vutla
Quoted 19 lines · Andrew F. Davis
Signed-off-by Andrew F. Davis <[email protected]>
---
 configs/k2hk_hs_evm_defconfig | 3 +++
 1 file changed, 3 insertions(+)
configs/k2hk_hs_evm_defconfig +1 -0
index 09ac21e8f3..1cca0caef8 100644
@@ -11,6 +11,7 @@ CONFIG_OF_BOARD_SETUP=y
 # CONFIG_USE_BOOTCOMMAND is not set
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_VERSION_VARIABLE=y
+CONFIG_BOARD_EARLY_INIT_F=y
 # CONFIG_CMD_FLASH is not set
 # CONFIG_CMD_GPIO is not set
 # CONFIG_CMD_GPT is not set

@@ -21,6 +22,8 @@ CONFIG_MTDIDS_DEFAULT="nand0=davinci_nand.0"
 CONFIG_MTDPARTS_DEFAULT="mtdparts=davinci_nand.0:1024k(bootloader)ro,512k(params)ro,-(ubifs)"
Quoted 9 lines

configs/k2hk_hs_evm_defconfig CONFIG_MTDIDS_DEFAULT="nand0=davinci_nand.0" · line 26

Quoted 4 lines
configs/k2hk_hs_evm_defconfig +2 -0
 CONFIG_CMD_UBI=y
 CONFIG_OF_CONTROL=y
+CONFIG_DTB_RESELECT=y
+CONFIG_MULTI_DTB_FIT=y

I understand you just synced with gp defconfig, but wondering why we require DTB_RESELECT for k2hk? If not required we should probably disable it in gp as well.

Quoted 3 lines

I'm not sure if it is needed either, but I'm not sure which one of these fixed the boot issue, so as you noticed I just did a full sync and the board started booting again.

commit 3107696784d59 ("defconfig: keystone2: Enable U-boot runtime DTB detection") enabled these configs. Looks like it is enforced to use RESELECT on all K2 platforms.

For the entire series:

Reviewed-by Lokesh vutla <[email protected]>

Thanks and regards,
Lokesh

Quoted 18 lines

If that config is removed for GP it should be removed for HS, I'll check for any further breaks later, but so far what works for GP works for HS.

If I didn't have plans for merging the GP and HS configs at some point I would say defconfig fragments for U-Boot would be something to look into..

Thanks,
Andrew

Quoted 7 lines

Thanks and regards,
Lokesh

Quoted 4 lines
configs/k2hk_hs_evm_defconfig +0 -0
 CONFIG_ENV_IS_IN_NAND=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_DM=y
#7 lore raw

PATCH 3/3 configs: k2hk_hs_evm: Resync defconfig with non-HS defconfig

In reply to Andrew F. Davis
Quoted 2 lines · Andrew F. Davis
Signed-off-by Andrew F. Davis <[email protected]>
Reviewed-by Lokesh vutla <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180407/79026f80/attachment.sig>
#8 lore raw

PATCH 1/3 configs: k2g_hs_evm: Resync defconfig with non-HS defconfig

In reply to Andrew F. Davis
Quoted 1 line · Andrew F. Davis
Signed-off-by Andrew F. Davis <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180407/7cf3e8ac/attachment.sig>