Skip to contentSkip to conversation

libxml-simple-perl: upgrade 2.24 -> 2.25

PATCH Superseded Tim Orling 2 participants 3 messages Mar 23, 2018

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Tim Orling

author
#0 lore raw

PATCH 1/2 libxml-simple-perl: upgrade 2.24 -> 2.25

* Fix RDEPENDS

Upstream release notes:
2.25 2018-03-18 16:18:24+13:00 Pacific/Auckland
- disable entity expansion when using XML::Parser, for more secure default behaviour (patch from Ray Morris)
- call to XML::Parser constructor is now in its own method to ease overriding

License-Update: update year to 2018

---
 ...l-simple-perl_2.24.bb => libxml-simple-perl_2.25.bb} | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)
 rename meta/recipes-devtools/perl/{libxml-simple-perl_2.24.bb => libxml-simple-perl_2.25.bb} (65%)
meta/recipes-devtools/perl/libxml-simple-perl_2.25.bb renamed from meta/recipes-devtools/perl/libxml-simple-perl_2.24.bb +14 -3
similarity index 65%
rename from meta/recipes-devtools/perl/libxml-simple-perl_2.24.bb
rename to meta/recipes-devtools/perl/libxml-simple-perl_2.25.bb
index f9d00d2e28..53788d5585 100644
@@ -7,13 +7,13 @@ where the original uses plain Perl or SAX parsers."
 HOMEPAGE = "http://search.cpan.org/~markov/XML-LibXML-Simple-0.93/lib/XML/LibXML/Simple.pod"
 SECTION = "libs"
 LICENSE = "Artistic-1.0 | GPL-1.0+"
-LIC_FILES_CHKSUM = "file://LICENSE;md5=23477e18a0d04392cdf44ae70e49b495"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=cf206df8c9fe775f1d4c484386491eac"
 DEPENDS += "libxml-parser-perl"
 
 SRC_URI = "http://www.cpan.org/modules/by-module/XML/XML-Simple-${PV}.tar.gz"
 
-SRC_URI[md5sum] = "1cd2e8e3421160c42277523d5b2f4dd2"
-SRC_URI[sha256sum] = "9a14819fd17c75fbb90adcec0446ceab356cab0ccaff870f2e1659205dc2424f"
+SRC_URI[md5sum] = "bb841dce889a26c89a1c2739970e9fbc"
+SRC_URI[sha256sum] = "531fddaebea2416743eb5c4fdfab028f502123d9a220405a4100e68fc480dbf8"
 
 S = "${WORKDIR}/XML-Simple-${PV}"
 
@@ -21,4 +21,15 @@ EXTRA_PERLFLAGS = "-I ${PERLHOSTLIB}"
 
 inherit cpan ptest-perl
 
+RDEPENDS_${PN} += " \
+    libxml-namespacesupport-perl \
+    libxml-parser-perl \
+    libxml-sax-perl \
+"
+
+RDEPENDS_${PN}-ptest += " \
+    perl-module-file-temp \
+    perl-module-test-more \
+"
+
 BBCLASSEXTEND = "native"
Signature · 1 line
2.14.3
author
#1 lore raw

PATCH 2/2 libxml-namespacesupport: use stable v1.12 release; inherit ptest-perl

* Fix RDEPENDS
* Upstream v1.12_9 is a development version, not a stable release
* Add UPSTREAM_CHECK_REGEX skip development releases
* Drop anonymous python function to "fix" version, which breaks auto-upgrade-helper (AUH)
* Use LICENSE file for checksum rather than ephemeral META.yml
* License remains the same

Fixes [YOCTO #12581]

License-Update: use LICENSE file for checksum

---
 .../perl/libxml-namespacesupport-perl_1.12.9.bb    | 35 ----------------------
 .../perl/libxml-namespacesupport-perl_1.12.bb      | 27 +++++++++++++++++
 2 files changed, 27 insertions(+), 35 deletions(-)
 delete mode 100644 meta/recipes-extended/perl/libxml-namespacesupport-perl_1.12.9.bb
 create mode 100644 meta/recipes-extended/perl/libxml-namespacesupport-perl_1.12.bb
meta/recipes-extended/perl/libxml-namespacesupport-perl_1.12.9.bb deleted +0 -35
deleted file mode 100644
index a7d26ea38c..0000000000
@@ -1,35 +0,0 @@
-SUMMARY = "Perl module for supporting simple generic namespaces"
-HOMEPAGE = "http://veillard.com/XML/"
-DESCRIPTION = "XML::NamespaceSupport offers a simple way to process namespace-based XML names. \
-                It also helps maintain a prefix-to-namespace URI map, and provides a number of \
-                basic checks. "
-
-SECTION = "libs"
-LICENSE = "Artistic-1.0 | GPL-1.0+"
-PR = "r3"
-
-LIC_FILES_CHKSUM = "file://META.yml;beginline=22;endline=22;md5=9ca1a4a941496e7feedac72c4fb8b137"
-
-# the upstream project complicate a bit url generartion on point release, using a underscore
-# instead of a point on URL, i.e 1.12_9 instead of 1.12.9
-python () {
-    baseurl = "http://search.cpan.org/CPAN/authors/id/P/PE/PERIGRIN/XML-NamespaceSupport"
-    pv = d.getVar('PV')
-    pvsplit = pv.split('.')
-
-    if len(pvsplit) != 3:
-        d.setVar('SRC_URI', "%s-%s.tar.gz" % (baseurl, pv))
-        d.setVar('S', "${WORKDIR}/XML-NamespaceSupport-${PV}")
-    else:
-        pvx, pvy, pvz = pvsplit
-        d.setVar('SRC_URI', "%s-%s.%s_%s.tar.gz" % (baseurl, pvx, pvy, pvz))
-        d.setVar('S', "${WORKDIR}/XML-NamespaceSupport-%s.%s_%s" % (pvx, pvy, pvz))
-}
-
-SRC_URI[md5sum] = "165927a311fb640961b28607035beab8"
-SRC_URI[sha256sum] = "2e84a057f0a8c845a612d212742cb94fca4fc8a433150b5721bd448f77d1e4a9"
-
-inherit cpan
-
-BBCLASSEXTEND="native"
-
meta/recipes-extended/perl/libxml-namespacesupport-perl_1.12.bb new file +27 -0
new file mode 100644
index 0000000000..fa9f9954bb
@@ -0,0 +1,27 @@
+SUMMARY = "Perl module for supporting simple generic namespaces"
+HOMEPAGE = "http://veillard.com/XML/"
+DESCRIPTION = "XML::NamespaceSupport offers a simple way to process namespace-based XML names. \
+                It also helps maintain a prefix-to-namespace URI map, and provides a number of \
+                basic checks. "
+
+SECTION = "libs"
+LICENSE = "Artistic-1.0 | GPL-1.0+"
+
+SRCNAME = "XML-NamespaceSupport"
+
+LIC_FILES_CHKSUM = "file://LICENSE;md5=c9d8a117e7620b5adf8d69c29613ceab"
+
+SRC_URI = "${CPAN_MIRROR}/authors/id/P/PE/PERIGRIN/${SRCNAME}-${PV}.tar.gz"
+SRC_URI[md5sum] = "a8916c6d095bcf073e1108af02e78c97"
+SRC_URI[sha256sum] = "47e995859f8dd0413aa3f22d350c4a62da652e854267aa0586ae544ae2bae5ef"
+
+UPSTREAM_CHECK_REGEX = "XML\-NamespaceSupport\-(?P<pver>(\d+\.\d+))(?!_\d+).tar"
+
+S = "${WORKDIR}/${SRCNAME}-${PV}"
+
+inherit cpan ptest-perl
+
+RDEPENDS_${PN}-ptest += "perl-module-test-more"
+
+BBCLASSEXTEND="native"
+
Signature · 1 line
2.14.3
#2 lore raw

✗ patchtest: failure for "libxml-simple-perl: upgrade 2...." and 1 more

In reply to Tim Orling

== Series Details ==

Series: "libxml-simple-perl: upgrade 2...." and 1 more
Revision: 1
URL : https://patchwork.openembedded.org/series/11543/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Patch            [1/2] libxml-simple-perl: upgrade 2.24 -> 2.25
 Issue             Patch is missing Signed-off-by [test_signed_off_by_presence] 
  Suggested fix    Sign off the patch (either manually or with "git commit --amend -s")

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe