Skip to contentSkip to conversation

ibmvnic: Potential NULL dereference in clean_one_tx_pool()

PATCH Applied Dan Carpenter 3 participants 3 messages Mar 23, 2018 – Mar 26, 2018

Subsystems (5)
Networking Network drivers PowerPC Kernel janitors +1 more subsystems
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 ibmvnic: Potential NULL dereference in clean_one_tx_pool()

There is an && vs || typo here, which potentially leads to a NULL dereference.

Fixes e9e1e97884b7 ("ibmvnic: Update TX pool cleaning routine")
Signed-off-by Dan Carpenter <[email protected]>
drivers/net/ethernet/ibm/ibmvnic.c +1 -1
index 5632c030811b..0389a7a52152 100644
@@ -1135,7 +1135,7 @@ static void clean_one_tx_pool(struct ibmvnic_adapter *adapter,
 	u64 tx_entries;
 	int i;
 
-	if (!tx_pool && !tx_pool->tx_buff)
+	if (!tx_pool || !tx_pool->tx_buff)
 		return;
 
 	tx_entries = tx_pool->num_buffers;
#1 lore raw
Quoted 2 lines · Dan Carpenter

There is an && vs || typo here, which potentially leads to a NULL dereference.

Thanks for catching that!

Quoted 18 lines
Fixes e9e1e97884b7 ("ibmvnic: Update TX pool cleaning routine")
Signed-off-by Dan Carpenter <[email protected]>
drivers/net/ethernet/ibm/ibmvnic.c +1 -1
index 5632c030811b..0389a7a52152 100644
@@ -1135,7 +1135,7 @@ static void clean_one_tx_pool(struct ibmvnic_adapter *adapter,
 	u64 tx_entries;
 	int i;
 
-	if (!tx_pool && !tx_pool->tx_buff)
+	if (!tx_pool || !tx_pool->tx_buff)
 		return;
 
 	tx_entries = tx_pool->num_buffers;