drm/scdc-helper: Convert errors into debug messages
Subsystems (2)
PATCH 1/1 drm/scdc-helper: Convert errors into debug messages
From: Ville Syrjälä <[email protected]>
Since we may attempt to reconfigure SCDC when the sink has already been disconnected we probably shouldn't scare the user with errors in dmesg that are 100% expected in that case. Just leave it up to the caller whether to print an error message or not, and just output debug messages from the helper itself.
--- drivers/gpu/drm/drm_scdc_helper.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/gpu/drm/drm_scdc_helper.c +5 -5
@@ -141,7 +141,7 @@ bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter) ret =drm_scdc_readb (adapter,SCDC_SCRAMBLER_STATUS , &status);if (ret <0 ) { -DRM_ERROR ("Failed to read scrambling status: %d\n" , ret); +DRM_DEBUG_KMS ("Failed to read scrambling status: %d\n" , ret);return false; }
@@ -168,7 +168,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) ret =drm_scdc_readb (adapter,SCDC_TMDS_CONFIG , &config);if (ret <0 ) { -DRM_ERROR ("Failed to read TMDS config: %d\n" , ret); +DRM_DEBUG_KMS ("Failed to read TMDS config: %d\n" , ret);return false; }
@@ -179,7 +179,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) ret =drm_scdc_writeb (adapter,SCDC_TMDS_CONFIG , config);if (ret <0 ) { -DRM_ERROR ("Failed to enable scrambling: %d\n" , ret); +DRM_DEBUG_KMS ("Failed to enable scrambling: %d\n" , ret);return false; }
@@ -223,7 +223,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set) ret =drm_scdc_readb (adapter,SCDC_TMDS_CONFIG , &config);if (ret <0 ) { -DRM_ERROR ("Failed to read TMDS config: %d\n" , ret); +DRM_DEBUG_KMS ("Failed to read TMDS config: %d\n" , ret);return false; }
@@ -234,7 +234,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set) ret =drm_scdc_writeb (adapter,SCDC_TMDS_CONFIG , config);if (ret <0 ) { -DRM_ERROR ("Failed to set TMDS clock ratio: %d\n" , ret); +DRM_DEBUG_KMS ("Failed to set TMDS clock ratio: %d\n" , ret);return false; }
Signature · 6 lines
2.16.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/scdc-helper: Convert errors into debug messages
== Series Details ==
== Series Details ==
Series: drm/scdc-helper: Convert errors into debug messages
URL : https://patchwork.freedesktop.org/series/40591/
State : success
== Summary ==
Series 40591v1 drm/scdc-helper: Convert errors into debug messages
https://patchwork.freedesktop.org/api/1.0/series/40591/revisions/1/mbox/
---- Known issues:
Test debugfs_test:
Subgroup read_all_entries:
incomplete -> PASS (fi-snb-2520m) fdo#103713 +1
Test kms_pipe_crc_basic:
Subgroup nonblocking-crc-pipe-b-frame-sequence:
pass -> FAIL (fi-skl-6770hq) fdo#103481
Test prime_vgem:
Subgroup basic-fence-flip:
fail -> PASS (fi-ilk-650) fdo#104008fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103481 https://bugs.freedesktop.org/show_bug.cgi?id=103481
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fi-bdw-5557u total:285 pass:264 dwarn:0 dfail:0 fail:0 skip:21 time:433s fi-bdw-gvtdvm total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:441s fi-blb-e6850 total:285 pass:220 dwarn:1 dfail:0 fail:0 skip:64 time:379s fi-bsw-n3050 total:285 pass:239 dwarn:0 dfail:0 fail:0 skip:46 time:542s fi-bwr-2160 total:285 pass:180 dwarn:0 dfail:0 fail:0 skip:105 time:296s fi-bxt-dsi total:285 pass:255 dwarn:0 dfail:0 fail:0 skip:30 time:515s fi-bxt-j4205 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:510s fi-byt-j1900 total:285 pass:250 dwarn:0 dfail:0 fail:0 skip:35 time:517s fi-byt-n2820 total:285 pass:246 dwarn:0 dfail:0 fail:0 skip:39 time:507s fi-cfl-8700k total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:417s fi-cfl-u total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:512s fi-cnl-y3 total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:578s fi-elk-e7500 total:285 pass:225 dwarn:1 dfail:0 fail:0 skip:59 time:426s fi-gdg-551 total:285 pass:177 dwarn:0 dfail:0 fail:0 skip:108 time:319s fi-glk-1 total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:535s fi-hsw-4770 total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:404s fi-ilk-650 total:285 pass:225 dwarn:0 dfail:0 fail:0 skip:60 time:425s fi-ivb-3520m total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:466s fi-ivb-3770 total:285 pass:252 dwarn:0 dfail:0 fail:0 skip:33 time:435s fi-kbl-7500u total:285 pass:260 dwarn:1 dfail:0 fail:0 skip:24 time:476s fi-kbl-7567u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:469s fi-kbl-r total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:514s fi-pnv-d510 total:285 pass:219 dwarn:1 dfail:0 fail:0 skip:65 time:655s fi-skl-6260u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:444s fi-skl-6600u total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:532s fi-skl-6700k2 total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:501s fi-skl-6770hq total:285 pass:264 dwarn:0 dfail:0 fail:1 skip:20 time:500s fi-skl-guc total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:431s fi-skl-gvtdvm total:285 pass:262 dwarn:0 dfail:0 fail:0 skip:23 time:448s fi-snb-2520m total:242 pass:208 dwarn:0 dfail:0 fail:0 skip:33 fi-snb-2600 total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:406s Blacklisted hosts: fi-cfl-s3 total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:576s fi-cnl-psr total:224 pass:198 dwarn:0 dfail:0 fail:1 skip:24 fi-glk-j4005 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:485s
101f8aec6229d54ff241bb46b9d7bfc92cf682e9 drm-tip: 2018y-03m-23d-17h-52m-01s UTC integration manifest 3bce9e90dc42 drm/scdc-helper: Convert errors into debug messages
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8481/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: failure for drm/scdc-helper: Convert errors into debug messages
In reply to Ville Syrjala== Series Details ==
== Series Details ==
Series: drm/scdc-helper: Convert errors into debug messages
URL : https://patchwork.freedesktop.org/series/40591/
State : failure
== Summary ==
---- Possible new issues:
Test kms_chv_cursor_fail:
Subgroup pipe-c-128x128-top-edge:
pass -> FAIL (shard-apl)---- Known issues:
Test kms_cursor_crc:
Subgroup cursor-256x256-suspend:
pass -> INCOMPLETE (shard-hsw) fdo#103375
Test kms_flip:
Subgroup 2x-plain-flip-fb-recreate-interruptible:
fail -> PASS (shard-hsw) fdo#100368 +3
Subgroup modeset-vs-vblank-race-interruptible:
pass -> FAIL (shard-hsw) fdo#103060
Test kms_sysfs_edid_timing:
warn -> PASS (shard-apl) fdo#100047fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
shard-apl total:3484 pass:1820 dwarn:1 dfail:0 fail:8 skip:1655 time:12986s shard-hsw total:3450 pass:1753 dwarn:1 dfail:0 fail:3 skip:1691 time:11281s shard-snb total:3484 pass:1363 dwarn:1 dfail:0 fail:3 skip:2117 time:7010s
Blacklisted hosts:
shard-kbl total:3484 pass:1945 dwarn:1 dfail:1 fail:9 skip:1528 time:9848s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8481/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✗ Fi.CI.IGT: failure for drm/scdc-helper: Convert errors into debug messages
Quoted 6 lines · Patchwork
== Series Details ==
Series: drm/scdc-helper: Convert errors into debug messages
URL : https://patchwork.freedesktop.org/series/40591/
State : failure
Quoted 7 lines
== Summary ==
---- Possible new issues:
Test
kms_chv_cursor_fail:Subgroup pipe-c-128x128-top-edge: pass -> FAIL (shard-apl)
Unrelated cursor crc fail
(kms_chv_cursor_fail:1617) DEBUG: Checking CRCs: [0] [1] CRC mismatch at index 0: 0x4f96bc87 != 0x70b9fd52
Quoted 28 lines
---- Known issues:
Test
kms_cursor_crc:Subgroup cursor-256x256-suspend: pass -> INCOMPLETE (shard-hsw) fdo#103375 Test kms_flip: Subgroup 2x-plain-flip-fb-recreate-interruptible: fail -> PASS (shard-hsw) fdo#100368 +3 Subgroup modeset-vs-vblank-race-interruptible: pass -> FAIL (shard-hsw) fdo#103060 Test kms_sysfs_edid_timing: warn -> PASS (shard-apl) fdo#100047fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047shard-apl total:3484 pass:1820 dwarn:1 dfail:0 fail:8 skip:1655 time:12986s shard-hsw total:3450 pass:1753 dwarn:1 dfail:0 fail:3 skip:1691 time:11281s shard-snb total:3484 pass:1363 dwarn:1 dfail:0 fail:3 skip:2117 time:7010sBlacklisted hosts:
shard-kbl total:3484 pass:1945 dwarn:1 dfail:1 fail:9 skip:1528 time:9848s== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8481/shards.html
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Regards
Shashank
Quoted 55 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
Since we may attempt to reconfigure SCDC when the sink has already been disconnected we probably shouldn't scare the user with errors in dmesg that are 100% expected in that case. Just leave it up to the caller whether to print an error message or not, and just output debug messages from the helper itself.
Cc Shashank Sharma <[email protected]>Signed-off-by Ville Syrjälä <[email protected]>--- drivers/gpu/drm/drm_scdc_helper.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)drivers/gpu/drm/drm_scdc_helper.c +4
-4@@ -141,7 +141,7 @@ bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter) ret =drm_scdc_readb (adapter,SCDC_SCRAMBLER_STATUS , &status);if (ret <0 ) { -DRM_ERROR ("Failed to read scrambling status: %d\n" , ret); +DRM_DEBUG_KMS ("Failed to read scrambling status: %d\n" , ret);return false; }@@ -168,7 +168,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) ret =drm_scdc_readb (adapter,SCDC_TMDS_CONFIG , &config);if (ret <0 ) { -DRM_ERROR ("Failed to read TMDS config: %d\n" , ret); +DRM_DEBUG_KMS ("Failed to read TMDS config: %d\n" , ret);return false; }@@ -179,7 +179,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) ret =drm_scdc_writeb (adapter,SCDC_TMDS_CONFIG , config);if (ret <0 ) { -DRM_ERROR ("Failed to enable scrambling: %d\n" , ret); +DRM_DEBUG_KMS ("Failed to enable scrambling: %d\n" , ret);return false; }@@ -223,7 +223,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set) ret =drm_scdc_readb (adapter,SCDC_TMDS_CONFIG , &config);if (ret <0 ) { -DRM_ERROR ("Failed to read TMDS config: %d\n" , ret); +DRM_DEBUG_KMS ("Failed to read TMDS config: %d\n" , ret);return false; }
drivers/gpu/drm/drm_scdc_helper.c bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set) · line 240
Quoted 8 lines
drivers/gpu/drm/drm_scdc_helper.c +1
-1@@ -234,7 +234,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set) ret =drm_scdc_writeb (adapter,SCDC_TMDS_CONFIG , config);if (ret <0 ) { -DRM_ERROR ("Failed to set TMDS clock ratio: %d\n" , ret); +DRM_DEBUG_KMS ("Failed to set TMDS clock ratio: %d\n" , ret);return false; }
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 1 line · Shashank
Reviewed-by Shashank Sharma <[email protected]>
Thanks. Pushed to drm-misc-next.
Quoted 67 lines
Regards
ShashankQuoted 63 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
Since we may attempt to reconfigure SCDC when the sink has already been disconnected we probably shouldn't scare the user with errors in dmesg that are 100% expected in that case. Just leave it up to the caller whether to print an error message or not, and just output debug messages from the helper itself.
Cc Shashank Sharma <[email protected]>Signed-off-by Ville Syrjälä <[email protected]>--- drivers/gpu/drm/drm_scdc_helper.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)drivers/gpu/drm/drm_scdc_helper.c +5
-5@@ -141,7 +141,7 @@ bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter) ret =drm_scdc_readb (adapter,SCDC_SCRAMBLER_STATUS , &status);if (ret <0 ) { -DRM_ERROR ("Failed to read scrambling status: %d\n" , ret); +DRM_DEBUG_KMS ("Failed to read scrambling status: %d\n" , ret);return false; }@@ -168,7 +168,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) ret =drm_scdc_readb (adapter,SCDC_TMDS_CONFIG , &config);if (ret <0 ) { -DRM_ERROR ("Failed to read TMDS config: %d\n" , ret); +DRM_DEBUG_KMS ("Failed to read TMDS config: %d\n" , ret);return false; }@@ -179,7 +179,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) ret =drm_scdc_writeb (adapter,SCDC_TMDS_CONFIG , config);if (ret <0 ) { -DRM_ERROR ("Failed to enable scrambling: %d\n" , ret); +DRM_DEBUG_KMS ("Failed to enable scrambling: %d\n" , ret);return false; }@@ -223,7 +223,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set) ret =drm_scdc_readb (adapter,SCDC_TMDS_CONFIG , &config);if (ret <0 ) { -DRM_ERROR ("Failed to read TMDS config: %d\n" , ret); +DRM_DEBUG_KMS ("Failed to read TMDS config: %d\n" , ret);return false; }@@ -234,7 +234,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set) ret =drm_scdc_writeb (adapter,SCDC_TMDS_CONFIG , config);if (ret <0 ) { -DRM_ERROR ("Failed to set TMDS clock ratio: %d\n" , ret); +DRM_DEBUG_KMS ("Failed to set TMDS clock ratio: %d\n" , ret);return false; }
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel