Skip to contentSkip to conversation

Bluetooth: hci_ll: Convert to use h4_recv_buf helper

PATCH In review Marcel Holtmann 2 participants 2 messages Mar 24, 2018 – Mar 25, 2018 Bluetooth drivers

lore
Share & tools
lore

Marcel Holtmann

author maintainer
#0 lore raw

PATCH v2 1/3 Bluetooth: hci_ll: Convert to use h4_recv_buf helper

The HCILL or eHCILL protocol from TI is actually an H:4 protocol with a few extra events and thus can also use the h4_recv_buf helper. Instead of open coding the same funtionality add the extra events to the packet description table and use h4_recv_buf.

Signed-off-by Marcel Holtmann <[email protected]>
Tested-by Tony Lindgren <[email protected]>
---
 drivers/bluetooth/Kconfig  |   1 +
 drivers/bluetooth/hci_ll.c | 214 +++++++++++++++------------------------------
 2 files changed, 70 insertions(+), 145 deletions(-)
drivers/bluetooth/Kconfig +1 -0
index 07e55cd8f8c8..d2abcb768ae8 100644
@@ -147,6 +147,7 @@ config BT_HCIUART_ATH3K
 config BT_HCIUART_LL
 	bool "HCILL protocol support"
 	depends on BT_HCIUART_SERDEV
+	select BT_HCIUART_H4
 	help
 	  HCILL (HCI Low Level) is a serial protocol for communication
 	  between Bluetooth device and host. This protocol is required for
drivers/bluetooth/hci_ll.c +69 -145

245 lines not on this page · raw message

Signature · 1 line
2.14.3
#1 lore raw

Hi Marcel,

Quoted 11 lines · Marcel Holtmann

The HCILL or eHCILL protocol from TI is actually an H:4 protocol with a few extra events and thus can also use the h4_recv_buf helper. Instead of open coding the same funtionality add the extra events to the packet description table and use h4_recv_buf.

Signed-off-by Marcel Holtmann <[email protected]>
Tested-by Tony Lindgren <[email protected]>
---
 drivers/bluetooth/Kconfig  |   1 +
 drivers/bluetooth/hci_ll.c | 214 +++++++++++++++------------------------------
 2 files changed, 70 insertions(+), 145 deletions(-)

All three patches in this set have been applied to bluetooth-next. Thanks.

Johan